66722 2011-08-22 15:01:40 -0700 Move code from PageClientImpl::doneWithKeyEvent to WKView 2011-08-22 15:08:38 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca darin oldest_to_newest 454965 0 andersca 2011-08-22 15:01:40 -0700 Move code from PageClientImpl::doneWithKeyEvent to WKView 454966 1 104744 andersca 2011-08-22 15:02:09 -0700 Created attachment 104744 Patch 454973 2 104744 darin 2011-08-22 15:05:21 -0700 Comment on attachment 104744 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104744&action=review > Source/WebKit2/UIProcess/API/mac/WKView.mm:2060 > +- (void)_doneWithKeyEvent:(const WebKit::NativeWebKeyboardEvent&)event wasEventHandled:(BOOL)wasEventHandled Objective-C methods that take C++ type arguments end up with super-long selectors. Probably no clean way of avoiding that in this case. I think the second half of the selection should be eventWasHandled instead of wasEventHandled. 454976 3 andersca 2011-08-22 15:08:38 -0700 Committed r93550: <http://trac.webkit.org/changeset/93550> 104744 2011-08-22 15:02:09 -0700 2011-08-22 15:05:21 -0700 Patch bug-66722-20110822150211.patch text/plain 3885 andersca SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzNTQ5KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDgtMjIgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBNb3ZlIGNvZGUgZnJvbSBQ YWdlQ2xpZW50SW1wbDo6ZG9uZVdpdGhLZXlFdmVudCB0byBXS1ZpZXcKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2NzIyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9QYWdl Q2xpZW50SW1wbC5tbToKKyAgICAgICAgKFdlYktpdDo6UGFnZUNsaWVudEltcGw6OmRvbmVXaXRo S2V5RXZlbnQpOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbToKKyAgICAg ICAgKC1bV0tWaWV3IF9kb25lV2l0aEtleUV2ZW50OldlYktpdDo6d2FzRXZlbnRIYW5kbGVkOl0p OgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvbWFjL1dLVmlld0ludGVybmFsLmg6CisKIDIwMTEt MDgtMjIgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBV cGRhdGUgdGhlIHRleHQgaW5wdXQgY29udGV4dCB3aGVuIHRoZSBwbHVnLWluIGZvY3VzIGNoYW5n ZXMgYW5kIG5vdCB3aGVuIHRoZSBjb21wbGV4IHRleHQgaW5wdXQgc3RhdGUgY2hhbmdlcwpJbmRl eDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvUGFnZUNsaWVudEltcGwubW0KPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvUGFnZUNsaWVudElt cGwubW0JKHJldmlzaW9uIDkzNTQ3KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9t YWMvUGFnZUNsaWVudEltcGwubW0JKHdvcmtpbmcgY29weSkKQEAgLTMwMCwxMyArMzAwLDcgQEAg SW50UmVjdCBQYWdlQ2xpZW50SW1wbDo6d2luZG93VG9TY3JlZW4oYwogCiB2b2lkIFBhZ2VDbGll bnRJbXBsOjpkb25lV2l0aEtleUV2ZW50KGNvbnN0IE5hdGl2ZVdlYktleWJvYXJkRXZlbnQmIGV2 ZW50LCBib29sIHdhc0V2ZW50SGFuZGxlZCkKIHsKLSAgICBOU0V2ZW50KiBuYXRpdmVFdmVudCA9 IGV2ZW50Lm5hdGl2ZUV2ZW50KCk7Ci0gICAgaWYgKFtuYXRpdmVFdmVudCB0eXBlXSAhPSBOU0tl eURvd24pCi0gICAgICAgIHJldHVybjsKLSAgICBpZiAod2FzRXZlbnRIYW5kbGVkKQotICAgICAg ICBbTlNDdXJzb3Igc2V0SGlkZGVuVW50aWxNb3VzZU1vdmVzOllFU107Ci0gICAgZWxzZQotICAg ICAgICBbbV93a1ZpZXcgX3Jlc2VuZEtleURvd25FdmVudDpuYXRpdmVFdmVudF07CisgICAgW21f d2tWaWV3IF9kb25lV2l0aEtleUV2ZW50OmV2ZW50IHdhc0V2ZW50SGFuZGxlZDp3YXNFdmVudEhh bmRsZWRdOwogfQogCiBQYXNzUmVmUHRyPFdlYlBvcHVwTWVudVByb3h5PiBQYWdlQ2xpZW50SW1w bDo6Y3JlYXRlUG9wdXBNZW51UHJveHkoV2ViUGFnZVByb3h5KiBwYWdlKQpJbmRleDogU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQkocmV2aXNpb24gOTM1NDgpCisr KyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0JKHdvcmtpbmcgY29w eSkKQEAgLTIwNTcsMTUgKzIwNTcsMjMgQEAgLSAodm9pZClfc2V0VXNlckludGVyZmFjZUl0ZW1T dGF0ZTooTlNTdAogICAgIH0KIH0KIAotLSAodm9pZClfcmVzZW5kS2V5RG93bkV2ZW50OihOU0V2 ZW50ICopZXZlbnQKKy0gKHZvaWQpX2RvbmVXaXRoS2V5RXZlbnQ6KGNvbnN0IFdlYktpdDo6TmF0 aXZlV2ViS2V5Ym9hcmRFdmVudCYpZXZlbnQgd2FzRXZlbnRIYW5kbGVkOihCT09MKXdhc0V2ZW50 SGFuZGxlZAogeworICAgIE5TRXZlbnQqIG5hdGl2ZUV2ZW50ID0gZXZlbnQubmF0aXZlRXZlbnQo KTsKKyAgICBpZiAoW25hdGl2ZUV2ZW50IHR5cGVdICE9IE5TS2V5RG93bikKKyAgICAgICAgcmV0 dXJuOworICAgIGlmICh3YXNFdmVudEhhbmRsZWQpIHsKKyAgICAgICAgW05TQ3Vyc29yIHNldEhp ZGRlblVudGlsTW91c2VNb3ZlczpZRVNdOworICAgICAgICByZXR1cm47CisgICAgfQorCiAgICAg Ly8gcmVzZW5kaW5nIHRoZSBldmVudCBtYXkgZGVzdHJveSB0aGlzIFdLVmlldwogICAgIFJldGFp blB0cjxXS1ZpZXc+IHByb3RlY3RvcihzZWxmKTsKIAogICAgIEFTU0VSVCghX2RhdGEtPl9rZXlE b3duRXZlbnRCZWluZ1Jlc2VudCk7Ci0gICAgX2RhdGEtPl9rZXlEb3duRXZlbnRCZWluZ1Jlc2Vu dCA9IGV2ZW50OwotICAgIFtOU0FwcCBfc2V0Q3VycmVudEV2ZW50OmV2ZW50XTsKLSAgICBbTlNB cHAgc2VuZEV2ZW50OmV2ZW50XTsKKyAgICBfZGF0YS0+X2tleURvd25FdmVudEJlaW5nUmVzZW50 ID0gbmF0aXZlRXZlbnQ7CisgICAgW05TQXBwIF9zZXRDdXJyZW50RXZlbnQ6bmF0aXZlRXZlbnRd OworICAgIFtOU0FwcCBzZW5kRXZlbnQ6bmF0aXZlRXZlbnRdOwogCiAgICAgX2RhdGEtPl9rZXlE b3duRXZlbnRCZWluZ1Jlc2VudCA9IG51bGxwdHI7CiB9CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL21hYy9XS1ZpZXdJbnRlcm5hbC5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlld0ludGVybmFsLmgJKHJldmlzaW9uIDkzNTQ3 KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3SW50ZXJuYWwuaAko d29ya2luZyBjb3B5KQpAQCAtNDEsNiArNDEsNyBAQCBuYW1lc3BhY2UgV2ViS2l0IHsKICAgICBj bGFzcyBEcmF3aW5nQXJlYVByb3h5OwogICAgIGNsYXNzIEZpbmRJbmRpY2F0b3I7CiAgICAgY2xh c3MgTGF5ZXJUcmVlQ29udGV4dDsKKyAgICBjbGFzcyBOYXRpdmVXZWJLZXlib2FyZEV2ZW50Owog ICAgIHN0cnVjdCBFZGl0b3JTdGF0ZTsKIH0KIApAQCAtNTYsNyArNTcsNyBAQCBAaW50ZXJmYWNl IFdLVmlldyAoSW50ZXJuYWwpCiAtICh2b2lkKV9zZXRDdXJzb3I6KE5TQ3Vyc29yICopY3Vyc29y OwogLSAodm9pZClfc2V0VXNlckludGVyZmFjZUl0ZW1TdGF0ZTooTlNTdHJpbmcgKiljb21tYW5k TmFtZSBlbmFibGVkOihCT09MKWlzRW5hYmxlZCBzdGF0ZTooaW50KW5ld1N0YXRlOwogLSAoQk9P TClfaW50ZXJwcmV0S2V5RXZlbnQ6KE5TRXZlbnQgKil0aGVFdmVudCBzYXZpbmdDb21tYW5kc1Rv OihWZWN0b3I8V2ViQ29yZTo6S2V5cHJlc3NDb21tYW5kPiYpY29tbWFuZHM7Ci0tICh2b2lkKV9y ZXNlbmRLZXlEb3duRXZlbnQ6KE5TRXZlbnQgKilldmVudDsKKy0gKHZvaWQpX2RvbmVXaXRoS2V5 RXZlbnQ6KGNvbnN0IFdlYktpdDo6TmF0aXZlV2ViS2V5Ym9hcmRFdmVudCYpZXZlbnQgd2FzRXZl bnRIYW5kbGVkOihCT09MKXdhc0V2ZW50SGFuZGxlZDsKIC0gKGJvb2wpX2V4ZWN1dGVTYXZlZENv bW1hbmRCeVNlbGVjdG9yOihTRUwpc2VsZWN0b3I7CiAtIChOU1JlY3QpX2NvbnZlcnRUb0Rldmlj ZVNwYWNlOihOU1JlY3QpcmVjdDsKIC0gKE5TUmVjdClfY29udmVydFRvVXNlclNwYWNlOihOU1Jl Y3QpcmVjdDsK