66711 2011-08-22 14:06:48 -0700 [chromium] Remove deprecated and unused bits of WebIDB* headers 2011-08-22 15:44:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 adamk adamk dgrogan hans tony webkit.review.bot oldest_to_newest 454896 0 adamk 2011-08-22 14:06:48 -0700 [chromium] Remove deprecated and unused bits of WebIDB* headers 454900 1 104735 adamk 2011-08-22 14:08:15 -0700 Created attachment 104735 Patch 454915 2 104735 tony 2011-08-22 14:22:18 -0700 Comment on attachment 104735 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104735&action=review Maybe cc the author of these changes? > Source/WebKit/chromium/ChangeLog:9 > + http://crrev.com/97687. Do we need to make sure Source/WebKit/chromium/DEPS is rolled this far? 454923 3 adamk 2011-08-22 14:27:05 -0700 (In reply to comment #2) > (From update of attachment 104735 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=104735&action=review > > Maybe cc the author of these changes? +dgrogan, hans. > > Source/WebKit/chromium/ChangeLog:9 > > + http://crrev.com/97687. > > Do we need to make sure Source/WebKit/chromium/DEPS is rolled this far? Not as far as I can tell: the changes in r97686 were entirely within content/, which isn't pulled in by our DEPS, and I've verified that this builds with build-webkit without any changes to DEPS. 455012 4 104735 webkit.review.bot 2011-08-22 15:44:45 -0700 Comment on attachment 104735 Patch Clearing flags on attachment: 104735 Committed r93553: <http://trac.webkit.org/changeset/93553> 455013 5 webkit.review.bot 2011-08-22 15:44:50 -0700 All reviewed patches have been landed. Closing bug. 104735 2011-08-22 14:08:15 -0700 2011-08-22 15:44:45 -0700 Patch bug-66711-20110822140814.patch text/plain 4666 adamk U3VidmVyc2lvbiBSZXZpc2lvbjogOTM1MzIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg YzI2YTczODM3ODA5ODg1NzQ4MjFjODEwYWJhOTI4MjE4MDkzZTFhYi4uNDg3ODIxNWU0ZTJlODEw ODY0MDkzYzI5YzQxZTgyNjI3ZTg3MmJlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwyMSBAQAorMjAxMS0wOC0yMiAgQWRhbSBLbGVpbiAgPGFkYW1rQGNocm9taXVtLm9y Zz4KKworICAgICAgICBbY2hyb21pdW1dIFJlbW92ZSBkZXByZWNhdGVkIGFuZCB1bnVzZWQgYml0 cyBvZiBXZWJJREIqIGhlYWRlcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTY2NzExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVGhlIENocm9taXVtIHNpZGUgb2YgdGhpcyBwYXRjaCB3YXMgc3VibWl0dGVk IGFzCisgICAgICAgIGh0dHA6Ly9jcnJldi5jb20vOTc2ODcuCisKKyAgICAgICAgKiBwdWJsaWMv V2ViSURCQ2FsbGJhY2tzLmg6CisgICAgICAgICogcHVibGljL1dlYklEQkN1cnNvci5oOgorICAg ICAgICAoV2ViS2l0OjpXZWJJREJDdXJzb3I6OnByaW1hcnlLZXkpOgorICAgICAgICAoV2ViS2l0 OjpXZWJJREJDdXJzb3I6OnZhbHVlKToKKyAgICAgICAgKFdlYktpdDo6V2ViSURCQ3Vyc29yOjpk ZWxldGVGdW5jdGlvbik6CisgICAgICAgICogcHVibGljL1dlYklEQkRhdGFiYXNlLmg6CisgICAg ICAgIChXZWJLaXQ6OldlYklEQkRhdGFiYXNlOjp0cmFuc2FjdGlvbik6CisKIDIwMTEtMDgtMjIg IEp1c3RpbiBOb3Zvc2FkICA8anVub3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1 bV0gQ3Jhc2ggd2hlbiBhbGxvY2F0aW9uIG9mIHZlcnkgbGFyZ2UgY2FudmFzIGZhaWxzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJREJDYWxsYmFja3MuaCBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklEQkNhbGxiYWNrcy5oCmluZGV4IGVj N2MwOTU1Y2Y2NTI1YWJlMjlhMzgyYzU2ZTk4YWNhZTYyZWM4MmYuLmE2NDQ4YjRmMjc2ZTg3NzFk NTdmNTc4ZjQ3OTRkMDk5N2Q4MmIwYWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYklEQkNhbGxiYWNrcy5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v cHVibGljL1dlYklEQkNhbGxiYWNrcy5oCkBAIC00OSw4ICs0OSw2IEBAIHB1YmxpYzoKICAgICB2 aXJ0dWFsIHZvaWQgb25TdWNjZXNzKFdlYklEQkN1cnNvciopIHsgV0VCS0lUX0FTU0VSVF9OT1Rf UkVBQ0hFRCgpOyB9CiAgICAgdmlydHVhbCB2b2lkIG9uU3VjY2VzcyhXZWJJREJEYXRhYmFzZSop IHsgV0VCS0lUX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOyB9CiAgICAgdmlydHVhbCB2b2lkIG9uU3Vj Y2Vzcyhjb25zdCBXZWJJREJLZXkmKSB7IFdFQktJVF9BU1NFUlRfTk9UX1JFQUNIRUQoKTsgfQot ICAgIC8vIEZJWE1FOiByZW1vdmUgYWZ0ZXIgV2Via2l0IHJvbGwuCi0gICAgdmlydHVhbCB2b2lk IG9uU3VjY2VzcyhXZWJJREJJbmRleCopIHsgV0VCS0lUX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOyB9 CiAgICAgdmlydHVhbCB2b2lkIG9uU3VjY2VzcyhXZWJJREJUcmFuc2FjdGlvbiopIHsgV0VCS0lU X0FTU0VSVF9OT1RfUkVBQ0hFRCgpOyB9CiAgICAgdmlydHVhbCB2b2lkIG9uU3VjY2Vzcyhjb25z dCBXZWJTZXJpYWxpemVkU2NyaXB0VmFsdWUmKSB7IFdFQktJVF9BU1NFUlRfTk9UX1JFQUNIRUQo KTsgfQogICAgIHZpcnR1YWwgdm9pZCBvbkJsb2NrZWQoKSB7IFdFQktJVF9BU1NFUlRfTk9UX1JF QUNIRUQoKTsgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2Vi SURCQ3Vyc29yLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJREJDdXJzb3Iu aAppbmRleCAzNTAwNGU1YmRiMDhiMWJjY2M5ZmZkMDg5YjZlZDRkNGFkY2IzYzMzLi4xZjE5NDdl MGJhZWY2ZGIxNzI0OTc5YTdhOTEyYjg1MTQxMTAyY2JiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJREJDdXJzb3IuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJJREJDdXJzb3IuaApAQCAtNTUsMjkgKzU1LDE1IEBAIHB1YmxpYzoK ICAgICAgICAgV0VCS0lUX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgICAgICByZXR1cm4gV2Vi SURCS2V5OjpjcmVhdGVJbnZhbGlkKCk7CiAgICAgfQotICAgIC8vIEZJWE1FOiBSZW1vdmUgdGhl IGZvbGxvd2luZyAyIG1ldGhvZHMgYW5kIHVuY29tbWVudCB0aGlyZCBhZnRlciByb2xsLgogICAg IHZpcnR1YWwgV2ViU2VyaWFsaXplZFNjcmlwdFZhbHVlIHZhbHVlKCkgY29uc3QKICAgICB7Ci0g ICAgICAgIFdlYlNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSBzZXJpYWxpemVkU2NyaXB0VmFsdWU7Ci0g ICAgICAgIFdlYklEQktleSBrZXk7Ci0gICAgICAgIHZhbHVlKHNlcmlhbGl6ZWRTY3JpcHRWYWx1 ZSwga2V5KTsKLSAgICAgICAgcmV0dXJuIHNlcmlhbGl6ZWRTY3JpcHRWYWx1ZTsgICAgICAgIAot ICAgIH0KLSAgICB2aXJ0dWFsIHZvaWQgdmFsdWUoV2ViU2VyaWFsaXplZFNjcmlwdFZhbHVlJiBz ZXJpYWxpemVkU2NyaXB0VmFsdWUsIFdlYklEQktleSYga2V5KSBjb25zdAotICAgIHsKLSAgICAg ICAgc2VyaWFsaXplZFNjcmlwdFZhbHVlID0gdmFsdWUoKTsKKyAgICAgICAgV0VCS0lUX0FTU0VS VF9OT1RfUkVBQ0hFRCgpOworICAgICAgICByZXR1cm4gV2ViU2VyaWFsaXplZFNjcmlwdFZhbHVl KCk7CiAgICAgfQotICAgIC8vIHZpcnR1YWwgV2ViU2VyaWFsaXplZFNjcmlwdFZhbHVlIHZhbHVl KCkgY29uc3QKLSAgICAvLyB7Ci0gICAgLy8gICAgIFdFQktJVF9BU1NFUlRfTk9UX1JFQUNIRUQo KTsKLSAgICAvLyAgICAgcmV0dXJuIFdlYlNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSgpOwotICAgIC8v IH0KIAogICAgIHZpcnR1YWwgdm9pZCB1cGRhdGUoY29uc3QgV2ViU2VyaWFsaXplZFNjcmlwdFZh bHVlJiwgV2ViSURCQ2FsbGJhY2tzKiwgV2ViRXhjZXB0aW9uQ29kZSYpIHsgV0VCS0lUX0FTU0VS VF9OT1RfUkVBQ0hFRCgpOyB9CiAgICAgdmlydHVhbCB2b2lkIGNvbnRpbnVlRnVuY3Rpb24oY29u c3QgV2ViSURCS2V5JiwgV2ViSURCQ2FsbGJhY2tzKiwgV2ViRXhjZXB0aW9uQ29kZSYpIHsgV0VC S0lUX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOyB9Ci0gICAgLy8gRklYTUU6IFJlbW92ZSBhZnRlciBX SyByb2xsLgotICAgIHZpcnR1YWwgdm9pZCByZW1vdmUoV2ViSURCQ2FsbGJhY2tzKiBjYWxsYmFj a3MsIFdlYkV4Y2VwdGlvbkNvZGUmIGVjKSB7IGRlbGV0ZUZ1bmN0aW9uKGNhbGxiYWNrcywgZWMp OyB9Ci0gICAgdmlydHVhbCB2b2lkIGRlbGV0ZUZ1bmN0aW9uKFdlYklEQkNhbGxiYWNrcyogY2Fs bGJhY2tzLCBXZWJFeGNlcHRpb25Db2RlJiBlYykgeyByZW1vdmUoY2FsbGJhY2tzLCBlYyk7IH0K KyAgICB2aXJ0dWFsIHZvaWQgZGVsZXRlRnVuY3Rpb24oV2ViSURCQ2FsbGJhY2tzKiBjYWxsYmFj a3MsIFdlYkV4Y2VwdGlvbkNvZGUmIGVjKSB7IFdFQktJVF9BU1NFUlRfTk9UX1JFQUNIRUQoKTsg fQogCiBwcm90ZWN0ZWQ6CiAgICAgV2ViSURCQ3Vyc29yKCkgeyB9CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJREJEYXRhYmFzZS5oIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9wdWJsaWMvV2ViSURCRGF0YWJhc2UuaAppbmRleCBiZDk4MWEwZDBmMDhlNGMy ZDRjM2VlYTZmOWU5OTc0MTE5NjNlOGIxLi42ZGM5M2Q5MjAzMTYyM2Q1YzA5ZGE3MDE5OWEzMjNk OGUwNWM4MGQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJ REJEYXRhYmFzZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklEQkRh dGFiYXNlLmgKQEAgLTY4LDEyICs2OCw4IEBAIHB1YmxpYzoKICAgICAvLyBUcmFuc2ZlcnMgb3du ZXJzaGlwIG9mIHRoZSBXZWJJREJUcmFuc2FjdGlvbiB0byB0aGUgY2FsbGVyLgogICAgIHZpcnR1 YWwgV2ViSURCVHJhbnNhY3Rpb24qIHRyYW5zYWN0aW9uKGNvbnN0IFdlYkRPTVN0cmluZ0xpc3Qm IG5hbWVzLCB1bnNpZ25lZCBzaG9ydCBtb2RlLCBXZWJFeGNlcHRpb25Db2RlJiBlYykKICAgICB7 Ci0gICAgICAgIHJldHVybiB0cmFuc2FjdGlvbihuYW1lcywgbW9kZSwgMCwgZWMpOwotICAgIH0K LSAgICAvLyBGSVhNRTogUmVtb3ZlLgotICAgIHZpcnR1YWwgV2ViSURCVHJhbnNhY3Rpb24qIHRy YW5zYWN0aW9uKGNvbnN0IFdlYkRPTVN0cmluZ0xpc3QmIG5hbWVzLCB1bnNpZ25lZCBzaG9ydCBt b2RlLCB1bnNpZ25lZCBsb25nLCBXZWJFeGNlcHRpb25Db2RlJiBlYykKLSAgICB7Ci0gICAgICAg IHJldHVybiB0cmFuc2FjdGlvbihuYW1lcywgbW9kZSwgZWMpOworICAgICAgICBXRUJLSVRfQVNT RVJUX05PVF9SRUFDSEVEKCk7CisgICAgICAgIHJldHVybiAwOwogICAgIH0KICAgICB2aXJ0dWFs IHZvaWQgY2xvc2UoKSB7IFdFQktJVF9BU1NFUlRfTk9UX1JFQUNIRUQoKTsgfQogCg==