66704 2011-08-22 13:17:12 -0700 [chromium] WebViewImpl should not reshape the 3D context 2011-08-22 17:37:31 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 husky webkit-unassigned husky jamesr nduca webkit.review.bot oldest_to_newest 454838 0 husky 2011-08-22 13:17:12 -0700 This is now handled by the compositor. Reshapes need to be done on the compositor thread. 454840 1 104723 husky 2011-08-22 13:19:13 -0700 Created attachment 104723 Remove two reshape calls. 454845 2 104723 nduca 2011-08-22 13:22:43 -0700 Comment on attachment 104723 Remove two reshape calls. Looks good. Should probably "test" that things work still by (a) visiting a page with WebGL and making sure it works and then (b) killing the GPU process and making sure the page still recovers from lost context. 455073 3 husky 2011-08-22 17:08:16 -0700 I manually tested WebGL and about:gpucrash 455096 4 104723 webkit.review.bot 2011-08-22 17:37:27 -0700 Comment on attachment 104723 Remove two reshape calls. Clearing flags on attachment: 104723 Committed r93566: <http://trac.webkit.org/changeset/93566> 455097 5 webkit.review.bot 2011-08-22 17:37:31 -0700 All reviewed patches have been landed. Closing bug. 104723 2011-08-22 13:19:13 -0700 2011-08-22 17:37:27 -0700 Remove two reshape calls. patch.txt text/plain 1847 husky SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCShyZXZpc2lvbiA5MzQyMSkKKysr IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0y NTk1LDggKzI1OTUsNiBAQAogICAgIFJlZlB0cjxHcmFwaGljc0NvbnRleHQzRD4gY29udGV4dCA9 IG1fdGVtcG9yYXJ5T25zY3JlZW5HcmFwaGljc0NvbnRleHQzRC5yZWxlYXNlKCk7CiAgICAgaWYg KCFjb250ZXh0KSB7CiAgICAgICAgIGNvbnRleHQgPSBHcmFwaGljc0NvbnRleHQzRDo6Y3JlYXRl KGdldENvbXBvc2l0b3JDb250ZXh0QXR0cmlidXRlcygpLCBtX3BhZ2UtPmNocm9tZSgpLCBHcmFw aGljc0NvbnRleHQzRDo6UmVuZGVyRGlyZWN0bHlUb0hvc3RXaW5kb3cpOwotICAgICAgICBpZiAo Y29udGV4dCkKLSAgICAgICAgICAgIGNvbnRleHQtPnJlc2hhcGUobWF4KDEsIG1fc2l6ZS53aWR0 aCksIG1heCgxLCBtX3NpemUuaGVpZ2h0KSk7CiAgICAgfQogICAgIHJldHVybiBjb250ZXh0Owog fQpAQCAtMjY1OSw4ICsyNjU3LDYgQEAKICAgICAgICAgICAgICAgICByZXR1cm4gd2ViQ29udGV4 dDsKICAgICAgICAgfQogICAgICAgICBtX3RlbXBvcmFyeU9uc2NyZWVuR3JhcGhpY3NDb250ZXh0 M0QgPSBHcmFwaGljc0NvbnRleHQzRDo6Y3JlYXRlKGdldENvbXBvc2l0b3JDb250ZXh0QXR0cmli dXRlcygpLCBtX3BhZ2UtPmNocm9tZSgpLCBHcmFwaGljc0NvbnRleHQzRDo6UmVuZGVyRGlyZWN0 bHlUb0hvc3RXaW5kb3cpOwotICAgICAgICBpZiAobV90ZW1wb3JhcnlPbnNjcmVlbkdyYXBoaWNz Q29udGV4dDNEKQotICAgICAgICAgICAgbV90ZW1wb3JhcnlPbnNjcmVlbkdyYXBoaWNzQ29udGV4 dDNELT5yZXNoYXBlKG1heCgxLCBtX3NpemUud2lkdGgpLCBtYXgoMSwgbV9zaXplLmhlaWdodCkp OwogICAgICAgICByZXR1cm4gR3JhcGhpY3NDb250ZXh0M0RJbnRlcm5hbDo6ZXh0cmFjdFdlYkdy YXBoaWNzQ29udGV4dDNEKG1fdGVtcG9yYXJ5T25zY3JlZW5HcmFwaGljc0NvbnRleHQzRC5nZXQo KSk7CiAgICAgfQogI2VuZGlmCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzNTMxKQorKysg V2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDExLTA4LTIyICBJYWluIE1lcnJpY2sgIDxodXNreUBnb29nbGUuY29tPgorCisgICAgICAg IFtjaHJvbWl1bV0gV2ViVmlld0ltcGwgc2hvdWxkIG5vdCByZXNoYXBlIHRoZSAzRCBjb250ZXh0 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjcwNAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3JjL1dl YlZpZXdJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OmNyZWF0ZUxheWVy VHJlZUhvc3RDb250ZXh0M0QpOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6Z3JhcGhp Y3NDb250ZXh0M0QpOgorCiAyMDExLTA4LTIyICBKdXN0aW4gTm92b3NhZCAgPGp1bm92QGNocm9t aXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dIENyYXNoIHdoZW4gYWxsb2NhdGlvbiBvZiB2 ZXJ5IGxhcmdlIGNhbnZhcyBmYWlscwo=