66702 2011-08-22 12:51:03 -0700 [EFL] Add auxiliary ewk_util functions for DRT. 2011-08-23 06:19:57 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 rakuco webkit-unassigned kenneth leandro webkit.review.bot oldest_to_newest 454816 0 rakuco 2011-08-22 12:51:03 -0700 [EFL] Add auxiliary ewk_util functions for DRT. 454820 1 104719 rakuco 2011-08-22 12:56:24 -0700 Created attachment 104719 Patch 454825 2 rakuco 2011-08-22 13:01:27 -0700 CC'ing kenneth on this drt-related bug. 454893 3 104719 kenneth 2011-08-22 14:05:20 -0700 Comment on attachment 104719 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104719&action=review > Source/WebKit/efl/ewk/ewk_private.h:119 > +void ewk_util_javascript_gc_collect(); > +void ewk_util_javascript_gc_alternate_thread_collect(Eina_Bool waitUntilDone); Personally I would have prefixed them with something like ewk_drt_ or, but ok 455117 4 104719 gyuyoung.kim 2011-08-22 17:57:05 -0700 Comment on attachment 104719 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104719&action=review >> Source/WebKit/efl/ewk/ewk_private.h:119 >> +void ewk_util_javascript_gc_alternate_thread_collect(Eina_Bool waitUntilDone); > > Personally I would have prefixed them with something like ewk_drt_ or, but ok Kubo, will you make ewk_drt.cpp? Personally, ewk_util is also not bad for this functions. 455328 5 rakuco 2011-08-23 05:09:53 -0700 For now, I have no intentions of creating an ewk_drt.cpp, although this may change in the future. 455367 6 104719 webkit.review.bot 2011-08-23 06:19:53 -0700 Comment on attachment 104719 Patch Clearing flags on attachment: 104719 Committed r93599: <http://trac.webkit.org/changeset/93599> 455368 7 webkit.review.bot 2011-08-23 06:19:57 -0700 All reviewed patches have been landed. Closing bug. 104719 2011-08-22 12:56:24 -0700 2011-08-23 06:19:53 -0700 Patch bug-66702-20110822165956.patch text/plain 3628 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogOTM1MTIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCAyMWVmMTFkMzk2 OTc3ODhlYjkwMDMyNmU5ODBmOThhNzZlYTU2MTM1Li44ZWJlNmFlNjczZmJiMGM2MjRhMGJjZDky ODlmZDdmYTc0OTRlZGFmIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEt MDgtMjIgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CisKKyAg ICAgICAgW0VGTF0gQWRkIGF1eGlsaWFyeSBld2tfdXRpbCBmdW5jdGlvbnMgZm9yIERSVC4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2NzAyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHNvbWUgYXV4 aWxpYXJ5IGZ1bmN0aW9ucyBuZWVkZWQgYnkgRUZMJ3MgRFJUIGltcGxlbWVudGF0aW9uLiBUaGV5 CisgICAgICAgIGFsbCByZXZvbHZlIGFyb3VuZCB0YWxraW5nIHRvIHRoZSBnYXJiYWdlIGNvbGxl Y3RvciBhbmQgY291bnRpbmcgdGhlCisgICAgICAgIHdvcmtlciB0aHJlYWRzLgorCisgICAgICAg ICogZXdrL2V3a19wcml2YXRlLmg6CisgICAgICAgICogZXdrL2V3a191dGlsLmNwcDoKKyAgICAg ICAgKGV3a191dGlsX2phdmFzY3JpcHRfZ2NfY29sbGVjdCk6CisgICAgICAgIChld2tfdXRpbF9q YXZhc2NyaXB0X2djX2FsdGVybmF0ZV90aHJlYWRfY29sbGVjdCk6CisgICAgICAgIChld2tfdXRp bF9qYXZhc2NyaXB0X2djX29iamVjdF9jb3VudF9nZXQpOgorICAgICAgICAoZXdrX3V0aWxfd29y a2VyX3RocmVhZF9jb3VudCk6CisgICAgICAgIChld2tfdXRpbF9kcGlfZ2V0KToKKwogMjAxMS0w OC0yMCAgR3J6ZWdvcnogQ3phamtvd3NraSAgPGcuY3phamtvd3NraUBzYW1zdW5nLmNvbT4KIAog ICAgICAgICBbRUZMXSBGaXggYW5kIHVwZGF0ZSBkb3h5Z2VuIGRvY3VtZW50YXRpb24gZm9yIGV3 a192aWV3LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19wcml2YXRlLmgg Yi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ByaXZhdGUuaAppbmRleCAzMzlhMGEwMmU2Zjkw ZDkyNTg2ZjY3MGE2YWMxZjRmZTEyYTM3MTA4Li4yZWU5MzVkYWFkZTAzMWQ2ZmRmMTM4ZDAxOTlm MzYzM2JkOTIxYTM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ByaXZh dGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ByaXZhdGUuaApAQCAtMTE1LDYg KzExNSwxMCBAQCB2b2lkIGV3a192aWV3X2VkaXRvcl9jbGllbnRfY29udGVudHNfY2hhbmdlZChF dmFzX09iamVjdCAqbyk7CiB2b2lkIGV3a192aWV3X2VkaXRvcl9jbGllbnRfc2VsZWN0aW9uX2No YW5nZWQoRXZhc19PYmplY3QgKm8pOwogCiBpbnQgZXdrX3V0aWxfZHBpX2dldCh2b2lkKTsKK3Zv aWQgZXdrX3V0aWxfamF2YXNjcmlwdF9nY19jb2xsZWN0KCk7Cit2b2lkIGV3a191dGlsX2phdmFz Y3JpcHRfZ2NfYWx0ZXJuYXRlX3RocmVhZF9jb2xsZWN0KEVpbmFfQm9vbCB3YWl0VW50aWxEb25l KTsKK3Vuc2lnbmVkIGV3a191dGlsX2phdmFzY3JpcHRfZ2Nfb2JqZWN0X2NvdW50X2dldCgpOwor dW5zaWduZWQgZXdrX3V0aWxfd29ya2VyX3RocmVhZF9jb3VudCgpOwogCiAjaWYgRU5BQkxFKFRP VUNIX0VWRU5UUykKIHZvaWQgZXdrX3ZpZXdfbmVlZF90b3VjaF9ldmVudHNfc2V0KEV2YXNfT2Jq ZWN0KiwgYm9vbCBuZWVkZWQpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a191dGlsLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdXRpbC5jcHAKaW5kZXggODEz MTllYjhjYWFmNTEzZjY5ZDNhMTVmNDY1ODQyNmYzMTI5MTlkZS4uMDhiM2MwM2VjOGFlM2MyOTMz MWI0NDgwNmQyOGYyYzFjNmE2MjMyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdr L2V3a191dGlsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3V0aWwuY3BwCkBA IC0yMSw2ICsyMSw5IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiZXdrX3V0aWwu aCIKIAorI2luY2x1ZGUgImJpbmRpbmdzL2pzL0dDQ29udHJvbGxlci5oIgorI2luY2x1ZGUgIndv cmtlcnMvV29ya2VyVGhyZWFkLmgiCisKICNpbmNsdWRlICJld2tfcHJpdmF0ZS5oIgogI2luY2x1 ZGUgPGVpbmFfc2FmZXR5X2NoZWNrcy5oPgogCkBAIC0xMTAsNiArMTEzLDUzIEBAIEV2YXNfT2Jq ZWN0ICpld2tfdXRpbF9pbWFnZV9mcm9tX2NhaXJvX3N1cmZhY2VfYWRkKEV2YXMgKmNhbnZhcywg Y2Fpcm9fc3VyZmFjZV90CiAKIC8qKgogICogQGludGVybmFsCisgKgorICogUGVyZm9ybXMgZ2Fy YmFnZSBjb2xsZWN0aW9uIG9mIEphdmFTY3JpcHQgb2JqZWN0cy4KKyAqLwordm9pZCBld2tfdXRp bF9qYXZhc2NyaXB0X2djX2NvbGxlY3QoKQoreworICAgIFdlYkNvcmU6OmdjQ29udHJvbGxlcigp LmdhcmJhZ2VDb2xsZWN0Tm93KCk7Cit9CisKKy8qKgorICogQGludGVybmFsCisgKgorICogUGVy Zm9ybXMgZ2FyYmFnZSBjb2xsZWN0aW9uIG9mIEphdmFTY3JpcHQgb2JqZWN0cyBpbiBhIHNlcGFy YXRlIHRocmVhZC4KKyAqCisgKiBAcGFyYW0gd2FpdFVudGlsRG9uZSBJZiBAYyBUUlVFLCB3YWl0 IHRoZSBnYXJiYWdlIGNvbGxlY3Rpb24gdGhyZWFkIHRvIGZpbmlzaDsgaWYgQGMgRkFMU0UsCisg KiByZXR1cm4gYXMgc29vbiBhcyB0aGUgdGhyZWFkIGhhcyBiZWVuIGNyZWF0ZWQuCisgKi8KK3Zv aWQgZXdrX3V0aWxfamF2YXNjcmlwdF9nY19hbHRlcm5hdGVfdGhyZWFkX2NvbGxlY3QoRWluYV9C b29sIHdhaXRVbnRpbERvbmUpCit7CisgICAgV2ViQ29yZTo6Z2NDb250cm9sbGVyKCkuZ2FyYmFn ZUNvbGxlY3RPbkFsdGVybmF0ZVRocmVhZEZvckRlYnVnZ2luZyh3YWl0VW50aWxEb25lKTsKK30K KworLyoqCisgKiBAaW50ZXJuYWwKKyAqCisgKiBSZXR1cm5zIHRoZSBudW1iZXIgb2YgY3VycmVu dCBKYXZhU2NyaXB0IG9iamVjdHMuCisgKi8KK3Vuc2lnbmVkIGV3a191dGlsX2phdmFzY3JpcHRf Z2Nfb2JqZWN0X2NvdW50X2dldCgpCit7CisgICAgcmV0dXJuIFdlYkNvcmU6OkpTRE9NV2luZG93 Ojpjb21tb25KU0dsb2JhbERhdGEoKS0+aGVhcC5vYmplY3RDb3VudCgpOworfQorCisvKioKKyAq IEBpbnRlcm5hbAorICoKKyAqIFJldHVybnMgdGhlIG51bWJlciBvZiBjdXJyZW50IHdvcmtlZCB0 aHJlYWRzLgorICovCit1bnNpZ25lZCBld2tfdXRpbF93b3JrZXJfdGhyZWFkX2NvdW50KCkKK3sK KyNpZiBFTkFCTEUoV09SS0VSUykKKyAgICByZXR1cm4gV2ViQ29yZTo6V29ya2VyVGhyZWFkOjp3 b3JrZXJUaHJlYWRDb3VudCgpOworI2Vsc2UKKyAgICByZXR1cm4gMDsKKyNlbmRpZgorfQorCisv KioKKyAqIEBpbnRlcm5hbAogICogR2V0cyBkcGkgdmFsdWUuCiAgKgogICogQHJldHVybiBkZXZp Y2UncyBkcGkgdmFsdWUuCkBAIC0xMjIsNCArMTcyLDMgQEAgaW50IGV3a191dGlsX2RwaV9nZXQo dm9pZCkKICAgICAgcmV0dXJuIDE2MDsKICNlbmRpZgogfQotCg==