66700 2011-08-22 12:19:56 -0700 [EFL] Add auxiliary history functions for DRT 2011-08-23 06:37:56 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 rakuco webkit-unassigned leandro tkent webkit.review.bot oldest_to_newest 454796 0 rakuco 2011-08-22 12:19:56 -0700 [EFL] Add auxiliary history functions for DRT 454798 1 104714 rakuco 2011-08-22 12:21:18 -0700 Created attachment 104714 Patch 454799 2 rakuco 2011-08-22 12:24:05 -0700 CC'ing tkent in this drt-related patch. 455140 3 104714 tkent 2011-08-22 18:41:04 -0700 Comment on attachment 104714 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104714&action=review > Source/WebKit/efl/ewk/ewk_history.cpp:413 > + * Returns a newly-allocated string with the item's target name. Probably you had better provide information about - Callers should delete the allocated string - how to delete the allocated string because the users can't know the function is using strdup() without reading the source code. 455333 4 104826 rakuco 2011-08-23 05:24:45 -0700 Created attachment 104826 Patch 455336 5 rakuco 2011-08-23 05:26:56 -0700 Oops, I ended up sending an updated patch after the cq+ was given, sorry :) 455381 6 104826 webkit.review.bot 2011-08-23 06:37:52 -0700 Comment on attachment 104826 Patch Clearing flags on attachment: 104826 Committed r93602: <http://trac.webkit.org/changeset/93602> 455382 7 webkit.review.bot 2011-08-23 06:37:56 -0700 All reviewed patches have been landed. Closing bug. 104714 2011-08-22 12:21:18 -0700 2011-08-23 05:24:35 -0700 Patch bug-66700-20110822162449.patch text/plain 3426 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogOTM1MTIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCAyMWVmMTFkMzk2 OTc3ODhlYjkwMDMyNmU5ODBmOThhNzZlYTU2MTM1Li43OGZhMGFjYmNlZTllZjIxNzZhNGQxOGNh MjBhNTdhOGMyMzE4ZTFjIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEt MDgtMjIgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CisKKyAg ICAgICAgW0VGTF0gQWRkIGF1eGlsaWFyeSBoaXN0b3J5IGZ1bmN0aW9ucyBmb3IgRFJUCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjcwMAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVGTCdzIER1bXBSZW5k ZXJUcmVlIGltcGxlbWVudGF0aW9uIG5lZWRzIHNvbWUgcHJpdmF0ZSwgYXV4aWxpYXJ5CisgICAg ICAgIGZ1bmN0aW9ucyBpbiBld2sgaW4gb3JkZXIgdG8gaXRlcmF0ZSBhbmQgZHVtcCB0aGUgaGlz dG9yeSB0cmVlIHdoZW4KKyAgICAgICAgbmVjZXNzYXJ5LgorCisgICAgICAgICogZXdrL2V3a19o aXN0b3J5LmNwcDoKKyAgICAgICAgKGV3a19oaXN0b3J5X2l0ZW1fdGFyZ2V0X2dldCk6CisgICAg ICAgIChld2tfaGlzdG9yeV9pdGVtX3RhcmdldF9pcyk6CisgICAgICAgIChld2tfaGlzdG9yeV9p dGVtX2NoaWxkcmVuX2dldCk6CisgICAgICAgICogZXdrL2V3a19wcml2YXRlLmg6CisKIDIwMTEt MDgtMjAgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWprb3dza2lAc2Ftc3VuZy5jb20+CiAK ICAgICAgICAgW0VGTF0gRml4IGFuZCB1cGRhdGUgZG94eWdlbiBkb2N1bWVudGF0aW9uIGZvciBl d2tfdmlldy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfaGlzdG9yeS5j cHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2hpc3RvcnkuY3BwCmluZGV4IGZjN2NjYWFj MjhmYzJiOTgzMGQ2YzFhM2YyNTcyOWRlNGM1OTVlZTAuLmZhZWQyMjJkNGU2ZDM2Zjc0MzYzYjZi MTljYThmZDA5ZGIyMGFiYjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tf aGlzdG9yeS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19oaXN0b3J5LmNwcApA QCAtNDA2LDMgKzQwNiw1MSBAQCB2b2lkIGV3a19oaXN0b3J5X2ZyZWUoRXdrX0hpc3RvcnkqIGhp c3RvcnkpCiAgICAgaGlzdG9yeS0+Y29yZS0+ZGVyZWYoKTsKICAgICBmcmVlKGhpc3RvcnkpOwog fQorCisvKioKKyAqIEBpbnRlcm5hbAorICoKKyAqIFJldHVybnMgYSBuZXdseS1hbGxvY2F0ZWQg c3RyaW5nIHdpdGggdGhlIGl0ZW0ncyB0YXJnZXQgbmFtZS4KKyAqCisgKiBAcGFyYW0gaXRlbSBp bnN0YW5jZSB0byBvcGVyYXRlIHVwb24uCisgKi8KK2NoYXIqIGV3a19oaXN0b3J5X2l0ZW1fdGFy Z2V0X2dldChjb25zdCBFd2tfSGlzdG9yeV9JdGVtKiBpdGVtKQoreworICAgIEVXS19ISVNUT1JZ X0lURU1fQ09SRV9HRVRfT1JfUkVUVVJOKGl0ZW0sIGNvcmUsIDApOworICAgIHJldHVybiBzdHJk dXAoY29yZS0+dGFyZ2V0KCkudXRmOCgpLmRhdGEoKSk7Cit9CisKKy8qKgorICogQGludGVybmFs CisgKgorICogUmV0dXJucyB3aGV0aGVyIHRoZSBnaXZlbiBpdGVtIGlzIGN1cnJlbnRseSBhIHRh cmdldC4KKyAqCisgKiBAcGFyYW0gaXRlbSBpbnN0YW5jZSB0byBjaGVjay4KKyAqLworRWluYV9C b29sIGV3a19oaXN0b3J5X2l0ZW1fdGFyZ2V0X2lzKGNvbnN0IEV3a19IaXN0b3J5X0l0ZW0qIGl0 ZW0pCit7CisgICAgRVdLX0hJU1RPUllfSVRFTV9DT1JFX0dFVF9PUl9SRVRVUk4oaXRlbSwgY29y ZSwgMCk7CisgICAgcmV0dXJuIGNvcmUtPmlzVGFyZ2V0SXRlbSgpOworfQorCisvKioKKyAqIEBp bnRlcm5hbAorICoKKyAqIFJldHVybnMgYSBsaXN0IG9mIGNoaWxkIGhpc3RvcnkgaXRlbXMgcmVs YXRpdmUgdG8gdGhlIGdpdmVuIGl0ZW0sCisgKiBvciBAYyBOVUxMIGlmIHRoZXJlIGFyZSBub25l LgorICoKKyAqIEBwYXJhbSBpdGVtIGluc3RhbmNlIHRvIG9wZXJhdGUgdXBvbi4KKyAqLworRWlu YV9MaXN0KiBld2tfaGlzdG9yeV9pdGVtX2NoaWxkcmVuX2dldChjb25zdCBFd2tfSGlzdG9yeV9J dGVtKiBpdGVtKQoreworICAgIEVXS19ISVNUT1JZX0lURU1fQ09SRV9HRVRfT1JfUkVUVVJOKGl0 ZW0sIGNvcmUsIDApOworICAgIGNvbnN0IFdlYkNvcmU6Okhpc3RvcnlJdGVtVmVjdG9yJiBjaGls ZHJlbiA9IGNvcmUtPmNoaWxkcmVuKCk7CisgICAgaWYgKCFjaGlsZHJlbi5zaXplKCkpCisgICAg ICAgIHJldHVybiAwOworCisgICAgRWluYV9MaXN0KiBraWRzID0gMDsKKyAgICBjb25zdCB1bnNp Z25lZCBzaXplID0gY2hpbGRyZW4uc2l6ZSgpOworICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkg PCBzaXplOyArK2kpCisgICAgICAgIGtpZHMgPSBlaW5hX2xpc3RfYXBwZW5kKGtpZHMsIF9ld2tf aGlzdG9yeV9pdGVtX25ldyhjaGlsZHJlbltpXS5nZXQoKSkpOworICAgIHJldHVybiBraWRzOwor fQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19wcml2YXRlLmggYi9Tb3Vy Y2UvV2ViS2l0L2VmbC9ld2svZXdrX3ByaXZhdGUuaAppbmRleCAzMzlhMGEwMmU2ZjkwZDkyNTg2 ZjY3MGE2YWMxZjRmZTEyYTM3MTA4Li4zYTg1NTlhN2Q4NjdhZTI4OTY3YTAwMGY0YjcxZTY3YmY0 NDdlOTgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ByaXZhdGUuaAor KysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ByaXZhdGUuaApAQCAtMTIzLDYgKzEyMyw5 IEBAIEVpbmFfQm9vbCBld2tfdmlld19uZWVkX3RvdWNoX2V2ZW50c19nZXQoRXZhc19PYmplY3Qq KTsKIAogRXdrX0hpc3RvcnkgKmV3a19oaXN0b3J5X25ldyhXZWJDb3JlOjpCYWNrRm9yd2FyZExp c3RJbXBsICpoaXN0b3J5KTsKIHZvaWQgZXdrX2hpc3RvcnlfZnJlZShFd2tfSGlzdG9yeSAqaGlz dG9yeSk7CitjaGFyICpld2tfaGlzdG9yeV9pdGVtX3RhcmdldF9nZXQoY29uc3QgRXdrX0hpc3Rv cnlfSXRlbSAqaXRlbSk7CitFaW5hX0Jvb2wgZXdrX2hpc3RvcnlfaXRlbV90YXJnZXRfaXMoY29u c3QgRXdrX0hpc3RvcnlfSXRlbSAqaXRlbSk7CitFaW5hX0xpc3QgKmV3a19oaXN0b3J5X2l0ZW1f Y2hpbGRyZW5fZ2V0KGNvbnN0IEV3a19IaXN0b3J5X0l0ZW0gKml0ZW0pOwogCiAjaWYgRU5BQkxF KENPTlRFWFRfTUVOVVMpCiBFd2tfQ29udGV4dF9NZW51ICpld2tfY29udGV4dF9tZW51X25ldyhF dmFzX09iamVjdCAqdmlldywgV2ViQ29yZTo6Q29udGV4dE1lbnVDb250cm9sbGVyICpjb250cm9s bGVyKTsK 104826 2011-08-23 05:24:45 -0700 2011-08-23 06:37:51 -0700 Patch bug-66700-20110823092817.patch text/plain 3512 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogOTM1OTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCAzMDkyZTFkYWI1 ZmE4YjA5MjZkYzMyOWUwMTljY2U5ZmZkMTNhYjYyLi5mYWU0ZTAxZjRjNzlhNWY4ZjA5YmNhOGVh ZjhhNmNmMmZlYTBkMDA2IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEt MDgtMjMgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CisKKyAg ICAgICAgW0VGTF0gQWRkIGF1eGlsaWFyeSBoaXN0b3J5IGZ1bmN0aW9ucyBmb3IgRFJUCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjcwMAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVGTCdzIER1bXBSZW5k ZXJUcmVlIGltcGxlbWVudGF0aW9uIG5lZWRzIHNvbWUgcHJpdmF0ZSwgYXV4aWxpYXJ5CisgICAg ICAgIGZ1bmN0aW9ucyBpbiBld2sgaW4gb3JkZXIgdG8gaXRlcmF0ZSBhbmQgZHVtcCB0aGUgaGlz dG9yeSB0cmVlIHdoZW4KKyAgICAgICAgbmVjZXNzYXJ5LgorCisgICAgICAgICogZXdrL2V3a19o aXN0b3J5LmNwcDoKKyAgICAgICAgKGV3a19oaXN0b3J5X2l0ZW1fdGFyZ2V0X2dldCk6CisgICAg ICAgIChld2tfaGlzdG9yeV9pdGVtX3RhcmdldF9pcyk6CisgICAgICAgIChld2tfaGlzdG9yeV9p dGVtX2NoaWxkcmVuX2dldCk6CisgICAgICAgICogZXdrL2V3a19wcml2YXRlLmg6CisKIDIwMTEt MDgtMjIgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CiAKICAg ICAgICAgW0VGTF0gSW1wbGVtZW50IEZyYW1lTG9hZGVyQ2xpZW50OjpkaXNwYXRjaERpZENsZWFy V2luZG93T2JqZWN0SW5Xb3JsZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a19oaXN0b3J5LmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfaGlzdG9yeS5jcHAKaW5k ZXggZmM3Y2NhYWMyOGZjMmI5ODMwZDZjMWEzZjI1NzI5ZGU0YzU5NWVlMC4uYjNiMTRlNGQ5Y2M4 MzYwOTJhZDkzNDEyMWY4NjU0Yzk3OWI2ODM2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9l ZmwvZXdrL2V3a19oaXN0b3J5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2hp c3RvcnkuY3BwCkBAIC00MDYsMyArNDA2LDUyIEBAIHZvaWQgZXdrX2hpc3RvcnlfZnJlZShFd2tf SGlzdG9yeSogaGlzdG9yeSkKICAgICBoaXN0b3J5LT5jb3JlLT5kZXJlZigpOwogICAgIGZyZWUo aGlzdG9yeSk7CiB9CisKKy8qKgorICogQGludGVybmFsCisgKgorICogUmV0dXJucyBhIG5ld2x5 LWFsbG9jYXRlZCBzdHJpbmcgd2l0aCB0aGUgaXRlbSdzIHRhcmdldCBuYW1lLgorICogQ2FsbGVy cyBhcmUgcmVzcG9uc2libGUgZm9yIGZyZWVpbmcgdGhlIGFsbG9jYXRlZCBtZW1vcnkgd2l0aCBm cmVlKDMpLgorICoKKyAqIEBwYXJhbSBpdGVtIGluc3RhbmNlIHRvIG9wZXJhdGUgdXBvbi4KKyAq LworY2hhciogZXdrX2hpc3RvcnlfaXRlbV90YXJnZXRfZ2V0KGNvbnN0IEV3a19IaXN0b3J5X0l0 ZW0qIGl0ZW0pCit7CisgICAgRVdLX0hJU1RPUllfSVRFTV9DT1JFX0dFVF9PUl9SRVRVUk4oaXRl bSwgY29yZSwgMCk7CisgICAgcmV0dXJuIHN0cmR1cChjb3JlLT50YXJnZXQoKS51dGY4KCkuZGF0 YSgpKTsKK30KKworLyoqCisgKiBAaW50ZXJuYWwKKyAqCisgKiBSZXR1cm5zIHdoZXRoZXIgdGhl IGdpdmVuIGl0ZW0gaXMgY3VycmVudGx5IGEgdGFyZ2V0LgorICoKKyAqIEBwYXJhbSBpdGVtIGlu c3RhbmNlIHRvIGNoZWNrLgorICovCitFaW5hX0Jvb2wgZXdrX2hpc3RvcnlfaXRlbV90YXJnZXRf aXMoY29uc3QgRXdrX0hpc3RvcnlfSXRlbSogaXRlbSkKK3sKKyAgICBFV0tfSElTVE9SWV9JVEVN X0NPUkVfR0VUX09SX1JFVFVSTihpdGVtLCBjb3JlLCAwKTsKKyAgICByZXR1cm4gY29yZS0+aXNU YXJnZXRJdGVtKCk7Cit9CisKKy8qKgorICogQGludGVybmFsCisgKgorICogUmV0dXJucyBhIGxp c3Qgb2YgY2hpbGQgaGlzdG9yeSBpdGVtcyByZWxhdGl2ZSB0byB0aGUgZ2l2ZW4gaXRlbSwKKyAq IG9yIEBjIE5VTEwgaWYgdGhlcmUgYXJlIG5vbmUuCisgKgorICogQHBhcmFtIGl0ZW0gaW5zdGFu Y2UgdG8gb3BlcmF0ZSB1cG9uLgorICovCitFaW5hX0xpc3QqIGV3a19oaXN0b3J5X2l0ZW1fY2hp bGRyZW5fZ2V0KGNvbnN0IEV3a19IaXN0b3J5X0l0ZW0qIGl0ZW0pCit7CisgICAgRVdLX0hJU1RP UllfSVRFTV9DT1JFX0dFVF9PUl9SRVRVUk4oaXRlbSwgY29yZSwgMCk7CisgICAgY29uc3QgV2Vi Q29yZTo6SGlzdG9yeUl0ZW1WZWN0b3ImIGNoaWxkcmVuID0gY29yZS0+Y2hpbGRyZW4oKTsKKyAg ICBpZiAoIWNoaWxkcmVuLnNpemUoKSkKKyAgICAgICAgcmV0dXJuIDA7CisKKyAgICBFaW5hX0xp c3QqIGtpZHMgPSAwOworICAgIGNvbnN0IHVuc2lnbmVkIHNpemUgPSBjaGlsZHJlbi5zaXplKCk7 CisgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IHNpemU7ICsraSkKKyAgICAgICAga2lkcyA9 IGVpbmFfbGlzdF9hcHBlbmQoa2lkcywgX2V3a19oaXN0b3J5X2l0ZW1fbmV3KGNoaWxkcmVuW2ld LmdldCgpKSk7CisgICAgcmV0dXJuIGtpZHM7Cit9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2VmbC9ld2svZXdrX3ByaXZhdGUuaCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfcHJpdmF0 ZS5oCmluZGV4IDdjMGQ5ZGU0NWE0MzQyYTQ1ZGQ4ODBhMjVlOTVlM2NmM2EyNzRlNDIuLmUyYjVm ZDFiN2FhMGU1MjIyOTYzNmViOTI3YWVmZTBiNDZmOTZjOGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvZWZsL2V3ay9ld2tfcHJpdmF0ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9l d2tfcHJpdmF0ZS5oCkBAIC0xMzAsNiArMTMwLDkgQEAgRWluYV9Cb29sIGV3a192aWV3X25lZWRf dG91Y2hfZXZlbnRzX2dldChFdmFzX09iamVjdCopOwogCiBFd2tfSGlzdG9yeSAqZXdrX2hpc3Rv cnlfbmV3KFdlYkNvcmU6OkJhY2tGb3J3YXJkTGlzdEltcGwgKmhpc3RvcnkpOwogdm9pZCBld2tf aGlzdG9yeV9mcmVlKEV3a19IaXN0b3J5ICpoaXN0b3J5KTsKK2NoYXIgKmV3a19oaXN0b3J5X2l0 ZW1fdGFyZ2V0X2dldChjb25zdCBFd2tfSGlzdG9yeV9JdGVtICppdGVtKTsKK0VpbmFfQm9vbCBl d2tfaGlzdG9yeV9pdGVtX3RhcmdldF9pcyhjb25zdCBFd2tfSGlzdG9yeV9JdGVtICppdGVtKTsK K0VpbmFfTGlzdCAqZXdrX2hpc3RvcnlfaXRlbV9jaGlsZHJlbl9nZXQoY29uc3QgRXdrX0hpc3Rv cnlfSXRlbSAqaXRlbSk7CiAKICNpZiBFTkFCTEUoQ09OVEVYVF9NRU5VUykKIEV3a19Db250ZXh0 X01lbnUgKmV3a19jb250ZXh0X21lbnVfbmV3KEV2YXNfT2JqZWN0ICp2aWV3LCBXZWJDb3JlOjpD b250ZXh0TWVudUNvbnRyb2xsZXIgKmNvbnRyb2xsZXIpOwo=