66698 2011-08-22 11:58:27 -0700 [EFL] Treat the case of WebCore::History->currentItem() returning NULL. 2011-08-23 08:49:12 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 rakuco webkit-unassigned leandro tonikitoo webkit.review.bot oldest_to_newest 454774 0 rakuco 2011-08-22 11:58:27 -0700 [EFL] Treat the case of WebCore::History->currentItem() returning NULL. 454777 1 104710 rakuco 2011-08-22 12:00:14 -0700 Created attachment 104710 Patch 454778 2 rakuco 2011-08-22 12:00:38 -0700 CC'ing tonikitoo. 454821 3 104710 kenneth 2011-08-22 12:57:55 -0700 Comment on attachment 104710 Patch Do you have any test case where it returns 0? 454854 4 leandro 2011-08-22 13:30:48 -0700 (In reply to comment #3) > (From update of attachment 104710 [details]) > Do you have any test case where it returns 0? Mostly tests from fast/loader, such as fast/loader/about-blank-hash-change.html, fast/loader/about-blank-hash-kept.html, and fast/loader/child-frame-add-after-back-forward.html. 455391 5 rakuco 2011-08-23 06:52:06 -0700 Can someone cq+ this one? 455428 6 104710 webkit.review.bot 2011-08-23 08:49:08 -0700 Comment on attachment 104710 Patch Clearing flags on attachment: 104710 Committed r93606: <http://trac.webkit.org/changeset/93606> 455429 7 webkit.review.bot 2011-08-23 08:49:12 -0700 All reviewed patches have been landed. Closing bug. 104710 2011-08-22 12:00:14 -0700 2011-08-23 08:49:08 -0700 Patch bug-66698-20110822160345.patch text/plain 2580 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogOTM1MTIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCAyMWVmMTFkMzk2 OTc3ODhlYjkwMDMyNmU5ODBmOThhNzZlYTU2MTM1Li40YzJlZGIzZTExMzcxNjc1OGE3NjliNmYw YTM5MjllZDA1MjFhNTNkIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEt MDgtMjIgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CisKKyAg ICAgICAgW0VGTF0gVHJlYXQgdGhlIGNhc2Ugb2YgV2ViQ29yZTo6SGlzdG9yeS0+Y3VycmVudEl0 ZW0oKSByZXR1cm5pbmcgTlVMTC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTY2Njk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgV2ViQ29yZTo6SGlzdG9yeS0+Y3VycmVudEl0ZW0oKSBtYXkgcmV0dXJuIE5V TEwsIGFuZCB3ZSdkIGJldHRlciB0cmVhdAorICAgICAgICBpdCBpbiBld2tfaGlzdG9yeV9oaXN0 b3J5X2l0ZW1fY3VycmVudF9nZXQgaXRzZWxmIHRoYW4gcHJvcGFnYXRlIHRoZQorICAgICAgICBp c3N1ZSB0byBfZXdrX2hpc3RvcnlfaXRlbV9uZXcuCisKKyAgICAgICAgKiBld2svZXdrX2hpc3Rv cnkuY3BwOgorICAgICAgICAoZXdrX2hpc3RvcnlfaGlzdG9yeV9pdGVtX2N1cnJlbnRfZ2V0KToK KyAgICAgICAgKiBld2svZXdrX2hpc3RvcnkuaDoKKwogMjAxMS0wOC0yMCAgR3J6ZWdvcnogQ3ph amtvd3NraSAgPGcuY3phamtvd3NraUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBGaXgg YW5kIHVwZGF0ZSBkb3h5Z2VuIGRvY3VtZW50YXRpb24gZm9yIGV3a192aWV3LgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19oaXN0b3J5LmNwcCBiL1NvdXJjZS9XZWJLaXQv ZWZsL2V3ay9ld2tfaGlzdG9yeS5jcHAKaW5kZXggZmM3Y2NhYWMyOGZjMmI5ODMwZDZjMWEzZjI1 NzI5ZGU0YzU5NWVlMC4uYzNhZGJmY2I1YzMwMWVkY2QwOGY4NTc5MzViYTY5NjRlNDRhY2RlZCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19oaXN0b3J5LmNwcAorKysgYi9T b3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2hpc3RvcnkuY3BwCkBAIC0xNTMsNyArMTUzLDEwIEBA IEV3a19IaXN0b3J5X0l0ZW0qIGV3a19oaXN0b3J5X2hpc3RvcnlfaXRlbV9iYWNrX2dldChjb25z dCBFd2tfSGlzdG9yeSogaGlzdG9yeSkKIEV3a19IaXN0b3J5X0l0ZW0qIGV3a19oaXN0b3J5X2hp c3RvcnlfaXRlbV9jdXJyZW50X2dldChjb25zdCBFd2tfSGlzdG9yeSogaGlzdG9yeSkKIHsKICAg ICBFV0tfSElTVE9SWV9DT1JFX0dFVF9PUl9SRVRVUk4oaGlzdG9yeSwgY29yZSwgMCk7Ci0gICAg cmV0dXJuIF9ld2tfaGlzdG9yeV9pdGVtX25ldyhjb3JlLT5jdXJyZW50SXRlbSgpKTsKKyAgICBX ZWJDb3JlOjpIaXN0b3J5SXRlbSAqY3VycmVudEl0ZW0gPSBjb3JlLT5jdXJyZW50SXRlbSgpOwor ICAgIGlmIChjdXJyZW50SXRlbSkKKyAgICAgICAgcmV0dXJuIF9ld2tfaGlzdG9yeV9pdGVtX25l dyhjdXJyZW50SXRlbSk7CisgICAgcmV0dXJuIDA7CiB9CiAKIEV3a19IaXN0b3J5X0l0ZW0qIGV3 a19oaXN0b3J5X2hpc3RvcnlfaXRlbV9mb3J3YXJkX2dldChjb25zdCBFd2tfSGlzdG9yeSogaGlz dG9yeSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfaGlzdG9yeS5oIGIv U291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19oaXN0b3J5LmgKaW5kZXggOGNiYTlkNjgyM2I3OTFl OGY2NDMxZmEwZmZhYTIxZjZmNTRlYjZmMC4uMGE2YzNjMjUyYzkxMmJiYzhjMzY0MjU4ZmM4MmFm ZjY0NWYzMDRkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19oaXN0b3J5 LmgKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19oaXN0b3J5LmgKQEAgLTExMCw4ICsx MTAsOCBAQCBFQVBJIEV3a19IaXN0b3J5X0l0ZW0gKmV3a19oaXN0b3J5X2hpc3RvcnlfaXRlbV9i YWNrX2dldChjb25zdCBFd2tfSGlzdG9yeSAqaGlzdAogICoKICAqIEBwYXJhbSBoaXN0b3J5IHdo aWNoIGhpc3RvcnkgaW5zdGFuY2UgdG8gcXVlcnkuCiAgKgotICogQHJldHVybiB0aGUgQGIgbmV3 bHkgYWxsb2NhdGVkIGl0ZW0gaW5zdGFuY2UuIFRoaXMgbWVtb3J5IG11c3QgYmUKLSAqICAgICAg ICAgcmVsZWFzZWQgd2l0aCBld2tfaGlzdG9yeV9pdGVtX2ZyZWUoKSBhZnRlciB1c2UuCisgKiBA cmV0dXJuIHRoZSBAYiBuZXdseSBhbGxvY2F0ZWQgaXRlbSBpbnN0YW5jZSBvciBAYyBOVUxMIG9u IGVycm9yLiBUaGlzIG1lbW9yeQorICogICAgICAgICBtdXN0IGJlIHJlbGVhc2VkIHdpdGggZXdr X2hpc3RvcnlfaXRlbV9mcmVlKCkgYWZ0ZXIgdXNlLgogICovCiBFQVBJIEV3a19IaXN0b3J5X0l0 ZW0gKmV3a19oaXN0b3J5X2hpc3RvcnlfaXRlbV9jdXJyZW50X2dldChjb25zdCBFd2tfSGlzdG9y eSAqaGlzdG9yeSk7CiAK