<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>66697</bug_id>
          
          <creation_ts>2011-08-22 11:47:10 -0700</creation_ts>
          <short_desc>fix the GPU bot names on the layout test dashboard</short_desc>
          <delta_ts>2011-08-22 14:13:25 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Dirk Pranke">dpranke</reporter>
          <assigned_to name="Dirk Pranke">dpranke</assigned_to>
          <cc>abarth</cc>
    
    <cc>dglazkov</cc>
    
    <cc>jamesr</cc>
    
    <cc>ojan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>454763</commentid>
    <comment_count>0</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2011-08-22 11:47:10 -0700</bug_when>
    <thetext>fix the GPU bot names on the layout test dashboard</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>454765</commentid>
    <comment_count>1</comment_count>
      <attachid>104708</attachid>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2011-08-22 11:47:31 -0700</bug_when>
    <thetext>Created attachment 104708
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>454780</commentid>
    <comment_count>2</comment_count>
      <attachid>104708</attachid>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2011-08-22 12:04:06 -0700</bug_when>
    <thetext>Comment on attachment 104708
Patch

Clearing flags on attachment: 104708

Committed r93527: &lt;http://trac.webkit.org/changeset/93527&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>454781</commentid>
    <comment_count>3</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2011-08-22 12:04:10 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>454797</commentid>
    <comment_count>4</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2011-08-22 12:20:36 -0700</bug_when>
    <thetext>I&apos;ve pushed the latest version of the app to App Engine. 

abarth (and anyone else who might also be pushing versions) ... at some point I tried to establish the convention that you would update the version correctly when pushing the code (and I think I convinced Ojan that this was a good idea, but neither of us got around to automating it).

To set the version when updating, you can actually specify it on the command line, e.g. &quot;appcfg.py update test-results r93527&quot;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>454874</commentid>
    <comment_count>5</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-08-22 13:51:13 -0700</bug_when>
    <thetext>That&apos;s too much work.  If I&apos;m required to do that before pushing, I&apos;d rather have my push access revoked.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>454899</commentid>
    <comment_count>6</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2011-08-22 14:07:35 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; That&apos;s too much work.  If I&apos;m required to do that before pushing, I&apos;d rather have my push access revoked.

saying &quot;appcfg.py update test-results r93527&quot; instead of &quot;appcfg.py update&quot; is too much work?

if you didn&apos;t push it as a separate version, how did you test that the new version didn&apos;t break anything? Did you use the test-results-test instance?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>454906</commentid>
    <comment_count>7</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-08-22 14:13:25 -0700</bug_when>
    <thetext>&gt; saying &quot;appcfg.py update test-results r93527&quot; instead of &quot;appcfg.py update&quot; is too much work?

I just click the &quot;deploy&quot; button in the UI.  Having to type anything on the command line is too hard.

&gt; if you didn&apos;t push it as a separate version, how did you test that the new version didn&apos;t break anything? Did you use the test-results-test instance?

The site was completely broken before I deployed.  I couldn&apos;t possibly make it any worse.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>104708</attachid>
            <date>2011-08-22 11:47:31 -0700</date>
            <delta_ts>2011-08-22 12:04:06 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-66697-20110822114730.patch</filename>
            <type>text/plain</type>
            <size>1606</size>
            <attacher name="Dirk Pranke">dpranke</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogOTM1MjMKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi
L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjNTgxNTJkZWZlMTFiNmE2OWVlYWE4Njg5MjUyNmY1OWFl
ZDg0NTU5Li4zNWQxZTc0MTliZDU3MmY0NjdiYzZhZDhlYTlhMjMxNTIyNzBlMjhkIDEwMDY0NAot
LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg
QEAKKzIwMTEtMDgtMjIgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAg
ICAgICAgZml4IHRoZSBHUFUgYm90IG5hbWVzIG9uIHRoZSBsYXlvdXQgdGVzdCBkYXNoYm9hcmQK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2Njk3CisK
KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0UmVz
dWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2J1aWxkZXJzLmpzOgorCiAyMDExLTA4LTIyICBE
aW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgZ2FyZGVu
LW8tbWF0aWMncyByZWxhdGl2ZSB0aW1lIGRpc3BsYXkgc2hvdWxkIGJlIHVwZGF0ZWQgcmVndWxh
cmx5LgpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJk
cy9idWlsZGVycy5qcyBiL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMv
YnVpbGRlcnMuanMKaW5kZXggMzU0NTI1NjViMjIzYTI5YzJlYTM2YTQ0NjcyMWIxOTZmZTdlMzAx
Ni4uYjczZDM5NmI3MjZiMTQxN2I1MjI3YjFhZmQ4MjM5ZjY2Y2MzNDBiMCAxMDA2NDQKLS0tIGEv
VG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9idWlsZGVycy5qcworKysg
Yi9Ub29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2J1aWxkZXJzLmpzCkBA
IC0xNDQsMTEgKzE0NCwxMSBAQCB2YXIgQ0hST01JVU1fR1BVX01FU0FfQlVJTERFUlMgPSBbCiAg
ICAgWydXZWJraXQgTGludXggMzIgLSBHUFUnXSwKICAgICBbJ1dlYmtpdCBMaW51eCAoZGJnKSgx
KSAtIEdQVSddLAogICAgIFsnV2Via2l0IExpbnV4IChkYmcpKDIpIC0gR1BVJ10sCi0gICAgWydX
ZWJraXQgTWFjMTAuNSAtIEdQVSddLAotICAgIFsnV2Via2l0IE1hYzEwLjUgKGRiZykoMSkgLSBH
UFUnXSwKLSAgICBbJ1dlYmtpdCBNYWMxMC41IChkYmcpKDIpIC0gR1BVJ10sCi0gICAgWydXZWJr
aXQgTWFjMTAuNiAtIEdQVSddLAotICAgIFsnV2Via2l0IE1hYzEwLjYgKGRiZykgLSBHUFUnXQor
ICAgIFsnV2Via2l0IE1hYzEwLjUgKENHKSAtIEdQVSddLAorICAgIFsnV2Via2l0IE1hYzEwLjUg
KENHKShkYmcpKDEpIC0gR1BVJ10sCisgICAgWydXZWJraXQgTWFjMTAuNSAoQ0cpKGRiZykoMikg
LSBHUFUnXSwKKyAgICBbJ1dlYmtpdCBNYWMxMC42IChDRykgLSBHUFUnXSwKKyAgICBbJ1dlYmtp
dCBNYWMxMC42IChDRykoZGJnKSAtIEdQVSddCiBdOwogYXNzb2NpYXRlQnVpbGRlcnNXaXRoTWFz
dGVyKENIUk9NSVVNX0dQVV9NRVNBX0JVSUxERVJTLCBDSFJPTUlVTV9XRUJLSVRfQlVJTERFUl9N
QVNURVIpOwogCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>