66691 2011-08-22 11:23:05 -0700 [chromium] Fix nullptr deref when switching composited tabs 2011-08-22 11:50:01 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enne enne enne jamesr webkit.review.bot oldest_to_newest 454730 0 enne 2011-08-22 11:23:05 -0700 [chromium] Fix nullptr deref when switching composited tabs 454731 1 104701 enne 2011-08-22 11:23:30 -0700 Created attachment 104701 Patch 454734 2 enne 2011-08-22 11:26:28 -0700 http://code.google.com/p/chromium/issues/detail?id=93739 I am not completely sure how to repro this locally, but the stack trace makes it obvious that the protect is being called on the root layer, but the tiler is null. My theory is that compositing is on (so the root layer gets created), but the tab gets switched away from (causing the protect call) prior to a compositing pass (where the tiler would get created). 454742 3 104701 jamesr 2011-08-22 11:35:59 -0700 Comment on attachment 104701 Patch Hm, whoops. It'd be nice if we had a way to test background tabs more directly (I think you could hook up a browser_test to do this, although I dunno how they interact with the compositor). 454767 4 104701 webkit.review.bot 2011-08-22 11:49:56 -0700 Comment on attachment 104701 Patch Clearing flags on attachment: 104701 Committed r93526: <http://trac.webkit.org/changeset/93526> 454768 5 webkit.review.bot 2011-08-22 11:50:01 -0700 All reviewed patches have been landed. Closing bug. 104701 2011-08-22 11:23:30 -0700 2011-08-22 11:49:56 -0700 Patch bug-66691-20110822112329.patch text/plain 1379 enne U3VidmVyc2lvbiBSZXZpc2lvbjogOTM1MjEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4ZTkxZmFhYjViYTczZjgx ZGI5ZjBhMjQ0NjdkNTQ2ZGUwMzUzMjNiLi4zNGM1NzQyZWVmYWI5NjdiNWYyMjYzOWQwYWY1NjMw YzMyNjhhM2JjIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDgtMjIgIEFkcmll bm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNvbT4KKworICAgICAgICBbY2hyb21pdW1dIEZpeCBu dWxscHRyIGRlcmVmIHdoZW4gc3dpdGNoaW5nIGNvbXBvc2l0ZWQgdGFicworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY2OTEKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL1RpbGVkTGF5ZXJDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUaWxlZExh eWVyQ2hyb21pdW06OnByb3RlY3RUaWxlVGV4dHVyZXMpOgorCiAyMDExLTA4LTIyICBOYXRlIENo YXBpbiAgPGphcGhldEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5sb2FkIGV2ZW50cyBjYW4g Y3Jhc2ggdXMgd2hlbiB0aGV5IGJsYW5rIG91dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVGlsZWRMYXllckNocm9taXVtLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1RpbGVkTGF5ZXJDaHJvbWl1bS5j cHAKaW5kZXggYmZkMDhjNTU0YmU3NzNlYjNjMzRhZThkZWNmY2M0ZWMzNWE2OGJhNy4uZWQ3Mjg4 MDY2Njc5ZWMyZDA4ZGI4OTM5ODBjZDE5YzIxNDhhMmFhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVGlsZWRMYXllckNocm9taXVtLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9UaWxlZExheWVy Q2hyb21pdW0uY3BwCkBAIC0zNTcsNyArMzU3LDcgQEAgdm9pZCBUaWxlZExheWVyQ2hyb21pdW06 OnByb3RlY3RWaXNpYmxlVGlsZVRleHR1cmVzKCkKIAogdm9pZCBUaWxlZExheWVyQ2hyb21pdW06 OnByb3RlY3RUaWxlVGV4dHVyZXMoY29uc3QgSW50UmVjdCYgY29udGVudFJlY3QpCiB7Ci0gICAg aWYgKGNvbnRlbnRSZWN0LmlzRW1wdHkoKSkKKyAgICBpZiAoIW1fdGlsZXIgfHwgY29udGVudFJl Y3QuaXNFbXB0eSgpKQogICAgICAgICByZXR1cm47CiAKICAgICBpbnQgbGVmdCwgdG9wLCByaWdo dCwgYm90dG9tOwo=