66682 2011-08-22 10:24:28 -0700 garden-o-matic's relative time display should be updated regularly. 2011-08-22 11:15:56 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 64188 1 dglazkov dglazkov abarth oldest_to_newest 454662 0 dglazkov 2011-08-22 10:24:28 -0700 garden-o-matic's relative time display should be updated regularly. 454665 1 104693 dglazkov 2011-08-22 10:25:44 -0700 Created attachment 104693 Patch 454681 2 104693 abarth 2011-08-22 10:45:18 -0700 Comment on attachment 104693 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104693&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:30 > +var kTimeUpdateFrequencyInMilliseconds = 1000; Should this be in config ? > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:183 > + Array.prototype.forEach.call(document.querySelectorAll("time"), function(time) { Do we want to add a class name here? It seems like we could use other <time> elements that don't derive from ui.Time 454695 3 104693 dglazkov 2011-08-22 10:58:05 -0700 Comment on attachment 104693 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104693&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:30 >> +var kTimeUpdateFrequencyInMilliseconds = 1000; > > Should this be in config ? Ooh, yes. >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:183 >> + Array.prototype.forEach.call(document.querySelectorAll("time"), function(time) { > > Do we want to add a class name here? It seems like we could use other <time> elements that don't derive from ui.Time That's a neat idea! I'll add "relative" to the instance. Hey, I should even rename this to RelativeTime class. 454722 4 dglazkov 2011-08-22 11:15:56 -0700 Committed r93522: <http://trac.webkit.org/changeset/93522> 104693 2011-08-22 10:25:44 -0700 2011-08-22 10:58:05 -0700 Patch bug-66682-20110822102543.patch text/plain 5033 dglazkov U3VidmVyc2lvbiBSZXZpc2lvbjogOTM1MTEKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9z Y3JpcHRzL3VpLmpzIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1j b25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvdWkuanMKaW5kZXggNjE1ODRl ZWFmY2Y4ODQ0ZDM2ZDQ2ZmNkNjA0NDBmZjg2NTQ1Y2M3OS4uMTk3MDc3Zjg3NmRlOGYyYzNkMGRl YTAzOTFmMWFiZWNiMzBlMzU5YyAxMDA2NDQKLS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv YnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMv dWkuanMKKysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25m aWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvdWkuanMKQEAgLTI3LDYgKzI3LDgg QEAgdmFyIHVpID0gdWkgfHwge307CiAKIChmdW5jdGlvbiAoKSB7CiAKK3ZhciBrVGltZVVwZGF0 ZUZyZXF1ZW5jeUluTWlsbGlzZWNvbmRzID0gMTAwMDsKKwogdWkuZGlzcGxheVVSTEZvckJ1aWxk ZXIgPSBmdW5jdGlvbihidWlsZGVyTmFtZSkKIHsKICAgICByZXR1cm4gJ2h0dHA6Ly9idWlsZC5j aHJvbWl1bS5vcmcvcC9jaHJvbWl1bS53ZWJraXQvd2F0ZXJmYWxsPycgKyAkLnBhcmFtKHsKQEAg LTE3Nyw0ICsxNzksMzAgQEAgdWkuY2hhbmdlbG9nID0gZnVuY3Rpb24oY29tbWl0RGF0YUxpc3Qp CiAgICAgcmV0dXJuIGJsb2NrOwogfTsKIAorc2V0SW50ZXJ2YWwoZnVuY3Rpb24oKSB7CisgICAg QXJyYXkucHJvdG90eXBlLmZvckVhY2guY2FsbChkb2N1bWVudC5xdWVyeVNlbGVjdG9yQWxsKCJ0 aW1lIiksIGZ1bmN0aW9uKHRpbWUpIHsKKyAgICAgICAgdGltZS51cGRhdGUgJiYgdGltZS51cGRh dGUoKTsKKyAgICB9KTsKK30sIGtUaW1lVXBkYXRlRnJlcXVlbmN5SW5NaWxsaXNlY29uZHMpOwor Cit1aS5UaW1lID0gYmFzZS5leHRlbmRzKCd0aW1lJywgeworICAgIGluaXQ6IGZ1bmN0aW9uKCkK KyAgICB7CisgICAgICAgIHRoaXMuc2V0RGF0ZShuZXcgRGF0ZSgpKTsKKyAgICB9LAorICAgIGRh dGU6IGZ1bmN0aW9uKCkKKyAgICB7CisgICAgICAgIHJldHVybiB0aGlzLl9kYXRlOworICAgIH0s CisgICAgdXBkYXRlOiBmdW5jdGlvbigpCisgICAgeworICAgICAgICB0aGlzLnRleHRDb250ZW50 ID0gYmFzZS5yZWxhdGl2aXplVGltZSh0aGlzLl9kYXRlKTsKKyAgICB9LAorICAgIHNldERhdGU6 IGZ1bmN0aW9uKGRhdGUpCisgICAgeworICAgICAgICB0aGlzLl9kYXRlID0gZGF0ZTsKKyAgICAg ICAgdGhpcy50ZXh0Q29udGVudCA9IGJhc2UucmVsYXRpdml6ZVRpbWUoZGF0ZSk7CisgICAgfQor fSk7CisKIH0pKCk7CmRpZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53 ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy91aS9ub3Rp ZmljYXRpb25zLmpzIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1j b25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvdWkvbm90aWZpY2F0aW9ucy5q cwppbmRleCAwNDk4NjU5YmRkNGEyYTAwYmVmNjUyNDdkNmFjYjk2NmE0YTYyZjFjLi5jYzA4NjNj OTc3ZDcxYWZiMTU2NzYwY2MwYjk3YzE1ODcyMGFkMTFkIDEwMDY0NAotLS0gYS9Ub29scy9CdWls ZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFp bHVyZXMvc2NyaXB0cy91aS9ub3RpZmljYXRpb25zLmpzCisrKyBiL1Rvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9z Y3JpcHRzL3VpL25vdGlmaWNhdGlvbnMuanMKQEAgLTgwLDIyICs4MCw2IEBAIHVpLm5vdGlmaWNh dGlvbnMuSW5mbyA9IGJhc2UuZXh0ZW5kcyh1aS5ub3RpZmljYXRpb25zLk5vdGlmaWNhdGlvbiwg ewogICAgIH0KIH0pOwogCi12YXIgVGltZSA9IGJhc2UuZXh0ZW5kcygndGltZScsIHsKLSAgICBp bml0OiBmdW5jdGlvbigpCi0gICAgewotICAgICAgICB0aGlzLnNldERhdGUobmV3IERhdGUoKSk7 Ci0gICAgfSwKLSAgICBkYXRlOiBmdW5jdGlvbigpCi0gICAgewotICAgICAgICByZXR1cm4gdGhp cy5fZGF0ZTsKLSAgICB9LAotICAgIHNldERhdGU6IGZ1bmN0aW9uKGRhdGUpCi0gICAgewotICAg ICAgICB0aGlzLl9kYXRlID0gZGF0ZTsKLSAgICAgICAgdGhpcy50ZXh0Q29udGVudCA9IGJhc2Uu cmVsYXRpdml6ZVRpbWUoZGF0ZSk7Ci0gICAgfQotfSk7Ci0KIHVpLm5vdGlmaWNhdGlvbnMuRmFp bGluZ1Rlc3QgPSBiYXNlLmV4dGVuZHMoJ2xpJywgewogICAgIGluaXQ6IGZ1bmN0aW9uKGZhaWx1 cmVBbmFseXNpcykKICAgICB7CkBAIC0xMzUsNyArMTE5LDcgQEAgdWkubm90aWZpY2F0aW9ucy5T dXNwaWNpb3VzQ29tbWl0ID0gYmFzZS5leHRlbmRzKENhdXNlLCB7CiB1aS5ub3RpZmljYXRpb25z LkZhaWx1cmUgPSBiYXNlLmV4dGVuZHModWkubm90aWZpY2F0aW9ucy5Ob3RpZmljYXRpb24sIHsK ICAgICBpbml0OiBmdW5jdGlvbigpCiAgICAgewotICAgICAgICB0aGlzLl90aW1lID0gdGhpcy5p bnNlcnRCZWZvcmUobmV3IFRpbWUoKSwgdGhpcy5maXJzdENoaWxkKTsKKyAgICAgICAgdGhpcy5f dGltZSA9IHRoaXMuaW5zZXJ0QmVmb3JlKG5ldyB1aS5UaW1lKCksIHRoaXMuZmlyc3RDaGlsZCk7 CiAgICAgICAgIHRoaXMuX3Byb2JsZW0gPSB0aGlzLl93aGF0LmFwcGVuZENoaWxkKGRvY3VtZW50 LmNyZWF0ZUVsZW1lbnQoJ2RpdicpKTsKICAgICAgICAgdGhpcy5fcHJvYmxlbS5jbGFzc05hbWUg PSAncHJvYmxlbSc7CiAgICAgICAgIHRoaXMuX2VmZmVjdHMgPSB0aGlzLl9wcm9ibGVtLmFwcGVu ZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ3VsJykpOwpkaWZmIC0tZ2l0IGEvVG9vbHMv QnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVz dEZhaWx1cmVzL3NjcmlwdHMvdWlfdW5pdHRlc3RzLmpzIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBv cnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3Njcmlw dHMvdWlfdW5pdHRlc3RzLmpzCmluZGV4IDc0MmMyZjQ2ZWYzZjY4NzBiZWJhNzc1M2E5MWMxNzMz NTNiYjE2NWEuLjYyYjcxNDU2ZWVhMWI1ZTVkNzZmODM4MjMyZjRhNzVjZmE3NTc2YTEgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1 YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zY3JpcHRzL3VpX3VuaXR0ZXN0cy5qcworKysgYi9Ub29s cy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9U ZXN0RmFpbHVyZXMvc2NyaXB0cy91aV91bml0dGVzdHMuanMKQEAgLTE2Miw0ICsxNjIsMTYgQEAg dGVzdCgic3VtbWFyaXplRmFpbHVyZSIsIDEsIGZ1bmN0aW9uKCkgewogICAgIF0pOwogfSk7CiAK K3Rlc3QoInRpbWUiLCA1LCBmdW5jdGlvbigpIHsKKyAgICB2YXIgdGltZSA9IG5ldyB1aS5UaW1l KCk7CisgICAgZXF1YWwodGltZS50YWdOYW1lLCAnVElNRScpOworICAgIGRlZXBFcXVhbChPYmpl Y3QuZ2V0T3duUHJvcGVydHlOYW1lcyh0aW1lLl9fcHJvdG9fXyksIFsnaW5pdCcsICdkYXRlJywg J3NldERhdGUnLCAndXBkYXRlJ10pOworICAgIGVxdWFsKHRpbWUub3V0ZXJIVE1MLCAnPHRpbWU+ SnVzdCBub3c8L3RpbWU+Jyk7CisgICAgdmFyIHRlbk1pbnV0ZXNBZ28gPSBuZXcgRGF0ZSgpOwor ICAgIHRlbk1pbnV0ZXNBZ28uc2V0TWludXRlcyh0ZW5NaW51dGVzQWdvLmdldE1pbnV0ZXMoKSAt IDEwKTsKKyAgICB0aW1lLnNldERhdGUodGVuTWludXRlc0Fnbyk7CisgICAgZXF1YWwodGltZS5v dXRlckhUTUwsICc8dGltZT4xMCBtaW51dGVzIGFnbzwvdGltZT4nKTsKKyAgICBlcXVhbCh0aW1l LmRhdGUoKS5nZXRUaW1lKCksIHRlbk1pbnV0ZXNBZ28uZ2V0VGltZSgpKTsKK30pOworCiB9KSgp OwpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGIz Y2ZiY2FmNGU4NmJkMGNlNDU4YTM1MzlkZjhmZjJjYmEwMzQxZTkuLjRkMzNjYzRhYzFjNGMzMTFi OGY1MjY0MDJiY2U2YzUxNjBlYmM3ZGIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysg Yi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMS0wOC0yMiAgRGltaXRyaSBH bGF6a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIGdhcmRlbi1vLW1hdGlj J3MgcmVsYXRpdmUgdGltZSBkaXNwbGF5IHNob3VsZCBiZSB1cGRhdGVkIHJlZ3VsYXJseS4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2NjgyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZl U3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMv c2NyaXB0cy91aS5qczogTW92ZWQgVGltZSB0byB1aS5UaW1lLCBhZGRlZCBjb2RlIGZvciByZWd1 bGFyIHVwZGF0ZXMuCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9y Zy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvdWkvbm90aWZpY2F0aW9u cy5qczogQ2hhbmdlZCB0byB1c2UgdWkuVGltZS4KKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9y dC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0 cy91aV91bml0dGVzdHMuanM6IEFkZGVkIHRlc3RzLgorCiAyMDExLTA4LTIyICBQZXRlciBCZXZl cmxvbyAgPHBldGVyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBBZGQgbXlzZWxmIHRvIHRoZSBj b250cmlidXRvciBsaXN0Lgo=