66679 2011-08-22 10:09:12 -0700 [chromium] DRT linux should pass nativeKeyCode to plugins 2011-12-01 16:51:31 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tony noel.gordon fsamuel noel.gordon tkent webkit.review.bot oldest_to_newest 454651 0 tony 2011-08-22 10:09:12 -0700 From https://bugs.webkit.org/show_bug.cgi?id=65964#c4 : > Do we know why we get an empty keycode with Chromium's DRT? It seems to be working for GTK+. The GTK port creates an honest to goodness GdkEvent keypress event http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/gtk/EventSender.cpp?rev=85516#L612 Chromium's DRT generates a WebKeyboardEvent, defined by the webkit api http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/EventSender.cpp?rev=85516#L566 and fills in the WebKeyboardEvent.windowsKeyCode field, but not the nativeKeyCode field http://trac.webkit.org/browser/trunk/WebKit/chromium/public/WebInputEvent.h?rev=50721#L153 The plugin is sent the nativeKeyCode value. That works in the real browser case, but not with the Chromium DRT. Is there a table somewhere that maps webkit::VKEY_CODE to native key codes? -- I don't think a table like this exists, but adding one for DRT would be fine. 456696 1 noel.gordon 2011-08-25 01:07:51 -0700 Will require two-sided patch, chromium side is http://crbug/66679 456697 2 noel.gordon 2011-08-25 01:08:51 -0700 Meant http://crbug.com/66679 456698 3 noel.gordon 2011-08-25 01:11:13 -0700 copy/paste-fu-day, it's http://crbug.com/94211 456703 4 105142 noel.gordon 2011-08-25 01:17:57 -0700 Created attachment 105142 patch 456912 5 105142 tony 2011-08-25 09:34:51 -0700 Comment on attachment 105142 patch View in context: https://bugs.webkit.org/attachment.cgi?id=105142&action=review > Tools/DumpRenderTree/chromium/EventSender.cpp:580 > + eventDown.nativeKeyCode = ui::NativeKeyCodeFromWindowsKeyCode(keyCode, needsShiftKeyModifier); We don't want to call code in ui directly. Instead, we want all methods to go through the webkit_support API. You can add a function to webkit_support.h that does this conversion. In general, this approach seems fine. 457358 6 105300 noel.gordon 2011-08-25 20:48:20 -0700 Created attachment 105300 Patch Right, move the helper into the webkit_support namespace. 458101 7 noel.gordon 2011-08-29 00:32:55 -0700 Chrome side part #1 done. http://src.chromium.org/viewvc/chrome?view=rev&revision=98599 458687 8 noel.gordon 2011-08-29 21:42:17 -0700 Chrome side part #2 done. http://src.chromium.org/viewvc/chrome?view=rev&revision=98771 458688 9 noel.gordon 2011-08-29 21:43:56 -0700 Wait for chrome rev 98771 to roll into webkit chromium DEPS. 459430 10 noel.gordon 2011-08-30 21:47:40 -0700 DEPS rolled rev 98771 in http://trac.webkit.org/changeset/94086 459432 11 105738 noel.gordon 2011-08-30 21:52:05 -0700 Created attachment 105738 Patch for landing 459725 12 105738 webkit.review.bot 2011-08-31 10:43:22 -0700 Comment on attachment 105738 Patch for landing Clearing flags on attachment: 105738 Committed r94203: <http://trac.webkit.org/changeset/94203> 459726 13 webkit.review.bot 2011-08-31 10:43:27 -0700 All reviewed patches have been landed. Closing bug. 496768 14 fsamuel 2011-11-05 19:24:05 -0700 (In reply to comment #13) > All reviewed patches have been landed. Closing bug. DumpRenderTree seems to be broken now. CXX(target) out/Debug/obj.target/DumpRenderTree/third_party/WebKit/Tools/DumpRenderTree/chromium/WebViewHost.o third_party/WebKit/Tools/DumpRenderTree/chromium/EventSender.cpp: In member function 'void EventSender::keyDown(const CppArgumentList&, CppVariant*)': third_party/WebKit/Tools/DumpRenderTree/chromium/EventSender.cpp:580: error: 'NativeKeyCodeForWindowsKeyCode' is not a member of 'webkit_support' make: *** [out/Debug/obj.target/DumpRenderTree/third_party/WebKit/Tools/DumpRenderTree/chromium/EventSender.o] Error 1 496781 15 noel.gordon 2011-11-05 22:41:03 -0700 http://src.chromium.org/viewvc/chrome?view=rev&revision=104013 496784 16 113778 noel.gordon 2011-11-05 23:19:32 -0700 Created attachment 113778 Patch 496787 17 noel.gordon 2011-11-06 00:38:03 -0700 webkit DEPS rolled past chromium r104013 4 weeks ago http://trac.webkit.org/changeset/96899/trunk/Source/WebKit/chromium/DEPS And you'd think we would have heard about Linux DumpRenderTree compilation failures 4 weeks ago. Checked Linux DumpRenderTree is compiling on queues.webkit.org as we speak http://queues.webkit.org/results/10338386 I don't see a problem, possible false alarm? 497316 18 tony 2011-11-07 11:19:17 -0800 (In reply to comment #14) > (In reply to comment #13) > > All reviewed patches have been landed. Closing bug. > > DumpRenderTree seems to be broken now. > > CXX(target) out/Debug/obj.target/DumpRenderTree/third_party/WebKit/Tools/DumpRenderTree/chromium/WebViewHost.o > third_party/WebKit/Tools/DumpRenderTree/chromium/EventSender.cpp: In member function 'void EventSender::keyDown(const CppArgumentList&, CppVariant*)': > third_party/WebKit/Tools/DumpRenderTree/chromium/EventSender.cpp:580: error: 'NativeKeyCodeForWindowsKeyCode' is not a member of 'webkit_support' > make: *** [out/Debug/obj.target/DumpRenderTree/third_party/WebKit/Tools/DumpRenderTree/chromium/EventSender.o] Error 1 Fady, which builder do you see this on? 513275 19 noel.gordon 2011-12-01 16:51:31 -0800 Fady worked it out in http://trac.webkit.org/changeset/101464 105142 2011-08-25 01:17:57 -0700 2011-08-25 20:48:20 -0700 patch keyboard-fix.git.diff text/plain 3337 noel.gordon ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0NGFiZDNiLi4yZjc5Zjg5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDgt MjUgIE5vZWwgR29yZG9uICA8bm9lbC5nb3Jkb25AZ21haWwuY29tPgorCisgICAgICAgIFtjaHJv bWl1bV0gRFJUIGxpbnV4IHNob3VsZCBwYXNzIG5hdGl2ZUtleUNvZGUgdG8gcGx1Z2lucworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY2NzkKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2No cm9taXVtLWxpbnV4L3BsdWdpbnMva2V5Ym9hcmQtZXZlbnRzLWV4cGVjdGVkLnR4dDoKKwogMjAx MS0wOC0yNCAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBnb29nbGUuY29tPgogCiAgICAgICAgIElt cGxlbWVudCBhbiBFdmVudCBjb25zdHJ1Y3Rvci4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL2Nocm9taXVtLWxpbnV4L3BsdWdpbnMva2V5Ym9hcmQtZXZlbnRzLWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtLWxpbnV4L3BsdWdpbnMva2V5Ym9hcmQt ZXZlbnRzLWV4cGVjdGVkLnR4dAppbmRleCA5ZDFlNzQ2Li44ODM0OTkwIDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS1saW51eC9wbHVnaW5zL2tleWJvYXJkLWV2ZW50 cy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0tbGludXgv cGx1Z2lucy9rZXlib2FyZC1ldmVudHMtZXhwZWN0ZWQudHh0CkBAIC0xLDExICsxLDExIEBACiBD T05TT0xFIE1FU1NBR0U6IGxpbmUgMTg6IFBMVUdJTjogZ2V0Rm9jdXNFdmVudAogQ09OU09MRSBN RVNTQUdFOiBsaW5lIDE4OiBQTFVHSU46IG1vdXNlRG93biBhdCAoMTIsIDEyKQogQ09OU09MRSBN RVNTQUdFOiBsaW5lIDE5OiBQTFVHSU46IG1vdXNlVXAgYXQgKDEyLCAxMikKLUNPTlNPTEUgTUVT U0FHRTogbGluZSAyMjogUExVR0lOOiBrZXlEb3duICcgJwotQ09OU09MRSBNRVNTQUdFOiBsaW5l IDIyOiBQTFVHSU46IGtleVVwICcgJwotQ09OU09MRSBNRVNTQUdFOiBsaW5lIDIzOiBQTFVHSU46 IGtleURvd24gJyAnCi1DT05TT0xFIE1FU1NBR0U6IGxpbmUgMjM6IFBMVUdJTjoga2V5VXAgJyAn Ci1DT05TT0xFIE1FU1NBR0U6IGxpbmUgMjQ6IFBMVUdJTjoga2V5RG93biAnICcKLUNPTlNPTEUg TUVTU0FHRTogbGluZSAyNDogUExVR0lOOiBrZXlVcCAnICcKK0NPTlNPTEUgTUVTU0FHRTogbGlu ZSAyMjogUExVR0lOOiBrZXlEb3duICdhJworQ09OU09MRSBNRVNTQUdFOiBsaW5lIDIyOiBQTFVH SU46IGtleVVwICdhJworQ09OU09MRSBNRVNTQUdFOiBsaW5lIDIzOiBQTFVHSU46IGtleURvd24g J2InCitDT05TT0xFIE1FU1NBR0U6IGxpbmUgMjM6IFBMVUdJTjoga2V5VXAgJ2InCitDT05TT0xF IE1FU1NBR0U6IGxpbmUgMjQ6IFBMVUdJTjoga2V5RG93biAnYycKK0NPTlNPTEUgTUVTU0FHRTog bGluZSAyNDogUExVR0lOOiBrZXlVcCAnYycKIAogVGhpcyB0ZXN0IGNoZWNrcyBpZiBhIHBsdWct aW4gY2FuIHJlY2VpdmUga2V5Ym9hcmQgZXZlbnRzIHNlbnQgZnJvbSBldmVudFNlbmRlci4gVGhp cyBpcyBhIHRlc3QgZm9yIEJ1ZyAzNDkzNi4KZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyNjViYWU4Li44MDkyZTFhIDEwMDY0NAotLS0gYS9Ub29s cy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEt MDgtMjUgIE5vZWwgR29yZG9uICA8bm9lbC5nb3Jkb25AZ21haWwuY29tPgorCisgICAgICAgIFtj aHJvbWl1bV0gRFJUIGxpbnV4IHNob3VsZCBwYXNzIG5hdGl2ZUtleUNvZGUgdG8gcGx1Z2lucwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY2NzkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIER1bXBSZW5k ZXJUcmVlL2Nocm9taXVtL0V2ZW50U2VuZGVyLmNwcDoKKyAgICAgICAgKEV2ZW50U2VuZGVyOjpr ZXlEb3duKTogIENhbGwgYSBDaHJvbWl1bSBMaW51eCBHVEsgaGVscGVyIHJvdXRpbmUgdGhhdCBy ZXR1cm5zIHRoZQorICAgICAgICAoc2ltdWxhdGVkKSBuYXRpdmVLZXlDb2RlIGZvciB0aGUgZ2l2 ZW4gaW5wdXQga2V5Ym9hcmQgY29kZS4KKwogMjAxMS0wOC0yNCAgQWRhbSBCYXJ0aCAgPGFiYXJ0 aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFRoZSB1c2VyIGNhbid0IGNsb3NlIHRoZSBkZXRhaWxz IHZpZXcgaW4gZ2FyZGVuLW8tbWF0aWMKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVl L2Nocm9taXVtL0V2ZW50U2VuZGVyLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVt L0V2ZW50U2VuZGVyLmNwcAppbmRleCA2ZGFmNjE2Li4xYmQ1NDg1IDEwMDY0NAotLS0gYS9Ub29s cy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9FdmVudFNlbmRlci5jcHAKKysrIGIvVG9vbHMvRHVt cFJlbmRlclRyZWUvY2hyb21pdW0vRXZlbnRTZW5kZXIuY3BwCkBAIC01NzQsMTAgKzU3NCwxNyBA QCB2b2lkIEV2ZW50U2VuZGVyOjprZXlEb3duKGNvbnN0IENwcEFyZ3VtZW50TGlzdCYgYXJndW1l bnRzLCBDcHBWYXJpYW50KiByZXN1bHQpCiAgICAgZXZlbnREb3duLnR5cGUgPSBXZWJJbnB1dEV2 ZW50OjpSYXdLZXlEb3duOwogICAgIGV2ZW50RG93bi5tb2RpZmllcnMgPSAwOwogICAgIGV2ZW50 RG93bi53aW5kb3dzS2V5Q29kZSA9IGNvZGU7CisKKyNpZiBPUyhMSU5VWCkKKyAgICBjb25zdCB1 aTo6S2V5Ym9hcmRDb2RlIGtleUNvZGUgPSBzdGF0aWNfY2FzdDx1aTo6S2V5Ym9hcmRDb2RlPihj b2RlKTsKKyAgICBldmVudERvd24ubmF0aXZlS2V5Q29kZSA9IHVpOjpOYXRpdmVLZXlDb2RlRnJv bVdpbmRvd3NLZXlDb2RlKGtleUNvZGUsIG5lZWRzU2hpZnRLZXlNb2RpZmllcik7CisjZW5kaWYK KwogICAgIGlmIChnZW5lcmF0ZUNoYXIpIHsKICAgICAgICAgZXZlbnREb3duLnRleHRbMF0gPSB0 ZXh0OwogICAgICAgICBldmVudERvd24udW5tb2RpZmllZFRleHRbMF0gPSB0ZXh0OwogICAgIH0K KwogICAgIGV2ZW50RG93bi5zZXRLZXlJZGVudGlmaWVyRnJvbVdpbmRvd3NLZXlDb2RlKCk7CiAK ICAgICBpZiAoYXJndW1lbnRzLnNpemUoKSA+PSAyICYmIChhcmd1bWVudHNbMV0uaXNPYmplY3Qo KSB8fCBhcmd1bWVudHNbMV0uaXNTdHJpbmcoKSkpCg== 105300 2011-08-25 20:48:20 -0700 2011-08-30 21:52:05 -0700 Patch keyboard-fix.git.diff text/plain 3115 noel.gordon ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0NGFiZDNiLi4yZjc5Zjg5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDgt MjUgIE5vZWwgR29yZG9uICA8bm9lbC5nb3Jkb25AZ21haWwuY29tPgorCisgICAgICAgIFtjaHJv bWl1bV0gRFJUIGxpbnV4IHNob3VsZCBwYXNzIG5hdGl2ZUtleUNvZGUgdG8gcGx1Z2lucworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY2NzkKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2No cm9taXVtLWxpbnV4L3BsdWdpbnMva2V5Ym9hcmQtZXZlbnRzLWV4cGVjdGVkLnR4dDoKKwogMjAx MS0wOC0yNCAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBnb29nbGUuY29tPgogCiAgICAgICAgIElt cGxlbWVudCBhbiBFdmVudCBjb25zdHJ1Y3Rvci4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL2Nocm9taXVtLWxpbnV4L3BsdWdpbnMva2V5Ym9hcmQtZXZlbnRzLWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtLWxpbnV4L3BsdWdpbnMva2V5Ym9hcmQt ZXZlbnRzLWV4cGVjdGVkLnR4dAppbmRleCA5ZDFlNzQ2Li44ODM0OTkwIDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS1saW51eC9wbHVnaW5zL2tleWJvYXJkLWV2ZW50 cy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0tbGludXgv cGx1Z2lucy9rZXlib2FyZC1ldmVudHMtZXhwZWN0ZWQudHh0CkBAIC0xLDExICsxLDExIEBACiBD T05TT0xFIE1FU1NBR0U6IGxpbmUgMTg6IFBMVUdJTjogZ2V0Rm9jdXNFdmVudAogQ09OU09MRSBN RVNTQUdFOiBsaW5lIDE4OiBQTFVHSU46IG1vdXNlRG93biBhdCAoMTIsIDEyKQogQ09OU09MRSBN RVNTQUdFOiBsaW5lIDE5OiBQTFVHSU46IG1vdXNlVXAgYXQgKDEyLCAxMikKLUNPTlNPTEUgTUVT U0FHRTogbGluZSAyMjogUExVR0lOOiBrZXlEb3duICcgJwotQ09OU09MRSBNRVNTQUdFOiBsaW5l IDIyOiBQTFVHSU46IGtleVVwICcgJwotQ09OU09MRSBNRVNTQUdFOiBsaW5lIDIzOiBQTFVHSU46 IGtleURvd24gJyAnCi1DT05TT0xFIE1FU1NBR0U6IGxpbmUgMjM6IFBMVUdJTjoga2V5VXAgJyAn Ci1DT05TT0xFIE1FU1NBR0U6IGxpbmUgMjQ6IFBMVUdJTjoga2V5RG93biAnICcKLUNPTlNPTEUg TUVTU0FHRTogbGluZSAyNDogUExVR0lOOiBrZXlVcCAnICcKK0NPTlNPTEUgTUVTU0FHRTogbGlu ZSAyMjogUExVR0lOOiBrZXlEb3duICdhJworQ09OU09MRSBNRVNTQUdFOiBsaW5lIDIyOiBQTFVH SU46IGtleVVwICdhJworQ09OU09MRSBNRVNTQUdFOiBsaW5lIDIzOiBQTFVHSU46IGtleURvd24g J2InCitDT05TT0xFIE1FU1NBR0U6IGxpbmUgMjM6IFBMVUdJTjoga2V5VXAgJ2InCitDT05TT0xF IE1FU1NBR0U6IGxpbmUgMjQ6IFBMVUdJTjoga2V5RG93biAnYycKK0NPTlNPTEUgTUVTU0FHRTog bGluZSAyNDogUExVR0lOOiBrZXlVcCAnYycKIAogVGhpcyB0ZXN0IGNoZWNrcyBpZiBhIHBsdWct aW4gY2FuIHJlY2VpdmUga2V5Ym9hcmQgZXZlbnRzIHNlbnQgZnJvbSBldmVudFNlbmRlci4gVGhp cyBpcyBhIHRlc3QgZm9yIEJ1ZyAzNDkzNi4KZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyNjViYWU4Li44MDkyZTFhIDEwMDY0NAotLS0gYS9Ub29s cy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEt MDgtMjUgIE5vZWwgR29yZG9uICA8bm9lbC5nb3Jkb25AZ21haWwuY29tPgorCisgICAgICAgIFtj aHJvbWl1bV0gRFJUIGxpbnV4IHNob3VsZCBwYXNzIG5hdGl2ZUtleUNvZGUgdG8gcGx1Z2lucwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY2NzkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIER1bXBSZW5k ZXJUcmVlL2Nocm9taXVtL0V2ZW50U2VuZGVyLmNwcDoKKyAgICAgICAgKEV2ZW50U2VuZGVyOjpr ZXlEb3duKTogIENhbGwgYSBDaHJvbWl1bSBMaW51eCBHVEsgaGVscGVyIHJvdXRpbmUgdGhhdCBy ZXR1cm5zIHRoZQorICAgICAgICAoc2ltdWxhdGVkKSBuYXRpdmVLZXlDb2RlIGZvciB0aGUgZ2l2 ZW4gaW5wdXQga2V5Ym9hcmQgY29kZS4KKwogMjAxMS0wOC0yNCAgQWRhbSBCYXJ0aCAgPGFiYXJ0 aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFRoZSB1c2VyIGNhbid0IGNsb3NlIHRoZSBkZXRhaWxz IHZpZXcgaW4gZ2FyZGVuLW8tbWF0aWMKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVl L2Nocm9taXVtL0V2ZW50U2VuZGVyLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVt L0V2ZW50U2VuZGVyLmNwcAppbmRleCA2ZGFmNjE2Li43ZDVlZDliIDEwMDY0NAotLS0gYS9Ub29s cy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9FdmVudFNlbmRlci5jcHAKKysrIGIvVG9vbHMvRHVt cFJlbmRlclRyZWUvY2hyb21pdW0vRXZlbnRTZW5kZXIuY3BwCkBAIC01NzQsNiArNTc0LDEwIEBA IHZvaWQgRXZlbnRTZW5kZXI6OmtleURvd24oY29uc3QgQ3BwQXJndW1lbnRMaXN0JiBhcmd1bWVu dHMsIENwcFZhcmlhbnQqIHJlc3VsdCkKICAgICBldmVudERvd24udHlwZSA9IFdlYklucHV0RXZl bnQ6OlJhd0tleURvd247CiAgICAgZXZlbnREb3duLm1vZGlmaWVycyA9IDA7CiAgICAgZXZlbnRE b3duLndpbmRvd3NLZXlDb2RlID0gY29kZTsKKyNpZiBPUyhMSU5VWCkKKyAgICBldmVudERvd24u bmF0aXZlS2V5Q29kZSA9IHdlYmtpdF9zdXBwb3J0OjpOYXRpdmVLZXlDb2RlRm9yV2luZG93c0tl eUNvZGUoY29kZSwgbmVlZHNTaGlmdEtleU1vZGlmaWVyKTsKKyNlbmRpZgorCiAgICAgaWYgKGdl bmVyYXRlQ2hhcikgewogICAgICAgICBldmVudERvd24udGV4dFswXSA9IHRleHQ7CiAgICAgICAg IGV2ZW50RG93bi51bm1vZGlmaWVkVGV4dFswXSA9IHRleHQ7Cg== 105738 2011-08-30 21:52:05 -0700 2011-11-05 23:19:22 -0700 Patch for landing keyboard.git.diff text/plain 3105 noel.gordon ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzNGZhMWRjLi42NWM2MDAyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDgt MzAgIE5vZWwgR29yZG9uICA8bm9lbC5nb3Jkb25AZ21haWwuY29tPgorCisgICAgICAgIFtjaHJv bWl1bV0gRFJUIGxpbnV4IHNob3VsZCBwYXNzIG5hdGl2ZUtleUNvZGUgdG8gcGx1Z2lucworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY2NzkKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2No cm9taXVtLWxpbnV4L3BsdWdpbnMva2V5Ym9hcmQtZXZlbnRzLWV4cGVjdGVkLnR4dDoKKwogMjAx MS0wOC0zMCAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIEFkZCBjb25z dHJ1Y3RvciBmb3IgQ3VzdG9tRXZlbnQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3Jt L2Nocm9taXVtLWxpbnV4L3BsdWdpbnMva2V5Ym9hcmQtZXZlbnRzLWV4cGVjdGVkLnR4dCBiL0xh eW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtLWxpbnV4L3BsdWdpbnMva2V5Ym9hcmQtZXZlbnRz LWV4cGVjdGVkLnR4dAppbmRleCA5ZDFlNzQ2Li44ODM0OTkwIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS1saW51eC9wbHVnaW5zL2tleWJvYXJkLWV2ZW50cy1leHBl Y3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0tbGludXgvcGx1Z2lu cy9rZXlib2FyZC1ldmVudHMtZXhwZWN0ZWQudHh0CkBAIC0xLDExICsxLDExIEBACiBDT05TT0xF IE1FU1NBR0U6IGxpbmUgMTg6IFBMVUdJTjogZ2V0Rm9jdXNFdmVudAogQ09OU09MRSBNRVNTQUdF OiBsaW5lIDE4OiBQTFVHSU46IG1vdXNlRG93biBhdCAoMTIsIDEyKQogQ09OU09MRSBNRVNTQUdF OiBsaW5lIDE5OiBQTFVHSU46IG1vdXNlVXAgYXQgKDEyLCAxMikKLUNPTlNPTEUgTUVTU0FHRTog bGluZSAyMjogUExVR0lOOiBrZXlEb3duICcgJwotQ09OU09MRSBNRVNTQUdFOiBsaW5lIDIyOiBQ TFVHSU46IGtleVVwICcgJwotQ09OU09MRSBNRVNTQUdFOiBsaW5lIDIzOiBQTFVHSU46IGtleURv d24gJyAnCi1DT05TT0xFIE1FU1NBR0U6IGxpbmUgMjM6IFBMVUdJTjoga2V5VXAgJyAnCi1DT05T T0xFIE1FU1NBR0U6IGxpbmUgMjQ6IFBMVUdJTjoga2V5RG93biAnICcKLUNPTlNPTEUgTUVTU0FH RTogbGluZSAyNDogUExVR0lOOiBrZXlVcCAnICcKK0NPTlNPTEUgTUVTU0FHRTogbGluZSAyMjog UExVR0lOOiBrZXlEb3duICdhJworQ09OU09MRSBNRVNTQUdFOiBsaW5lIDIyOiBQTFVHSU46IGtl eVVwICdhJworQ09OU09MRSBNRVNTQUdFOiBsaW5lIDIzOiBQTFVHSU46IGtleURvd24gJ2InCitD T05TT0xFIE1FU1NBR0U6IGxpbmUgMjM6IFBMVUdJTjoga2V5VXAgJ2InCitDT05TT0xFIE1FU1NB R0U6IGxpbmUgMjQ6IFBMVUdJTjoga2V5RG93biAnYycKK0NPTlNPTEUgTUVTU0FHRTogbGluZSAy NDogUExVR0lOOiBrZXlVcCAnYycKIAogVGhpcyB0ZXN0IGNoZWNrcyBpZiBhIHBsdWctaW4gY2Fu IHJlY2VpdmUga2V5Ym9hcmQgZXZlbnRzIHNlbnQgZnJvbSBldmVudFNlbmRlci4gVGhpcyBpcyBh IHRlc3QgZm9yIEJ1ZyAzNDkzNi4KZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xz L0NoYW5nZUxvZwppbmRleCBkMzJhY2NkLi4wOTNjMjAxIDEwMDY0NAotLS0gYS9Ub29scy9DaGFu Z2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDgtMzAg IE5vZWwgR29yZG9uICA8bm9lbC5nb3Jkb25AZ21haWwuY29tPgorCisgICAgICAgIFtjaHJvbWl1 bV0gRFJUIGxpbnV4IHNob3VsZCBwYXNzIG5hdGl2ZUtleUNvZGUgdG8gcGx1Z2lucworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY2NzkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVl L2Nocm9taXVtL0V2ZW50U2VuZGVyLmNwcDoKKyAgICAgICAgKEV2ZW50U2VuZGVyOjprZXlEb3du KTogIENhbGwgYSBDaHJvbWl1bSBMaW51eCBHVEsgaGVscGVyIHJvdXRpbmUgdGhhdCByZXR1cm5z IHRoZQorICAgICAgICAoc2ltdWxhdGVkKSBuYXRpdmVLZXlDb2RlIGZvciB0aGUgZ2l2ZW4gaW5w dXQga2V5Ym9hcmQgY29kZS4KKwogMjAxMS0wOC0zMCAgVGFrYXNoaSBUb3lvc2hpbWEgIDx0b3lv c2hpbUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1dlYlNvY2tldF0gdXBkYXRlIHB5d2Vic29j a2V0IHRvIDAuNmI1LgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0v RXZlbnRTZW5kZXIuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vRXZlbnRTZW5k ZXIuY3BwCmluZGV4IDZkYWY2MTYuLjdkNWVkOWIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5k ZXJUcmVlL2Nocm9taXVtL0V2ZW50U2VuZGVyLmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJl ZS9jaHJvbWl1bS9FdmVudFNlbmRlci5jcHAKQEAgLTU3NCw2ICs1NzQsMTAgQEAgdm9pZCBFdmVu dFNlbmRlcjo6a2V5RG93bihjb25zdCBDcHBBcmd1bWVudExpc3QmIGFyZ3VtZW50cywgQ3BwVmFy aWFudCogcmVzdWx0KQogICAgIGV2ZW50RG93bi50eXBlID0gV2ViSW5wdXRFdmVudDo6UmF3S2V5 RG93bjsKICAgICBldmVudERvd24ubW9kaWZpZXJzID0gMDsKICAgICBldmVudERvd24ud2luZG93 c0tleUNvZGUgPSBjb2RlOworI2lmIE9TKExJTlVYKQorICAgIGV2ZW50RG93bi5uYXRpdmVLZXlD b2RlID0gd2Via2l0X3N1cHBvcnQ6Ok5hdGl2ZUtleUNvZGVGb3JXaW5kb3dzS2V5Q29kZShjb2Rl LCBuZWVkc1NoaWZ0S2V5TW9kaWZpZXIpOworI2VuZGlmCisKICAgICBpZiAoZ2VuZXJhdGVDaGFy KSB7CiAgICAgICAgIGV2ZW50RG93bi50ZXh0WzBdID0gdGV4dDsKICAgICAgICAgZXZlbnREb3du LnVubW9kaWZpZWRUZXh0WzBdID0gdGV4dDsK 113778 2011-11-05 23:19:32 -0700 2011-11-06 00:51:17 -0700 Patch bug-66679-20111106171930.patch text/plain 3659 noel.gordon U3VidmVyc2lvbiBSZXZpc2lvbjogOTkzNTEKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5YTBjMThiYzM1NmJhZjY0ZjMyNmY5NmQ3ZDU0ZDkwOTFi ZGM5ZTA5Li42OTU0OWI3Y2FlZDYyNzdkMWE3ZWVmYTUxODYxNjNjMTYwNGMwNDMzIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMTEtMDUgIE5vZWwgR29yZG9uICA8bm9lbC5nb3Jkb25AZ21haWwuY29tPgorCisg ICAgICAgIFtjaHJvbWl1bV0gRFJUIGxpbnV4IHNob3VsZCBwYXNzIG5hdGl2ZUtleUNvZGUgdG8g cGx1Z2lucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NjY2NzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBD b2RlIGNoYW5nZSBpbiBjaHJvbWl1bSBBdXJhIGJ1aWxkIGJyb2tlIGNvbXBpbGF0aW9uIG9mIGNo cm9taXVtIER1bXBSZW5kZXJUcmVlCisgICAgICAgIG9uIHRoZSBMSU5VWCBwb3J0LiBEaXNhYmxl IHRoZSBlZmZlY3RlZCBjb2RlIGluIER1bXBSZW5kZXJUcmVlIHdoaWxlIHdlIHNvcnQgaXQKKyAg ICAgICAgb3V0LCBhZGp1c3QgdGhlIHBsdWdpbiB0ZXN0IGV4cGVjdGF0aW9uIHRvIG1hdGNoLgor CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vRXZlbnRTZW5kZXIuY3BwOgorICAg ICAgICAoRXZlbnRTZW5kZXI6OmtleURvd24pOiBkaXNhYmxlIHNlbmRpbmcgbmF0aXZlS2V5Q29k ZSBvbiBPUyhMSU5VWCkKKwogMjAxMS0xMS0wNCAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5v cmc+CiAKICAgICAgICAgVXBncmFkZSB0byB0aGUgbGF0ZXN0IE1lY2hhbml6ZQpkaWZmIC0tZ2l0 IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vRXZlbnRTZW5kZXIuY3BwIGIvVG9vbHMv RHVtcFJlbmRlclRyZWUvY2hyb21pdW0vRXZlbnRTZW5kZXIuY3BwCmluZGV4IGMxYjhjMTY5MjFl MzU1NTY3ZmM3YjY1N2M4OTIyYTUxOGE0YTUyZDAuLjBkNDg0MWJjMmUwYmIzYjA3OGI0NDYwY2Nk MTZmYTZkMzQ0ODAyM2EgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVt L0V2ZW50U2VuZGVyLmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9FdmVu dFNlbmRlci5jcHAKQEAgLTU3Nyw3ICs1NzcsOSBAQCB2b2lkIEV2ZW50U2VuZGVyOjprZXlEb3du KGNvbnN0IENwcEFyZ3VtZW50TGlzdCYgYXJndW1lbnRzLCBDcHBWYXJpYW50KiByZXN1bHQpCiAg ICAgZXZlbnREb3duLm1vZGlmaWVycyA9IDA7CiAgICAgZXZlbnREb3duLndpbmRvd3NLZXlDb2Rl ID0gY29kZTsKICNpZiBPUyhMSU5VWCkKLSAgICBldmVudERvd24ubmF0aXZlS2V5Q29kZSA9IHdl YmtpdF9zdXBwb3J0OjpOYXRpdmVLZXlDb2RlRm9yV2luZG93c0tleUNvZGUoY29kZSwgbmVlZHNT aGlmdEtleU1vZGlmaWVyKTsKKyAgICAvLyBCcm9rZW4gYnkgaHR0cDovL3NyYy5jaHJvbWl1bS5v cmcvdmlld3ZjL2Nocm9tZT92aWV3PXJldiZyZXZpc2lvbj0xMDQwMTMgQXVyYQorICAgIC8vIGJ1 aWxkZXIsIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjY3OQorICAg IC8vIGV2ZW50RG93bi5uYXRpdmVLZXlDb2RlID0gd2Via2l0X3N1cHBvcnQ6Ok5hdGl2ZUtleUNv ZGVGb3JXaW5kb3dzS2V5Q29kZShjb2RlLCBuZWVkc1NoaWZ0S2V5TW9kaWZpZXIpOwogI2VuZGlm CiAKICAgICBpZiAoZ2VuZXJhdGVDaGFyKSB7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZjlkZjUyZGU5ZDdmMjNlNzI4MDFh NDI0ZTVkNGRlZDBjYzI4NWZiNC4uM2YzODc1YjA0MTk3MTRjMTg4NmY2MTZhMTQwOTJkZmE1NGIy NGFjOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDExLTExLTA1ICBOb2VsIEdvcmRvbiAgPG5v ZWwuZ29yZG9uQGdtYWlsLmNvbT4KKworICAgICAgICBbY2hyb21pdW1dIERSVCBsaW51eCBzaG91 bGQgcGFzcyBuYXRpdmVLZXlDb2RlIHRvIHBsdWdpbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2Njc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS1saW51eC9wbHVnaW5z L2tleWJvYXJkLWV2ZW50cy1leHBlY3RlZC50eHQ6CisKIDIwMTEtMTEtMDQgIFRvbnkgQ2hhbmcg IDx0b255QGNocm9taXVtLm9yZz4KIAogICAgICAgICBVcGRhdGUgYSB0aW1pbmcgb3V0IGdwdSB0 ZXN0LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0tbGludXgvcGx1 Z2lucy9rZXlib2FyZC1ldmVudHMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v Y2hyb21pdW0tbGludXgvcGx1Z2lucy9rZXlib2FyZC1ldmVudHMtZXhwZWN0ZWQudHh0CmluZGV4 IDg4MzQ5OTBiMjZhY2UxNDg3MDM1NzQ0ZGZhMzFmMzE5ZGRkYjcxNjMuLjlkMWU3NDYwYjliYzUy YTA3ZmM4NTk3NWE5MmZlZmMzMTExMDA2NzkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRm b3JtL2Nocm9taXVtLWxpbnV4L3BsdWdpbnMva2V5Ym9hcmQtZXZlbnRzLWV4cGVjdGVkLnR4dAor KysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS1saW51eC9wbHVnaW5zL2tleWJvYXJk LWV2ZW50cy1leHBlY3RlZC50eHQKQEAgLTEsMTEgKzEsMTEgQEAKIENPTlNPTEUgTUVTU0FHRTog bGluZSAxODogUExVR0lOOiBnZXRGb2N1c0V2ZW50CiBDT05TT0xFIE1FU1NBR0U6IGxpbmUgMTg6 IFBMVUdJTjogbW91c2VEb3duIGF0ICgxMiwgMTIpCiBDT05TT0xFIE1FU1NBR0U6IGxpbmUgMTk6 IFBMVUdJTjogbW91c2VVcCBhdCAoMTIsIDEyKQotQ09OU09MRSBNRVNTQUdFOiBsaW5lIDIyOiBQ TFVHSU46IGtleURvd24gJ2EnCi1DT05TT0xFIE1FU1NBR0U6IGxpbmUgMjI6IFBMVUdJTjoga2V5 VXAgJ2EnCi1DT05TT0xFIE1FU1NBR0U6IGxpbmUgMjM6IFBMVUdJTjoga2V5RG93biAnYicKLUNP TlNPTEUgTUVTU0FHRTogbGluZSAyMzogUExVR0lOOiBrZXlVcCAnYicKLUNPTlNPTEUgTUVTU0FH RTogbGluZSAyNDogUExVR0lOOiBrZXlEb3duICdjJwotQ09OU09MRSBNRVNTQUdFOiBsaW5lIDI0 OiBQTFVHSU46IGtleVVwICdjJworQ09OU09MRSBNRVNTQUdFOiBsaW5lIDIyOiBQTFVHSU46IGtl eURvd24gJyAnCitDT05TT0xFIE1FU1NBR0U6IGxpbmUgMjI6IFBMVUdJTjoga2V5VXAgJyAnCitD T05TT0xFIE1FU1NBR0U6IGxpbmUgMjM6IFBMVUdJTjoga2V5RG93biAnICcKK0NPTlNPTEUgTUVT U0FHRTogbGluZSAyMzogUExVR0lOOiBrZXlVcCAnICcKK0NPTlNPTEUgTUVTU0FHRTogbGluZSAy NDogUExVR0lOOiBrZXlEb3duICcgJworQ09OU09MRSBNRVNTQUdFOiBsaW5lIDI0OiBQTFVHSU46 IGtleVVwICcgJwogCiBUaGlzIHRlc3QgY2hlY2tzIGlmIGEgcGx1Zy1pbiBjYW4gcmVjZWl2ZSBr ZXlib2FyZCBldmVudHMgc2VudCBmcm9tIGV2ZW50U2VuZGVyLiBUaGlzIGlzIGEgdGVzdCBmb3Ig QnVnIDM0OTM2Lgo=