66673 2011-08-22 07:14:09 -0700 [chromium] Fonts returned by FontCache::getFontDataForCharacters() are never released 2011-09-01 11:40:47 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66774 1 tonyg tonyg ggaren jamesr mnaganov msaboff satish webkit.review.bot oldest_to_newest 454580 0 tonyg 2011-08-22 07:14:09 -0700 [chromium] Fonts returned by FontCache::getFontDataForCharacters() are never released 454583 1 104675 tonyg 2011-08-22 07:20:11 -0700 Created attachment 104675 Patch 455167 2 104675 jamesr 2011-08-22 20:09:13 -0700 Comment on attachment 104675 Patch R=me. What a repetitive API (repetitive API) 455183 3 104675 webkit.review.bot 2011-08-22 21:09:22 -0700 Comment on attachment 104675 Patch Clearing flags on attachment: 104675 Committed r93579: <http://trac.webkit.org/changeset/93579> 455184 4 webkit.review.bot 2011-08-22 21:09:27 -0700 All reviewed patches have been landed. Closing bug. 455376 5 tonyg 2011-08-23 06:35:30 -0700 When this rolled into chromium it triggered an "ASSERTION FAILED: m_purgePreventCount" in the nacl tests: http://build.chromium.org/p/chromium/builders/Linux%20Tests%20(dbg)(2)/builds/11797/steps/nacl_integration/logs/stdio This likely means that we are missing a FontCachePurgePreventer in some nacl specific code. I'll investigate and roll forward w/ the fix. 457061 6 jamesr 2011-08-25 12:27:31 -0700 We saw an ASSERT() fail on the mac bot today, think it's related: The assertion is: ASSERTION FAILED: fontCache()->generation() == m_generation build log here: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.6%20(CG)(dbg)/builds/202/steps/webkit_tests/logs/stdio test was fast/css-generated-content/table-before-after-child-add.html. 457507 7 tonyg 2011-08-26 04:13:34 -0700 > We saw an ASSERT() fail on the mac bot today, think it's related: It isn't directly related to this patch as FontCacheLinux isn't used on the mac and my original patch was rolled back almost immediately due to a nacl test failure. I've broken this issue off into https://bugs.webkit.org/show_bug.cgi?id=67031 along with some additional details. I have a patch coming shortly which rolls this forward again along with a FontCachePurgePreventer to fix the nacl test. 457509 8 105345 tonyg 2011-08-26 04:31:20 -0700 Created attachment 105345 Patch 459727 9 tonyg 2011-08-31 10:45:56 -0700 James, are you still willing to review the follow-up or should I look around for someone else? 460586 10 105345 jamesr 2011-09-01 10:38:17 -0700 Comment on attachment 105345 Patch R=me sorry for the delay, was out on vacation for a week 460641 11 105345 webkit.review.bot 2011-09-01 11:40:43 -0700 Comment on attachment 105345 Patch Clearing flags on attachment: 105345 Committed r94323: <http://trac.webkit.org/changeset/94323> 460642 12 webkit.review.bot 2011-09-01 11:40:47 -0700 All reviewed patches have been landed. Closing bug. 104675 2011-08-22 07:20:11 -0700 2011-08-26 04:31:15 -0700 Patch bug-66673-20110822152009.patch text/plain 1903 tonyg U3VidmVyc2lvbiBSZXZpc2lvbjogOTM1MDYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2ODdkZDBmNDk2MzRlMmMz MjU2N2MzNGJjZDI1YjgwYTQ4NGYwNWY4Li4yYThlZDNkNjA5Y2UzOGZhNzlhNTgwMTRjNDdjYTNi YzcwNWE0MDY3IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDgtMjIgIFRvbnkg R2VudGlsY29yZSAgPHRvbnlnQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIEZv bnRzIHJldHVybmVkIGJ5IEZvbnRDYWNoZTo6Z2V0Rm9udERhdGFGb3JDaGFyYWN0ZXJzKCkgYXJl IG5ldmVyIHJlbGVhc2VkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD02NjY3MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoaXMgd2FzIGZpeGVkIGZvciBvdGhlciBwb3J0cyBpbiBodHRwOi8vdHJhYy53ZWJr aXQub3JnL2NoYW5nZXNldC84ODI2MC4KKyAgICAgICAgSG93ZXZlciwgaXQgd2FzIG1pc3NlZCBp biBGb250Q2FjaGVMaW51eCBsaWtlbHkgZHVlIHRvIHNpbWlsYXIgcGFyYW0gaW4gdGhlIG5lc3Rl ZCBjYWxsIHRvIGdldENhY2hlZEZvbnRQbGF0Zm9ybURhdGEoKS4KKworICAgICAgICBObyBuZXcg dGVzdHMgYmVjYXVzZSBubyBkaXJlY3RseSBvYnNlcnZhYmxlIGNoYW5nZSBpbiBiZWhhdmlvci4K KworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRDYWNoZUxpbnV4LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkZvbnRDYWNoZTo6Z2V0Rm9udERhdGFGb3JDaGFyYWN0ZXJz KToKKwogMjAxMS0wOC0yMiAgS2Vpc2hpIEhhdHRvcmkgIDxrZWlzaGlAd2Via2l0Lm9yZz4KIAog ICAgICAgICBDaHJvbWU6OnNldFNlbGVjdGVkQ29sb3JJbkNvbG9yQ2hvb3NlciBzaG91bGRuJ3Qg YmUgY2FsbGVkIHdoZW4gY29sb3IgY2hvb3NlciBzZXRzIGEgbmV3IGNvbG9yCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Gb250Q2FjaGVMaW51 eC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Gb250Q2Fj aGVMaW51eC5jcHAKaW5kZXggMzUwZTdmNDJlMWFkYzc5YTI4ODkzMTMxOThkODE1NTU3YzVhMzNl Yi4uZjhjMjc2NGZhNDYyZTQzMGIzZjYwNzU3ZTJkMzNiY2MwMDUzODkyZCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udENhY2hlTGludXgu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRD YWNoZUxpbnV4LmNwcApAQCAtNjQsNyArNjQsNyBAQCBjb25zdCBTaW1wbGVGb250RGF0YSogRm9u dENhY2hlOjpnZXRGb250RGF0YUZvckNoYXJhY3RlcnMoY29uc3QgRm9udCYgZm9udCwKICAgICAg ICAgcmV0dXJuIDA7CiAKICAgICBBdG9taWNTdHJpbmcgYXRvbWljRmFtaWx5KGZhbWlseSk7Ci0g ICAgcmV0dXJuIGdldENhY2hlZEZvbnREYXRhKGdldENhY2hlZEZvbnRQbGF0Zm9ybURhdGEoZm9u dC5mb250RGVzY3JpcHRpb24oKSwgYXRvbWljRmFtaWx5LCBEb05vdFJldGFpbikpOworICAgIHJl dHVybiBnZXRDYWNoZWRGb250RGF0YShnZXRDYWNoZWRGb250UGxhdGZvcm1EYXRhKGZvbnQuZm9u dERlc2NyaXB0aW9uKCksIGF0b21pY0ZhbWlseSwgRG9Ob3RSZXRhaW4pLCBEb05vdFJldGFpbik7 CiB9CiAKIFNpbXBsZUZvbnREYXRhKiBGb250Q2FjaGU6OmdldFNpbWlsYXJGb250UGxhdGZvcm1E YXRhKGNvbnN0IEZvbnQmIGZvbnQpCg== 105345 2011-08-26 04:31:20 -0700 2011-09-01 11:40:43 -0700 Patch bug-66673-20110826123119.patch text/plain 2787 tonyg U3VidmVyc2lvbiBSZXZpc2lvbjogOTM4NjUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmYTc3MmU5ZWRkZjM1Y2Rl MDkzMjcyMjAyMGI3MzA1NGRhMmJjMDJmLi4xMGU2YWQ5ZDFlN2Q1NzRhNmJiZDU0MzAwMjk1ODlj ODRkMGU4MDcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDgtMjIgIFRvbnkg R2VudGlsY29yZSAgPHRvbnlnQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIEZv bnRzIHJldHVybmVkIGJ5IEZvbnRDYWNoZTo6Z2V0Rm9udERhdGFGb3JDaGFyYWN0ZXJzKCkgYXJl IG5ldmVyIHJlbGVhc2VkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD02NjY3MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoaXMgd2FzIGZpeGVkIGZvciBvdGhlciBwb3J0cyBpbiBodHRwOi8vdHJhYy53ZWJr aXQub3JnL2NoYW5nZXNldC84ODI2MC4KKyAgICAgICAgSG93ZXZlciwgaXQgd2FzIG1pc3NlZCBp biBGb250Q2FjaGVMaW51eCBsaWtlbHkgZHVlIHRvIHNpbWlsYXIgcGFyYW0gaW4gdGhlIG5lc3Rl ZCBjYWxsIHRvIGdldENhY2hlZEZvbnRQbGF0Zm9ybURhdGEoKS4KKworICAgICAgICBObyBuZXcg dGVzdHMgYmVjYXVzZSBubyBkaXJlY3RseSBvYnNlcnZhYmxlIGNoYW5nZSBpbiBiZWhhdmlvci4K KworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRDYWNoZUxpbnV4LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkZvbnRDYWNoZTo6Z2V0Rm9udERhdGFGb3JDaGFyYWN0ZXJz KToKKwogMjAxMS0wOC0yNiAgTmlrb2xhcyBaaW1tZXJtYW5uICA8bnppbW1lcm1hbm5AcmltLmNv bT4KIAogICAgICAgICBbUXRdIGh0dHAvdGVzdHMvbWlzYy9vYmplY3QtZW1iZWRkaW5nLXN2Zy1k ZWxheWVkLXNpemUtbmVnb3RpYXRpb24tMi5odG0gZmFpbHMgaW50ZXJtaXR0ZW50bHkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRDYWNo ZUxpbnV4LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0Zv bnRDYWNoZUxpbnV4LmNwcAppbmRleCAzNTBlN2Y0MmUxYWRjNzlhMjg4OTMxMzE5OGQ4MTU1NTdj NWEzM2ViLi5mOGMyNzY0ZmE0NjJlNDMwYjNmNjA3NTdlMmQzM2JjYzAwNTM4OTJkIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Gb250Q2FjaGVM aW51eC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0v Rm9udENhY2hlTGludXguY3BwCkBAIC02NCw3ICs2NCw3IEBAIGNvbnN0IFNpbXBsZUZvbnREYXRh KiBGb250Q2FjaGU6OmdldEZvbnREYXRhRm9yQ2hhcmFjdGVycyhjb25zdCBGb250JiBmb250LAog ICAgICAgICByZXR1cm4gMDsKIAogICAgIEF0b21pY1N0cmluZyBhdG9taWNGYW1pbHkoZmFtaWx5 KTsKLSAgICByZXR1cm4gZ2V0Q2FjaGVkRm9udERhdGEoZ2V0Q2FjaGVkRm9udFBsYXRmb3JtRGF0 YShmb250LmZvbnREZXNjcmlwdGlvbigpLCBhdG9taWNGYW1pbHksIERvTm90UmV0YWluKSk7Cisg ICAgcmV0dXJuIGdldENhY2hlZEZvbnREYXRhKGdldENhY2hlZEZvbnRQbGF0Zm9ybURhdGEoZm9u dC5mb250RGVzY3JpcHRpb24oKSwgYXRvbWljRmFtaWx5LCBEb05vdFJldGFpbiksIERvTm90UmV0 YWluKTsKIH0KIAogU2ltcGxlRm9udERhdGEqIEZvbnRDYWNoZTo6Z2V0U2ltaWxhckZvbnRQbGF0 Zm9ybURhdGEoY29uc3QgRm9udCYgZm9udCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYkZvbnRJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YkZvbnRJbXBsLmNwcAppbmRleCBmZDI3OWEyZTk1YmFjMTFiZjFiZjE0NDkxNWIyNTViNGNhNzA5 NGY1Li43ODQwNzU3NDdiMzlkMWIwOTZiYzFkOGEyZjZkZWNhODZmODljY2QwIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGb250SW1wbC5jcHAKKysrIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRm9udEltcGwuY3BwCkBAIC0zMiw2ICszMiw3IEBACiAj aW5jbHVkZSAiV2ViRm9udEltcGwuaCIKIAogI2luY2x1ZGUgIkZvbnQuaCIKKyNpbmNsdWRlICJG b250Q2FjaGUuaCIKICNpbmNsdWRlICJGb250RGVzY3JpcHRpb24uaCIKICNpbmNsdWRlICJHcmFw aGljc0NvbnRleHQuaCIKICNpbmNsdWRlICJwYWludGluZy9HcmFwaGljc0NvbnRleHRCdWlsZGVy LmgiCkBAIC05Myw2ICs5NCw4IEBAIHZvaWQgV2ViRm9udEltcGw6OmRyYXdUZXh0KFdlYkNhbnZh cyogY2FudmFzLCBjb25zdCBXZWJUZXh0UnVuJiBydW4sIGNvbnN0IFdlYkZsCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICBXZWJDb2xvciBjb2xvciwgY29uc3QgV2ViUmVjdCYgY2xpcCwgYm9v bCBjYW52YXNJc09wYXF1ZSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgIGludCBmcm9tLCBp bnQgdG8pIGNvbnN0CiB7CisgICAgRm9udENhY2hlUHVyZ2VQcmV2ZW50ZXIgZm9udENhY2hlUHVy Z2VQcmV2ZW50ZXI7CisKICAgICBHcmFwaGljc0NvbnRleHRCdWlsZGVyIGJ1aWxkZXIoY2FudmFz KTsKICAgICBHcmFwaGljc0NvbnRleHQmIGdjID0gYnVpbGRlci5jb250ZXh0KCk7CiAK