66659 2011-08-22 03:40:25 -0700 REGRESSION (r88115): Uploading a file to mydrive.ch produces an endless busyloop. 2011-08-29 22:21:43 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED http://www.mydrive.ch/ InRadar, Regression P1 Normal --- 1 fabien.coeurjoly tkent darin dglazkov dominicc jonlee tkent webkit-bug-importer oldest_to_newest 454519 0 fabien.coeurjoly 2011-08-22 03:40:25 -0700 Conditions: - WebKit r93490 (any version since r91657 will trigger it). - GtkLauncher was used (but it also happens with my own webkit-based browser) Steps to reproduce the bug: 1. Go to http://www.mydrive.ch (you need an account, it's free). 2. Log in and press Upload button on the top/left: different upload methods will be shown, select "Standard" method and save. 3. Select a file to upload, and then press Upload button below. 4. The browser enters a neverending busyloop. To be noted it didn't happen in r90337. I firt noticed this bug in r91657, so it's somewhere in between. 455609 1 ap 2011-08-23 12:36:36 -0700 Also happens in Safari on Mac. This is freezing in HTMLFormControlElement/ShadowRoot::recalcStyle(), so <http://trac.webkit.org/changeset/88115> (convert file <input> to use the new shadow DOM model) seems like a likely culprit. 455610 2 ap 2011-08-23 12:37:10 -0700 <rdar://problem/10008934> 456744 3 105157 tkent 2011-08-25 03:13:55 -0700 Created attachment 105157 Reduced HTML 457368 4 tkent 2011-08-25 21:20:47 -0700 I confirmed r88115 is the culprit, and will post a fix soon. 457383 5 105307 tkent 2011-08-25 21:52:35 -0700 Created attachment 105307 Patch 457594 6 105307 darin 2011-08-26 09:58:10 -0700 Comment on attachment 105307 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105307&action=review > Source/WebCore/rendering/RenderFileUploadControl.cpp:69 > + bool newDisabled = !theme()->isEnabled(this); > + if (button->disabled() != newDisabled) > + button->setDisabled(newDisabled); Could we put this early return inside the setDisabled function instead? It seems wrong for setDisabled to trigger style recalculation if the state is not changing. 458044 7 105307 tkent 2011-08-28 19:58:42 -0700 Comment on attachment 105307 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105307&action=review >> Source/WebCore/rendering/RenderFileUploadControl.cpp:69 >> + button->setDisabled(newDisabled); > > Could we put this early return inside the setDisabled function instead? It seems wrong for setDisabled to trigger style recalculation if the state is not changing. Sure. 458045 8 105453 tkent 2011-08-28 20:00:02 -0700 Created attachment 105453 Patch 2 Update setDisabled() 458049 9 105453 darin 2011-08-28 20:16:25 -0700 Comment on attachment 105453 Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=105453&action=review > Source/WebCore/html/HTMLFormControlElement.cpp:245 > void HTMLFormControlElement::setDisabled(bool b) > { > - setAttribute(disabledAttr, b ? "" : 0); > + if (disabled() != b) > + setAttribute(disabledAttr, b ? "" : 0); > } I know I was the one who suggested this fix, but now I have to be the one doubting my own suggestion. Since setDisabled is a function exported via the DOM to JavaScript (I did not realize that when I made my suggestion earlier) we need to test what it does in other browsers. For example, does setting it to true overwrite the existing value of the disabled attribute, setting it to the empty string? Also, are there any other side effects of an extra setAttribute call that are detectable from JavaScript? 458076 10 tkent 2011-08-28 23:22:42 -0700 (In reply to comment #9) > I know I was the one who suggested this fix, but now I have to be the one doubting my own suggestion. Since setDisabled is a function exported via the DOM to JavaScript (I did not realize that when I made my suggestion earlier) we need to test what it does in other browsers. For example, does setting it to true overwrite the existing value of the disabled attribute, setting it to the empty string? Also, are there any other side effects of an extra setAttribute call that are detectable from JavaScript? * The HTML standard says nothing about this case. http://www.whatwg.org/specs/web-apps/current-work/multipage/common-microsyntaxes.html#boolean-attribute * IE9, and Firefox 7 beta behaves same as the curent WebKit. input.disabled=true always updates the "disabled" attribute value. * The behavior of Opera 11.01 looks same as the "Patch 2". input.disabled=true doesn't update the "disabled" attribute value if the "disabled" attribute already has a value. I think we had better follow IE9 and Firefox. So I'll withdraw the second patch and set r? to the first patch. 458289 11 105307 darin 2011-08-29 10:58:44 -0700 Comment on attachment 105307 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105307&action=review >>> Source/WebCore/rendering/RenderFileUploadControl.cpp:69 >>> + if (button->disabled() != newDisabled) >>> + button->setDisabled(newDisabled); >> >> Could we put this early return inside the setDisabled function instead? It seems wrong for setDisabled to trigger style recalculation if the state is not changing. > > Sure. I suggest we add a “why” comment explaining why we need to check the disabled state instead of unconditionally calling setDisabled. 458682 12 tkent 2011-08-29 21:24:29 -0700 Thank you for reviewing. (In reply to comment #11) > I suggest we add a “why” comment explaining why we need to check the disabled state instead of unconditionally calling setDisabled. ok, I'll add a comment and will land the patch. 458703 13 tkent 2011-08-29 22:21:43 -0700 Committed r94045: <http://trac.webkit.org/changeset/94045> 105157 2011-08-25 03:13:55 -0700 2011-08-25 03:13:55 -0700 Reduced HTML MyDrive.html text/html 1531 tkent PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KPG1ldGEgaHR0cC1lcXVpdj0iQ29udGVudC1U eXBlIiBjb250ZW50PSJ0ZXh0L2h0bWw7IGNoYXJzZXQ9VVRGLTgiPgo8c3R5bGU+Ci5jaGVja2Jv eFtkaXNhYmxlZF0sLnJhZGlvW2Rpc2FibGVkXXtjdXJzb3I6ZGVmYXVsdH0KPC9zdHlsZT4KPC9o ZWFkPgo8Ym9keT4KPGRpdiBpZD0idXBsb2FkIiBzdHlsZT0iIj4KIDxmb3JtIGFjdGlvbj0iaHR0 cDovL3d3dy5oYXVOLm9yZy9rZW50L3ByaW50ZW52LnBsIiBtZXRob2Q9InBvc3QiIGlkPSJ1cGxv YWQtZm9ybSIgZW5jdHlwZT0ibXVsdGlwYXJ0L2Zvcm0tZGF0YSIgc3R5bGU9IiIgdGFyZ2V0PSJ1 cGxvYWQtZm9ybS10YXJnZXQiPgogICA8aWZyYW1lIGlkPSJ1cGxvYWQtZm9ybS10YXJnZXQiIG5h bWU9InVwbG9hZC1mb3JtLXRhcmdldCIgc3R5bGU9ImRpc3BsYXk6IG5vbmUiPjwvaWZyYW1lPgog ICA8aW5wdXQgbmFtZT0iRmlsZWRhdGEiIHR5cGU9ImZpbGUiIHNpemU9IjM2IiBpZD0iRmlsZWRh dGEiIGNsYXNzPSJmaWxlIj4KICAgPGlucHV0IHR5cGU9InN1Ym1pdCIgdmFsdWU9IlVwbG9hZCIg Y2xhc3M9InN1Ym1pdCBidXR0b24iPgogPC9mb3JtPgo8L2Rpdj4KPHNjcmlwdD4KZnVuY3Rpb24g JChpZCkgeyByZXR1cm4gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoaWQpOyB9Cgp2YXIgc3RhdGUg PSAwOwokKCd1cGxvYWQtZm9ybScpLm9uc3VibWl0ID0gaGFuZGxlRm9ybVN0YXJ0OwokKCdGaWxl ZGF0YScpLnZhbHVlID0gJyc7CiQoJ0ZpbGVkYXRhJykuZGlzYWJsZWQgPSBmYWxzZTsKJCgndXBs b2FkLWZvcm0tdGFyZ2V0Jykub25sb2FkID0gaGFuZGxlRm9ybUZpbmlzaDsKCmZ1bmN0aW9uIGhh bmRsZUZvcm1TdGFydCgpIHsKICBjb25zb2xlLmxvZygnaGFuZGxlRm9ybVN0YXJ0KCk6IEVOVEVS Jyk7CiAgaWYgKCQoJ0ZpbGVkYXRhJykudmFsdWUgPT0gJycpIHsKICAgIGFsZXJ0KCdObyBmaWxl IHNlbGVjdGVkJyk7CiAgICByZXR1cm4gZmFsc2U7CiAgfQogIGNvbnNvbGUubG9nKCdTdWJtaXR0 aW5nIHRoZSBmb3JtLi4uJyk7CiAgc3RhdGUgPSAxOwogICQoJ3VwbG9hZCcpLmNsYXNzTGlzdC5h ZGQoJ2FjdGl2ZScpOwogICQoJ3VwbG9hZC1mb3JtJykuc3VibWl0KCk7CiAgc2V0VGltZW91dChm dW5jdGlvbigpIHsKICAgIGNvbnNvbGUubG9nKCdEaXNhYmxpbmcgdGhlIHVwbG9hZCBjb250cm9s LicpOwogICAgJCgnRmlsZWRhdGEnKS5kaXNhYmxlZCA9IHRydWU7CiAgICBjb25zb2xlLmxvZygn RGlzYWJsZWQgdGhlIHVwbG9hZCBjb250cm9sLicpOwogIH0sIDApOwogIHJldHVybiBmYWxzZTsK fQpmdW5jdGlvbiBoYW5kbGVGb3JtRmluaXNoKCkgewogIGlmIChzdGF0ZSA8IDEpCiAgICByZXR1 cm47CiAgY29uc29sZS5sb2coJ1N1Ym1pdHRlZCB0aGUgZm9ybS4uLicpOwogICQoJ0ZpbGVkYXRh JykuZGlzYWJsZWQgPSBmYWxzZTsKICAkKCdGaWxlZGF0YScpLnZhbHVlID0gJyc7CiAgY29uc29s ZS5sb2coJ0ZpbmlzaGVkLicpOwp9Cjwvc2NyaXB0Pgo8L2JvZHk+CjwvaHRtbD4KCg== 105307 2011-08-25 21:52:35 -0700 2011-08-29 10:58:44 -0700 Patch bug-66659-20110826135233.patch text/plain 3944 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogOTM4NDgKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA4ZTM5ZjQ4OTJhZTlhNzY3MjFhMDRk MzEzNjQ0ZGY5YTYxMTMzYzIwLi5iNTRhZDk0MDNkZTY3NjYzNjdjMWMyMmUzNWI1ZTYwOWNiYjY4 ZjE1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDgtMjUgIEtlbnQgVGFtdXJhICA8dGtl bnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjg4MTE1KTogRGlzYWJsaW5n IGEgZmlsZSB1cGxvYWQgY29udHJvbCBjYXVzZXMgYW4gZW5kbGVzcyBidXN5bG9vcC4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2NjU5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2Zvcm1zL2Zp bGUvZGlzYWJsaW5nLWZpbGUtYnVzeS1sb29wLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAg ICogZmFzdC9mb3Jtcy9maWxlL2Rpc2FibGluZy1maWxlLWJ1c3ktbG9vcC5odG1sOiBBZGRlZC4K KwogMjAxMS0wOC0yNSAgUGV0ZXIgS2FzdGluZyAgPHBrYXN0aW5nQGdvb2dsZS5jb20+CiAKICAg ICAgICAgVGVtcG9yYXJpbHkgbWFyayBzb21lIHRlc3RzIGFzIGNyYXNoaW5nIChhc3NlcnRpb24g ZmFpbHVyZSkgYWZ0ZXIgcjkzNzk0LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jt cy9maWxlL2Rpc2FibGluZy1maWxlLWJ1c3ktbG9vcC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0 cy9mYXN0L2Zvcm1zL2ZpbGUvZGlzYWJsaW5nLWZpbGUtYnVzeS1sb29wLWV4cGVjdGVkLnR4dApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi41NWIxYzkyMTcxZTNkNzg2NTI5OTE5M2NiZTg2YzZiZDM5NWI3Mjc5Ci0tLSAv ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9maWxlL2Rpc2FibGluZy1maWxl LWJ1c3ktbG9vcC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwyIEBACisKK1BBU1MgaWYgdGhpcyB0 ZXh0IGlzIHZpc2libGUuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2ZpbGUv ZGlzYWJsaW5nLWZpbGUtYnVzeS1sb29wLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2Zp bGUvZGlzYWJsaW5nLWZpbGUtYnVzeS1sb29wLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNzk3NjVlZTNiMGFl ZWIxNGU4NThkOWVkZjhlYWQ4NDA3MzQ1NThhYwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRl c3RzL2Zhc3QvZm9ybXMvZmlsZS9kaXNhYmxpbmctZmlsZS1idXN5LWxvb3AuaHRtbApAQCAtMCww ICsxLDE4IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8c3R5bGU+CisuZm9v W2Rpc2FibGVkXSB7fQorPC9zdHlsZT4KKzwvaGVhZD4KKzxib2R5PgorPGlucHV0IHR5cGU9ImZp bGUiIGlkPSJmaWxlVXBsb2FkIj4KKzxkaXYgaWQ9Y29uc29sZT48L2Rpdj4KKzxzY3JpcHQ+Citp ZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgIGxheW91dFRlc3RDb250cm9sbGVy LmR1bXBBc1RleHQoKTsKK2RvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdmaWxlVXBsb2FkJykuZGlz YWJsZWQgPSB0cnVlOworZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2NvbnNvbGUnKS5pbm5lclRl eHQgPSAnUEFTUyBpZiB0aGlzIHRleHQgaXMgdmlzaWJsZS4nOworPC9zY3JpcHQ+Cis8L2JvZHk+ Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTNiMWMwOTIwMjE1MGZiYTA4Y2M1MDE2MzU1MjkyZGQ1 OGI5Zjg2Mi4uMjdiNzhjYjFjOWFjZjMwMGE3ZmNlZDVlMjFjNGFhYTMyMmRjYWRjNyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDExLTA4LTI1ICBLZW50IFRhbXVyYSAgPHRrZW50QGNo cm9taXVtLm9yZz4KKworICAgICAgICBSRUdSRVNTSU9OKHI4ODExNSk6IERpc2FibGluZyBhIGZp bGUgdXBsb2FkIGNvbnRyb2wgY2F1c2VzIGFuIGVuZGxlc3MgYnVzeWxvb3AuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjY1OQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IGZhc3QvZm9ybXMvZmls ZS9kaXNhYmxpbmctZmlsZS1idXN5LWxvb3AuaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1Jl bmRlckZpbGVVcGxvYWRDb250cm9sLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckZpbGVV cGxvYWRDb250cm9sOjp1cGRhdGVGcm9tRWxlbWVudCk6CisgICAgICAgIERvbid0IGNhbGwgc2V0 RGlzYWJsZWQoKSBpZiB0aGUgZGlzYWJsZWQgc3RhdHVzIGlzIG5vdCBjaGFuZ2VkLgorICAgICAg ICBzZXREaXNhYmxlZCgpIGNhdXNlcyBzdHlsZVJlY2FsYygpLCBhbmQKKyAgICAgICAgSFRNTEZv cm1Db250cm9sRWxlbWVudDo6c3R5bGVSZWNhbGMoKSBjYXVzZXMKKyAgICAgICAgdXBkYXRlRnJv bUVsZW1lbnQoKS4gdXBkYXRlRnJvbUVsZW1lbnQoKSBzaG91bGQgbm90IGNhbGwKKyAgICAgICAg c2V0RGlzYWJsZWQoKSBhZ2Fpbi4KKwogMjAxMS0wOC0yNSAgTHVrZSBNYWNwaGVyc29uICAgPG1h Y3BoZXJzb25AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEltcGxlbWVudCBhbmltYXRpb24gYW5k IHRyYW5zaXRpb24gcHJvcGVydGllcyBpbiBDU1NTdHlsZUFwcGx5UHJvcGVydHkuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmlsZVVwbG9hZENvbnRyb2wuY3Bw IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZpbGVVcGxvYWRDb250cm9sLmNwcApp bmRleCBhYjkxOGFhYjFlMzY1MWU2NjVjODA1M2ExZjkyNjMwMzhiNTBlY2ZkLi4wYTNlMWE4OWRl MDFjMTBmYjQxMzc2NTIwZDEzZjhiYTQ4ODE3NDg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyRmlsZVVwbG9hZENvbnRyb2wuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJGaWxlVXBsb2FkQ29udHJvbC5jcHAKQEAgLTYzLDggKzYzLDEx IEBAIHZvaWQgUmVuZGVyRmlsZVVwbG9hZENvbnRyb2w6OnVwZGF0ZUZyb21FbGVtZW50KCkKICAg ICBIVE1MSW5wdXRFbGVtZW50KiBpbnB1dCA9IHN0YXRpY19jYXN0PEhUTUxJbnB1dEVsZW1lbnQq Pihub2RlKCkpOwogICAgIEFTU0VSVChpbnB1dC0+aXNGaWxlVXBsb2FkKCkpOwogCi0gICAgaWYg KEhUTUxJbnB1dEVsZW1lbnQqIGJ1dHRvbiA9IHVwbG9hZEJ1dHRvbigpKQotICAgICAgICBidXR0 b24tPnNldERpc2FibGVkKCF0aGVtZSgpLT5pc0VuYWJsZWQodGhpcykpOworICAgIGlmIChIVE1M SW5wdXRFbGVtZW50KiBidXR0b24gPSB1cGxvYWRCdXR0b24oKSkgeworICAgICAgICBib29sIG5l d0Rpc2FibGVkID0gIXRoZW1lKCktPmlzRW5hYmxlZCh0aGlzKTsKKyAgICAgICAgaWYgKGJ1dHRv bi0+ZGlzYWJsZWQoKSAhPSBuZXdEaXNhYmxlZCkKKyAgICAgICAgICAgIGJ1dHRvbi0+c2V0RGlz YWJsZWQobmV3RGlzYWJsZWQpOworICAgIH0KIAogICAgIC8vIFRoaXMgb25seSBzdXBwb3J0cyBj bGVhcmluZyBvdXQgdGhlIGZpbGVzLCBidXQgdGhhdCdzIE9LIGJlY2F1c2UgZm9yCiAgICAgLy8g c2VjdXJpdHkgcmVhc29ucyB0aGF0J3MgdGhlIG9ubHkgY2hhbmdlIHRoZSBET00gaXMgYWxsb3dl ZCB0byBtYWtlLgo= 105453 2011-08-28 20:00:02 -0700 2011-08-28 23:22:55 -0700 Patch 2 bug-66659-20110829120000.patch text/plain 3546 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogOTM5NTIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA2NGEwZTM5YmNlMzcxMDZlYmEzNjNl MDU5OWQwYjA0MzlkZTVjODkzLi5iZWIzNzFmZDIwN2E5MWY2MzkwMTFiMzM0MzY3ODdkMWQ0NTcy ZDNmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDgtMjggIEtlbnQgVGFtdXJhICA8dGtl bnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjg4MTE1KTogRGlzYWJsaW5n IGEgZmlsZSB1cGxvYWQgY29udHJvbCBjYXVzZXMgYW4gZW5kbGVzcyBidXN5bG9vcC4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2NjU5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2Zvcm1zL2Zp bGUvZGlzYWJsaW5nLWZpbGUtYnVzeS1sb29wLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAg ICogZmFzdC9mb3Jtcy9maWxlL2Rpc2FibGluZy1maWxlLWJ1c3ktbG9vcC5odG1sOiBBZGRlZC4K KwogMjAxMS0wOC0yOCAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIEFk ZCBzdXBwb3J0IGZvciBjb25zdHJ1Y3RvciBzeW50YXggZm9yIEV2ZW50cwpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9maWxlL2Rpc2FibGluZy1maWxlLWJ1c3ktbG9vcC1leHBl Y3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2ZpbGUvZGlzYWJsaW5nLWZpbGUtYnVz eS1sb29wLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi41NWIxYzkyMTcxZTNkNzg2NTI5OTE5M2Ni ZTg2YzZiZDM5NWI3Mjc5Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jt cy9maWxlL2Rpc2FibGluZy1maWxlLWJ1c3ktbG9vcC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwy IEBACisKK1BBU1MgaWYgdGhpcyB0ZXh0IGlzIHZpc2libGUuCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9mYXN0L2Zvcm1zL2ZpbGUvZGlzYWJsaW5nLWZpbGUtYnVzeS1sb29wLmh0bWwgYi9MYXlv dXRUZXN0cy9mYXN0L2Zvcm1zL2ZpbGUvZGlzYWJsaW5nLWZpbGUtYnVzeS1sb29wLmh0bWwKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMC4uNzk3NjVlZTNiMGFlZWIxNGU4NThkOWVkZjhlYWQ4NDA3MzQ1NThhYwotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvZmlsZS9kaXNhYmxpbmctZmlsZS1i dXN5LWxvb3AuaHRtbApAQCAtMCwwICsxLDE4IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgor PGhlYWQ+Cis8c3R5bGU+CisuZm9vW2Rpc2FibGVkXSB7fQorPC9zdHlsZT4KKzwvaGVhZD4KKzxi b2R5PgorPGlucHV0IHR5cGU9ImZpbGUiIGlkPSJmaWxlVXBsb2FkIj4KKzxkaXYgaWQ9Y29uc29s ZT48L2Rpdj4KKzxzY3JpcHQ+CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAg IGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKK2RvY3VtZW50LmdldEVsZW1lbnRC eUlkKCdmaWxlVXBsb2FkJykuZGlzYWJsZWQgPSB0cnVlOworZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoJ2NvbnNvbGUnKS5pbm5lclRleHQgPSAnUEFTUyBpZiB0aGlzIHRleHQgaXMgdmlzaWJsZS4n OworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTk3MGFjMmQxYWVi NWNkMzlkNTk2MzY5NTUyN2I2MmJiMThlNGFlNi4uZGNkOTBmOWUxMjdiZTAxODU2Y2IwYmM4N2Ux YzYzMGMxMDNlYTA3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDExLTA4LTI4ICBL ZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBSRUdSRVNTSU9OKHI4 ODExNSk6IERpc2FibGluZyBhIGZpbGUgdXBsb2FkIGNvbnRyb2wgY2F1c2VzIGFuIGVuZGxlc3Mg YnVzeWxvb3AuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02NjY1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFRlc3Q6IGZhc3QvZm9ybXMvZmlsZS9kaXNhYmxpbmctZmlsZS1idXN5LWxvb3AuaHRtbAorCisg ICAgICAgICogaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6OnNldERpc2FibGVkKToKKyAgICAgICAgRG9uJ3Qg Y2FsbCBzZXRBdHRyaWJ1dGUoKSBpZiB0aGUgZGlzYWJsZWQgc3RhdHVzIGlzIG5vdCBjaGFuZ2Vk LgorICAgICAgICBzZXRBdHRyaWJ1dGUoKSBjYXVzZXMgc3R5bGVSZWNhbGMoKSwgYW5kCisgICAg ICAgIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6OnN0eWxlUmVjYWxjKCkgY2F1c2VzCisgICAgICAg IHVwZGF0ZUZyb21FbGVtZW50KCkuIHVwZGF0ZUZyb21FbGVtZW50KCkgY2FsbHMgc2V0RGlzYWJs ZWQoKSwgYW5kCisgICAgICAgIHNldERpc2FibGVkKCkgc2hvdWxkIG5vdCBjYWxsIHNldEF0dHJp YnV0ZSgpIGFnYWluLgorCiAyMDExLTA4LTI4ICBMdWtlIE1hY3BoZXJzb24gICA8bWFjcGhlcnNv bkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgRml4IHJlZmVyZW5jZSBjb3VudGluZyBvZiB2YWx1 ZXMgaW4gQ1NTU2VsZWN0b3IuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxG b3JtQ29udHJvbEVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRy b2xFbGVtZW50LmNwcAppbmRleCBmZmFmYmE1ZWNiZWYwYzkzMTE2YmJhNDAyNjcwMTdlN2VlYTIw YWE4Li43NmMxYmUxOTBmN2U5Y2UyNWJkMDNmN2Q2ZmEyNzFkMWEyYzQ5YWNhIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnQuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250cm9sRWxlbWVudC5jcHAKQEAgLTI0MCw3ICsy NDAsOCBAQCB2b2lkIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6OmRpc3BhdGNoRm9ybUNvbnRyb2xJ bnB1dEV2ZW50KCkKIAogdm9pZCBIVE1MRm9ybUNvbnRyb2xFbGVtZW50OjpzZXREaXNhYmxlZChi b29sIGIpCiB7Ci0gICAgc2V0QXR0cmlidXRlKGRpc2FibGVkQXR0ciwgYiA/ICIiIDogMCk7Cisg ICAgaWYgKGRpc2FibGVkKCkgIT0gYikKKyAgICAgICAgc2V0QXR0cmlidXRlKGRpc2FibGVkQXR0 ciwgYiA/ICIiIDogMCk7CiB9CiAKIGJvb2wgSFRNTEZvcm1Db250cm9sRWxlbWVudDo6YXV0b2Zv Y3VzKCkgY29uc3QK