66657 2011-08-22 03:23:14 -0700 [NRWT] Fix "Only unexpected results" option of results.html 2011-08-22 06:43:48 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P3 Normal --- 1 ossy kkristof ossy webkit.review.bot oldest_to_newest 454515 0 ossy 2011-08-22 03:23:14 -0700 "Only unexpected results" option of results.html only works in WebKit based browsers. It doesn't work in the latest FireFox, IE, Opera. Other browsers simple ignores this checkbox and always shows everything. 454545 1 104666 kkristof 2011-08-22 06:03:04 -0700 Created attachment 104666 proposed fix 454571 2 104666 ossy 2011-08-22 06:34:50 -0700 Comment on attachment 104666 proposed fix great, r=me Let's try CQ. ( Maybe it likes my name now. :) ) 454572 3 104666 webkit.review.bot 2011-08-22 06:36:24 -0700 Comment on attachment 104666 proposed fix Rejecting attachment 104666 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 1 Last 500 characters of output: cripts/webkitpy/common/system/executive.py", line 420, in run_command close_fds=self._should_close_fds()) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 476, in popen return subprocess.Popen(*args, **kwargs) File "/usr/lib/python2.6/subprocess.py", line 623, in __init__ errread, errwrite) File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child raise child_exception TypeError: execv() arg 2 must contain only strings Full output: http://queues.webkit.org/results/9468658 454574 4 104666 ossy 2011-08-22 06:43:41 -0700 Comment on attachment 104666 proposed fix Clearing flags on attachment: 104666 Committed r93508: <http://trac.webkit.org/changeset/93508> 454575 5 ossy 2011-08-22 06:43:48 -0700 All reviewed patches have been landed. Closing bug. 104666 2011-08-22 06:03:04 -0700 2011-08-22 06:43:41 -0700 proposed fix 0822.patch text/plain 1078 kkristof ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlNzhjOTk0Li44MWRhN2EwIDEwMDc1NQotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDgt MjIgIEtyaXN0w7NmIEtvc3p0ecOzICA8a2tyaXN0b2ZAaW5mLnUtc3plZ2VkLmh1PgorCisgICAg ICAgIFtOUldUXSBGaXggIk9ubHkgdW5leHBlY3RlZCByZXN1bHRzIiBvcHRpb24gb2YgcmVzdWx0 cy5odG1sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02 NjY1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog ZmFzdC9oYXJuZXNzL3Jlc3VsdHMuaHRtbDoKKwogMjAxMS0wOC0yMiAgVml0YWx5IFJlcGVzaGtv ICA8dml0YWx5ckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBVcGRhdGluZyB0 ZXN0IGV4cGVjdGF0aW9ucy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvaGFybmVzcy9y ZXN1bHRzLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2hhcm5lc3MvcmVzdWx0cy5odG1sCmluZGV4 IDE3YzQ4ZTYuLjY0ZTIzZWMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvaGFybmVzcy9y ZXN1bHRzLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9oYXJuZXNzL3Jlc3VsdHMuaHRtbApA QCAtODcxLDcgKzg3MSw3IEBAIGZ1bmN0aW9uIGhhbmRsZVVuZXhwZWN0ZWRSZXN1bHRzQ2hhbmdl KCkKIAogZnVuY3Rpb24gdXBkYXRlRXhwZWN0ZWRGYWlsdXJlcygpCiB7Ci0gICAgZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoJ3VuZXhwZWN0ZWQtc3R5bGUnKS5pbm5lclRleHQgPSBvbmx5U2hvd1Vu ZXhwZWN0ZWRGYWlsdXJlcygpID8KKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndW5leHBl Y3RlZC1zdHlsZScpLnRleHRDb250ZW50ID0gb25seVNob3dVbmV4cGVjdGVkRmFpbHVyZXMoKSA/ CiAgICAgICAgICcuZXhwZWN0ZWQgeyBkaXNwbGF5OiBub25lOyB9JyA6ICcnOwogfQogCg==