66649 2011-08-22 00:14:01 -0700 [Chromium] [WebSocket] Add a test to reproduce chromium bug on close before open 2011-08-22 05:06:55 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Other All RESOLVED FIXED P2 Normal --- 0 toyoshim webkit-unassigned abarth ap tkent webkit.review.bot yutak oldest_to_newest 454482 0 toyoshim 2011-08-22 00:14:01 -0700 On Chromium port, WebSocket.onclose() callback doesn't be called when JavaScript call close() before onopen() is called. Current test to check this scenario, access to ws://127.0.0.1:8880/websocket/tests/hybi/handing-handshake. This URL cause close event by another reason, so the problem is hidden by chance. 454485 1 104650 toyoshim 2011-08-22 00:24:50 -0700 Created attachment 104650 Patch 454488 2 tkent 2011-08-22 01:05:52 -0700 (In reply to comment #1) > Created an attachment (id=104650) [details] > Patch Do you need review? The review flag is not set. 454492 3 toyoshim 2011-08-22 01:34:49 -0700 Thank you for comment. I'll check it in Chromium if this test reproduce the issue. After that, I'll check the review flag. Thanks! 454494 4 toyoshim 2011-08-22 02:03:24 -0700 DumpRenderTree/chromium passes this test because its IPC implementation is different from one of chromium itself. But, manual test by Chrome fails. So I think it's worth to submit. 454496 5 104650 tkent 2011-08-22 02:04:51 -0700 Comment on attachment 104650 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104650&action=review > LayoutTests/platform/chromium/test_expectations.txt:173 > +// Temporally disable until WebSocket IPC bug is fixed. > +BUGCR93698 SKIP : http/tests/websocket/tests/hybi/close-before-open.html = PASS TIMEOUT FAIL > + You said DRT/Chromium passed this test. So we don't need this part. 454499 6 104652 toyoshim 2011-08-22 02:13:54 -0700 Created attachment 104652 Patch 454521 7 104652 tkent 2011-08-22 03:53:21 -0700 Comment on attachment 104652 Patch ok 454536 8 104652 webkit.review.bot 2011-08-22 05:06:50 -0700 Comment on attachment 104652 Patch Clearing flags on attachment: 104652 Committed r93505: <http://trac.webkit.org/changeset/93505> 454537 9 webkit.review.bot 2011-08-22 05:06:55 -0700 All reviewed patches have been landed. Closing bug. 104650 2011-08-22 00:24:50 -0700 2011-08-22 02:13:47 -0700 Patch bug-66649-20110822162448.patch text/plain 3917 toyoshim U3VidmVyc2lvbiBSZXZpc2lvbjogOTM0OTIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAwMjk3MjIxOTYyMWNjYWI4NTFlODU2 OTk0NDVjNWVjMTMzMGY2NWZhLi45NjYwNGUxMjNiMDcxZDQxYzdkZjBlMDNkNjlkNTJmNWMyN2Ji NGViIDEwMDc1NQotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDgtMjIgIFRha2FzaGkgVG95b3NoaW1h ICA8dG95b3NoaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gW1dlYlNvY2tl dF0gQWRkIGEgdGVzdCB0byByZXByb2R1Y2UgY2hyb21pdW0gYnVnIG9uIGNsb3NlIGJlZm9yZSBv cGVuLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY2 NDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0 dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2h5YmkvY2xvc2UtYmVmb3JlLW9wZW4tZXhwZWN0ZWQu dHh0OgorICAgICAgICAqIGh0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2h5YmkvY2xvc2UtYmVm b3JlLW9wZW4uaHRtbDoKKyAgICAgICAgQWRkIG5ldyBVUkwgdG8gcmVwcm9kdWNlIHRoZSBwcm9i bGVtLgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dDoK KyAgICAgICAgU3VwcHJlc3MgdGhpcyB0ZXN0IG9uIENocm9taXVtLgorCiAyMDExLTA4LTIxICBE YXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBVcGRhdGUgcmVzdWx0cyBm b3IgbW9yZSB0ZXN0cyBhZmZlY3RlZCBieSB0aGUgYWRkaXRpb24gb2YgdGhlCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9oeWJpL2Nsb3NlLWJlZm9y ZS1vcGVuLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvd2Vic29ja2V0L3Rl c3RzL2h5YmkvY2xvc2UtYmVmb3JlLW9wZW4tZXhwZWN0ZWQudHh0CmluZGV4IDU3YTU0MmE0ZGZm NjUyMzkxMmVkNDQ2MjMyYzc3M2M2OGNjN2JkMjEuLjBkZjAzMzNmMmI2NTU2MGM4M2NlYjIyODdk NmNmZmJkYmNlNTgxNTAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvd2Vic29j a2V0L3Rlc3RzL2h5YmkvY2xvc2UtYmVmb3JlLW9wZW4tZXhwZWN0ZWQudHh0CisrKyBiL0xheW91 dFRlc3RzL2h0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2h5YmkvY2xvc2UtYmVmb3JlLW9wZW4t ZXhwZWN0ZWQudHh0CkBAIC0xLDkgKzEsMTEgQEAKIENPTlNPTEUgTUVTU0FHRTogbGluZSAwOiBX ZWJTb2NrZXQgaXMgY2xvc2VkIGJlZm9yZSB0aGUgY29ubmVjdGlvbiBpcyBlc3RhYmxpc2hlZC4K K0NPTlNPTEUgTUVTU0FHRTogbGluZSAwOiBXZWJTb2NrZXQgaXMgY2xvc2VkIGJlZm9yZSB0aGUg Y29ubmVjdGlvbiBpcyBlc3RhYmxpc2hlZC4KIFRlc3QgaWYgV2ViIFNvY2tldCBmaXJlcyBjbG9z ZSBldmVudCB3aGVuIFdlYlNvY2tldCBpcyBvcGVuZWQgYW5kIGNsb3NlZCBmb3JlIG9wZW4gZXZl bnQgaXMgcmVjZWl2ZWQuCiAKIE9uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAi UEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KIAotY2xvc2VkCitj bG9zZWQgb24gdGVzdCAxCitjbG9zZWQgb24gdGVzdCAyCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNl ZCBpcyB0cnVlCiAKIFRFU1QgQ09NUExFVEUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAv dGVzdHMvd2Vic29ja2V0L3Rlc3RzL2h5YmkvY2xvc2UtYmVmb3JlLW9wZW4uaHRtbCBiL0xheW91 dFRlc3RzL2h0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2h5YmkvY2xvc2UtYmVmb3JlLW9wZW4u aHRtbAppbmRleCBiYjNiMWQzMjQxODdmNDg2YzNhNDM1YmZhNmYzMDJiNmM1OGQ2YzU2Li5lNGU2 N2RmNmQwMjIxNmY5MzI0ZTUyNDM0NTIwYTJkOGFlY2ViNzBkIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9oeWJpL2Nsb3NlLWJlZm9yZS1vcGVuLmh0 bWwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy93ZWJzb2NrZXQvdGVzdHMvaHliaS9jbG9z ZS1iZWZvcmUtb3Blbi5odG1sCkBAIC0xNCwxMyArMTQsMjggQEAgd2luZG93LmpzVGVzdElzQXN5 bmMgPSB0cnVlOwogaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKICAgICBsYXlvdXRU ZXN0Q29udHJvbGxlci5vdmVycmlkZVByZWZlcmVuY2UoIldlYktpdEhpeGllNzZXZWJTb2NrZXRQ cm90b2NvbEVuYWJsZWQiLCAwKTsKIAotdmFyIHdzID0gbmV3IFdlYlNvY2tldCgid3M6Ly8xMjcu MC4wLjE6ODg4MC93ZWJzb2NrZXQvdGVzdHMvaHliaS9oYW5naW5nLWhhbmRzaGFrZSIpOwotd3Mu b25jbG9zZSA9IGZ1bmN0aW9uKCkgewotICAgIGRlYnVnKCJjbG9zZWQiKTsKLSAgICBmaW5pc2hK U1Rlc3QoKTsKK3ZhciB1cmxzID0gWworICAgICJ3czovLzEyNy4wLjAuMTo4ODgwL3dlYnNvY2tl dC90ZXN0cy9oeWJpL2hhbmdpbmctaGFuZHNoYWtlIiwKKyAgICAid3M6Ly8xMjcuMC4wLjE6ODg4 MC93ZWJzb2NrZXQvdGVzdHMvaHliaS9jbG9zZS1jb2RlLWFuZC1yZWFzb24iCitdOworCit2YXIg dGVzdElkID0gMDsKKwordmFyIHRlc3QgPSBmdW5jdGlvbigpIHsKKyAgICBpZiAoMCAhPSB0ZXN0 SWQpCisgICAgICAgIGRlYnVnKCJjbG9zZWQgb24gdGVzdCAiICsgdGVzdElkKTsKKyAgICBpZiAo MiA9PSB0ZXN0SWQpCisgICAgICAgIGZpbmlzaEpTVGVzdCgpOworICAgIGVsc2UgeworICAgICAg ICB3cyA9IG5ldyBXZWJTb2NrZXQodXJsc1t0ZXN0SWQrK10pOworICAgICAgICB3cy5vbmNsb3Nl ID0gdGVzdDsKKyAgICAgICAgd3MuY2xvc2UoKTsKKyAgICB9CiB9OworCit0ZXN0KCk7CisKIHZh ciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOwotd3MuY2xvc2UoKTsKIDwvc2NyaXB0PgogPHNj cmlwdCBzcmM9Ii4uLy4uLy4uLy4uL2pzLXRlc3QtcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+ PC9zY3JpcHQ+CiA8L2JvZHk+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJv bWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1 bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKaW5kZXggMWRkYzdiNmI1ZDUzNDMzYzdkZDcxYWE0NTM4 MTQ3ODYyNjA4MWMzOS4uYjg5ZDBmZThmNDgyMTVjYmZjZjE1MDcyOTI0YWEwYmI4NDk5YjdjOCAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlv bnMudHh0CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRp b25zLnR4dApAQCAtMTY4LDYgKzE2OCw5IEBAIEJVR0NSODk0NjggOiBjc3MzL3NlbGVjdG9yczMg PSBQQVNTIEZBSUwKIC8vIFRlc3RzIGZvciBXZWJWVFQgcGFyc2VyIGZvciA8dHJhY2s+LiAgRmVh dHVyZSBpcyBub3QgeWV0IGZ1bmN0aW9uYWwuCiBCVUdXSzQzNjY4IFNLSVAgOiBtZWRpYS90cmFj ay8gPSBUSU1FT1VUCiAKKy8vIFRlbXBvcmFsbHkgZGlzYWJsZSB1bnRpbCBXZWJTb2NrZXQgSVBD IGJ1ZyBpcyBmaXhlZC4KK0JVR0NSOTM2OTggU0tJUCA6IGh0dHAvdGVzdHMvd2Vic29ja2V0L3Rl c3RzL2h5YmkvY2xvc2UtYmVmb3JlLW9wZW4uaHRtbCA9IFBBU1MgVElNRU9VVCBGQUlMCisKIC8v IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tCiAvLyBXT05URklYIFRFU1RTCiAvLyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo= 104652 2011-08-22 02:13:54 -0700 2011-08-22 05:06:50 -0700 Patch bug-66649-20110822181352.patch text/plain 3004 toyoshim U3VidmVyc2lvbiBSZXZpc2lvbjogOTM0OTIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAwMjk3MjIxOTYyMWNjYWI4NTFlODU2 OTk0NDVjNWVjMTMzMGY2NWZhLi5lNWY5NzczODY1YWFlMTUzYmM0NWQ1OGJmNWQxZjdkOGM4Njhl YjI5IDEwMDc1NQotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDgtMjIgIFRha2FzaGkgVG95b3NoaW1h ICA8dG95b3NoaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gW1dlYlNvY2tl dF0gQWRkIGEgdGVzdCB0byByZXByb2R1Y2UgY2hyb21pdW0gYnVnIG9uIGNsb3NlIGJlZm9yZSBv cGVuLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY2 NDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0 dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2h5YmkvY2xvc2UtYmVmb3JlLW9wZW4tZXhwZWN0ZWQu dHh0OgorICAgICAgICAqIGh0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2h5YmkvY2xvc2UtYmVm b3JlLW9wZW4uaHRtbDoKKyAgICAgICAgQWRkIG5ldyBVUkwgdG8gcmVwcm9kdWNlIHRoZSBwcm9i bGVtLgorCiAyMDExLTA4LTIxICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAg ICAgICBVcGRhdGUgcmVzdWx0cyBmb3IgbW9yZSB0ZXN0cyBhZmZlY3RlZCBieSB0aGUgYWRkaXRp b24gb2YgdGhlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3dlYnNvY2tldC90 ZXN0cy9oeWJpL2Nsb3NlLWJlZm9yZS1vcGVuLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2h0 dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2h5YmkvY2xvc2UtYmVmb3JlLW9wZW4tZXhwZWN0ZWQu dHh0CmluZGV4IDU3YTU0MmE0ZGZmNjUyMzkxMmVkNDQ2MjMyYzc3M2M2OGNjN2JkMjEuLjBkZjAz MzNmMmI2NTU2MGM4M2NlYjIyODdkNmNmZmJkYmNlNTgxNTAgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL2h0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2h5YmkvY2xvc2UtYmVmb3JlLW9wZW4tZXhw ZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2h5 YmkvY2xvc2UtYmVmb3JlLW9wZW4tZXhwZWN0ZWQudHh0CkBAIC0xLDkgKzEsMTEgQEAKIENPTlNP TEUgTUVTU0FHRTogbGluZSAwOiBXZWJTb2NrZXQgaXMgY2xvc2VkIGJlZm9yZSB0aGUgY29ubmVj dGlvbiBpcyBlc3RhYmxpc2hlZC4KK0NPTlNPTEUgTUVTU0FHRTogbGluZSAwOiBXZWJTb2NrZXQg aXMgY2xvc2VkIGJlZm9yZSB0aGUgY29ubmVjdGlvbiBpcyBlc3RhYmxpc2hlZC4KIFRlc3QgaWYg V2ViIFNvY2tldCBmaXJlcyBjbG9zZSBldmVudCB3aGVuIFdlYlNvY2tldCBpcyBvcGVuZWQgYW5k IGNsb3NlZCBmb3JlIG9wZW4gZXZlbnQgaXMgcmVjZWl2ZWQuCiAKIE9uIHN1Y2Nlc3MsIHlvdSB3 aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENP TVBMRVRFIi4KIAotY2xvc2VkCitjbG9zZWQgb24gdGVzdCAxCitjbG9zZWQgb24gdGVzdCAyCiBQ QVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKIFRFU1QgQ09NUExFVEUKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2h5YmkvY2xvc2UtYmVm b3JlLW9wZW4uaHRtbCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2h5 YmkvY2xvc2UtYmVmb3JlLW9wZW4uaHRtbAppbmRleCBiYjNiMWQzMjQxODdmNDg2YzNhNDM1YmZh NmYzMDJiNmM1OGQ2YzU2Li5lNGU2N2RmNmQwMjIxNmY5MzI0ZTUyNDM0NTIwYTJkOGFlY2ViNzBk IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9oeWJp L2Nsb3NlLWJlZm9yZS1vcGVuLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy93ZWJz b2NrZXQvdGVzdHMvaHliaS9jbG9zZS1iZWZvcmUtb3Blbi5odG1sCkBAIC0xNCwxMyArMTQsMjgg QEAgd2luZG93LmpzVGVzdElzQXN5bmMgPSB0cnVlOwogaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29u dHJvbGxlcikKICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5vdmVycmlkZVByZWZlcmVuY2UoIldl YktpdEhpeGllNzZXZWJTb2NrZXRQcm90b2NvbEVuYWJsZWQiLCAwKTsKIAotdmFyIHdzID0gbmV3 IFdlYlNvY2tldCgid3M6Ly8xMjcuMC4wLjE6ODg4MC93ZWJzb2NrZXQvdGVzdHMvaHliaS9oYW5n aW5nLWhhbmRzaGFrZSIpOwotd3Mub25jbG9zZSA9IGZ1bmN0aW9uKCkgewotICAgIGRlYnVnKCJj bG9zZWQiKTsKLSAgICBmaW5pc2hKU1Rlc3QoKTsKK3ZhciB1cmxzID0gWworICAgICJ3czovLzEy Ny4wLjAuMTo4ODgwL3dlYnNvY2tldC90ZXN0cy9oeWJpL2hhbmdpbmctaGFuZHNoYWtlIiwKKyAg ICAid3M6Ly8xMjcuMC4wLjE6ODg4MC93ZWJzb2NrZXQvdGVzdHMvaHliaS9jbG9zZS1jb2RlLWFu ZC1yZWFzb24iCitdOworCit2YXIgdGVzdElkID0gMDsKKwordmFyIHRlc3QgPSBmdW5jdGlvbigp IHsKKyAgICBpZiAoMCAhPSB0ZXN0SWQpCisgICAgICAgIGRlYnVnKCJjbG9zZWQgb24gdGVzdCAi ICsgdGVzdElkKTsKKyAgICBpZiAoMiA9PSB0ZXN0SWQpCisgICAgICAgIGZpbmlzaEpTVGVzdCgp OworICAgIGVsc2UgeworICAgICAgICB3cyA9IG5ldyBXZWJTb2NrZXQodXJsc1t0ZXN0SWQrK10p OworICAgICAgICB3cy5vbmNsb3NlID0gdGVzdDsKKyAgICAgICAgd3MuY2xvc2UoKTsKKyAgICB9 CiB9OworCit0ZXN0KCk7CisKIHZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOwotd3MuY2xv c2UoKTsKIDwvc2NyaXB0PgogPHNjcmlwdCBzcmM9Ii4uLy4uLy4uLy4uL2pzLXRlc3QtcmVzb3Vy Y2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+CiA8L2JvZHk+Cg==