66648 2011-08-21 23:49:10 -0700 Implement cast between CSSPrimitiveValue and EBackfaceVisibility, use in CSSStyleSelector::applyProperty. 2011-08-22 16:24:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 macpherson macpherson eric macpherson simon.fraser webkit.review.bot oldest_to_newest 454478 0 macpherson 2011-08-21 23:49:10 -0700 Implement cast between CSSPrimitiveValue and EBackfaceVisibility, use in CSSStyleSelector::applyProperty. 454479 1 104648 macpherson 2011-08-21 23:51:04 -0700 Created attachment 104648 Patch 455037 2 104648 webkit.review.bot 2011-08-22 16:24:33 -0700 Comment on attachment 104648 Patch Clearing flags on attachment: 104648 Committed r93557: <http://trac.webkit.org/changeset/93557> 455038 3 webkit.review.bot 2011-08-22 16:24:37 -0700 All reviewed patches have been landed. Closing bug. 104648 2011-08-21 23:51:04 -0700 2011-08-22 16:24:33 -0700 Patch bug-66648-20110822165102.patch text/plain 3184 macpherson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzNDkzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDgtMjEgIEx1a2UgTWFj cGhlcnNvbiAgIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBJbXBsZW1lbnQg Y2FzdCBiZXR3ZWVuIENTU1ByaW1pdGl2ZVZhbHVlIGFuZCBFQmFja2ZhY2VWaXNpYmlsaXR5LCB1 c2UgaW4gQ1NTU3R5bGVTZWxlY3Rvcjo6YXBwbHlQcm9wZXJ0eS4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2NjQ4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIC8gbm8gZnVuY3Rpb25h bGl0eSBjaGFuZ2VkLgorCisgICAgICAgICogY3NzL0NTU1ByaW1pdGl2ZVZhbHVlTWFwcGluZ3Mu aDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1ByaW1pdGl2ZVZhbHVlOjpDU1NQcmltaXRpdmVWYWx1 ZSk6CisgICAgICAgIFN1cHBvcnQgY2FzdCBmcm9tIEVCYWNrZmFjZVZpc2liaWxpdHkuCisgICAg ICAgIChXZWJDb3JlOjpDU1NQcmltaXRpdmVWYWx1ZTo6b3BlcmF0b3IgRUJhY2tmYWNlVmlzaWJp bGl0eSk6CisgICAgICAgIFN1cHBvcnQgY2FzdCBmcm9tIEVCYWNrZmFjZVZpc2liaWxpdHkuCisg ICAgICAgICogY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NT U3R5bGVTZWxlY3Rvcjo6YXBwbHlQcm9wZXJ0eSk6CisgICAgICAgIFVzZSBIQU5ETEVfSU5IRVJJ VF9BTkRfSU5JVElBTF9BTkRfUFJJTUlUSVZFIG1hY3JvLgorCiAyMDExLTA4LTIxICBNYXJ0aW4g Um9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBGaXggJ21ha2UgZGlz dCcgZm9yIFdlYktpdEdUSysuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJpbWl0aXZl VmFsdWVNYXBwaW5ncy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmlt aXRpdmVWYWx1ZU1hcHBpbmdzLmgJKHJldmlzaW9uIDkzNDkzKQorKysgU291cmNlL1dlYkNvcmUv Y3NzL0NTU1ByaW1pdGl2ZVZhbHVlTWFwcGluZ3MuaAkod29ya2luZyBjb3B5KQpAQCAtNDU3LDYg KzQ1NywzNCBAQCB0ZW1wbGF0ZTw+IGlubGluZSBDU1NQcmltaXRpdmVWYWx1ZTo6b3BlCiAgICAg ICAgIHJldHVybiBDb250cm9sUGFydChtX3ZhbHVlLmlkZW50IC0gQ1NTVmFsdWVDaGVja2JveCAr IDEpOwogfQogCit0ZW1wbGF0ZTw+IGlubGluZSBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTUHJpbWl0 aXZlVmFsdWUoRUJhY2tmYWNlVmlzaWJpbGl0eSBlKQorICAgIDogbV90eXBlKENTU19JREVOVCkK KyAgICAsIG1faGFzQ2FjaGVkQ1NTVGV4dChmYWxzZSkKK3sKKyAgICBzd2l0Y2ggKGUpIHsKKyAg ICBjYXNlIEJhY2tmYWNlVmlzaWJpbGl0eVZpc2libGU6CisgICAgICAgIG1fdmFsdWUuaWRlbnQg PSBDU1NWYWx1ZVZpc2libGU7CisgICAgICAgIGJyZWFrOworICAgIGNhc2UgQmFja2ZhY2VWaXNp YmlsaXR5SGlkZGVuOgorICAgICAgICBtX3ZhbHVlLmlkZW50ID0gQ1NTVmFsdWVIaWRkZW47Cisg ICAgICAgIGJyZWFrOworICAgIH0KK30KKwordGVtcGxhdGU8PiBpbmxpbmUgQ1NTUHJpbWl0aXZl VmFsdWU6Om9wZXJhdG9yIEVCYWNrZmFjZVZpc2liaWxpdHkoKSBjb25zdAoreworICAgIHN3aXRj aCAobV92YWx1ZS5pZGVudCkgeworICAgIGNhc2UgQ1NTVmFsdWVWaXNpYmxlOgorICAgICAgICBy ZXR1cm4gQmFja2ZhY2VWaXNpYmlsaXR5VmlzaWJsZTsKKyAgICBjYXNlIENTU1ZhbHVlSGlkZGVu OgorICAgICAgICByZXR1cm4gQmFja2ZhY2VWaXNpYmlsaXR5SGlkZGVuOworICAgIGRlZmF1bHQ6 CisgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgICAgICByZXR1cm4gQmFja2ZhY2VW aXNpYmlsaXR5SGlkZGVuOworICAgIH0KK30KKworCiB0ZW1wbGF0ZTw+IGlubGluZSBDU1NQcmlt aXRpdmVWYWx1ZTo6Q1NTUHJpbWl0aXZlVmFsdWUoRUZpbGxBdHRhY2htZW50IGUpCiAgICAgOiBt X3R5cGUoQ1NTX0lERU5UKQogICAgICwgbV9oYXNDYWNoZWRDU1NUZXh0KGZhbHNlKQpJbmRleDog U291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAkocmV2aXNpb24gOTM0OTMpCisr KyBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTQ0ODMsOSArNDQ4Myw3IEBAIHZvaWQgQ1NTU3R5bGVTZWxlY3Rvcjo6YXBwbHlQcm9wZXJ0 eShpbnQKICAgICBjYXNlIENTU1Byb3BlcnR5VW5pY29kZVJhbmdlOiAvLyBPbmx5IHVzZWQgaW4g QGZvbnQtZmFjZSBydWxlcy4KICAgICAgICAgcmV0dXJuOwogICAgIGNhc2UgQ1NTUHJvcGVydHlX ZWJraXRCYWNrZmFjZVZpc2liaWxpdHk6Ci0gICAgICAgIEhBTkRMRV9JTkhFUklUX0FORF9JTklU SUFMKGJhY2tmYWNlVmlzaWJpbGl0eSwgQmFja2ZhY2VWaXNpYmlsaXR5KQotICAgICAgICBpZiAo cHJpbWl0aXZlVmFsdWUpCi0gICAgICAgICAgICBtX3N0eWxlLT5zZXRCYWNrZmFjZVZpc2liaWxp dHkoKHByaW1pdGl2ZVZhbHVlLT5nZXRJZGVudCgpID09IENTU1ZhbHVlVmlzaWJsZSkgPyBCYWNr ZmFjZVZpc2liaWxpdHlWaXNpYmxlIDogQmFja2ZhY2VWaXNpYmlsaXR5SGlkZGVuKTsKKyAgICAg ICAgSEFORExFX0lOSEVSSVRfQU5EX0lOSVRJQUxfQU5EX1BSSU1JVElWRShiYWNrZmFjZVZpc2li aWxpdHksIEJhY2tmYWNlVmlzaWJpbGl0eSkKICAgICAgICAgcmV0dXJuOwogICAgIGNhc2UgQ1NT UHJvcGVydHlXZWJraXRCb3hEaXJlY3Rpb246CiAgICAgICAgIEhBTkRMRV9JTkhFUklUX0FORF9J TklUSUFMX0FORF9QUklNSVRJVkUoYm94RGlyZWN0aW9uLCBCb3hEaXJlY3Rpb24pCg==