66638 2011-08-21 22:27:56 -0700 Range::setEnd(const Position&, ExceptionCode) calls setStart() instead of setEnd() 2011-08-22 19:07:20 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 65900 1 aboxhall aboxhall rniwa webkit.review.bot oldest_to_newest 454451 0 aboxhall 2011-08-21 22:27:56 -0700 Range::setEnd, introduced in bug 64403, incorrectly calls setStart(PassRefPtr<Node> refNode, int offset, ExceptionCode& ec) instead of the equivalent setEnd() method. 454453 1 104640 aboxhall 2011-08-21 22:30:52 -0700 Created attachment 104640 Patch 454631 2 104640 rniwa 2011-08-22 09:34:36 -0700 Comment on attachment 104640 Patch Oops, that was careless. Thanks for fixing it. 454657 3 104640 rniwa 2011-08-22 10:19:54 -0700 Comment on attachment 104640 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104640&action=review > Source/WebCore/ChangeLog:8 > + Relevant layout test coming in a future patch (see https://bugs.webkit.org/show_bug.cgi?id=65900) The patch for this bug doesn't appear to use setEnd. Maybe a wrong bug number? 455022 4 aboxhall 2011-08-22 15:54:14 -0700 (In reply to comment #3) > (From update of attachment 104640 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=104640&action=review > > > Source/WebCore/ChangeLog:8 > > + Relevant layout test coming in a future patch (see https://bugs.webkit.org/show_bug.cgi?id=65900) > > The patch for this bug doesn't appear to use setEnd. Maybe a wrong bug number? The patch doesn't, but the surrounding code does, in AccessibilityRenderObject::indexForVisiblePosition(const VisiblePosition&). The test for this patch exercises this code (which is how I found this bug in the first place). 455024 5 aboxhall 2011-08-22 15:55:10 -0700 (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 104640 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=104640&action=review > > > > > Source/WebCore/ChangeLog:8 > > > + Relevant layout test coming in a future patch (see https://bugs.webkit.org/show_bug.cgi?id=65900) > > > > The patch for this bug doesn't appear to use setEnd. Maybe a wrong bug number? > > The patch doesn't, but the surrounding code does, in AccessibilityRenderObject::indexForVisiblePosition(const VisiblePosition&). The test for this patch exercises this code (which is how I found this bug in the first place). Oh, and that patch is out of date; I was waiting for this fix before I updated it, but now I realise that's unnecessary, so I'll update it now. 455150 6 104640 webkit.review.bot 2011-08-22 19:07:16 -0700 Comment on attachment 104640 Patch Clearing flags on attachment: 104640 Committed r93574: <http://trac.webkit.org/changeset/93574> 455151 7 webkit.review.bot 2011-08-22 19:07:20 -0700 All reviewed patches have been landed. Closing bug. 104640 2011-08-21 22:30:52 -0700 2011-08-22 19:07:16 -0700 Patch bug-66638-20110822153049.patch text/plain 1465 aboxhall U3VidmVyc2lvbiBSZXZpc2lvbjogOTM0OTIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4MDUyNDQ3NGU4ZDIzYjFh MDJmOWM3MTEzMTdjY2IzM2E3YmIyNjJjLi44ZjQ1MWQ3M2MyZWQ1ZDczOTlhNzY4Yjc5MDU0MDE1 Mzk0MGZjMzAzIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDgtMjEgIEFsaWNl IEJveGhhbGwgIDxhYm94aGFsbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmFuZ2U6OnNldEVu ZChjb25zdCBQb3NpdGlvbiYsIEV4Y2VwdGlvbkNvZGUpIGNhbGxzIHNldFN0YXJ0KCkgaW5zdGVh ZCBvZiBzZXRFbmQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NjY2MzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBSZWxldmFudCBsYXlvdXQgdGVzdCBjb21pbmcgaW4gYSBmdXR1cmUgcGF0Y2ggKHNlZSBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjU5MDApCisKKyAgICAgICAg KiBkb20vUmFuZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmFuZ2U6OnNldEVuZCk6CisKIDIw MTEtMDgtMjEgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAgICAg ICAgIEZpeCAnbWFrZSBkaXN0JyBmb3IgV2ViS2l0R1RLKy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2RvbS9SYW5nZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vUmFuZ2UuY3BwCmluZGV4 IDkxZDIyYjk3ZDk0NjBjMThhM2RkZTNhYTUyN2ViZDg5YzRkOTc5OTEuLmUxODA2NmU4YWU5ZGU1 MWVkODJmZTRjODE2ZDc3ZmM2ZmFkMzNmOWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9SYW5nZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL1JhbmdlLmNwcApAQCAtMjgzLDcg KzI4Myw3IEBAIHZvaWQgUmFuZ2U6OnNldFN0YXJ0KGNvbnN0IFBvc2l0aW9uJiBzdGFydCwgRXhj ZXB0aW9uQ29kZSYgZWMpCiB2b2lkIFJhbmdlOjpzZXRFbmQoY29uc3QgUG9zaXRpb24mIGVuZCwg RXhjZXB0aW9uQ29kZSYgZWMpCiB7CiAgICAgUG9zaXRpb24gcGFyZW50QW5jaG9yZWQgPSBlbmQu cGFyZW50QW5jaG9yZWRFcXVpdmFsZW50KCk7Ci0gICAgc2V0U3RhcnQocGFyZW50QW5jaG9yZWQu Y29udGFpbmVyTm9kZSgpLCBwYXJlbnRBbmNob3JlZC5vZmZzZXRJbkNvbnRhaW5lck5vZGUoKSwg ZWMpOworICAgIHNldEVuZChwYXJlbnRBbmNob3JlZC5jb250YWluZXJOb2RlKCksIHBhcmVudEFu Y2hvcmVkLm9mZnNldEluQ29udGFpbmVyTm9kZSgpLCBlYyk7CiB9CiAKIHZvaWQgUmFuZ2U6OmNv bGxhcHNlKGJvb2wgdG9TdGFydCwgRXhjZXB0aW9uQ29kZSYgZWMpCg==