66636 2011-08-21 18:03:44 -0700 FrameSelection::setNonDirectionalSelectionIfNeeded should not have a FrameSelection passed to it 2011-08-22 13:06:08 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Minor --- 0 wcarss webkit-unassigned rniwa webkit.review.bot oldest_to_newest 454428 0 wcarss 2011-08-21 18:03:44 -0700 FrameSelection::setNonDirectionalSelectionIfNeeded (FrameSelection.cpp:166) was moved from EventHandler.cpp in r93134, but still has a FrameSelection argument. It should be removed. 454430 1 104632 wcarss 2011-08-21 18:08:59 -0700 Created attachment 104632 Patch 454830 2 104632 webkit.review.bot 2011-08-22 13:06:04 -0700 Comment on attachment 104632 Patch Clearing flags on attachment: 104632 Committed r93531: <http://trac.webkit.org/changeset/93531> 454831 3 webkit.review.bot 2011-08-22 13:06:08 -0700 All reviewed patches have been landed. Closing bug. 104632 2011-08-21 18:08:59 -0700 2011-08-22 13:06:04 -0700 Patch bug-66636-20110821180858.patch text/plain 4467 wcarss U3VidmVyc2lvbiBSZXZpc2lvbjogOTM0OTEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmYjYzZjBhY2ZjNWRmMzE0 OTRjYjIzMjAxNDIwZWVmMzE5OGE3MTc4Li5iYzMzNjI3NWRlNGIzMjBkYmY5NTgyMDAyODU4MmQ1 MmJiY2RiZjVhIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDgtMjEgIFd5YXR0 IENhcnNzICA8d2NhcnNzQGNocm9taXVtLm9yZz4KKworICAgICAgICBGcmFtZVNlbGVjdGlvbjo6 c2V0Tm9uRGlyZWN0aW9uYWxTZWxlY3Rpb25JZk5lZWRlZCBzaG91bGQgbm90IGhhdmUgYSBGcmFt ZVNlbGVjdGlvbiBwYXNzZWQgdG8gaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTY2NjM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgc2V0Tm9uRGlyZWN0aW9uYWxTZWxlY3Rpb24gd2FzIG1vdmVkIGludG8g RnJhbWVTZWxlY3Rpb24gaW4gcjkzMTM0IGZvciAKKyAgICAgICAgYnVnIDYwNTI5LCBhbmQgc3Rp bGwgdG9vayBhIEZyYW1lU2VsZWN0aW9uIGFzIGFuIGFyZ3VtZW50LCB3aGljaCBoYXMgYmVlbiBy ZW1vdmVkLgorCisgICAgICAgICogZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5jcHA6CisgICAgICAg IChXZWJDb3JlOjpGcmFtZVNlbGVjdGlvbjo6c2V0Tm9uRGlyZWN0aW9uYWxTZWxlY3Rpb25JZk5l ZWRlZCk6CisKIDIwMTEtMDgtMjAgIE5lYm9qc2EgQ2lyaWMgIDxjaXJhQGNocm9taXVtLm9yZz4K IAogICAgICAgICBQb2ludCBidWlsZCBzeXN0ZW0gYW5kICNpbmNsdWRlIGhlYWRlcnMgdG8gdjgt aTE4biBsaWJyYXJ5IGluc3RlYWQgb2YgdjggbGlicmFyeS4KQEAgLTIyLDcgKzM1LDcgQEAKICAg ICAgICAgQWRkIEhUTUxTb3VyY2VFbGVtZW50IHRvIERPTVdpbmRvdy5pZGwgZm9yIGNvbnNpc3Rl bmN5LiAgQ29uc3RydWN0b3JzIGZvcgogICAgICAgICBhbGwgZWxlbWVudHMgc2hvdWxkIGJlIGF2 YWlsYWJsZSBvbiBET01XaW5kb3cuCiAKLSAgICAgICAgICogYmluZGluZ3MvZ2VuZXJpYy9SdW50 aW1lRW5hYmxlZEZlYXR1cmVzLmNwcDoKKyAgICAgICAgKiBiaW5kaW5ncy9nZW5lcmljL1J1bnRp bWVFbmFibGVkRmVhdHVyZXMuY3BwOgogICAgICAgICAoV2ViQ29yZTo6UnVudGltZUVuYWJsZWRG ZWF0dXJlczo6aHRtbFNvdXJjZUVsZW1lbnRFbmFibGVkKToKICAgICAgICAgKiBiaW5kaW5ncy9n ZW5lcmljL1J1bnRpbWVFbmFibGVkRmVhdHVyZXMuaDoKICAgICAgICAgKiBwYWdlL0RPTVdpbmRv dy5pZGw6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0ZyYW1lU2VsZWN0aW9u LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxlY3Rpb24uY3BwCmluZGV4IDAz N2Y4YjZkOGNlNWM1ZTYxMTQwYTUzZWViNjBlNjBkYjQ1NDliOTQuLjE4ZmU5ZWY0YmExYmM1MGJj NDg4MzVlNTI5MzI1Y2ZjMTlmYmMwZTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRp bmcvRnJhbWVTZWxlY3Rpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVT ZWxlY3Rpb24uY3BwCkBAIC0xNjMsMTUgKzE2MywxNCBAQCB2b2lkIERyYWdDYXJldENvbnRyb2xs ZXI6OnNldENhcmV0UG9zaXRpb24oY29uc3QgVmlzaWJsZVBvc2l0aW9uJiBwb3NpdGlvbikKICAg ICAgICAgdXBkYXRlQ2FyZXRSZWN0KGRvY3VtZW50LCBtX3Bvc2l0aW9uKTsKIH0KIAotdm9pZCBG cmFtZVNlbGVjdGlvbjo6c2V0Tm9uRGlyZWN0aW9uYWxTZWxlY3Rpb25JZk5lZWRlZChGcmFtZVNl bGVjdGlvbiogc2VsZWN0aW9uLCBjb25zdCBWaXNpYmxlU2VsZWN0aW9uJiBwYXNzZWROZXdTZWxl Y3Rpb24sIFRleHRHcmFudWxhcml0eSBncmFudWxhcml0eSkKK3ZvaWQgRnJhbWVTZWxlY3Rpb246 OnNldE5vbkRpcmVjdGlvbmFsU2VsZWN0aW9uSWZOZWVkZWQoY29uc3QgVmlzaWJsZVNlbGVjdGlv biYgcGFzc2VkTmV3U2VsZWN0aW9uLCBUZXh0R3JhbnVsYXJpdHkgZ3JhbnVsYXJpdHkpCiB7Ci0g ICAgQVNTRVJUKHNlbGVjdGlvbik7CiAgICAgVmlzaWJsZVNlbGVjdGlvbiBuZXdTZWxlY3Rpb24g PSBwYXNzZWROZXdTZWxlY3Rpb247CiAKICAgICBpZiAoc2hvdWxkQWx3YXlzVXNlRGlyZWN0aW9u YWxTZWxlY3Rpb24obV9mcmFtZSkpCiAgICAgICAgIG5ld1NlbGVjdGlvbi5zZXRJc0RpcmVjdGlv bmFsKHRydWUpOwogCi0gICAgaWYgKHNlbGVjdGlvbi0+c2VsZWN0aW9uKCkgPT0gbmV3U2VsZWN0 aW9uIHx8ICFzZWxlY3Rpb24tPnNob3VsZENoYW5nZVNlbGVjdGlvbihuZXdTZWxlY3Rpb24pKQor ICAgIGlmIChtX3NlbGVjdGlvbiA9PSBuZXdTZWxlY3Rpb24gfHwgIXNob3VsZENoYW5nZVNlbGVj dGlvbihuZXdTZWxlY3Rpb24pKQogICAgICAgICByZXR1cm47CiAKICAgICBzZXRTZWxlY3Rpb24o bmV3U2VsZWN0aW9uLCBncmFudWxhcml0eSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9l ZGl0aW5nL0ZyYW1lU2VsZWN0aW9uLmggYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0ZyYW1lU2Vs ZWN0aW9uLmgKaW5kZXggZmI3M2MwZTFjYzJiZjE5MGI5MzhjNDJkNGJhMGZiZWRkNDczODQxNi4u OTYxOWRmNTc0NDhiZWRlNzQwMGQ1OWJkZjAzYTAxZmI5ZTM0YmVjMyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2VkaXRpbmcvRnJhbWVTZWxlY3Rpb24uaApAQCAtMjIzLDcgKzIyMyw3IEBAIHB1YmxpYzoKIAog ICAgIGJvb2wgc2hvdWxkQ2hhbmdlU2VsZWN0aW9uKGNvbnN0IFZpc2libGVTZWxlY3Rpb24mKSBj b25zdDsKICAgICBib29sIHNob3VsZERlbGV0ZVNlbGVjdGlvbihjb25zdCBWaXNpYmxlU2VsZWN0 aW9uJikgY29uc3Q7Ci0gICAgdm9pZCBzZXROb25EaXJlY3Rpb25hbFNlbGVjdGlvbklmTmVlZGVk KEZyYW1lU2VsZWN0aW9uKiwgY29uc3QgVmlzaWJsZVNlbGVjdGlvbiYsIFRleHRHcmFudWxhcml0 eSk7CisgICAgdm9pZCBzZXROb25EaXJlY3Rpb25hbFNlbGVjdGlvbklmTmVlZGVkKGNvbnN0IFZp c2libGVTZWxlY3Rpb24mLCBUZXh0R3JhbnVsYXJpdHkpOwogICAgIHZvaWQgc2V0Rm9jdXNlZE5v ZGVJZk5lZWRlZCgpOwogICAgIHZvaWQgbm90aWZ5UmVuZGVyZXJPZlNlbGVjdGlvbkNoYW5nZShF VXNlclRyaWdnZXJlZCk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRI YW5kbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAppbmRleCA4 MmRhMjBkMzExMDJjYmMzMDRiYzZiY2ViNmE2ODg0ZGY4ZTM2N2JlLi4wOGZkMjc3NDMyNDI3M2Jl ZWRiMTgzYTc4YjUzYjQ0MDExYTRiNTJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdl L0V2ZW50SGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIu Y3BwCkBAIC0yODcsNyArMjg3LDcgQEAgYm9vbCBFdmVudEhhbmRsZXI6OnVwZGF0ZVNlbGVjdGlv bkZvck1vdXNlRG93bkRpc3BhdGNoaW5nU2VsZWN0U3RhcnQoTm9kZSogdGFyZ2UKICAgICAgICAg bV9zZWxlY3Rpb25Jbml0aWF0aW9uU3RhdGUgPSBQbGFjZWRDYXJldDsKICAgICB9CiAKLSAgICBt X2ZyYW1lLT5zZWxlY3Rpb24oKS0+c2V0Tm9uRGlyZWN0aW9uYWxTZWxlY3Rpb25JZk5lZWRlZCht X2ZyYW1lLT5zZWxlY3Rpb24oKSwgbmV3U2VsZWN0aW9uLCBncmFudWxhcml0eSk7CisgICAgbV9m cmFtZS0+c2VsZWN0aW9uKCktPnNldE5vbkRpcmVjdGlvbmFsU2VsZWN0aW9uSWZOZWVkZWQobmV3 U2VsZWN0aW9uLCBncmFudWxhcml0eSk7CiAKICAgICByZXR1cm4gdHJ1ZTsKIH0KQEAgLTY5MCw3 ICs2OTAsNyBAQCB2b2lkIEV2ZW50SGFuZGxlcjo6dXBkYXRlU2VsZWN0aW9uRm9yTW91c2VEcmFn KGNvbnN0IEhpdFRlc3RSZXN1bHQmIGhpdFRlc3RSZXN1bAogICAgIGlmIChtX2ZyYW1lLT5zZWxl Y3Rpb24oKS0+Z3JhbnVsYXJpdHkoKSAhPSBDaGFyYWN0ZXJHcmFudWxhcml0eSkKICAgICAgICAg bmV3U2VsZWN0aW9uLmV4cGFuZFVzaW5nR3JhbnVsYXJpdHkobV9mcmFtZS0+c2VsZWN0aW9uKCkt PmdyYW51bGFyaXR5KCkpOwogCi0gICAgbV9mcmFtZS0+c2VsZWN0aW9uKCktPnNldE5vbkRpcmVj dGlvbmFsU2VsZWN0aW9uSWZOZWVkZWQobV9mcmFtZS0+c2VsZWN0aW9uKCksIG5ld1NlbGVjdGlv biwgbV9mcmFtZS0+c2VsZWN0aW9uKCktPmdyYW51bGFyaXR5KCkpOworICAgIG1fZnJhbWUtPnNl bGVjdGlvbigpLT5zZXROb25EaXJlY3Rpb25hbFNlbGVjdGlvbklmTmVlZGVkKG5ld1NlbGVjdGlv biwgbV9mcmFtZS0+c2VsZWN0aW9uKCktPmdyYW51bGFyaXR5KCkpOwogfQogI2VuZGlmIC8vIEVO QUJMRShEUkFHX1NVUFBPUlQpCiAK