66635 2011-08-21 16:15:30 -0700 [Qt] Button text is invisible when mobile theme is in use and application palette set to use light text color. 2011-08-23 16:12:44 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All Unspecified RESOLVED FIXED Qt P3 Normal --- 1 mtutunik mtutunik kling webkit.review.bot oldest_to_newest 454424 0 mtutunik 2011-08-21 16:15:30 -0700 When mobile theme is in use and application pallete is using light color to display text button text become invisible. The reason for that is that in RenderThemeQt::systemFont() we are using application pallete while when are painting button lightGrayPalette is used. 454425 1 104631 mtutunik 2011-08-21 16:25:55 -0700 Created attachment 104631 proposed patch. Calling setPaletteFromPageClientIfExists() takes care about the issue. 454524 2 104631 kling 2011-08-22 04:07:10 -0700 Comment on attachment 104631 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=104631&action=review LGTM. It's a shame we don't test the mobile theme on the bots, though. > Source/WebCore/ChangeLog:7 > + When mobile theme is in use and application pallete is using light pallete -> palette > Source/WebCore/ChangeLog:8 > + color to display text button text become invisible. The reason for "text button text become" -> "text, button text becomes" > Source/WebCore/ChangeLog:10 > + pallete while when are painting button lightGrayPalette is used. pallete -> palette "when are painting button" -> "when we are painting buttons" > Source/WebCore/ChangeLog:11 > + Calling setPaletteFromPageClientIfExists() takes care about the issue. about -> of 454813 3 104717 mtutunik 2011-08-22 12:47:39 -0700 Created attachment 104717 patch with corrected change log 454823 4 104717 kenneth 2011-08-22 12:59:06 -0700 Comment on attachment 104717 patch with corrected change log This changelog is missing the Reviewed by part. 455602 5 104890 mtutunik 2011-08-23 12:28:18 -0700 Created attachment 104890 Corrected Change log again 455788 6 104890 webkit.review.bot 2011-08-23 16:12:40 -0700 Comment on attachment 104890 Corrected Change log again Clearing flags on attachment: 104890 Committed r93652: <http://trac.webkit.org/changeset/93652> 455789 7 webkit.review.bot 2011-08-23 16:12:44 -0700 All reviewed patches have been landed. Closing bug. 104631 2011-08-21 16:25:55 -0700 2011-08-22 12:47:39 -0700 proposed patch. button_text.patch text/plain 1708 mtutunik ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhODI4Y2VjLi5lZGYwNDMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTEtMDgtMjEgIE1pc2hhIFR5dXR5dW5payAgPG1pY2hhZWwudHl1dHl1bmlrQG5va2lh LmNvbT4KKworICAgICAgICBbUXRdIEJ1dHRvbiB0ZXh0IGlzIGludmlzaWJsZSB3aGVuIG1vYmls ZSB0aGVtZSBpcyBpbiB1c2UgYW5kIAorICAgICAgICBhcHBsaWNhdGlvbiBwYWxldHRlIHNldCB0 byB1c2UgbGlnaHQgdGV4dCBjb2xvci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTY2NjM1CisKKyAgICAgICAgV2hlbiBtb2JpbGUgdGhlbWUgaXMgaW4g dXNlIGFuZCBhcHBsaWNhdGlvbiBwYWxsZXRlIGlzIHVzaW5nIGxpZ2h0IAorICAgICAgICBjb2xv ciB0byBkaXNwbGF5IHRleHQgYnV0dG9uIHRleHQgYmVjb21lIGludmlzaWJsZS4gVGhlIHJlYXNv biBmb3IgCisgICAgICAgIHRoYXQgaXMgdGhhdCBpbiBSZW5kZXJUaGVtZVF0OjpzeXN0ZW1Gb250 KCkgd2UgYXJlIHVzaW5nIGFwcGxpY2F0aW9uIAorICAgICAgICBwYWxsZXRlIHdoaWxlIHdoZW4g YXJlIHBhaW50aW5nIGJ1dHRvbiBsaWdodEdyYXlQYWxldHRlIGlzIHVzZWQuCisgICAgICAgIENh bGxpbmcgc2V0UGFsZXR0ZUZyb21QYWdlQ2xpZW50SWZFeGlzdHMoKSB0YWtlcyBjYXJlIGFib3V0 IHRoZSBpc3N1ZS4KKyAgICAgICAgCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9xdC9SZW5kZXJUaGVtZVF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1l UXQ6OnN5c3RlbUNvbG9yKToKKwogMjAxMS0wOC0xNiAgSm9zZXBoIFBlY29yYXJvICA8am9lcGVj a0B3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgQ2hyb21pdW0gV2luZG93cyBidWls ZCBmaXggYWZ0ZXIgcjkzMTQwLiBUYWtlIDQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9xdC9SZW5kZXJUaGVtZVF0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0 L1JlbmRlclRoZW1lUXQuY3BwCmluZGV4IGRhNWYxZDIuLmI0NmIxOGQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1JlbmRlclRoZW1lUXQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL3F0L1JlbmRlclRoZW1lUXQuY3BwCkBAIC00MzgsNiArNDM4LDcgQEAg dm9pZCBSZW5kZXJUaGVtZVF0OjpzeXN0ZW1Gb250KGludCwgRm9udERlc2NyaXB0aW9uJikgY29u c3QKIENvbG9yIFJlbmRlclRoZW1lUXQ6OnN5c3RlbUNvbG9yKGludCBjc3NWYWx1ZUlkKSBjb25z dAogewogICAgIFFQYWxldHRlIHBhbCA9IFFBcHBsaWNhdGlvbjo6cGFsZXR0ZSgpOworICAgIHNl dFBhbGV0dGVGcm9tUGFnZUNsaWVudElmRXhpc3RzKHBhbCk7CiAgICAgc3dpdGNoIChjc3NWYWx1 ZUlkKSB7CiAgICAgY2FzZSBDU1NWYWx1ZUJ1dHRvbnRleHQ6CiAgICAgICAgIHJldHVybiBwYWwu YnJ1c2goUVBhbGV0dGU6OkFjdGl2ZSwgUVBhbGV0dGU6OkJ1dHRvblRleHQpLmNvbG9yKCk7Cg== 104717 2011-08-22 12:47:39 -0700 2011-08-23 12:28:18 -0700 patch with corrected change log button_text.patch text/plain 1630 mtutunik ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3MmVkODNmLi40NzdmYjM1IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTEtMDgtMjIgIE1pc2hhIFR5dXR5dW5payAgPG1pY2hhZWwudHl1dHl1bmlrQG5va2lh LmNvbT4KKworICAgICAgICBbUXRdIEJ1dHRvbiB0ZXh0IGlzIGludmlzaWJsZSB3aGVuIG1vYmls ZSB0aGVtZSBpcyBpbiB1c2UgYW5kIGFwcGxpY2F0aW9uIHBhbGV0dGUgc2V0IHRvIHVzZSBsaWdo dCB0ZXh0IGNvbG9yLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NjY2MzUKKworICAgICAgICBXaGVuIG1vYmlsZSB0aGVtZSBpcyBpbiB1c2UgYW5kIGFw cGxpY2F0aW9uIHBhbGV0dGUgaXMgdXNpbmcgbGlnaHQgCisgICAgICAgIGNvbG9yIHRvIGRpc3Bs YXkgdGV4dCBidXR0b24gdGV4dCBiZWNvbWVzIGludmlzaWJsZS4gVGhlIHJlYXNvbiBmb3IgCisg ICAgICAgIHRoYXQgaXMgdGhhdCBpbiBSZW5kZXJUaGVtZVF0OjpzeXN0ZW1Gb250KCkgd2UgYXJl IHVzaW5nIGFwcGxpY2F0aW9uIAorICAgICAgICBwYWxsZXRlIHdoaWxlIHdoZW4gYXJlIHBhaW50 aW5nIGJ1dHRvbnMgbGlnaHRHcmF5UGFsZXR0ZSBpcyB1c2VkLgorICAgICAgICBDYWxsaW5nIHNl dFBhbGV0dGVGcm9tUGFnZUNsaWVudElmRXhpc3RzKCkgdGFrZXMgY2FyZSBvZiB0aGUgaXNzdWUu CisgICAgICAgIAorICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAg ICogcGxhdGZvcm0vcXQvUmVuZGVyVGhlbWVRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5k ZXJUaGVtZVF0OjpzeXN0ZW1Db2xvcik6CisKIDIwMTEtMDgtMjIgIFRvbnkgQ2hhbmcgIDx0b255 QGNocm9taXVtLm9yZz4KIAogICAgICAgICBBZGQgQ1NTIHBhcnNpbmcgb2YgLXdlYmtpdC1mbGV4 LW9yZGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9SZW5kZXJUaGVt ZVF0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1JlbmRlclRoZW1lUXQuY3BwCmlu ZGV4IGRhNWYxZDIuLmI0NmIxOGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L3F0L1JlbmRlclRoZW1lUXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1Jl bmRlclRoZW1lUXQuY3BwCkBAIC00MzgsNiArNDM4LDcgQEAgdm9pZCBSZW5kZXJUaGVtZVF0Ojpz eXN0ZW1Gb250KGludCwgRm9udERlc2NyaXB0aW9uJikgY29uc3QKIENvbG9yIFJlbmRlclRoZW1l UXQ6OnN5c3RlbUNvbG9yKGludCBjc3NWYWx1ZUlkKSBjb25zdAogewogICAgIFFQYWxldHRlIHBh bCA9IFFBcHBsaWNhdGlvbjo6cGFsZXR0ZSgpOworICAgIHNldFBhbGV0dGVGcm9tUGFnZUNsaWVu dElmRXhpc3RzKHBhbCk7CiAgICAgc3dpdGNoIChjc3NWYWx1ZUlkKSB7CiAgICAgY2FzZSBDU1NW YWx1ZUJ1dHRvbnRleHQ6CiAgICAgICAgIHJldHVybiBwYWwuYnJ1c2goUVBhbGV0dGU6OkFjdGl2 ZSwgUVBhbGV0dGU6OkJ1dHRvblRleHQpLmNvbG9yKCk7Cg== 104890 2011-08-23 12:28:18 -0700 2011-08-23 16:12:39 -0700 Corrected Change log again button_text.patch text/plain 1673 mtutunik ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5MjI4YWRhLi5kMjc3NzgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTEtMDgtMjMgIE1pc2hhIFR5dXR5dW5payAgPG1pY2hhZWwudHl1dHl1bmlrQG5va2lh LmNvbT4KKworICAgICAgICBbUXRdIEJ1dHRvbiB0ZXh0IGlzIGludmlzaWJsZSB3aGVuIG1vYmls ZSB0aGVtZSBpcyBpbiB1c2UgYW5kIGFwcGxpY2F0aW9uIHBhbGV0dGUgc2V0IHRvIHVzZSBsaWdo dCB0ZXh0IGNvbG9yLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NjY2MzUKKworICAgICAgICBXaGVuIG1vYmlsZSB0aGVtZSBpcyBpbiB1c2UgYW5kIGFw cGxpY2F0aW9uIHBhbGV0dGUgaXMgdXNpbmcgbGlnaHQgCisgICAgICAgIGNvbG9yIHRvIGRpc3Bs YXkgdGV4dCBidXR0b24gdGV4dCBiZWNvbWVzIGludmlzaWJsZS4gVGhlIHJlYXNvbiBmb3IgCisg ICAgICAgIHRoYXQgaXMgdGhhdCBpbiBSZW5kZXJUaGVtZVF0OjpzeXN0ZW1Gb250KCkgd2UgYXJl IHVzaW5nIGFwcGxpY2F0aW9uIAorICAgICAgICBwYWxsZXRlIHdoaWxlIHdoZW4gYXJlIHBhaW50 aW5nIGJ1dHRvbnMgbGlnaHRHcmF5UGFsZXR0ZSBpcyB1c2VkLgorICAgICAgICBDYWxsaW5nIHNl dFBhbGV0dGVGcm9tUGFnZUNsaWVudElmRXhpc3RzKCkgdGFrZXMgY2FyZSBvZiB0aGUgaXNzdWUu CisgICAgICAgIAorICAgICAgICBSZXZpZXdlZCBieSBBbmRyZWFzIEtsaW5nLgorCisgICAgICAg IENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9SZW5k ZXJUaGVtZVF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lUXQ6OnN5c3RlbUNv bG9yKToKKwogMjAxMS0wOC0yMyAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFp bC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjkzNjE2LgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvUmVuZGVyVGhlbWVRdC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9SZW5kZXJUaGVtZVF0LmNwcAppbmRleCBkYTVmMWQyLi5i NDZiMThkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9SZW5kZXJUaGVt ZVF0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9SZW5kZXJUaGVtZVF0LmNw cApAQCAtNDM4LDYgKzQzOCw3IEBAIHZvaWQgUmVuZGVyVGhlbWVRdDo6c3lzdGVtRm9udChpbnQs IEZvbnREZXNjcmlwdGlvbiYpIGNvbnN0CiBDb2xvciBSZW5kZXJUaGVtZVF0OjpzeXN0ZW1Db2xv cihpbnQgY3NzVmFsdWVJZCkgY29uc3QKIHsKICAgICBRUGFsZXR0ZSBwYWwgPSBRQXBwbGljYXRp b246OnBhbGV0dGUoKTsKKyAgICBzZXRQYWxldHRlRnJvbVBhZ2VDbGllbnRJZkV4aXN0cyhwYWwp OwogICAgIHN3aXRjaCAoY3NzVmFsdWVJZCkgewogICAgIGNhc2UgQ1NTVmFsdWVCdXR0b250ZXh0 OgogICAgICAgICByZXR1cm4gcGFsLmJydXNoKFFQYWxldHRlOjpBY3RpdmUsIFFQYWxldHRlOjpC dXR0b25UZXh0KS5jb2xvcigpOwo=