<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>66617</bug_id>
          
          <creation_ts>2011-08-19 18:24:06 -0700</creation_ts>
          <short_desc>Only #include &lt;signal.h&gt; and require SA_RESTART when building with JSC_MULTIPLE_THREADS</short_desc>
          <delta_ts>2011-08-19 19:59:26 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Daniel Bates">dbates</reporter>
          <assigned_to name="Daniel Bates">dbates</assigned_to>
          <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>454262</commentid>
    <comment_count>0</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2011-08-19 18:24:06 -0700</bug_when>
    <thetext>SA_RESTART is only applicable when building with JSC_MULTIPLE_THREADS enabled.

On QNX we use Pthreads and don&apos;t enable JSC_MULTIPLE_THREADS. Currently, we require a platform to have SA_RESTART support even when JSC_MULTIPLE_THREADS is disabled. But SA_RESTART support is only applicable when JSC_MULTIPLE_THREADS is enabled. Hence, we should only require SA_RESTART support when JSC_MULTIPLE_THREADS is enabled.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>454267</commentid>
    <comment_count>1</comment_count>
      <attachid>104607</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2011-08-19 18:38:51 -0700</bug_when>
    <thetext>Created attachment 104607
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>454286</commentid>
    <comment_count>2</comment_count>
      <attachid>104607</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-08-19 19:59:22 -0700</bug_when>
    <thetext>Comment on attachment 104607
Patch

Clearing flags on attachment: 104607

Committed r93467: &lt;http://trac.webkit.org/changeset/93467&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>454287</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-08-19 19:59:26 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>104607</attachid>
            <date>2011-08-19 18:38:51 -0700</date>
            <delta_ts>2011-08-19 19:59:22 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-66617-20110819183605.patch</filename>
            <type>text/plain</type>
            <size>1522</size>
            <attacher name="Daniel Bates">dbates</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTM0NjIpCisrKyBTb3VyY2Uv
SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAK
KzIwMTEtMDgtMTkgIERhbmllbCBCYXRlcyAgPGRiYXRlc0B3ZWJraXQub3JnPgorCisgICAgICAg
IE9ubHkgI2luY2x1ZGUgPHNpZ25hbC5oPiBhbmQgcmVxdWlyZSBTQV9SRVNUQVJUIHdoZW4gYnVp
bGRpbmcgd2l0aCBKU0NfTVVMVElQTEVfVEhSRUFEUworICAgICAgICBodHRwczovL2J1Z3Mud2Vi
a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY2MTcKKworICAgICAgICBCb3RoIDxzaWduYWwuaD4g
YW5kIFNBX1JFU1RBUlQgdXNhZ2UgYXJlIGd1YXJkZWQgYmVoaW5kIEVOQUJMRShKU0NfTVVMVElQ
TEVfVEhSRUFEUykuCisgICAgICAgIEJ1dCB3ZSBjYXVzZSBhIGNvbXBpbGUgZXJyb3IgaWYgdGhl
IHBsYXRmb3JtIGRvZXNuJ3Qgc3VwcG9ydCBTQV9SRVNUQVJUIHJlZ2FyZGxlc3Mgb2YKKyAgICAg
ICAgd2hldGhlciBKU0NfTVVMVElQTEVfVEhSRUFEUyBpcyBlbmFibGVkIGZvciB0aGUgcG9ydC4g
SW5zdGVhZCwgd2Ugc2hvdWxkbid0IHJlcXVpcmUKKyAgICAgICAgU0FfUkVTVEFSVCBzdXBwb3J0
IHVubGVzcyB3ZSBhcmUgYnVpbGRpbmcgd2l0aCBKU0NfTVVMVElQTEVfVEhSRUFEUyBlbmFibGVk
LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaGVh
cC9NYWNoaW5lU3RhY2tNYXJrZXIuY3BwOgorCiAyMDExLTA4LTE5ICBEYW5pZWwgQmF0ZXMgIDxk
YmF0ZXNAd2Via2l0Lm9yZz4KIAogICAgICAgICBJbXBsZW1lbnQgRXhlY3V0YWJsZUFsbG9jYXRv
cjo6Y2FjaGVGbHVzaCgpIGZvciBRTlgKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFw
L01hY2hpbmVTdGFja01hcmtlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD
b3JlL2hlYXAvTWFjaGluZVN0YWNrTWFya2VyLmNwcAkocmV2aXNpb24gOTM0NTYpCisrKyBTb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYWNoaW5lU3RhY2tNYXJrZXIuY3BwCSh3b3JraW5nIGNv
cHkpCkBAIC03Niw3ICs3Niw3IEBACiAjaW5jbHVkZSA8ZXJybm8uaD4KICNlbmRpZgogCi0jaWYg
VVNFKFBUSFJFQURTKSAmJiAhT1MoV0lORE9XUykgJiYgIU9TKERBUldJTikKKyNpZiBFTkFCTEUo
SlNDX01VTFRJUExFX1RIUkVBRFMpICYmIFVTRShQVEhSRUFEUykgJiYgIU9TKFdJTkRPV1MpICYm
ICFPUyhEQVJXSU4pCiAjaW5jbHVkZSA8c2lnbmFsLmg+CiAjaWZuZGVmIFNBX1JFU1RBUlQKICNl
cnJvciBNYWNoaW5lVGhyZWFkcyByZXF1aXJlcyBTQV9SRVNUQVJUCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>