66611 2011-08-19 17:10:01 -0700 Implement ExecutableAllocator::cacheFlush() for QNX 2011-08-19 18:17:37 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dbates dbates webkit.review.bot oldest_to_newest 454218 0 dbates 2011-08-19 17:10:01 -0700 Add definition of ExecutableAllocator::cacheFlush() for QNX 454220 1 104598 dbates 2011-08-19 17:17:52 -0700 Created attachment 104598 Patch 454222 2 webkit.review.bot 2011-08-19 17:19:26 -0700 Attachment 104598 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/jit/ExecutableAllocator.h:43: "sys/mman.h" already included at Source/JavaScriptCore/jit/ExecutableAllocator.h:39 [build/include] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 454231 3 104600 dbates 2011-08-19 17:30:18 -0700 Created attachment 104600 Patch 454236 4 104600 darin 2011-08-19 17:32:02 -0700 Comment on attachment 104600 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104600&action=review > Source/JavaScriptCore/jit/ExecutableAllocator.h:337 > + static void cacheFlush(void* code, size_t size) > + { > +#if !ENABLE(ASSEMBLER_WX_EXCLUSIVE) > + msync(code, size, MS_INVALIDATE_ICACHE); > +#endif > + } Looks like you’d get an unused variable warning if ENABLE(ASSEMBLER_WX_EXCLUSIVE) was true. 454242 5 dbates 2011-08-19 17:47:23 -0700 (In reply to comment #4) > (From update of attachment 104600 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=104600&action=review > > > Source/JavaScriptCore/jit/ExecutableAllocator.h:337 > > + static void cacheFlush(void* code, size_t size) > > + { > > +#if !ENABLE(ASSEMBLER_WX_EXCLUSIVE) > > + msync(code, size, MS_INVALIDATE_ICACHE); > > +#endif > > + } > > Looks like you’d get an unused variable warning if ENABLE(ASSEMBLER_WX_EXCLUSIVE) was true. Will fix. 454246 6 104602 dbates 2011-08-19 17:53:40 -0700 Created attachment 104602 Patch 454260 7 104602 webkit.review.bot 2011-08-19 18:17:32 -0700 Comment on attachment 104602 Patch Clearing flags on attachment: 104602 Committed r93462: <http://trac.webkit.org/changeset/93462> 454261 8 webkit.review.bot 2011-08-19 18:17:37 -0700 All reviewed patches have been landed. Closing bug. 104598 2011-08-19 17:17:52 -0700 2011-08-19 17:30:13 -0700 Patch bug-66611-20110819171507.patch text/plain 1447 dbates SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTM0NTcpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTEtMDgtMTkgIERhbmllbCBCYXRlcyAgPGRiYXRlc0B3ZWJraXQub3JnPgorCisgICAgICAg IEltcGxlbWVudCBFeGVjdXRhYmxlQWxsb2NhdG9yOjpjYWNoZUZsdXNoKCkgZm9yIFFOWAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY2MTEKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGppdC9FeGVjdXRh YmxlQWxsb2NhdG9yLmg6CisgICAgICAgIChKU0M6OkV4ZWN1dGFibGVBbGxvY2F0b3I6OmNhY2hl Rmx1c2gpOgorCiAyMDExLTA4LTE5ICBEYW5pZWwgQmF0ZXMgIDxkYmF0ZXNAd2Via2l0Lm9yZz4K IAogICAgICAgICBJbXBsZW1lbnQgV1RGOjphdG9taWN7SW5jcmVtZW50LCBEZWNyZW1lbnR9KCkg Zm9yIFFOWApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2Nh dG9yLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxl QWxsb2NhdG9yLmgJKHJldmlzaW9uIDkzNDU2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2pp dC9FeGVjdXRhYmxlQWxsb2NhdG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTM5LDYgKzM5LDEwIEBA CiAjaW5jbHVkZSA8c3lzL21tYW4uaD4KICNlbmRpZgogCisjaWYgT1MoUU5YKQorI2luY2x1ZGUg PHN5cy9tbWFuLmg+CisjZW5kaWYKKwogI2lmIE9TKFNZTUJJQU4pCiAjaW5jbHVkZSA8ZTMyc3Rk Lmg+CiAjZW5kaWYKQEAgLTMyNSw2ICszMjksMTMgQEAgcHVibGljOgogICAgICAgICBzeXNjYWxs KF9fTlJfY2FjaGVmbHVzaCwgcmVpbnRlcnByZXRfY2FzdDx1bnNpZ25lZD4oY29kZSksIHNpemUs IENBQ0hFRkxVU0hfRF9XQiB8IENBQ0hFRkxVU0hfSSk7CiAjZW5kaWYKICAgICB9CisjZWxpZiBP UyhRTlgpCisgICAgc3RhdGljIHZvaWQgY2FjaGVGbHVzaCh2b2lkKiBjb2RlLCBzaXplX3Qgc2l6 ZSkKKyAgICB7CisjaWYgIUVOQUJMRShBU1NFTUJMRVJfV1hfRVhDTFVTSVZFKQorICAgICAgICBt c3luYyhjb2RlLCBzaXplLCBNU19JTlZBTElEQVRFX0lDQUNIRSk7CisjZW5kaWYKKyAgICB9CiAj ZWxzZQogICAgICNlcnJvciAiVGhlIGNhY2hlRmx1c2ggc3VwcG9ydCBpcyBtaXNzaW5nIG9uIHRo aXMgcGxhdGZvcm0uIgogI2VuZGlmCg== 104600 2011-08-19 17:30:18 -0700 2011-08-19 17:53:35 -0700 Patch bug-66611-20110819172733.patch text/plain 1440 dbates SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTM0NTcpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTEtMDgtMTkgIERhbmllbCBCYXRlcyAgPGRiYXRlc0B3ZWJraXQub3JnPgorCisgICAgICAg IEltcGxlbWVudCBFeGVjdXRhYmxlQWxsb2NhdG9yOjpjYWNoZUZsdXNoKCkgZm9yIFFOWAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY2MTEKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGppdC9FeGVjdXRh YmxlQWxsb2NhdG9yLmg6CisgICAgICAgIChKU0M6OkV4ZWN1dGFibGVBbGxvY2F0b3I6OmNhY2hl Rmx1c2gpOgorCiAyMDExLTA4LTE5ICBEYW5pZWwgQmF0ZXMgIDxkYmF0ZXNAd2Via2l0Lm9yZz4K IAogICAgICAgICBJbXBsZW1lbnQgV1RGOjphdG9taWN7SW5jcmVtZW50LCBEZWNyZW1lbnR9KCkg Zm9yIFFOWApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2Nh dG9yLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxl QWxsb2NhdG9yLmgJKHJldmlzaW9uIDkzNDU2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2pp dC9FeGVjdXRhYmxlQWxsb2NhdG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTM2LDYgKzM2LDkgQEAK IAogI2lmIE9TKElPUykKICNpbmNsdWRlIDxsaWJrZXJuL09TQ2FjaGVDb250cm9sLmg+CisjZW5k aWYKKworI2lmIE9TKElPUykgfHwgT1MoUU5YKQogI2luY2x1ZGUgPHN5cy9tbWFuLmg+CiAjZW5k aWYKIApAQCAtMzI1LDYgKzMyOCwxMyBAQCBwdWJsaWM6CiAgICAgICAgIHN5c2NhbGwoX19OUl9j YWNoZWZsdXNoLCByZWludGVycHJldF9jYXN0PHVuc2lnbmVkPihjb2RlKSwgc2l6ZSwgQ0FDSEVG TFVTSF9EX1dCIHwgQ0FDSEVGTFVTSF9JKTsKICNlbmRpZgogICAgIH0KKyNlbGlmIE9TKFFOWCkK KyAgICBzdGF0aWMgdm9pZCBjYWNoZUZsdXNoKHZvaWQqIGNvZGUsIHNpemVfdCBzaXplKQorICAg IHsKKyNpZiAhRU5BQkxFKEFTU0VNQkxFUl9XWF9FWENMVVNJVkUpCisgICAgICAgIG1zeW5jKGNv ZGUsIHNpemUsIE1TX0lOVkFMSURBVEVfSUNBQ0hFKTsKKyNlbmRpZgorICAgIH0KICNlbHNlCiAg ICAgI2Vycm9yICJUaGUgY2FjaGVGbHVzaCBzdXBwb3J0IGlzIG1pc3Npbmcgb24gdGhpcyBwbGF0 Zm9ybS4iCiAjZW5kaWYK 104602 2011-08-19 17:53:40 -0700 2011-08-19 18:17:32 -0700 Patch bug-66611-20110819175055.patch text/plain 1505 dbates SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTM0NTgpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTEtMDgtMTkgIERhbmllbCBCYXRlcyAgPGRiYXRlc0B3ZWJraXQub3JnPgorCisgICAgICAg IEltcGxlbWVudCBFeGVjdXRhYmxlQWxsb2NhdG9yOjpjYWNoZUZsdXNoKCkgZm9yIFFOWAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY2MTEKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGppdC9FeGVjdXRh YmxlQWxsb2NhdG9yLmg6CisgICAgICAgIChKU0M6OkV4ZWN1dGFibGVBbGxvY2F0b3I6OmNhY2hl Rmx1c2gpOgorCiAyMDExLTA4LTE5ICBEYW5pZWwgQmF0ZXMgIDxkYmF0ZXNAd2Via2l0Lm9yZz4K IAogICAgICAgICBJbXBsZW1lbnQgV1RGOjphdG9taWN7SW5jcmVtZW50LCBEZWNyZW1lbnR9KCkg Zm9yIFFOWApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2Nh dG9yLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxl QWxsb2NhdG9yLmgJKHJldmlzaW9uIDkzNDU2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2pp dC9FeGVjdXRhYmxlQWxsb2NhdG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTM2LDYgKzM2LDkgQEAK IAogI2lmIE9TKElPUykKICNpbmNsdWRlIDxsaWJrZXJuL09TQ2FjaGVDb250cm9sLmg+CisjZW5k aWYKKworI2lmIE9TKElPUykgfHwgT1MoUU5YKQogI2luY2x1ZGUgPHN5cy9tbWFuLmg+CiAjZW5k aWYKIApAQCAtMzI1LDYgKzMyOCwxNiBAQCBwdWJsaWM6CiAgICAgICAgIHN5c2NhbGwoX19OUl9j YWNoZWZsdXNoLCByZWludGVycHJldF9jYXN0PHVuc2lnbmVkPihjb2RlKSwgc2l6ZSwgQ0FDSEVG TFVTSF9EX1dCIHwgQ0FDSEVGTFVTSF9JKTsKICNlbmRpZgogICAgIH0KKyNlbGlmIE9TKFFOWCkK KyAgICBzdGF0aWMgdm9pZCBjYWNoZUZsdXNoKHZvaWQqIGNvZGUsIHNpemVfdCBzaXplKQorICAg IHsKKyNpZiAhRU5BQkxFKEFTU0VNQkxFUl9XWF9FWENMVVNJVkUpCisgICAgICAgIG1zeW5jKGNv ZGUsIHNpemUsIE1TX0lOVkFMSURBVEVfSUNBQ0hFKTsKKyNlbHNlCisgICAgICAgIFVOVVNFRF9Q QVJBTShjb2RlKTsKKyAgICAgICAgVU5VU0VEX1BBUkFNKHNpemUpOworI2VuZGlmCisgICAgfQog I2Vsc2UKICAgICAjZXJyb3IgIlRoZSBjYWNoZUZsdXNoIHN1cHBvcnQgaXMgbWlzc2luZyBvbiB0 aGlzIHBsYXRmb3JtLiIKICNlbmRpZgo=