66599 2011-08-19 15:00:22 -0700 Chromium Mac: PDF: Scrollsbars should be visible when scrolling using the two finger gesture on Lion 2011-08-31 18:30:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sail sail fishd jam webkit.review.bot oldest_to_newest 454120 0 sail 2011-08-19 15:00:22 -0700 Chromium Mac: PDF: Scrollsbars should be visible when scrolling using the two finger gesture on Lion 454124 1 104578 sail 2011-08-19 15:04:44 -0700 Created attachment 104578 Patch 454134 2 sail 2011-08-19 15:14:39 -0700 This fixes the following chromium bug: http://code.google.com/p/chromium/issues/detail?id=92606 456241 3 sail 2011-08-24 11:24:07 -0700 Ping! 456585 4 104578 thakis 2011-08-24 18:13:51 -0700 Comment on attachment 104578 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104578&action=review > Source/WebKit/chromium/src/WebViewImpl.cpp:615 > + I'm not an expert in plugins, but I would've expected the flow to go "if plugin has touch focus, send to plugin, and only send to webview if plugin didn't handle it". Sending the event to two targets looks weird to me. But again, I'm probably not the right person to look at this. 459955 5 104578 sail 2011-08-31 14:51:20 -0700 Comment on attachment 104578 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104578&action=review >> Source/WebKit/chromium/src/WebViewImpl.cpp:615 >> + > > I'm not an expert in plugins, but I would've expected the flow to go "if plugin has touch focus, send to plugin, and only send to webview if plugin didn't handle it". Sending the event to two targets looks weird to me. But again, I'm probably not the right person to look at this. Unfortunately this is not possible right now. Currently ScrollableArea::handleGestureEvent() just swallows all events. There's a TODO in EventHandler::handleGestureEvent() to add proper hit testing. I think once this is done it'll be possible to go back and do this. 459960 6 104578 fishd 2011-08-31 14:57:21 -0700 Comment on attachment 104578 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104578&action=review >>> Source/WebKit/chromium/src/WebViewImpl.cpp:615 >>> + >> >> I'm not an expert in plugins, but I would've expected the flow to go "if plugin has touch focus, send to plugin, and only send to webview if plugin didn't handle it". Sending the event to two targets looks weird to me. But again, I'm probably not the right person to look at this. > > Unfortunately this is not possible right now. Currently ScrollableArea::handleGestureEvent() just swallows all events. > > There's a TODO in EventHandler::handleGestureEvent() to add proper hit testing. I think once this is done it'll be possible to go back and do this. I agree with Nico. Dispatching the event to both targets seems kind of problematic. I also wonder why the EventHandler wouldn't just forward the event to the plugin if that is what it hits. 459971 7 104578 sail 2011-08-31 15:06:23 -0700 Comment on attachment 104578 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104578&action=review >>>> Source/WebKit/chromium/src/WebViewImpl.cpp:615 >>>> + >>> >>> I'm not an expert in plugins, but I would've expected the flow to go "if plugin has touch focus, send to plugin, and only send to webview if plugin didn't handle it". Sending the event to two targets looks weird to me. But again, I'm probably not the right person to look at this. >> >> Unfortunately this is not possible right now. Currently ScrollableArea::handleGestureEvent() just swallows all events. >> >> There's a TODO in EventHandler::handleGestureEvent() to add proper hit testing. I think once this is done it'll be possible to go back and do this. > > I agree with Nico. Dispatching the event to both targets seems kind of problematic. I also wonder why the EventHandler wouldn't just forward the event to the plugin if that is what it hits. The EventHandler doesn't do hit testing so it can't tell if the gesture was for the plugin or not. Safari does it the same way too so I think we can live with this for now. 460020 8 jam 2011-08-31 16:05:54 -0700 btw this looks good to me 460051 9 104578 fishd 2011-08-31 16:30:39 -0700 Comment on attachment 104578 Patch OK, is there a bug about cleaning this up? 460067 10 sail 2011-08-31 16:43:40 -0700 (In reply to comment #9) > (From update of attachment 104578 [details]) > OK, is there a bug about cleaning this up? I couldn't find one so I filed this bug: https://bugs.webkit.org/show_bug.cgi?id=67338 460141 11 104578 webkit.review.bot 2011-08-31 18:30:55 -0700 Comment on attachment 104578 Patch Clearing flags on attachment: 104578 Committed r94261: <http://trac.webkit.org/changeset/94261> 460142 12 webkit.review.bot 2011-08-31 18:30:59 -0700 All reviewed patches have been landed. Closing bug. 104578 2011-08-19 15:04:44 -0700 2011-08-31 18:30:55 -0700 Patch bug-66599-20110819150443.patch text/plain 4280 sail U3VidmVyc2lvbiBSZXZpc2lvbjogOTMzMjgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg Mzg1OWM3NjhkN2QxNTc2YTc1MzE1YTA4ZjU4OGNiOTliMDllNjVhYy4uMzliMzFjZDg5ZGI1YjM4 MGE3NzY5ZmMwMmQ4MTM3YzE1ZDhkZWQ5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwyMCBAQAorMjAxMS0wOC0xOSAgU2FpbGVzaCBBZ3Jhd2FsICA8c2FpbEBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgQ2hyb21pdW0gTWFjOiBQREY6IFNjcm9sbHNiYXJzIHNob3VsZCBi ZSB2aXNpYmxlIHdoZW4gc2Nyb2xsaW5nIHVzaW5nIHRoZSB0d28gZmluZ2VyIGdlc3R1cmUgb24g TGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY1 OTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPdmVy bGF5IHNjcm9sbGJhcnMgb3ZlciBhIHBkZiB3b3VsZG4ndCBzdGF5IHZpc2libGUgaWYgYSBnZXN0 dXJlIHdhcyBpbiBwcm9ncmVzcy4gTm9ybWFsbHkgd2UgdXNlIGEgYmVnaW5TY3JvbGxHZXN0dXJl IGFuZCBlbmRTY3JvbGxHZXN0dXJlIHRvIGtlZXAgdGhlIHNjcm9sbGJhcnMgdmlzaWJsZS4gVW5m b3J0dW5hdGVseSBQREZzIGRpZG4ndCBoYW5kbGUgZ2VzdHVyZSBldmVudHMgc28gd2UgZGlkbid0 IGdldCB0aGUgYmVnaW4vZW5kIGdlc3R1cmUgZXZlbnRzLgorCisgICAgICAgIFRoaXMgY2hhbmdl IHBpcGVzIGdlc3R1cmUgZXZlbnRzIHRvIFdlYlBsdWdpbkNvbnRhaW5lckltcGwgaWYgcG9zc2li bGUuIFRoaXMgZml4ZXMgdGhpcyBidWcuCisKKyAgICAgICAgKiBzcmMvV2ViUGx1Z2luQ29udGFp bmVySW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBsdWdpbkNvbnRhaW5lckltcGw6Omhh bmRsZUdlc3R1cmVFdmVudCk6CisgICAgICAgICogc3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwu aDoKKyAgICAgICAgKiBzcmMvV2ViVmlld0ltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJW aWV3SW1wbDo6Z2VzdHVyZUV2ZW50KToKKwogMjAxMS0wOC0xOCAgVG9ueSBDaGFuZyAgPHRvbnlA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmVydCByOTMyOTQsIGRvZXNuJ3QgY29tcGlsZSBv biBDaHJvbWl1bSBNYWMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJQbHVnaW5Db250YWluZXJJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YlBsdWdpbkNvbnRhaW5lckltcGwuY3BwCmluZGV4IDZjMzE5NzUyOWZiNzcyNzY0NTljMDA1OWZk MGJmZGRhYmJjM2VhOWUuLjE1M2ViZDU3ZjA0MzA4MzQwYWJhZWUyMmYxYTVmZGM3YzRlYjRkODAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5l ckltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBsdWdpbkNvbnRh aW5lckltcGwuY3BwCkBAIC03Niw2ICs3NiwxMCBAQAogI2luY2x1ZGUgIlVzZXJHZXN0dXJlSW5k aWNhdG9yLmgiCiAjaW5jbHVkZSAiV2hlZWxFdmVudC5oIgogCisjaWYgRU5BQkxFKEdFU1RVUkVf RVZFTlRTKQorI2luY2x1ZGUgIlBsYXRmb3JtR2VzdHVyZUV2ZW50LmgiCisjZW5kaWYKKwogI2lm IFdFQktJVF9VU0lOR19TS0lBCiAjaW5jbHVkZSAiUGxhdGZvcm1Db250ZXh0U2tpYS5oIgogI2Vu ZGlmCkBAIC00NzEsNiArNDc1LDE3IEBAIHZvaWQgV2ViUGx1Z2luQ29udGFpbmVySW1wbDo6d2ls bEVuZExpdmVSZXNpemUoKQogICAgICAgICBtX3Njcm9sbGJhckdyb3VwLT53aWxsRW5kTGl2ZVJl c2l6ZSgpOwogfQogCisjaWYgRU5BQkxFKEdFU1RVUkVfRVZFTlRTKQorYm9vbCBXZWJQbHVnaW5D b250YWluZXJJbXBsOjpoYW5kbGVHZXN0dXJlRXZlbnQoY29uc3QgV2ViQ29yZTo6UGxhdGZvcm1H ZXN0dXJlRXZlbnQmIGdlc3R1cmVFdmVudCkKK3sKKyAgICBpZiAobV9zY3JvbGxiYXJHcm91cCkg eworICAgICAgICBtX3Njcm9sbGJhckdyb3VwLT5oYW5kbGVHZXN0dXJlRXZlbnQoZ2VzdHVyZUV2 ZW50KTsKKyAgICAgICAgcmV0dXJuIHRydWU7CisgICAgfQorICAgIHJldHVybiBmYWxzZTsKK30K KyNlbmRpZgorCiAvLyBQcml2YXRlIG1ldGhvZHMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogCiBXZWJQbHVnaW5Db250YWluZXJJ bXBsOjpXZWJQbHVnaW5Db250YWluZXJJbXBsKFdlYkNvcmU6OkhUTUxQbHVnSW5FbGVtZW50KiBl bGVtZW50LCBXZWJQbHVnaW4qIHdlYlBsdWdpbikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuaCBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuaAppbmRleCA3NGU0OTI3NWUyMmQ5MjRm ZWYzMDE5Nzk0YTJkM2NiMjgwODU5MGU2Li42ZjIzYWZjNTA4NGJjZTMxNTg5NGRjNDRiMTZjOTFj MzYzMjhkMjZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVn aW5Db250YWluZXJJbXBsLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGx1 Z2luQ29udGFpbmVySW1wbC5oCkBAIC01MSw2ICs1MSwxMCBAQCBjbGFzcyBQbHVnaW5MYXllckNo cm9taXVtOwogY2xhc3MgUmVzb3VyY2VFcnJvcjsKIGNsYXNzIFJlc291cmNlUmVzcG9uc2U7CiBj bGFzcyBXaGVlbEV2ZW50OworCisjaWYgRU5BQkxFKEdFU1RVUkVfRVZFTlRTKQorY2xhc3MgUGxh dGZvcm1HZXN0dXJlRXZlbnQ7CisjZW5kaWYKIH0KIAogbmFtZXNwYWNlIFdlYktpdCB7CkBAIC0x MzQsNiArMTM4LDEwIEBAIHB1YmxpYzoKICAgICB2b2lkIHdpbGxTdGFydExpdmVSZXNpemUoKTsK ICAgICB2b2lkIHdpbGxFbmRMaXZlUmVzaXplKCk7CiAKKyNpZiBFTkFCTEUoR0VTVFVSRV9FVkVO VFMpCisgICAgYm9vbCBoYW5kbGVHZXN0dXJlRXZlbnQoY29uc3QgV2ViQ29yZTo6UGxhdGZvcm1H ZXN0dXJlRXZlbnQmKTsKKyNlbmRpZgorCiBwcml2YXRlOgogICAgIFdlYlBsdWdpbkNvbnRhaW5l ckltcGwoV2ViQ29yZTo6SFRNTFBsdWdJbkVsZW1lbnQqIGVsZW1lbnQsIFdlYlBsdWdpbiogd2Vi UGx1Z2luKTsKICAgICB+V2ViUGx1Z2luQ29udGFpbmVySW1wbCgpOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCmluZGV4IDJiZmJmNDdiNDFhYmM0Y2Q5YjlmMDQ3 OGU3OTlmNmVmNWI1NjAxM2YuLjE0M2QyMDAzMTczMDU5NTc3ZjAwN2I3Y2E2ODVjNzdlOTBmN2Iy NWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKQEAgLTYw Niw3ICs2MDYsMTQgQEAgYm9vbCBXZWJWaWV3SW1wbDo6bW91c2VXaGVlbChjb25zdCBXZWJNb3Vz ZVdoZWVsRXZlbnQmIGV2ZW50KQogYm9vbCBXZWJWaWV3SW1wbDo6Z2VzdHVyZUV2ZW50KGNvbnN0 IFdlYkdlc3R1cmVFdmVudCYgZXZlbnQpCiB7CiAgICAgUGxhdGZvcm1HZXN0dXJlRXZlbnRCdWls ZGVyIHBsYXRmb3JtRXZlbnQobWFpbkZyYW1lSW1wbCgpLT5mcmFtZVZpZXcoKSwgZXZlbnQpOwot ICAgIHJldHVybiBtYWluRnJhbWVJbXBsKCktPmZyYW1lKCktPmV2ZW50SGFuZGxlcigpLT5oYW5k bGVHZXN0dXJlRXZlbnQocGxhdGZvcm1FdmVudCk7CisgICAgYm9vbCBoYW5kbGVkID0gbWFpbkZy YW1lSW1wbCgpLT5mcmFtZSgpLT5ldmVudEhhbmRsZXIoKS0+aGFuZGxlR2VzdHVyZUV2ZW50KHBs YXRmb3JtRXZlbnQpOworCisgICAgRnJhbWUqIGZyYW1lID0gbWFpbkZyYW1lSW1wbCgpLT5mcmFt ZSgpOworICAgIFdlYlBsdWdpbkNvbnRhaW5lckltcGwqIHBsdWdpbkNvbnRhaW5lciA9IFdlYkZy YW1lSW1wbDo6cGx1Z2luQ29udGFpbmVyRnJvbUZyYW1lKGZyYW1lKTsKKyAgICBpZiAocGx1Z2lu Q29udGFpbmVyKQorICAgICAgICBoYW5kbGVkIHw9IHBsdWdpbkNvbnRhaW5lci0+aGFuZGxlR2Vz dHVyZUV2ZW50KHBsYXRmb3JtRXZlbnQpOworCisgICAgcmV0dXJuIGhhbmRsZWQ7CiB9CiAjZW5k aWYKIAo=