66589 2011-08-19 14:08:23 -0700 [chromium] Content and render surface textures not freed when compositor context destroyed 2011-08-22 11:19:15 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr enne kbr vangelis webkit.review.bot oldest_to_newest 454075 0 jamesr 2011-08-19 14:08:23 -0700 [chromium] Content and render surface textures not freed when compositor context destroyed 454083 1 104563 jamesr 2011-08-19 14:19:10 -0700 Created attachment 104563 Patch 454086 2 jamesr 2011-08-19 14:22:45 -0700 We talked some in person about how to get better automated testing for stuff like this. I think the general thinking is that we need a way to test the compositing path with either a mock GraphicsContext3D or something lower-level to verify that we're actually releasing all of the resources we create. 454356 3 enne 2011-08-20 12:49:22 -0700 Unofficially, looks good to me. 454696 4 104563 kbr 2011-08-22 10:59:13 -0700 Comment on attachment 104563 Patch rs=me 454727 5 104563 webkit.review.bot 2011-08-22 11:19:11 -0700 Comment on attachment 104563 Patch Clearing flags on attachment: 104563 Committed r93523: <http://trac.webkit.org/changeset/93523> 454728 6 webkit.review.bot 2011-08-22 11:19:15 -0700 All reviewed patches have been landed. Closing bug. 104563 2011-08-19 14:19:10 -0700 2011-08-22 11:19:11 -0700 Patch bug-66589-20110819141909.patch text/plain 2340 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogOTM0MjQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5YTNmOGY1MDIwMTBkNDJh MmY0OTgzNDVhYWRkMWEwOTY2MmRmZWI2Li5hNTFjYmMwNTMyYThlMjcyMThlNDlmNGQ2ZTlmMTkx NjE1MmE2ZTA1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDgtMTkgIEphbWVz IFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIENv bnRlbnQgYW5kIHJlbmRlciBzdXJmYWNlIHRleHR1cmVzIG5vdCBmcmVlZCB3aGVuIGNvbXBvc2l0 b3IgY29udGV4dCBkZXN0cm95ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTY2NTg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgRXhwbGljaXRseSBkZWxldGUgYWxsIG1hbmFnZWQgdGV4dHVyZXMgd2hlbiBk ZXN0cm95aW5nIHRoZSBjb21wb3NpdG9yCisgICAgICAgIGNvbnRleHQuICBUaGlzIHJlZ3Jlc3Nl ZCBkdWUgdG8gYSBjb21iaW5hdGlvbiBvZiB1c2luZyBzaGFyZSBncm91cHMKKyAgICAgICAgKHNv IGRlc3Ryb3lpbmcgYSBjb250ZXh0IG5vIGxvbmdlciBpbXBsaWNpdGx5IHJlbGVhc2VzIGFsbCBy ZXNvdXJjZXMKKyAgICAgICAgaW4gdGhhdCBjb250ZXh0KSBhbmQgc3dpdGNoaW5nIHRoZSBUZXh0 dXJlTWFuYWdlciBvdmVyIHRvIHN1cHBvcnQKKyAgICAgICAgZGVmZXJyZWQgdGV4dHVyZSBkZXN0 cnVjdGlvbi4KKworICAgICAgICBXZSBzYWRseSBkb24ndCBoYXZlIGEgd2F5IHRvIGNvbnN0cnVj dCBhdXRvbWF0ZWQgdGVzdHMgZm9yIHJlc291cmNlCisgICAgICAgIGxlYWtzIGN1cnJlbnRseS4K KworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVuZGVyZXJDaHJv bWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXllclJlbmRlcmVyQ2hyb21pdW06OmNsZWFu dXBTaGFyZWRPYmplY3RzKToKKwogMjAxMS0wOC0xNyAgQWRyaWVubmUgV2Fsa2VyICA8ZW5uZUBn b29nbGUuY29tPgogCiAgICAgICAgIFtjaHJvbWl1bV0gU3BsaXQgdGlsZXIgaW50byBtYWluIHRo cmVhZCAvIGNvbXBvc2l0b3IgdGhyZWFkIHZlcnNpb25zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0uY3Bw IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5kZXJl ckNocm9taXVtLmNwcAppbmRleCA0NTk1MmViZWZlOTQ4YzBkZTBhY2U4ZmY5OTVlMTdiY2RkNDYx MDVmLi43MDc4N2E4N2I3ODE5NGQwOGQ2NjAzZDBlNTY2OWE5MjhiNzMwZWYyIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVy Q2hyb21pdW0uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1bS5jcHAKQEAgLTEyODMsNyArMTI4MywxMyBAQCB2b2lk IExheWVyUmVuZGVyZXJDaHJvbWl1bTo6Y2xlYW51cFNoYXJlZE9iamVjdHMoKQogICAgICAgICBH TEMobV9jb250ZXh0LmdldCgpLCBtX2NvbnRleHQtPmRlbGV0ZUZyYW1lYnVmZmVyKG1fb2Zmc2Ny ZWVuRnJhbWVidWZmZXJJZCkpOwogCiAgICAgLy8gQ2xlYXIgdGlsZXJzIGJlZm9yZSB0aGUgdGV4 dHVyZSBtYW5hZ2VyLCBhcyB0aGV5IGhhdmUgcmVmZXJlbmNlcyB0byB0ZXh0dXJlcy4KKyAgICBt X2NvbnRlbnRzVGV4dHVyZU1hbmFnZXItPnVucHJvdGVjdEFsbFRleHR1cmVzKCk7CisgICAgbV9j b250ZW50c1RleHR1cmVNYW5hZ2VyLT5yZWR1Y2VNZW1vcnlUb0xpbWl0KDApOworICAgIG1fY29u dGVudHNUZXh0dXJlTWFuYWdlci0+ZGVsZXRlRXZpY3RlZFRleHR1cmVzKG1fY29udGV4dC5nZXQo KSk7CiAgICAgbV9jb250ZW50c1RleHR1cmVNYW5hZ2VyLmNsZWFyKCk7CisgICAgbV9yZW5kZXJT dXJmYWNlVGV4dHVyZU1hbmFnZXItPnVucHJvdGVjdEFsbFRleHR1cmVzKCk7CisgICAgbV9yZW5k ZXJTdXJmYWNlVGV4dHVyZU1hbmFnZXItPnJlZHVjZU1lbW9yeVRvTGltaXQoMCk7CisgICAgbV9y ZW5kZXJTdXJmYWNlVGV4dHVyZU1hbmFnZXItPmRlbGV0ZUV2aWN0ZWRUZXh0dXJlcyhtX2NvbnRl eHQuZ2V0KCkpOwogICAgIG1fcmVuZGVyU3VyZmFjZVRleHR1cmVNYW5hZ2VyLmNsZWFyKCk7CiB9 CiAK