66583 2011-08-19 13:57:25 -0700 [Qt] unnecessary folders in webkit2 2011-08-23 14:02:56 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED P3 Minor --- 0 gopal.1.raghavan webkit-unassigned jturcotte kling webkit.review.bot oldest_to_newest 454056 0 gopal.1.raghavan 2011-08-19 13:57:25 -0700 Probably left over from past implementation of graphicswkview 455614 1 104892 gopal.1.raghavan 2011-08-23 12:40:04 -0700 Created attachment 104892 remove empty folders 455616 2 webkit.review.bot 2011-08-23 12:43:11 -0700 Attachment 104892 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog']" exit_code: 1 Source/WebKit2/ChangeLog:4: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style. 455622 3 104893 gopal.1.raghavan 2011-08-23 12:48:32 -0700 Created attachment 104893 remove empty folders 455623 4 104893 menard 2011-08-23 12:50:02 -0700 Comment on attachment 104893 remove empty folders LGTM :D 455639 5 jturcotte 2011-08-23 13:00:09 -0700 The folders were already removed in trunk, make sure you generate your ChangeLog on master after cherry-picking and not on a branch to prevent this. 455657 6 gopal.1.raghavan 2011-08-23 13:24:15 -0700 folders and still there on trunk. I have svn trunk checked out. I am not on a branch. It's also visible here http://trac.webkit.org/browser/trunk/Source/WebKit2/UIProcess/API/qt/tests 455675 7 kling 2011-08-23 13:49:03 -0700 Committed r93636: <http://trac.webkit.org/changeset/93636> 455676 8 104893 kling 2011-08-23 13:49:49 -0700 Comment on attachment 104893 remove empty folders This patch won't do anything via CQ as there's nothing telling it to remove the folders. I removed the folders directly using svn. 455691 9 gopal.1.raghavan 2011-08-23 14:02:56 -0700 Thanks. For some reason svn-create-patch didn't pick this up. Looks like svn diff on empty folders don't listing them either. Anyway, thanks for manually removing it. 104892 2011-08-23 12:40:04 -0700 2011-08-23 12:48:32 -0700 remove empty folders 66583.patch text/plain 855 gopal.1.raghavan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzNDM1KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDgtMTkgIEdvcGFsIFJh Z2hhdmFuICA8Z29wYWwuMS5yYWdoYXZhbkBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XSB1bm5l Y2Vzc2FyeSBmb2xkZXJzIGluIHdlYmtpdDIKKwlodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NjY1ODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBDbGVhbi11cCBlbXB0eSBmb2xkZXJzIHRoYXQgYXJlIHByb2JhYmx5IG5vdCBy ZXF1aXJlZC4gTG9va3MgbGlrZSBhcnRpZmFjdHMgZnJvbSBncmFwaGljc3drdmlldworCisgICAg ICAgICogVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xZ3JhcGhpY3N3a3ZpZXc6IFJlbW92ZWQuCisg ICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xd2toaXN0b3J5OiBSZW1vdmVkLgorICAg ICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcXdrcGFnZTogUmVtb3ZlZC4KKwogMjAxMS0w OC0xOSAgQ2FpbyBNYXJjZWxvIGRlIE9saXZlaXJhIEZpbGhvICA8Y2Fpby5vbGl2ZWlyYUBvcGVu Ym9zc2Eub3JnPgogCiAgICAgICAgIFtRdF0gW1dLMl0gUHJvdmlkZSBBUEkgZm9yIGludGVyY2Vw dCAoYW5kIHBvc3NpYmxlIGlnbm9yZSkgbGlua3MgY2xpY2tlZCBpbiBRRGVza3RvcFdlYlZpZXcK 104893 2011-08-23 12:48:32 -0700 2011-08-23 13:49:49 -0700 remove empty folders 66583a.patch text/plain 862 gopal.1.raghavan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzNDM1KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDgtMTkgIEdvcGFsIFJh Z2hhdmFuICA8Z29wYWwuMS5yYWdoYXZhbkBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XSB1bm5l Y2Vzc2FyeSBmb2xkZXJzIGluIHdlYmtpdDIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTY2NTgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQ2xlYW4tdXAgZW1wdHkgZm9sZGVycyB0aGF0IGFyZSBwcm9iYWJs eSBub3QgcmVxdWlyZWQuIExvb2tzIGxpa2UgYXJ0aWZhY3RzIGZyb20gZ3JhcGhpY3N3a3ZpZXcK KworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcWdyYXBoaWNzd2t2aWV3OiBSZW1v dmVkLgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcXdraGlzdG9yeTogUmVtb3Zl ZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3F3a3BhZ2U6IFJlbW92ZWQuCisK IDIwMTEtMDgtMTkgIENhaW8gTWFyY2VsbyBkZSBPbGl2ZWlyYSBGaWxobyAgPGNhaW8ub2xpdmVp cmFAb3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBbUXRdIFtXSzJdIFByb3ZpZGUgQVBJIGZvciBp bnRlcmNlcHQgKGFuZCBwb3NzaWJsZSBpZ25vcmUpIGxpbmtzIGNsaWNrZWQgaW4gUURlc2t0b3BX ZWJWaWV3Cg==