66570 2011-08-19 10:59:41 -0700 [chromium] Remove dependency of WebThemeControlDRTWin on skia::PlatformCanvas 2011-08-19 13:22:18 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 alokp alokp jamesr mihaip webkit.review.bot oldest_to_newest 453930 0 alokp 2011-08-19 10:59:41 -0700 The dependency is not necessary. WebThemeControlDRTWin only uses basic SkCanvas. 453931 1 104528 alokp 2011-08-19 11:03:20 -0700 Created attachment 104528 proposed patch 453944 2 104528 mihaip 2011-08-19 11:33:40 -0700 Comment on attachment 104528 proposed patch Rubber stamp. 454019 3 104528 webkit.review.bot 2011-08-19 13:22:14 -0700 Comment on attachment 104528 proposed patch Clearing flags on attachment: 104528 Committed r93433: <http://trac.webkit.org/changeset/93433> 454020 4 webkit.review.bot 2011-08-19 13:22:18 -0700 All reviewed patches have been landed. Closing bug. 104528 2011-08-19 11:03:20 -0700 2011-08-19 13:22:14 -0700 proposed patch drt.patch text/plain 3334 alokp SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDkzNDIzKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTYgQEAKKzIwMTEtMDgtMTkgIEFsb2sgUHJpeWFkYXJzaGkgIDxhbG9rcEBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBSZW1vdmUgZGVwZW5kZW5jeSBvZiBXZWJUaGVtZUNv bnRyb2xEUlRXaW4gb24gc2tpYTo6UGxhdGZvcm1DYW52YXMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2NTcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJU aGVtZUNvbnRyb2xEUlRXaW4uY3BwOgorICAgICAgICAoV2ViVGhlbWVDb250cm9sRFJUV2luOjpk cmF3KToKKyAgICAgICAgKFdlYlRoZW1lQ29udHJvbERSVFdpbjo6ZHJhd1RleHRGaWVsZCk6Cisg ICAgICAgIChXZWJUaGVtZUNvbnRyb2xEUlRXaW46OmRyYXdQcm9ncmVzc0Jhcik6CisgICAgICAg ICogRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVGhlbWVDb250cm9sRFJUV2luLmg6CisKIDIw MTEtMDgtMTkgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBw cm9qZWN0IGZpbGUgY2hhbmdlcyBJIGxlZnQgb3V0IGluIHI5MzQxNwpJbmRleDogVG9vbHMvRHVt cFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVGhlbWVDb250cm9sRFJUV2luLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJUaGVtZUNvbnRyb2xEUlRXaW4u Y3BwCShyZXZpc2lvbiA5MzQxMikKKysrIFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dl YlRoZW1lQ29udHJvbERSVFdpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM3LDggKzM3LDggQEAK ICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJXZWJUaGVtZUNvbnRyb2xEUlRXaW4uaCIK IAotI2luY2x1ZGUgInNraWEvZXh0L3BsYXRmb3JtX2NhbnZhcy5oIgogI2luY2x1ZGUgInNraWEv ZXh0L3NraWFfdXRpbHNfd2luLmgiCisjaW5jbHVkZSAidGhpcmRfcGFydHkvc2tpYS9pbmNsdWRl L2NvcmUvU2tDYW52YXMuaCIKICNpbmNsdWRlICJ0aGlyZF9wYXJ0eS9za2lhL2luY2x1ZGUvY29y ZS9Ta1BhaW50LmgiCiAjaW5jbHVkZSAidGhpcmRfcGFydHkvc2tpYS9pbmNsdWRlL2NvcmUvU2tQ YXRoLmgiCiAjaW5jbHVkZSAidGhpcmRfcGFydHkvc2tpYS9pbmNsdWRlL2NvcmUvU2tSZWN0Lmgi CkBAIC0zMDMsOCArMzAzLDYgQEAgdm9pZCBXZWJUaGVtZUNvbnRyb2xEUlRXaW46OmRyYXcoKQog ICAgIC8vIEluZGVudHMgZm9yIHRoZSB0aGUgc2xpZGVyIHRyYWNrLgogICAgIGNvbnN0IGludCBz bGlkZXJJbmRlbnQgPSAyOwogCi0gICAgc2tpYTo6QmVnaW5QbGF0Zm9ybVBhaW50KG1fY2FudmFz KTsKLQogICAgIHN3aXRjaCAobV90eXBlKSB7CiAgICAgY2FzZSBVbmtub3duVHlwZToKICAgICAg ICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CkBAIC00ODYsNyArNDg0LDYgQEAgdm9pZCBXZWJUaGVt ZUNvbnRyb2xEUlRXaW46OmRyYXcoKQogICAgIH0KIAogICAgIG1hcmtTdGF0ZSgpOwotICAgIHNr aWE6OkVuZFBsYXRmb3JtUGFpbnQobV9jYW52YXMpOwogfQogCiAvLyBCZWNhdXNlIHJlbmRlcmlu ZyBhIHRleHQgZmllbGQgaXMgZGVwZW5kZW50IG9uIGlucHV0CkBAIC00OTYsNyArNDkzLDYgQEAg dm9pZCBXZWJUaGVtZUNvbnRyb2xEUlRXaW46OmRyYXdUZXh0RmllbAogewogICAgIFNrUGFpbnQg cGFpbnQ7CiAKLSAgICBza2lhOjpCZWdpblBsYXRmb3JtUGFpbnQobV9jYW52YXMpOwogICAgIGlm IChmaWxsQ29udGVudEFyZWEpIHsKICAgICAgICAgcGFpbnQuc2V0Q29sb3IoY29sb3IpOwogICAg ICAgICBwYWludC5zZXRTdHlsZShTa1BhaW50OjprRmlsbF9TdHlsZSk7CkBAIC01MDksMTQgKzUw NSwxMiBAQCB2b2lkIFdlYlRoZW1lQ29udHJvbERSVFdpbjo6ZHJhd1RleHRGaWVsCiAgICAgfQog CiAgICAgbWFya1N0YXRlKCk7Ci0gICAgc2tpYTo6RW5kUGxhdGZvcm1QYWludChtX2NhbnZhcyk7 CiB9CiAKIHZvaWQgV2ViVGhlbWVDb250cm9sRFJUV2luOjpkcmF3UHJvZ3Jlc3NCYXIoY29uc3Qg U2tJUmVjdCYgZmlsbFJlY3QpCiB7CiAgICAgU2tQYWludCBwYWludDsKIAotICAgIHNraWE6OkJl Z2luUGxhdGZvcm1QYWludChtX2NhbnZhcyk7CiAgICAgcGFpbnQuc2V0Q29sb3IobV9iZ0NvbG9y KTsKICAgICBwYWludC5zZXRTdHlsZShTa1BhaW50OjprRmlsbF9TdHlsZSk7CiAgICAgbV9jYW52 YXMtPmRyYXdJUmVjdChtX2lyZWN0LCBwYWludCk7CkBAIC01MjksNiArNTIzLDUgQEAgdm9pZCBX ZWJUaGVtZUNvbnRyb2xEUlRXaW46OmRyYXdQcm9ncmVzcwogICAgIG1fY2FudmFzLT5kcmF3SVJl Y3QodG9maWxsLCBwYWludCk7CiAKICAgICBtYXJrU3RhdGUoKTsKLSAgICBza2lhOjpFbmRQbGF0 Zm9ybVBhaW50KG1fY2FudmFzKTsKIH0KIApJbmRleDogVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hy b21pdW0vV2ViVGhlbWVDb250cm9sRFJUV2luLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvRHVtcFJl bmRlclRyZWUvY2hyb21pdW0vV2ViVGhlbWVDb250cm9sRFJUV2luLmgJKHJldmlzaW9uIDkzNDEy KQorKysgVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVGhlbWVDb250cm9sRFJUV2lu LmgJKHdvcmtpbmcgY29weSkKQEAgLTM5LDEyICszOSwxMiBAQAogI2lmbmRlZiBXZWJUaGVtZUNv bnRyb2xEUlRXaW5faAogI2RlZmluZSBXZWJUaGVtZUNvbnRyb2xEUlRXaW5faAogCi0jaW5jbHVk ZSAic2tpYS9leHQvcGxhdGZvcm1fY2FudmFzLmgiCiAjaW5jbHVkZSAidGhpcmRfcGFydHkvc2tp YS9pbmNsdWRlL2NvcmUvU2tDb2xvci5oIgorI2luY2x1ZGUgInRoaXJkX3BhcnR5L3NraWEvaW5j bHVkZS9jb3JlL1NrUmVjdC5oIgogI2luY2x1ZGUgPHd0Zi9Ob25jb3B5YWJsZS5oPgogCiAvLyBT a2lhIGZvcndhcmQgZGVjbGFyYXRpb25zCi1zdHJ1Y3QgU2tJUmVjdDsKK2NsYXNzIFNrQ2FudmFz OwogCiBjbGFzcyBXZWJUaGVtZUNvbnRyb2xEUlRXaW4gewogICAgIFdURl9NQUtFX05PTkNPUFlB QkxFKFdlYlRoZW1lQ29udHJvbERSVFdpbik7Cg==