66563 2011-08-19 08:40:22 -0700 [Chromium] Crash when allocation of very large canvas fails 2011-08-22 09:02:28 -0700 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) Unspecified Windows XP RESOLVED FIXED http://www.atopon.org/maze/ P2 Major --- 1 junov junov alokp dglazkov mdelaney7 senorblanco webkit.review.bot oldest_to_newest 453846 0 junov 2011-08-19 08:40:22 -0700 This is in reference to Chromium bug: http://code.google.com/p/chromium/issues/detail?id=88038 A patch soon to land in Chromium will introduce a non-crashing version of the canvas factory function CreateBitmapCanvas. The constructor of ImageBuffer in ImageBufferSkia.cpp must be modified to use the non-crashing version, and gracefully fail when it returns NULL. 453921 1 104525 junov 2011-08-19 10:44:41 -0700 Created attachment 104525 Patch 453925 2 104525 webkit.review.bot 2011-08-19 10:52:07 -0700 Comment on attachment 104525 Patch Attachment 104525 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9439367 453928 3 104527 junov 2011-08-19 10:54:50 -0700 Created attachment 104527 Patch 453934 4 104529 junov 2011-08-19 11:18:09 -0700 Created attachment 104529 Patch 454592 5 104529 senorblanco 2011-08-22 07:30:09 -0700 Comment on attachment 104529 Patch Looks good. r=me 454620 6 104529 webkit.review.bot 2011-08-22 09:02:23 -0700 Comment on attachment 104529 Patch Clearing flags on attachment: 104529 Committed r93512: <http://trac.webkit.org/changeset/93512> 454621 7 webkit.review.bot 2011-08-22 09:02:28 -0700 All reviewed patches have been landed. Closing bug. 104525 2011-08-19 10:44:41 -0700 2011-08-19 10:54:45 -0700 Patch bug-66563-20110819134440.patch text/plain 1631 junov SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzNDIxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDgtMTkgIEp1c3RpbiBO b3Zvc2FkICA8anVub3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gQ3Jhc2gg d2hlbiBhbGxvY2F0aW9uIG9mIHZlcnkgbGFyZ2UgY2FudmFzIGZhaWxzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjU2MworICAgICAgICBSZXBsYWNp bmcgdGhlIGNyYXNoIHdpdGggYSBtb3JlIGdyYWNlZnVsIGZhaWx1cmU6IGNhbnZhcworICAgICAg ICB3aWxsIG5vdCByZW5kZXIuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpJbWFnZUJ1ZmZlcjo6SW1hZ2VCdWZmZXIpOgorICAgICAgICBJ bnZva2luZyBUcnlDcmVhdGVCaXRtYXBDYW52YXMgaW5zdGVhZCBvZiBDcmVhdGVCaXRtYXBDYW52 YXMKKyAgICAgICAgVGhpcyBpcyB0aGUgbm9uLWNyYXNoaW5nIHZlcnNpb24gb2YgdGhlIGZhY3Rv cnkgZnVuY3Rpb24uCisgICAgICAgIEl0IHJldHVybnMgTlVMTCBpZiBhbGxvY2F0aW9uIGZhaWxz LiAgQ29kZSBmb3IgaGFuZGxpbmcKKyAgICAgICAgTlVMTCBwb2ludGVyIHdhcyBhbHJlYWR5IGlu IHBsYWNlLgorCiAyMDExLTA4LTE5ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAK ICAgICAgICAgQmV0dGVyIGJ1aWxkIGZpeCBhZnRlciByOTMzODQuCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZlclNr aWEuY3BwCShyZXZpc2lvbiA5MzQxNSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3NraWEvSW1hZ2VCdWZmZXJTa2lhLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjcsNyArNjcs NyBAQCBJbWFnZUJ1ZmZlcjo6SW1hZ2VCdWZmZXIoY29uc3QgSW50U2l6ZSYgCiAgICAgLCBtX3Np emUoc2l6ZSkKICAgICAsIG1fYWNjZWxlcmF0ZVJlbmRlcmluZyhmYWxzZSkKIHsKLSAgICBPd25Q dHI8U2tDYW52YXM+IGNhbnZhcyA9IGFkb3B0UHRyKHNraWE6OkNyZWF0ZUJpdG1hcENhbnZhcyhz aXplLndpZHRoKCksIHNpemUuaGVpZ2h0KCksIGZhbHNlKSk7CisgICAgT3duUHRyPFNrQ2FudmFz PiBjYW52YXMgPSBhZG9wdFB0cihza2lhOjpUcnlDcmVhdGVCaXRtYXBDYW52YXMoc2l6ZS53aWR0 aCgpLCBzaXplLmhlaWdodCgpLCBmYWxzZSkpOwogICAgIGlmICghY2FudmFzKSB7CiAgICAgICAg IHN1Y2Nlc3MgPSBmYWxzZTsKICAgICAgICAgcmV0dXJuOwo= 104527 2011-08-19 10:54:50 -0700 2011-08-19 11:18:05 -0700 Patch bug-66563-20110819135448.patch text/plain 1989 junov SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzNDIxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDgtMTkgIEp1c3RpbiBO b3Zvc2FkICA8anVub3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gQ3Jhc2gg d2hlbiBhbGxvY2F0aW9uIG9mIHZlcnkgbGFyZ2UgY2FudmFzIGZhaWxzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjU2MworICAgICAgICBSZXBsYWNp bmcgdGhlIGNyYXNoIHdpdGggYSBtb3JlIGdyYWNlZnVsIGZhaWx1cmU6IGNhbnZhcworICAgICAg ICB3aWxsIG5vdCByZW5kZXIuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpJbWFnZUJ1ZmZlcjo6SW1hZ2VCdWZmZXIpOgorICAgICAgICBJ bnZva2luZyBUcnlDcmVhdGVCaXRtYXBDYW52YXMgaW5zdGVhZCBvZiBDcmVhdGVCaXRtYXBDYW52 YXMKKyAgICAgICAgVGhpcyBpcyB0aGUgbm9uLWNyYXNoaW5nIHZlcnNpb24gb2YgdGhlIGZhY3Rv cnkgZnVuY3Rpb24uCisgICAgICAgIEl0IHJldHVybnMgTlVMTCBpZiBhbGxvY2F0aW9uIGZhaWxz LiAgQ29kZSBmb3IgaGFuZGxpbmcKKyAgICAgICAgTlVMTCBwb2ludGVyIHdhcyBhbHJlYWR5IGlu IHBsYWNlLgorCiAyMDExLTA4LTE5ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAK ICAgICAgICAgQmV0dGVyIGJ1aWxkIGZpeCBhZnRlciByOTMzODQuCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZlclNr aWEuY3BwCShyZXZpc2lvbiA5MzQxNSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3NraWEvSW1hZ2VCdWZmZXJTa2lhLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjcsNyArNjcs NyBAQCBJbWFnZUJ1ZmZlcjo6SW1hZ2VCdWZmZXIoY29uc3QgSW50U2l6ZSYgCiAgICAgLCBtX3Np emUoc2l6ZSkKICAgICAsIG1fYWNjZWxlcmF0ZVJlbmRlcmluZyhmYWxzZSkKIHsKLSAgICBPd25Q dHI8U2tDYW52YXM+IGNhbnZhcyA9IGFkb3B0UHRyKHNraWE6OkNyZWF0ZUJpdG1hcENhbnZhcyhz aXplLndpZHRoKCksIHNpemUuaGVpZ2h0KCksIGZhbHNlKSk7CisgICAgT3duUHRyPFNrQ2FudmFz PiBjYW52YXMgPSBhZG9wdFB0cihza2lhOjpUcnlDcmVhdGVCaXRtYXBDYW52YXMoc2l6ZS53aWR0 aCgpLCBzaXplLmhlaWdodCgpLCBmYWxzZSkpOwogICAgIGlmICghY2FudmFzKSB7CiAgICAgICAg IHN1Y2Nlc3MgPSBmYWxzZTsKICAgICAgICAgcmV0dXJuOwpJbmRleDogU291cmNlL1dlYktpdC9j aHJvbWl1bS9ERVBTCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vREVQUwko cmV2aXNpb24gOTM0MTUpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0RFUFMJKHdvcmtpbmcg Y29weSkKQEAgLTMyLDcgKzMyLDcgQEAKIAogdmFycyA9IHsKICAgJ2Nocm9taXVtX3N2bic6ICdo dHRwOi8vc3JjLmNocm9taXVtLm9yZy9zdm4vdHJ1bmsvc3JjJywKLSAgJ2Nocm9taXVtX3Jldic6 ICc5Njk0MCcKKyAgJ2Nocm9taXVtX3Jldic6ICc5NzQ3NCcKIH0KIAogZGVwcyA9IHsK 104529 2011-08-19 11:18:09 -0700 2011-08-22 09:02:23 -0700 Patch bug-66563-20110819141808.patch text/plain 2721 junov SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzNDI0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDgtMTkgIEp1c3RpbiBO b3Zvc2FkICA8anVub3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gQ3Jhc2gg d2hlbiBhbGxvY2F0aW9uIG9mIHZlcnkgbGFyZ2UgY2FudmFzIGZhaWxzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjU2MworICAgICAgICBSZXBsYWNp bmcgdGhlIGNyYXNoIHdpdGggYSBtb3JlIGdyYWNlZnVsIGZhaWx1cmU6IGNhbnZhcworICAgICAg ICB3aWxsIG5vdCByZW5kZXIuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpJbWFnZUJ1ZmZlcjo6SW1hZ2VCdWZmZXIpOgorICAgICAgICBJ bnZva2luZyBUcnlDcmVhdGVCaXRtYXBDYW52YXMgaW5zdGVhZCBvZiBDcmVhdGVCaXRtYXBDYW52 YXMKKyAgICAgICAgVGhpcyBpcyB0aGUgbm9uLWNyYXNoaW5nIHZlcnNpb24gb2YgdGhlIGZhY3Rv cnkgZnVuY3Rpb24uCisgICAgICAgIEl0IHJldHVybnMgTlVMTCBpZiBhbGxvY2F0aW9uIGZhaWxz LiAgQ29kZSBmb3IgaGFuZGxpbmcKKyAgICAgICAgTlVMTCBwb2ludGVyIHdhcyBhbHJlYWR5IGlu IHBsYWNlLgorCiAyMDExLTA4LTE3ICBBZHJpZW5uZSBXYWxrZXIgIDxlbm5lQGdvb2dsZS5jb20+ CiAKICAgICAgICAgW2Nocm9taXVtXSBTcGxpdCB0aWxlciBpbnRvIG1haW4gdGhyZWFkIC8gY29t cG9zaXRvciB0aHJlYWQgdmVyc2lvbnMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3NraWEvSW1hZ2VCdWZmZXJTa2lhLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHAJKHJldmlzaW9u IDkzNDE1KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZUJ1 ZmZlclNraWEuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02Nyw3ICs2Nyw3IEBAIEltYWdlQnVmZmVy OjpJbWFnZUJ1ZmZlcihjb25zdCBJbnRTaXplJiAKICAgICAsIG1fc2l6ZShzaXplKQogICAgICwg bV9hY2NlbGVyYXRlUmVuZGVyaW5nKGZhbHNlKQogewotICAgIE93blB0cjxTa0NhbnZhcz4gY2Fu dmFzID0gYWRvcHRQdHIoc2tpYTo6Q3JlYXRlQml0bWFwQ2FudmFzKHNpemUud2lkdGgoKSwgc2l6 ZS5oZWlnaHQoKSwgZmFsc2UpKTsKKyAgICBPd25QdHI8U2tDYW52YXM+IGNhbnZhcyA9IGFkb3B0 UHRyKHNraWE6OlRyeUNyZWF0ZUJpdG1hcENhbnZhcyhzaXplLndpZHRoKCksIHNpemUuaGVpZ2h0 KCksIGZhbHNlKSk7CiAgICAgaWYgKCFjYW52YXMpIHsKICAgICAgICAgc3VjY2VzcyA9IGZhbHNl OwogICAgICAgICByZXR1cm47CkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxv Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkocmV2aXNp b24gOTM0MjQpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBj b3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDExLTA4LTE5ICBKdXN0aW4gTm92b3NhZCAgPGp1bm92 QGNocm9taXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIENyYXNoIHdoZW4gYWxsb2NhdGlv biBvZiB2ZXJ5IGxhcmdlIGNhbnZhcyBmYWlscworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY1NjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIERFUFM6CisgICAgICAgIEJ1bXBpbmcgdXAgdGhlIGNocm9t ZSBERVBTIHRvIHBpY2sgdXAgOTc0NzQsIHdoaWNoIGlzCisgICAgICAgIHJlcXVpcmVkIGJ5IHRo aXMgcGF0Y2guCisKIDIwMTEtMDgtMTcgIEFkcmllbm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNv bT4KIAogICAgICAgICBbY2hyb21pdW1dIFNwbGl0IHRpbGVyIGludG8gbWFpbiB0aHJlYWQgLyBj b21wb3NpdG9yIHRocmVhZCB2ZXJzaW9ucwpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9E RVBTCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vREVQUwkocmV2aXNpb24g OTM0MTUpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0RFUFMJKHdvcmtpbmcgY29weSkKQEAg LTMyLDcgKzMyLDcgQEAKIAogdmFycyA9IHsKICAgJ2Nocm9taXVtX3N2bic6ICdodHRwOi8vc3Jj LmNocm9taXVtLm9yZy9zdm4vdHJ1bmsvc3JjJywKLSAgJ2Nocm9taXVtX3Jldic6ICc5Njk0MCcK KyAgJ2Nocm9taXVtX3Jldic6ICc5NzQ3NCcKIH0KIAogZGVwcyA9IHsK