66561 2011-08-19 07:58:14 -0700 [WK2] Support password echo feature in WebKit2 2011-10-07 12:04:57 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED INVALID P2 Normal --- 32509 68924 69143 1 cshu cshu ap darin laszlo.gombos oldest_to_newest 453831 0 cshu 2011-08-19 07:58:14 -0700 Some additional work needs to do in WebKit2 for this feature. 478679 1 109861 cshu 2011-10-05 14:21:11 -0700 Created attachment 109861 patch 1 478735 2 109861 darin 2011-10-05 15:32:14 -0700 Comment on attachment 109861 patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=109861&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1707 > +#if ENABLE(PASSWORD_ECHO) > + settings->setPasswordEchoEnabled(true); > + settings->setPasswordEchoDurationInSeconds(1); > +#endif Password echo turned on unconditionally if it’s compiled at all? That just doesn’t seem right. If that was the policy then I’d expect to see that policy in WebCore. 478760 3 cshu 2011-10-05 16:02:05 -0700 (In reply to comment #2) > (From update of attachment 109861 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=109861&action=review > > > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1707 > > +#if ENABLE(PASSWORD_ECHO) > > + settings->setPasswordEchoEnabled(true); > > + settings->setPasswordEchoDurationInSeconds(1); > > +#endif > > Password echo turned on unconditionally if it’s compiled at all? That just doesn’t seem right. If that was the policy then I’d expect to see that policy in WebCore. By default, PASSWORD_ECHO is not enabled. If the feature is chosen to turn on, a build time flag is required. An alternative way is to enable it in runtime. Alexey and I have discussed on whether the application(such as MiniBrowser) should take care of this (during runtime) but we chose to control this in WebKit. WebCore seems a place to provide this option in the settings. 478766 4 ap 2011-10-05 16:15:22 -0700 I remember discussing that every application on a platform should not be required to do something to follow default platform behavior for password echo. Details of proposed solution are a bit vague - this was a while ago. 478774 5 darin 2011-10-05 16:31:26 -0700 (In reply to comment #4) > I remember discussing that every application on a platform should not be required to do something to follow default platform behavior for password echo. Details of proposed solution are a bit vague - this was a while ago. It seems strange to have something defaulting off at the WebCore level then turned on unconditionally at the WebKit level. 478852 6 cshu 2011-10-05 18:21:49 -0700 (In reply to comment #5) > (In reply to comment #4) > > I remember discussing that every application on a platform should not be required to do something to follow default platform behavior for password echo. Details of proposed solution are a bit vague - this was a while ago. > > It seems strange to have something defaulting off at the WebCore level then turned on unconditionally at the WebKit level. The "condition" is the build flag. In fact, symbian has already defined ENABLE_PASSWORD_ECHO=1 in WebCore/config.h. And other platforms are disabled by default. In anther way, we can set different default value using #if PLATFORM() flag in WebCore. Maybe we should do this. Btw, just got the sad news. 480193 7 cshu 2011-10-07 12:04:57 -0700 We don't need this any more. The compile time is removed in bug 69647 so we don't need any special treatment in WK2 code. The unskipped tests are included there, too. 109861 2011-10-05 14:21:11 -0700 2011-10-07 11:37:01 -0700 patch 1 66561_1.patch text/plain 2860 cshu SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk2NzQ2KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTAtMDUgIENoYW5nIFNo dSAgPGNzaHVAd2Via2l0Lm9yZz4KKworICAgICAgICBbV0syXSBTdXBwb3J0IHBhc3N3b3JkIGVj aG8gZmVhdHVyZSBpbiBXZWJLaXQyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD02NjU2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEVuYWJsZSBwYXNzd29yZC1lY2hvIGZlYXR1cmUgdW5kZXIgYnVpbGQgZmxh Zy4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcDoKKyAgICAgICAg KFdlYktpdDo6V2ViUGFnZTo6dXBkYXRlUHJlZmVyZW5jZXMpOgorCiAyMDExLTEwLTA1ICBDYWlv IE1hcmNlbG8gZGUgT2xpdmVpcmEgRmlsaG8gIDxjYWlvLm9saXZlaXJhQG9wZW5ib3NzYS5vcmc+ CiAKICAgICAgICAgW1F0XSBbV0syXSBTdXBwb3J0IEpTIGFsZXJ0L2NvbmZpcm0vcHJvbXB0IGlu IFFEZXNrdG9wV2ViVmlldwpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdl L1dlYlBhZ2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UGFnZS9XZWJQYWdlLmNwcAkocmV2aXNpb24gOTY3NDIpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE3MDEsNiArMTcw MSwxMSBAQCB2b2lkIFdlYlBhZ2U6OnVwZGF0ZVByZWZlcmVuY2VzKGNvbnN0IFdlCiAKICAgICBz ZXR0aW5ncy0+c2V0QXBwbGljYXRpb25DaHJvbWVNb2RlKHN0b3JlLmdldEJvb2xWYWx1ZUZvcktl eShXZWJQcmVmZXJlbmNlc0tleTo6YXBwbGljYXRpb25DaHJvbWVNb2RlS2V5KCkpKTsKICAgICAK KyNpZiBFTkFCTEUoUEFTU1dPUkRfRUNITykKKyAgICBzZXR0aW5ncy0+c2V0UGFzc3dvcmRFY2hv RW5hYmxlZCh0cnVlKTsKKyAgICBzZXR0aW5ncy0+c2V0UGFzc3dvcmRFY2hvRHVyYXRpb25JblNl Y29uZHMoMSk7CisjZW5kaWYKKwogICAgIHBsYXRmb3JtUHJlZmVyZW5jZXNEaWRDaGFuZ2Uoc3Rv cmUpOwogfQogCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA5Njc0NykKKysrIExheW91dFRlc3RzL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDExLTEwLTA1ICBDaGFuZyBT aHUgIDxjc2h1QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1dLMl0gU3VwcG9ydCBwYXNzd29yZCBl Y2hvIGZlYXR1cmUgaW4gV2ViS2l0MgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NjY1NjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBVbnNraXAgcGFzc2VkIHRlc3RzLiBUaGV5IHNob3VsZCBoYXZlIGJlZW4g d29ya2luZyBhZnRlciByOTY3NDAgKGJ1ZyA2ODkyNCkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS93 azIvU2tpcHBlZDoKKwogMjAxMS0xMC0wNSAgQ2hhbmcgU2h1ICA8Y3NodUB3ZWJraXQub3JnPgog CiAgICAgICAgIFtXSzJdIFN1cHBvcnQgc2V0TWFya2VkVGV4dC9oYXNNYXJrZWRUZXh0L3VubWFy a1RleHQvaW5zZXJ0VGV4dCBmb3IgV1RSIFRleHRJbnB1dENvbnRyb2xsZXIKSW5kZXg6IExheW91 dFRlc3RzL3BsYXRmb3JtL3drMi9Ta2lwcGVkCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3Bs YXRmb3JtL3drMi9Ta2lwcGVkCShyZXZpc2lvbiA5Njc0MikKKysrIExheW91dFRlc3RzL3BsYXRm b3JtL3drMi9Ta2lwcGVkCSh3b3JraW5nIGNvcHkpCkBAIC0xMTAyLDEzICsxMTAyLDYgQEAgZWRp dGluZy9zcGVsbGluZy9zcGVsbGNoZWNrLWlucHV0LXNlYXJjaAogIyBtaXNzaW5nIHdpbmRvdy5p bnRlcm5hbHMuY3JlYXRlU2hhZG93Q29udGVudEVsZW1lbnQKIGZhc3QvZG9tL3NoYWRvdy9jcmVh dGUtY29udGVudC1lbGVtZW50Lmh0bWwKIAotIyBXZWJLaXRUZXN0UnVubmVyIG5lZWRzIGxheW91 dFRlc3RDb250cm9sbGVyLnNldFBhc3N3b3JkRWNob0VuYWJsZWQKLSMgV2ViS2l0VGVzdFJ1bm5l ciBuZWVkcyBsYXlvdXRUZXN0Q29udHJvbGxlci5zZXRQYXNzd29yZEVjaG9EdXJhdGlvbgotZWRp dGluZy9pbnB1dC9wYXNzd29yZC1lY2hvLXBhc3Nub2RlLmh0bWwKLWVkaXRpbmcvaW5wdXQvcGFz c3dvcmQtZWNoby1wYXNzbm9kZTIuaHRtbAotZWRpdGluZy9pbnB1dC9wYXNzd29yZC1lY2hvLXBh c3Nub2RlMy5odG1sCi1lZGl0aW5nL2lucHV0L3Bhc3N3b3JkLWVjaG8tdGV4dG5vZGUuaHRtbAot CiAjIFdUUiBuZWVkcyBhbiBpbXBsZW1lbnRhdGlvbiBmb3IgZXZlbnRTZW5kZXIuY29udGludW91 c01vdXNlU2Nyb2xsQnkKICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTY5NDE3CiBmYXN0L2V2ZW50cy93aGVlbGV2ZW50LWRpcmVjdGlvbi1pbnZlcnRlZC1mcm9tLWRl dmljZS5odG1sCg==