66549 2011-08-19 05:51:24 -0700 [Qt][WK2] Change the rect argument of QtWebPageProxy::paint() to const ref 2011-08-19 07:46:32 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Normal --- 0 larsgk webkit-unassigned benjamin kling webkit.review.bot oldest_to_newest 453767 0 larsgk 2011-08-19 05:51:24 -0700 SSIA 453771 1 104495 larsgk 2011-08-19 06:02:37 -0700 Created attachment 104495 change arg to const ref 453775 2 104495 benjamin 2011-08-19 06:07:09 -0700 Comment on attachment 104495 change arg to const ref View in context: https://bugs.webkit.org/attachment.cgi?id=104495&action=review You should use webkit-patch for uploading patches. I reject for the changelog and educational purpose :) > Source/WebKit2/ChangeLog:3 > + Changed argument to const ref. I updated the title, please update the changelog accordingly. 453785 3 104502 larsgk 2011-08-19 06:22:37 -0700 Created attachment 104502 Patch 453787 4 104502 benjamin 2011-08-19 06:23:46 -0700 Comment on attachment 104502 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104502&action=review > Source/WebKit2/ChangeLog:3 > + [Qt][WK2] Change the rect argument of QtWebPageProxy::paint() to to const ref Oops, sorry, I did a typo in the title. 453792 5 104505 larsgk 2011-08-19 06:32:33 -0700 Created attachment 104505 Patch 453819 6 104505 webkit.review.bot 2011-08-19 07:46:27 -0700 Comment on attachment 104505 Patch Clearing flags on attachment: 104505 Committed r93402: <http://trac.webkit.org/changeset/93402> 453820 7 webkit.review.bot 2011-08-19 07:46:32 -0700 All reviewed patches have been landed. Closing bug. 104495 2011-08-19 06:02:37 -0700 2011-08-19 06:22:28 -0700 change arg to const ref ParamChange.patch text/plain 1707 larsgk ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1ZTA4MDQ0Li4xZGJhZDQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMDgtMTkgIExhcnMgS251ZHNlbiAgPGxhcnMua251ZHNlbkBub2tpYS5jb20+CisK KyAgICAgICAgQ2hhbmdlZCBhcmd1bWVudCB0byBjb25zdCByZWYuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjU0OQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL3F0L1F0V2ViUGFnZVBy b3h5LmNwcDoKKyAgICAgICAgKFF0V2ViUGFnZVByb3h5OjpwYWludCk6CisgICAgICAgICogVUlQ cm9jZXNzL3F0L1F0V2ViUGFnZVByb3h5Lmg6CisKIDIwMTEtMDgtMTggIEJldGggRGFraW4gIDxi ZGFraW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQYWdlUHJveHkuY3BwIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0V2ViUGFnZVByb3h5LmNwcAppbmRleCA3ZDBj MmNiLi4wNjI2YmRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRX ZWJQYWdlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdlYlBh Z2VQcm94eS5jcHAKQEAgLTQzNiw3ICs0MzYsNyBAQCB2b2lkIFF0V2ViUGFnZVByb3h5OjpkaWRD aGFuZ2VMb2FkUHJvZ3Jlc3MoaW50IG5ld0xvYWRQcm9ncmVzcykKICAgICBtX3ZpZXdJbnRlcmZh Y2UtPmRpZENoYW5nZUxvYWRQcm9ncmVzcyhuZXdMb2FkUHJvZ3Jlc3MpOwogfQogCi12b2lkIFF0 V2ViUGFnZVByb3h5OjpwYWludChRUGFpbnRlciogcGFpbnRlciwgUVJlY3QgYXJlYSkKK3ZvaWQg UXRXZWJQYWdlUHJveHk6OnBhaW50KFFQYWludGVyKiBwYWludGVyLCBjb25zdCBRUmVjdCYgYXJl YSkKIHsKICAgICBpZiAobV93ZWJQYWdlUHJveHktPmlzVmFsaWQoKSkKICAgICAgICAgcGFpbnRD b250ZW50KHBhaW50ZXIsIGFyZWEpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL3F0L1F0V2ViUGFnZVByb3h5LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRX ZWJQYWdlUHJveHkuaAppbmRleCA0MzFmNDhjLi42ODE1MTRlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQYWdlUHJveHkuaAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvcXQvUXRXZWJQYWdlUHJveHkuaApAQCAtMTM4LDcgKzEzOCw3IEBAIHB1Ymxp YzoKICAgICB2b2lkIGRpZENoYW5nZUxvYWRQcm9ncmVzcyhpbnQpOwogICAgIGludCBsb2FkUHJv Z3Jlc3MoKSBjb25zdCB7IHJldHVybiBtX2xvYWRQcm9ncmVzczsgfQogCi0gICAgdm9pZCBwYWlu dChRUGFpbnRlciogcGFpbnRlciwgUVJlY3QpOworICAgIHZvaWQgcGFpbnQoUVBhaW50ZXIqLCBj b25zdCBRUmVjdCYpOwogCiAgICAgdm9pZCB1cGRhdGVBY3Rpb24oUXRXZWJQYWdlUHJveHk6Oldl YkFjdGlvbiBhY3Rpb24pOwogICAgIHZvaWQgdXBkYXRlTmF2aWdhdGlvbkFjdGlvbnMoKTsK 104502 2011-08-19 06:22:37 -0700 2011-08-19 06:32:25 -0700 Patch bug-66549-20110819152228.patch text/plain 1979 larsgk U3VidmVyc2lvbiBSZXZpc2lvbjogOTMzODgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA1ZTA4MDQ0YzM2MWIwYWY4 NWZjMTNiOGIxM2FlY2Q1ZGNmYzZmNTcxLi44YThjM2YzMzE1YjZjYThmNDA4ZGIzM2JmNjQ0OTM1 OGFmMDQ5MjYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDgtMTkgIExhcnMg S251ZHNlbiAgPGxhcnMua251ZHNlbkBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XVtXSzJdIENo YW5nZSB0aGUgcmVjdCBhcmd1bWVudCBvZiBRdFdlYlBhZ2VQcm94eTo6cGFpbnQoKSB0byB0byBj b25zdCByZWYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTY2NTQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBVSVByb2Nlc3MvcXQvUXRXZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAoUXRXZWJQYWdlUHJv eHk6OnBhaW50KToKKyAgICAgICAgKiBVSVByb2Nlc3MvcXQvUXRXZWJQYWdlUHJveHkuaDoKKwog MjAxMS0wOC0xOCAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgU2FtIFdlaW5pZy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9xdC9RdFdlYlBhZ2VQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRX ZWJQYWdlUHJveHkuY3BwCmluZGV4IDdkMGMyY2IzYzJlYTM0NTE2MWEzNWM2OWYxM2VjZDRjMmU1 MzQyNDguLjA2MjZiZGY5Yjc0YzkyZGQ2MTgyMmE2MjFiN2MyZDdlNjI3MjkwM2QgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VQcm94eS5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0V2ViUGFnZVByb3h5LmNwcApAQCAtNDM2LDcg KzQzNiw3IEBAIHZvaWQgUXRXZWJQYWdlUHJveHk6OmRpZENoYW5nZUxvYWRQcm9ncmVzcyhpbnQg bmV3TG9hZFByb2dyZXNzKQogICAgIG1fdmlld0ludGVyZmFjZS0+ZGlkQ2hhbmdlTG9hZFByb2dy ZXNzKG5ld0xvYWRQcm9ncmVzcyk7CiB9CiAKLXZvaWQgUXRXZWJQYWdlUHJveHk6OnBhaW50KFFQ YWludGVyKiBwYWludGVyLCBRUmVjdCBhcmVhKQordm9pZCBRdFdlYlBhZ2VQcm94eTo6cGFpbnQo UVBhaW50ZXIqIHBhaW50ZXIsIGNvbnN0IFFSZWN0JiBhcmVhKQogewogICAgIGlmIChtX3dlYlBh Z2VQcm94eS0+aXNWYWxpZCgpKQogICAgICAgICBwYWludENvbnRlbnQocGFpbnRlciwgYXJlYSk7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQYWdlUHJveHku aCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VQcm94eS5oCmluZGV4IDQz MWY0OGM4YTAyNTQ2ZGIyMGFjZTNhNGQzMjhhMGViZDMwN2Q0OGEuLjY4MTUxNGVhNzQ0NTI2MGVl ZDM5MGMzMzdlNTUyYzViMzU2YzA0MWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9xdC9RdFdlYlBhZ2VQcm94eS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9x dC9RdFdlYlBhZ2VQcm94eS5oCkBAIC0xMzgsNyArMTM4LDcgQEAgcHVibGljOgogICAgIHZvaWQg ZGlkQ2hhbmdlTG9hZFByb2dyZXNzKGludCk7CiAgICAgaW50IGxvYWRQcm9ncmVzcygpIGNvbnN0 IHsgcmV0dXJuIG1fbG9hZFByb2dyZXNzOyB9CiAKLSAgICB2b2lkIHBhaW50KFFQYWludGVyKiBw YWludGVyLCBRUmVjdCk7CisgICAgdm9pZCBwYWludChRUGFpbnRlciosIGNvbnN0IFFSZWN0Jik7 CiAKICAgICB2b2lkIHVwZGF0ZUFjdGlvbihRdFdlYlBhZ2VQcm94eTo6V2ViQWN0aW9uIGFjdGlv bik7CiAgICAgdm9pZCB1cGRhdGVOYXZpZ2F0aW9uQWN0aW9ucygpOwo= 104505 2011-08-19 06:32:33 -0700 2011-08-19 07:46:27 -0700 Patch bug-66549-20110819153225.patch text/plain 1976 larsgk U3VidmVyc2lvbiBSZXZpc2lvbjogOTMzODgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA1ZTA4MDQ0YzM2MWIwYWY4 NWZjMTNiOGIxM2FlY2Q1ZGNmYzZmNTcxLi4wNGZhNTQxZjk4YmJhNmJmYTYzNTMyMDU3NTA0ZWIw OTVlNTgwMmVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDgtMTkgIExhcnMg S251ZHNlbiAgPGxhcnMua251ZHNlbkBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XVtXSzJdIENo YW5nZSB0aGUgcmVjdCBhcmd1bWVudCBvZiBRdFdlYlBhZ2VQcm94eTo6cGFpbnQoKSB0byBjb25z dCByZWYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2 NTQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBV SVByb2Nlc3MvcXQvUXRXZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAoUXRXZWJQYWdlUHJveHk6 OnBhaW50KToKKyAgICAgICAgKiBVSVByb2Nlc3MvcXQvUXRXZWJQYWdlUHJveHkuaDoKKwogMjAx MS0wOC0xOCAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgU2FtIFdlaW5pZy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9x dC9RdFdlYlBhZ2VQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQ YWdlUHJveHkuY3BwCmluZGV4IDdkMGMyY2IzYzJlYTM0NTE2MWEzNWM2OWYxM2VjZDRjMmU1MzQy NDguLjA2MjZiZGY5Yjc0YzkyZGQ2MTgyMmE2MjFiN2MyZDdlNjI3MjkwM2QgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VQcm94eS5jcHAKKysrIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0V2ViUGFnZVByb3h5LmNwcApAQCAtNDM2LDcgKzQz Niw3IEBAIHZvaWQgUXRXZWJQYWdlUHJveHk6OmRpZENoYW5nZUxvYWRQcm9ncmVzcyhpbnQgbmV3 TG9hZFByb2dyZXNzKQogICAgIG1fdmlld0ludGVyZmFjZS0+ZGlkQ2hhbmdlTG9hZFByb2dyZXNz KG5ld0xvYWRQcm9ncmVzcyk7CiB9CiAKLXZvaWQgUXRXZWJQYWdlUHJveHk6OnBhaW50KFFQYWlu dGVyKiBwYWludGVyLCBRUmVjdCBhcmVhKQordm9pZCBRdFdlYlBhZ2VQcm94eTo6cGFpbnQoUVBh aW50ZXIqIHBhaW50ZXIsIGNvbnN0IFFSZWN0JiBhcmVhKQogewogICAgIGlmIChtX3dlYlBhZ2VQ cm94eS0+aXNWYWxpZCgpKQogICAgICAgICBwYWludENvbnRlbnQocGFpbnRlciwgYXJlYSk7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQYWdlUHJveHkuaCBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VQcm94eS5oCmluZGV4IDQzMWY0 OGM4YTAyNTQ2ZGIyMGFjZTNhNGQzMjhhMGViZDMwN2Q0OGEuLjY4MTUxNGVhNzQ0NTI2MGVlZDM5 MGMzMzdlNTUyYzViMzU2YzA0MWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9xdC9RdFdlYlBhZ2VQcm94eS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9R dFdlYlBhZ2VQcm94eS5oCkBAIC0xMzgsNyArMTM4LDcgQEAgcHVibGljOgogICAgIHZvaWQgZGlk Q2hhbmdlTG9hZFByb2dyZXNzKGludCk7CiAgICAgaW50IGxvYWRQcm9ncmVzcygpIGNvbnN0IHsg cmV0dXJuIG1fbG9hZFByb2dyZXNzOyB9CiAKLSAgICB2b2lkIHBhaW50KFFQYWludGVyKiBwYWlu dGVyLCBRUmVjdCk7CisgICAgdm9pZCBwYWludChRUGFpbnRlciosIGNvbnN0IFFSZWN0Jik7CiAK ICAgICB2b2lkIHVwZGF0ZUFjdGlvbihRdFdlYlBhZ2VQcm94eTo6V2ViQWN0aW9uIGFjdGlvbik7 CiAgICAgdm9pZCB1cGRhdGVOYXZpZ2F0aW9uQWN0aW9ucygpOwo=