<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>66544</bug_id>
          
          <creation_ts>2011-08-19 03:15:54 -0700</creation_ts>
          <short_desc>Web Inspector: getAttributes should work on a single node, not array.</short_desc>
          <delta_ts>2011-08-19 05:50:44 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Inspector (Deprecated)</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Pavel Feldman">pfeldman</reporter>
          <assigned_to name="Pavel Feldman">pfeldman</assigned_to>
          <cc>apavlov</cc>
    
    <cc>bweinstein</cc>
    
    <cc>joepeck</cc>
    
    <cc>keishi</cc>
    
    <cc>loislo</cc>
    
    <cc>pfeldman</cc>
    
    <cc>pmuellr</cc>
    
    <cc>rik</cc>
    
    <cc>timothy</cc>
    
    <cc>webkit.review.bot</cc>
    
    <cc>yurys</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>453724</commentid>
    <comment_count>0</comment_count>
    <who name="Pavel Feldman">pfeldman</who>
    <bug_when>2011-08-19 03:15:54 -0700</bug_when>
    <thetext>Patch to follow.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>453725</commentid>
    <comment_count>1</comment_count>
      <attachid>104483</attachid>
    <who name="Pavel Feldman">pfeldman</who>
    <bug_when>2011-08-19 03:17:21 -0700</bug_when>
    <thetext>Created attachment 104483
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>453729</commentid>
    <comment_count>2</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-08-19 03:20:10 -0700</bug_when>
    <thetext>Attachment 104483 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;Source/WebCore/ChangeLog&apos;, u&apos;Source/WebCor...&quot; exit_code: 1

Source/WebCore/inspector/InspectorDOMAgent.cpp:1083:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorDOMAgent.h:131:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>453741</commentid>
    <comment_count>3</comment_count>
      <attachid>104483</attachid>
    <who name="Alexander Pavlov (apavlov)">apavlov</who>
    <bug_when>2011-08-19 04:39:01 -0700</bug_when>
    <thetext>Comment on attachment 104483
Patch

One comment, otherwise looks good.

View in context: https://bugs.webkit.org/attachment.cgi?id=104483&amp;action=review

&gt; Source/WebCore/inspector/Inspector.json:1064
&gt; +                    { &quot;name&quot;: &quot;nodeId&quot;, &quot;type&quot;: &quot;integer&quot;, &quot;description&quot;: &quot;Ids of the nodes to retrieve attibutes for.&quot; }

Ids of the nodes -&gt; Id of the node</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>453756</commentid>
    <comment_count>4</comment_count>
      <attachid>104483</attachid>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2011-08-19 05:23:10 -0700</bug_when>
    <thetext>Comment on attachment 104483
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104483&amp;action=review

&gt;&gt; Source/WebCore/inspector/InspectorDOMAgent.cpp:1083
&gt;&gt; +void InspectorDOMAgent::getAttributes(ErrorString* errorString, int nodeId, RefPtr&lt;InspectorArray&gt;* result)
&gt; 
&gt; The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]

We should file a bug about check-webkit-style not understanding RefPtr out-parameters.

&gt; Source/WebCore/inspector/front-end/DOMAgent.js:463
&gt; -        var nodeIds = [];
&gt;          for (var nodeId in this._attributeLoadNodeIds)
&gt; -            nodeIds.push(Number(nodeId));
&gt; -        DOMAgent.getAttributes(nodeIds, this._wrapClientCallback(callback.bind(this)));
&gt; +            DOMAgent.getAttributes(parseInt(nodeId), this._wrapClientCallback(callback.bind(this, nodeId)));

Presumably this is worse from an efficiency standpoint. Hopefully it won&apos;t matter in practice.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>453766</commentid>
    <comment_count>5</comment_count>
    <who name="Pavel Feldman">pfeldman</who>
    <bug_when>2011-08-19 05:50:44 -0700</bug_when>
    <thetext>Committed r93398: &lt;http://trac.webkit.org/changeset/93398&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>104483</attachid>
            <date>2011-08-19 03:17:21 -0700</date>
            <delta_ts>2011-08-19 05:23:10 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-66544-20110819141719.patch</filename>
            <type>text/plain</type>
            <size>7212</size>
            <attacher name="Pavel Feldman">pfeldman</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogOTMzOTEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwYzE2NjBiZmJmNGQzZTVl
ZTA4NWE4MTMzNTQ5ZTVhYzMzY2NjNTUwLi4xY2IxMmRlZjliMjBhNzUzZDlhYjA3OTY3OWMyNzI3
M2U3MzAwZTEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDgtMTkgIFBhdmVs
IEZlbGRtYW4gIDxwZmVsZG1hbkBnb29nbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6
IGdldEF0dHJpYnV0ZXMgc2hvdWxkIHdvcmsgb24gYSBzaW5nbGUgbm9kZSwgbm90IGFycmF5Lgor
ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY1NDQKKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rv
ci9JbnNwZWN0b3IuanNvbjoKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQu
Y3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yRE9NQWdlbnQ6OmdldEF0dHJpYnV0ZXMp
OgorICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5oOgorICAgICAgICAqIGlu
c3BlY3Rvci9mcm9udC1lbmQvRE9NQWdlbnQuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRE9N
QWdlbnQucHJvdG90eXBlLl9sb2FkTm9kZUF0dHJpYnV0ZXMpOgorCiAyMDExLTA4LTE5ICBOYXlh
biBLdW1hciBLICA8bmF5YW5ra0Btb3Rvcm9sYS5jb20+CiAKICAgICAgICAgUnVuLXRpbWUgZXJy
b3IgZml4IGluIFdlYktpdC1HVEsgd2l0aCB2aWRlbyBzdXBwb3J0IGRpc2FibGVkLgpkaWZmIC0t
Z2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rvci5qc29uIGIvU291cmNlL1dl
YkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rvci5qc29uCmluZGV4IDNmYzUyNDNmMTllYjk4NDM2MmQy
ZjUxMWYyYzI2NWVhMGU3ODMwMzEuLjU0MTlhOTU3MDNiODM5MDBjNjRkYzFlMGFmMmZhOWNlZDA0
YzYxMDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3IuanNv
bgorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yLmpzb24KQEAgLTg0NSwx
NSArODQ1LDYgQEAKICAgICAgICAgICAgICAgICAgICAgeyAibmFtZSI6ICJsb2NhdGlvbiIsICIk
cmVmIjogIkRlYnVnZ2VyLkxvY2F0aW9uIiwgIm9wdGlvbmFsIjogdHJ1ZSwgImRlc2NyaXB0aW9u
IjogIkhhbmRsZXIgY29kZSBsb2NhdGlvbi4iIH0KICAgICAgICAgICAgICAgICBdLAogICAgICAg
ICAgICAgICAgICJkZXNjcmlwdGlvbiI6ICJET00gaW50ZXJhY3Rpb24gaXMgaW1wbGVtZW50ZWQg
aW4gdGVybXMgb2YgbWlycm9yIG9iamVjdHMgdGhhdCByZXByZXNlbnQgdGhlIGFjdHVhbCBET00g
bm9kZXMuIERPTU5vZGUgaXMgYSBiYXNlIG5vZGUgbWlycm9yIHR5cGUuIgotICAgICAgICAgICAg
fSwKLSAgICAgICAgICAgIHsKLSAgICAgICAgICAgICAgICAiaWQiOiAiQXR0cmlidXRlcyIsCi0g
ICAgICAgICAgICAgICAgInR5cGUiOiAib2JqZWN0IiwKLSAgICAgICAgICAgICAgICAicHJvcGVy
dGllcyI6IFsKLSAgICAgICAgICAgICAgICAgICAgeyAibmFtZSI6ICJpZCIsICJ0eXBlIjogImlu
dGVnZXIiLCAiZGVzY3JpcHRpb24iOiAiRWxlbWVudCBpZCB0byBnZXQgYXR0cmlidXRlcyBmb3Iu
IiB9LAotICAgICAgICAgICAgICAgICAgICB7ICJuYW1lIjogImF0dHJpYnV0ZXMiLCAidHlwZSI6
ICJhcnJheSIsICJpdGVtcyI6IHsgInR5cGUiOiAic3RyaW5nIiB9LCAiZGVzY3JpcHRpb24iOiAi
QW4gaW50ZXJsZWF2ZWQgYXJyYXkgb2Ygbm9kZSBhdHRyaWJ1dGUgbmFtZXMgYW5kIHZhbHVlcy4i
IH0KLSAgICAgICAgICAgICAgICBdLAotICAgICAgICAgICAgICAgICJkZXNjcmlwdGlvbiI6ICJB
IGhvbGRlciBzdHJ1Y3R1cmUgZm9yIGFsbCBhdHRyaWJ1dGVzIG9mIGEgc2luZ2xlIG5vZGUuIgog
ICAgICAgICAgICAgfQogICAgICAgICBdLAogICAgICAgICAiY29tbWFuZHMiOiBbCkBAIC0xMDcw
LDEyICsxMDYxLDEyIEBACiAgICAgICAgICAgICB7CiAgICAgICAgICAgICAgICAgIm5hbWUiOiAi
Z2V0QXR0cmlidXRlcyIsCiAgICAgICAgICAgICAgICAgInBhcmFtZXRlcnMiOiBbCi0gICAgICAg
ICAgICAgICAgICAgIHsgIm5hbWUiOiAibm9kZUlkcyIsICJ0eXBlIjogImFycmF5IiwgIml0ZW1z
IjogeyAidHlwZSI6ICJpbnRlZ2VyIiB9LCAiZGVzY3JpcHRpb24iOiAiSWRzIG9mIHRoZSBub2Rl
cyB0byByZXRyaWV2ZSBhdHRpYnV0ZXMgZm9yLiIgfQorICAgICAgICAgICAgICAgICAgICB7ICJu
YW1lIjogIm5vZGVJZCIsICJ0eXBlIjogImludGVnZXIiLCAiZGVzY3JpcHRpb24iOiAiSWRzIG9m
IHRoZSBub2RlcyB0byByZXRyaWV2ZSBhdHRpYnV0ZXMgZm9yLiIgfQogICAgICAgICAgICAgICAg
IF0sCiAgICAgICAgICAgICAgICAgInJldHVybnMiOiBbCi0gICAgICAgICAgICAgICAgICAgIHsg
Im5hbWUiOiAiYXR0cmlidXRlcyIsICJ0eXBlIjogImFycmF5IiwgIml0ZW1zIjogeyAidHlwZSI6
ICJBdHRyaWJ1dGVzIiB9LCAiZGVzY3JpcHRpb24iOiAiQXR0cmlidXRlIGhvbGRlcnMgZm9yIHRo
ZSByZXF1ZXN0ZWQgbm9kZXMuIiB9CisgICAgICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAiYXR0
cmlidXRlcyIsICJ0eXBlIjogImFycmF5IiwgIml0ZW1zIjogeyAidHlwZSI6ICJzdHJpbmciIH0s
ICJkZXNjcmlwdGlvbiI6ICJBbiBpbnRlcmxlYXZlZCBhcnJheSBvZiBub2RlIGF0dHJpYnV0ZSBu
YW1lcyBhbmQgdmFsdWVzLiIgfQogICAgICAgICAgICAgICAgIF0sCi0gICAgICAgICAgICAgICAg
ImRlc2NyaXB0aW9uIjogIlJldHVybnMgYXR0cmlidXRlcyBmb3IgdGhlIHNwZWNpZmllZCBub2Rl
cy4iCisgICAgICAgICAgICAgICAgImRlc2NyaXB0aW9uIjogIlJldHVybnMgYXR0cmlidXRlcyBm
b3IgdGhlIHNwZWNpZmllZCBub2RlLiIKICAgICAgICAgICAgIH0sCiAgICAgICAgICAgICB7CiAg
ICAgICAgICAgICAgICAgIm5hbWUiOiAibW92ZVRvIiwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD
b3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw
ZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuY3BwCmluZGV4IGM5MDZlMWYyMmQ1OTkxY2QzYWI3M2Ey
MDc1MDJkZGE5YjJkYmFkYjEuLmVjM2I3Y2U0MGE4MzE3ZTE5MzJiNzFhYWUzYWYyM2E3M2FiYWI2
MGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2Vu
dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNw
cApAQCAtMTA4MCwyMSArMTA4MCwxMyBAQCB2b2lkIEluc3BlY3RvckRPTUFnZW50OjpyZXNvbHZl
Tm9kZShFcnJvclN0cmluZyogZXJyb3IsIGludCBub2RlSWQsIGNvbnN0IFN0cmluZwogICAgICpy
ZXN1bHQgPSByZXNvbHZlTm9kZShub2RlLCBvYmplY3RHcm91cE5hbWUpOwogfQogCi12b2lkIElu
c3BlY3RvckRPTUFnZW50OjpnZXRBdHRyaWJ1dGVzKEVycm9yU3RyaW5nKiwgY29uc3QgUmVmUHRy
PEluc3BlY3RvckFycmF5PiYgbm9kZUlkcywgUmVmUHRyPEluc3BlY3RvckFycmF5PiogcmVzdWx0
KQordm9pZCBJbnNwZWN0b3JET01BZ2VudDo6Z2V0QXR0cmlidXRlcyhFcnJvclN0cmluZyogZXJy
b3JTdHJpbmcsIGludCBub2RlSWQsIFJlZlB0cjxJbnNwZWN0b3JBcnJheT4qIHJlc3VsdCkKIHsK
LSAgICBmb3IgKHVuc2lnbmVkIGkgPSAwLCBzaXplID0gbm9kZUlkcy0+bGVuZ3RoKCk7IGkgPCBz
aXplOyArK2kpIHsKLSAgICAgICAgUmVmUHRyPEluc3BlY3RvclZhbHVlPiBub2RlSWRWYWx1ZSA9
IG5vZGVJZHMtPmdldChpKTsKLSAgICAgICAgaW50IG5vZGVJZDsKLSAgICAgICAgaWYgKCFub2Rl
SWRWYWx1ZS0+YXNOdW1iZXIoJm5vZGVJZCkpCi0gICAgICAgICAgICBjb250aW51ZTsKLSAgICAg
ICAgTm9kZSogbm9kZSA9IG5vZGVGb3JJZChub2RlSWQpOwotICAgICAgICBpZiAobm9kZSAmJiBu
b2RlLT5pc0VsZW1lbnROb2RlKCkpIHsKLSAgICAgICAgICAgIFJlZlB0cjxJbnNwZWN0b3JPYmpl
Y3Q+IGVudHJ5ID0gSW5zcGVjdG9yT2JqZWN0OjpjcmVhdGUoKTsKLSAgICAgICAgICAgIGVudHJ5
LT5zZXROdW1iZXIoImlkIiwgbm9kZUlkKTsKLSAgICAgICAgICAgIGVudHJ5LT5zZXRBcnJheSgi
YXR0cmlidXRlcyIsIGJ1aWxkQXJyYXlGb3JFbGVtZW50QXR0cmlidXRlcyhzdGF0aWNfY2FzdDxF
bGVtZW50Kj4obm9kZSkpKTsKLSAgICAgICAgICAgICgqcmVzdWx0KS0+cHVzaE9iamVjdChlbnRy
eS5yZWxlYXNlKCkpOwotICAgICAgICB9Ci0gICAgfQorICAgIEVsZW1lbnQqIGVsZW1lbnQgPSBh
c3NlcnRFbGVtZW50KGVycm9yU3RyaW5nLCBub2RlSWQpOworICAgIGlmICghZWxlbWVudCkKKyAg
ICAgICAgcmV0dXJuOworCisgICAgKnJlc3VsdCA9IGJ1aWxkQXJyYXlGb3JFbGVtZW50QXR0cmli
dXRlcyhlbGVtZW50KTsKIH0KIAogdm9pZCBJbnNwZWN0b3JET01BZ2VudDo6cHVzaE5vZGVUb0Zy
b250ZW5kKEVycm9yU3RyaW5nKiwgY29uc3QgU3RyaW5nJiBvYmplY3RJZCwgaW50KiBub2RlSWQp
CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQu
aCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5oCmluZGV4IDBj
OTMyNzY0NjMwNTBlYzdjZjdkMjViNzdhNDljODEzMDRkZjI0YjAuLjRjNWVmYTcyOGJiNGE1YzU1
NzUyMTIzNDNiNmJlOTQ4ZWQ0YjM1OTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3Bl
Y3Rvci9JbnNwZWN0b3JET01BZ2VudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9J
bnNwZWN0b3JET01BZ2VudC5oCkBAIC0xMjgsNyArMTI4LDcgQEAgcHVibGljOgogICAgIHZvaWQg
cGVyZm9ybVNlYXJjaChFcnJvclN0cmluZyosIGNvbnN0IFN0cmluZyYgd2hpdGVzcGFjZVRyaW1t
ZWRRdWVyeSwgY29uc3QgYm9vbCogY29uc3QgcnVuU3luY2hyb25vdXNseSk7CiAgICAgdm9pZCBj
YW5jZWxTZWFyY2goRXJyb3JTdHJpbmcqKTsKICAgICB2b2lkIHJlc29sdmVOb2RlKEVycm9yU3Ry
aW5nKiwgaW50IG5vZGVJZCwgY29uc3QgU3RyaW5nKiBjb25zdCBvYmplY3RHcm91cCwgUmVmUHRy
PEluc3BlY3Rvck9iamVjdD4qIHJlc3VsdCk7Ci0gICAgdm9pZCBnZXRBdHRyaWJ1dGVzKEVycm9y
U3RyaW5nKiwgY29uc3QgUmVmUHRyPEluc3BlY3RvckFycmF5PiYgbm9kZUlkcywgUmVmUHRyPElu
c3BlY3RvckFycmF5PiogcmVzdWx0KTsKKyAgICB2b2lkIGdldEF0dHJpYnV0ZXMoRXJyb3JTdHJp
bmcqLCBpbnQgbm9kZUlkLCBSZWZQdHI8SW5zcGVjdG9yQXJyYXk+KiByZXN1bHQpOwogICAgIHZv
aWQgc2V0SW5zcGVjdE1vZGVFbmFibGVkKEVycm9yU3RyaW5nKiwgYm9vbCBlbmFibGVkKTsKICAg
ICB2b2lkIHB1c2hOb2RlVG9Gcm9udGVuZChFcnJvclN0cmluZyosIGNvbnN0IFN0cmluZyYgb2Jq
ZWN0SWQsIGludCogbm9kZUlkKTsKICAgICB2b2lkIHB1c2hOb2RlQnlQYXRoVG9Gcm9udGVuZChF
cnJvclN0cmluZyosIGNvbnN0IFN0cmluZyYgcGF0aCwgaW50KiBub2RlSWQpOwpkaWZmIC0tZ2l0
IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9ET01BZ2VudC5qcyBiL1NvdXJj
ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRE9NQWdlbnQuanMKaW5kZXggOWNhYzhkMDE0
OWYwN2E1NGJjZWIyN2MzMGM3OGE4YjYyNDMzNjI4ZC4uYjg5MTQ1NTI5ZWU4YzNkZTlkMThlNDg4
YTlhMWU1ZTE4Yjc4ZTMxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy
b250LWVuZC9ET01BZ2VudC5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt
ZW5kL0RPTUFnZW50LmpzCkBAIC00NDYsMjQgKzQ0NiwyMSBAQCBXZWJJbnNwZWN0b3IuRE9NQWdl
bnQucHJvdG90eXBlID0gewogCiAgICAgX2xvYWROb2RlQXR0cmlidXRlczogZnVuY3Rpb24oKQog
ICAgIHsKLSAgICAgICAgZnVuY3Rpb24gY2FsbGJhY2sobm9kZUF0dHJpYnV0ZXMpCisgICAgICAg
IGZ1bmN0aW9uIGNhbGxiYWNrKG5vZGVJZCwgYXR0cmlidXRlcykKICAgICAgICAgewotICAgICAg
ICAgICAgaWYgKCFub2RlQXR0cmlidXRlcykKKyAgICAgICAgICAgIGlmICghYXR0cmlidXRlcykK
ICAgICAgICAgICAgICAgICByZXR1cm47Ci0gICAgICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8
IG5vZGVBdHRyaWJ1dGVzLmxlbmd0aDsgKytpKSB7Ci0gICAgICAgICAgICAgICAgdmFyIGVudHJ5
ID0gbm9kZUF0dHJpYnV0ZXNbaV07Ci0gICAgICAgICAgICAgICAgdmFyIG5vZGUgPSB0aGlzLl9p
ZFRvRE9NTm9kZVtlbnRyeS5pZF07Ci0gICAgICAgICAgICAgICAgbm9kZS5fc2V0QXR0cmlidXRl
c1BheWxvYWQoZW50cnkuYXR0cmlidXRlcyk7CisgICAgICAgICAgICB2YXIgbm9kZSA9IHRoaXMu
X2lkVG9ET01Ob2RlW25vZGVJZF07CisgICAgICAgICAgICBpZiAobm9kZSkgeworICAgICAgICAg
ICAgICAgIG5vZGUuX3NldEF0dHJpYnV0ZXNQYXlsb2FkKGF0dHJpYnV0ZXMpOwogICAgICAgICAg
ICAgICAgIHRoaXMuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdlYkluc3BlY3Rvci5ET01BZ2Vu
dC5FdmVudHMuQXR0ck1vZGlmaWVkLCBub2RlKTsKICAgICAgICAgICAgIH0KICAgICAgICAgfQog
CiAgICAgICAgIGRlbGV0ZSB0aGlzLl9sb2FkTm9kZUF0dHJpYnV0ZXNUaW1lb3V0OwogCi0gICAg
ICAgIHZhciBub2RlSWRzID0gW107CiAgICAgICAgIGZvciAodmFyIG5vZGVJZCBpbiB0aGlzLl9h
dHRyaWJ1dGVMb2FkTm9kZUlkcykKLSAgICAgICAgICAgIG5vZGVJZHMucHVzaChOdW1iZXIobm9k
ZUlkKSk7Ci0gICAgICAgIERPTUFnZW50LmdldEF0dHJpYnV0ZXMobm9kZUlkcywgdGhpcy5fd3Jh
cENsaWVudENhbGxiYWNrKGNhbGxiYWNrLmJpbmQodGhpcykpKTsKKyAgICAgICAgICAgIERPTUFn
ZW50LmdldEF0dHJpYnV0ZXMocGFyc2VJbnQobm9kZUlkKSwgdGhpcy5fd3JhcENsaWVudENhbGxi
YWNrKGNhbGxiYWNrLmJpbmQodGhpcywgbm9kZUlkKSkpOwogICAgICAgICB0aGlzLl9hdHRyaWJ1
dGVMb2FkTm9kZUlkcyA9IHt9OwogICAgIH0sCiAK
</data>
<flag name="review"
          id="100328"
          type_id="1"
          status="+"
          setter="aroben"
    />
          </attachment>
      

    </bug>

</bugzilla>