66541 2011-08-18 23:18:58 -0700 [webkit-gtk] Run-time error while trying to run GtkLauncher with no video support. 2011-08-19 01:58:44 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nayankk nayankk mrobinson pnormand webkit.review.bot oldest_to_newest 453663 0 nayankk 2011-08-18 23:18:58 -0700 We get following error while trying to launch GtkLauncher with video support disabled, nayankk@qtc746-01:~/Sources/WebKit$ Tools/Scripts/run-launcher --gtk --debug Starting webkit launcher. /home/nayankk/Sources/WebKit/WebKitBuild/Debug/Programs/GtkLauncher: symbol lookup error: /home/nayankk/Sources/WebKit/WebKitBuild/Debug/.libs/libwebkitgtk-1.0.so.0: undefined symbol: _ZN7WebCore14RenderThemeGtk25extraFullScreenStyleSheetEv Reason for this being, in Source/WebCore/platform/gtk/RenderThemeGtk.h file, the function virtual String extraFullScreenStyleSheet(); is declared outside the ENABLE(VIDEO) guard, however it is defined in Source/WebCore/platform/gtk/RenderThemeGtk.cpp within ENABLE(VIDEO) guard. Ideally, definition of this function should lie within ENABLE(VIDEO) conditional compilation guard. This bug is raised to fix this error. 453673 1 104469 nayankk 2011-08-19 00:02:46 -0700 Created attachment 104469 Run time error fix 453675 2 webkit.review.bot 2011-08-19 00:05:11 -0700 Attachment 104469 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:3: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:4: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:7: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 4 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 453676 3 104469 pnormand 2011-08-19 00:12:22 -0700 Comment on attachment 104469 Run time error fix The Fullscreen feature doesn't depend on VIDEO, ideally it's RenderThemeGtk.cpp that needs to be fixed. For the ChangeLog you can use the prepare-ChangeLog script :) 453680 4 nayankk 2011-08-19 00:21:46 -0700 (In reply to comment #3) > (From update of attachment 104469 [details]) > The Fullscreen feature doesn't depend on VIDEO, ideally it's RenderThemeGtk.cpp that needs to be fixed. On the first look, that was my guess too. However, when I looked at how this is being implemented in other ports, (Source/WebCore/rendering/RenderThemeChromiumMac.h, Source/WebCore/rendering/RenderThemeMac.h and Source/WebCore/rendering/RenderThemeWin.h), they seems to be implementing it the other way! Given this, which way should we follow? (Does full screen here implies full screen video?) For the ChangeLog you can use the prepare-ChangeLog script :) My emacs being the culprit here!. Will correct the patch and upload the new patch shortly! 453682 5 104473 nayankk 2011-08-19 00:44:33 -0700 Created attachment 104473 Updated patch, corrected indentation 453687 6 pnormand 2011-08-19 00:56:08 -0700 (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 104469 [details] [details]) > > The Fullscreen feature doesn't depend on VIDEO, ideally it's RenderThemeGtk.cpp that needs to be fixed. > > On the first look, that was my guess too. However, when I looked at how this is being implemented in other ports, (Source/WebCore/rendering/RenderThemeChromiumMac.h, Source/WebCore/rendering/RenderThemeMac.h and Source/WebCore/rendering/RenderThemeWin.h), they seems to be implementing it the other way! Given this, which way should we follow? (Does full screen here implies full screen video?) > Right let's do it like this then :) 453707 7 104473 webkit.review.bot 2011-08-19 01:58:40 -0700 Comment on attachment 104473 Updated patch, corrected indentation Clearing flags on attachment: 104473 Committed r93391: <http://trac.webkit.org/changeset/93391> 453708 8 webkit.review.bot 2011-08-19 01:58:44 -0700 All reviewed patches have been landed. Closing bug. 104469 2011-08-19 00:02:46 -0700 2011-08-19 00:12:21 -0700 Run time error fix 0001-Run-time-error-fix-in-WebKit-GTK-with-video-support-.patch text/plain 2195 nayankk RnJvbSA1NWEyMzYwZmIyNzc4OWJkMjEyN2I1ZDJiMGFiOWI1YzVlYmMzOTY3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOYXlhbiBLdW1hciBLIDxuYXlhbmtrQG1vdG9yb2xhLmNvbT4K RGF0ZTogRnJpLCAxOSBBdWcgMjAxMSAxMjoxMDoyNyArMDUzMApTdWJqZWN0OiBbUEFUQ0hdIFJ1 bi10aW1lIGVycm9yIGZpeCBpbiBXZWJLaXQtR1RLIHdpdGggdmlkZW8gc3VwcG9ydCBkaXNhYmxl ZC4KIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjU0MQoKRGVmaW5p dGlvbiBvZiB0aGUgZnVuY3Rpb24gZXh0cmFGdWxsU2NyZWVuU3R5bGVTaGVldCgpIGluIHdlYmtp dC1ndGsKbGllcyBvdXRzaWRlIEVOQUJMRShWSURFTykgZ3VhcmQsIHJlc3VsdGluZyBpbiBydW50 aW1lIGVycm9yIHdoaWxlCnRyeWluZyB0byBsYXVuY2ggR3RrTGF1bmNoZXIgd2l0aCB2aWRlbyBz dXBwb3J0IGRpc2FibGVkLgoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpSdW4tdGltZSBl cnJvciBmaXguIE5vIHRlc3QgY2FzZXMgd2VyZSBhZGRlZC4KCiogcGxhdGZvcm0vZ3RrL1JlbmRl clRoZW1lR3RrLmg6Ci0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAg ICAgICAgfCAgIDE1ICsrKysrKysrKysrKysrKwogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Rr L1JlbmRlclRoZW1lR3RrLmggfCAgICAyICstCiAyIGZpbGVzIGNoYW5nZWQsIDE2IGluc2VydGlv bnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGVkNjMxOWQuLmQ5Mzg0OTkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMS0wOC0xOCAgTmF5YW4gS3VtYXIgSyAgPG5h eWFua2tAbW90b3JvbGEuY29tPgorCisJUnVuLXRpbWUgZXJyb3IgZml4IGluIFdlYktpdC1HVEsg d2l0aCB2aWRlbyBzdXBwb3J0IGRpc2FibGVkLgorCWh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD02NjU0MQorCisgICAgICAgIERlZmluaXRpb24gb2YgdGhlIGZ1bmN0aW9u IGV4dHJhRnVsbFNjcmVlblN0eWxlU2hlZXQoKSBpbiB3ZWJraXQtZ3RrCisJbGllcyBvdXRzaWRl IEVOQUJMRShWSURFTykgZ3VhcmQsIHJlc3VsdGluZyBpbiBydW50aW1lIGVycm9yIHdoaWxlCisJ dHJ5aW5nIHRvIGxhdW5jaCBHdGtMYXVuY2hlciB3aXRoIHZpZGVvIHN1cHBvcnQgZGlzYWJsZWQu CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUnVuLXRp bWUgZXJyb3IgZml4LiBObyB0ZXN0IGNhc2VzIHdlcmUgYWRkZWQuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGsuaDoKKwogMjAxMS0wOC0xOCAgU2hhd24gU2luZ2ggIDxz aGF3bnNpbmdoQGNocm9taXVtLm9yZz4KIAogICAgICAgICBDb21wdXRpbmcgc2NyZWVuLXNwYWNl IHRyYW5zZm9ybSBmb3IgTGF5ZXJDaHJvbWl1bSBhbmQgQ0NMYXllckltcGwKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5oIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3RrLmgKaW5kZXggYjNiMTQ4Zi4uZGQ0ZTNh MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3Rr LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3RrLmgKQEAg LTg1LDExICs4NSwxMSBAQCBwdWJsaWM6CiAjaWYgRU5BQkxFKFZJREVPKQogICAgIHZpcnR1YWwg U3RyaW5nIGV4dHJhTWVkaWFDb250cm9sc1N0eWxlU2hlZXQoKTsKICAgICB2aXJ0dWFsIFN0cmlu ZyBmb3JtYXRNZWRpYUNvbnRyb2xzQ3VycmVudFRpbWUoZmxvYXQgY3VycmVudFRpbWUsIGZsb2F0 IGR1cmF0aW9uKSBjb25zdDsKLSNlbmRpZgogCiAjaWYgRU5BQkxFKEZVTExTQ1JFRU5fQVBJKQog ICAgIHZpcnR1YWwgU3RyaW5nIGV4dHJhRnVsbFNjcmVlblN0eWxlU2hlZXQoKTsKICNlbmRpZgor I2VuZGlmCiAKICNpZmRlZiBHVEtfQVBJX1ZFUlNJT05fMgogICAgIEd0a1dpZGdldCogZ3RrQ29u dGFpbmVyKCkgY29uc3Q7Ci0tIAoxLjcuNC4xCgo= 104473 2011-08-19 00:44:33 -0700 2011-08-19 01:58:40 -0700 Updated patch, corrected indentation 0001-Run-time-error-fix-in-WebKit-GTK-with-video-support-.patch text/plain 2223 nayankk RnJvbSBlZTM4ZWVkODI4MzZmMDBkZDI2NGQzNDgyMzJhOGNjNmM4YWExN2JjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOYXlhbiBLdW1hciBLIDxuYXlhbmtrQG1vdG9yb2xhLmNvbT4K RGF0ZTogRnJpLCAxOSBBdWcgMjAxMSAxMjoxMDoyNyArMDUzMApTdWJqZWN0OiBbUEFUQ0hdIFJ1 bi10aW1lIGVycm9yIGZpeCBpbiBXZWJLaXQtR1RLIHdpdGggdmlkZW8gc3VwcG9ydCBkaXNhYmxl ZC4KIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjU0MQoKRGVmaW5p dGlvbiBvZiB0aGUgZnVuY3Rpb24gZXh0cmFGdWxsU2NyZWVuU3R5bGVTaGVldCgpIGluIHdlYmtp dC1ndGsKbGllcyBvdXRzaWRlIEVOQUJMRShWSURFTykgZ3VhcmQsIHJlc3VsdGluZyBpbiBydW50 aW1lIGVycm9yIHdoaWxlCnRyeWluZyB0byBsYXVuY2ggR3RrTGF1bmNoZXIgd2l0aCB2aWRlbyBz dXBwb3J0IGRpc2FibGVkLgoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpSdW4tdGltZSBl cnJvciBmaXguIE5vIHRlc3QgY2FzZXMgd2VyZSBhZGRlZC4KCiogcGxhdGZvcm0vZ3RrL1JlbmRl clRoZW1lR3RrLmg6Ci0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAg ICAgICAgfCAgIDE1ICsrKysrKysrKysrKysrKwogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Rr L1JlbmRlclRoZW1lR3RrLmggfCAgICAyICstCiAyIGZpbGVzIGNoYW5nZWQsIDE2IGluc2VydGlv bnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGVkNjMxOWQuLjJmODFjMDcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMS0wOC0xOCAgTmF5YW4gS3VtYXIgSyAgPG5h eWFua2tAbW90b3JvbGEuY29tPgorCisgICAgICAgIFJ1bi10aW1lIGVycm9yIGZpeCBpbiBXZWJL aXQtR1RLIHdpdGggdmlkZW8gc3VwcG9ydCBkaXNhYmxlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2NTQxCisKKyAgICAgICAgRGVmaW5pdGlvbiBv ZiB0aGUgZnVuY3Rpb24gZXh0cmFGdWxsU2NyZWVuU3R5bGVTaGVldCgpIGluIHdlYmtpdC1ndGsK KyAgICAgICAgbGllcyBvdXRzaWRlIEVOQUJMRShWSURFTykgZ3VhcmQsIHJlc3VsdGluZyBpbiBy dW50aW1lIGVycm9yIHdoaWxlCisgICAgICAgIHRyeWluZyB0byBsYXVuY2ggR3RrTGF1bmNoZXIg d2l0aCB2aWRlbyBzdXBwb3J0IGRpc2FibGVkLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFJ1bi10aW1lIGVycm9yIGZpeC4gTm8gdGVzdCBjYXNlcyB3 ZXJlIGFkZGVkLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3RrLmg6CisK IDIwMTEtMDgtMTggIFNoYXduIFNpbmdoICA8c2hhd25zaW5naEBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgQ29tcHV0aW5nIHNjcmVlbi1zcGFjZSB0cmFuc2Zvcm0gZm9yIExheWVyQ2hyb21pdW0g YW5kIENDTGF5ZXJJbXBsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsv UmVuZGVyVGhlbWVHdGsuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVt ZUd0ay5oCmluZGV4IGIzYjE0OGYuLmRkNGUzYTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5oCkBAIC04NSwxMSArODUsMTEgQEAgcHVibGljOgogI2lm IEVOQUJMRShWSURFTykKICAgICB2aXJ0dWFsIFN0cmluZyBleHRyYU1lZGlhQ29udHJvbHNTdHls ZVNoZWV0KCk7CiAgICAgdmlydHVhbCBTdHJpbmcgZm9ybWF0TWVkaWFDb250cm9sc0N1cnJlbnRU aW1lKGZsb2F0IGN1cnJlbnRUaW1lLCBmbG9hdCBkdXJhdGlvbikgY29uc3Q7Ci0jZW5kaWYKIAog I2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkKICAgICB2aXJ0dWFsIFN0cmluZyBleHRyYUZ1bGxT Y3JlZW5TdHlsZVNoZWV0KCk7CiAjZW5kaWYKKyNlbmRpZgogCiAjaWZkZWYgR1RLX0FQSV9WRVJT SU9OXzIKICAgICBHdGtXaWRnZXQqIGd0a0NvbnRhaW5lcigpIGNvbnN0OwotLSAKMS43LjQuMQoK