66524 2011-08-18 19:59:48 -0700 Test how HTMLButtonElement.setCustomValidity reacts to too few arguments 2011-11-30 03:23:13 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66235 0 pilgrim pilgrim abarth mjs sam tkent webkit.review.bot oldest_to_newest 453566 0 pilgrim 2011-08-18 19:59:48 -0700 Test how HTMLButtonElement.setCustomValidity reacts to too few arguments 453567 1 104441 pilgrim 2011-08-18 20:00:57 -0700 Created attachment 104441 Patch 453646 2 tkent 2011-08-18 22:29:01 -0700 Existing setCustomValidity-related tests are in LayoutTests/fast/forms/. Would you merge this, Bug 66525, and Bug 66526 into one test, and move it to fast/forms/ please? 461853 3 104441 abarth 2011-09-03 14:24:57 -0700 Comment on attachment 104441 Patch I agree with Darin. Having a separate test for each of these functions is kind of overkill. Can we combine them into one (or a few) tests that exercise groups of related APIs. For example, it seems like all the setCustomValidity tests would be better combined into a single test. 510935 4 117006 pilgrim 2011-11-29 11:23:13 -0800 Created attachment 117006 Patch 510937 5 pilgrim 2011-11-29 11:23:42 -0800 *** Bug 66528 has been marked as a duplicate of this bug. *** 510939 6 pilgrim 2011-11-29 11:23:51 -0800 *** Bug 66526 has been marked as a duplicate of this bug. *** 510941 7 pilgrim 2011-11-29 11:24:06 -0800 *** Bug 66525 has been marked as a duplicate of this bug. *** 510942 8 pilgrim 2011-11-29 11:24:29 -0800 Reopening with fresh patch. 511599 9 117006 webkit.review.bot 2011-11-30 03:23:07 -0800 Comment on attachment 117006 Patch Clearing flags on attachment: 117006 Committed r101478: <http://trac.webkit.org/changeset/101478> 511600 10 webkit.review.bot 2011-11-30 03:23:13 -0800 All reviewed patches have been landed. Closing bug. 104441 2011-08-18 20:00:57 -0700 2011-11-29 11:22:57 -0800 Patch bug-66524-20110818230118.patch text/plain 2176 pilgrim SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDkzMzgzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDgtMTggIE1hcmsgUGlsZ3JpbSAgPHBp bGdyaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFRlc3QgaG93IEhUTUxCdXR0b25FbGVtZW50 LnNldEN1c3RvbVZhbGlkaXR5IHJlYWN0cyB0byB0b28gZmV3IGFyZ3VtZW50cworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY1MjQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvZG9tL0hUTUxCdXR0 b25FbGVtZW50L3NldC1jdXN0b20tdmFsaWRpdHktZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAg ICAgKiBmYXN0L2RvbS9IVE1MQnV0dG9uRWxlbWVudC9zZXQtY3VzdG9tLXZhbGlkaXR5Lmh0bWw6 IEFkZGVkLgorCiAyMDExLTA4LTE4ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4K IAogICAgICAgICBSRUdSRVNTSU9OKHI5MDk3MSk6IE51bGwgcG9pbnRlciBkZXJlZmVyZW5jZSB3 aXRoIHBsYWNlaG9sZGVyIGFuZCB3ZWJraXQtc2Nyb2xsYmFyLWNvcm5lcgpJbmRleDogTGF5b3V0 VGVzdHMvZmFzdC9kb20vSFRNTEJ1dHRvbkVsZW1lbnQvc2V0LWN1c3RvbS12YWxpZGl0eS1leHBl Y3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTEJ1dHRvbkVs ZW1lbnQvc2V0LWN1c3RvbS12YWxpZGl0eS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBM YXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MQnV0dG9uRWxlbWVudC9zZXQtY3VzdG9tLXZhbGlkaXR5 LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMCBAQAorVGVzdCBob3cgc2V0 Q3VzdG9tVmFsaWRpdHkgcmVhY3RzIHRvIHRvbyBmZXcgYXJndW1lbnRzLgorCitPbiBzdWNjZXNz LCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAi VEVTVCBDT01QTEVURSIuCisKKworUEFTUyBiLnNldEN1c3RvbVZhbGlkaXR5KCkgdGhyZXcgZXhj ZXB0aW9uIFR5cGVFcnJvcjogTm90IGVub3VnaCBhcmd1bWVudHMuCitQQVNTIHN1Y2Nlc3NmdWxs eVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpJbmRleDogTGF5b3V0VGVzdHMvZmFz dC9kb20vSFRNTEJ1dHRvbkVsZW1lbnQvc2V0LWN1c3RvbS12YWxpZGl0eS5odG1sCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxCdXR0b25FbGVtZW50L3NldC1jdXN0b20t dmFsaWRpdHkuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxC dXR0b25FbGVtZW50L3NldC1jdXN0b20tdmFsaWRpdHkuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAs MCArMSwxOCBAQAorPCFET0NUWVBFIEhUTUw+Cis8aHRtbD4KKzxoZWFkPgorPGxpbmsgcmVsPSJz dHlsZXNoZWV0IiBocmVmPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPgor PHNjcmlwdCBzcmM9Ii4uLy4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+ Cis8L2hlYWQ+Cis8Ym9keT4KKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBpZD0iY29u c29sZSI+PC9kaXY+Cis8c2NyaXB0PgorZGVzY3JpcHRpb24oJ1Rlc3QgaG93IHNldEN1c3RvbVZh bGlkaXR5IHJlYWN0cyB0byB0b28gZmV3IGFyZ3VtZW50cy4nKTsKK3ZhciBiID0gZG9jdW1lbnQu Y3JlYXRlRWxlbWVudCgnYnV0dG9uJyk7CitzaG91bGRUaHJvdygiYi5zZXRDdXN0b21WYWxpZGl0 eSgpIik7CitzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOworPC9zY3JpcHQ+Cis8c2NyaXB0IHNy Yz0iLi4vLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+ Cis8L2h0bWw+Cg== 117006 2011-11-29 11:23:13 -0800 2011-11-30 03:23:07 -0800 Patch bug-66524-20111129142330.patch text/plain 2727 pilgrim SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEwMTM5OSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDExLTExLTI5ICBNYXJrIFBpbGdyaW0gIDxw aWxncmltQGNocm9taXVtLm9yZz4KKworICAgICAgICBUZXN0IGhvdyBIVE1MQnV0dG9uRWxlbWVu dC5zZXRDdXN0b21WYWxpZGl0eSByZWFjdHMgdG8gdG9vIGZldyBhcmd1bWVudHMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2NTI0CisKKyAgICAgICAg VGhpcyBwYXRjaCBjb21iaW5lcyB0ZXN0cyBmcm9tIHRoaXMgYnVnLCBidWcgNjY1MjUsIGJ1ZyA2 NjUyNiwgYW5kIGJ1ZyA2NjUyOAorICAgICAgICBhbmQgcHV0cyB0aGVtIGluIGEgc2luZ2xlIGZp bGUgdW5kZXIgZmFzdC9mb3Jtcy8KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIGZhc3QvZm9ybXMvc2V0Q3VzdG9tVmFsaWRpdHktYXJndW1lbnRzLWV4 cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9mb3Jtcy9zZXRDdXN0b21WYWxpZGl0 eS1hcmd1bWVudHMuaHRtbDogQWRkZWQuCisKIDIwMTEtMTEtMjkgIFRvbnkgQ2hhbmcgIDx0b255 QGNocm9taXVtLm9yZz4KIAogICAgICAgICBmbGV4LWFsaWduOnN0cmV0Y2ggKyBtYXgtaGVpZ2h0 IG5lZWRzIHRvIGNsYW1wIHRvIG1heC1oZWlnaHQgYW5kIHBvc2l0aW9uIGFwcHJvcHJpYXRlbHkK SW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZm9ybXMvc2V0Q3VzdG9tVmFsaWRpdHktYXJndW1lbnRz LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NldEN1 c3RvbVZhbGlkaXR5LWFyZ3VtZW50cy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlv dXRUZXN0cy9mYXN0L2Zvcm1zL3NldEN1c3RvbVZhbGlkaXR5LWFyZ3VtZW50cy1leHBlY3RlZC50 eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTMgQEAKK1Rlc3QgaG93IHNldEN1c3RvbVZhbGlk aXR5IHJlYWN0cyB0byB0b28gZmV3IGFyZ3VtZW50cy4KKworT24gc3VjY2VzcywgeW91IHdpbGwg c2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExF VEUiLgorCisKK1BBU1MgYi5zZXRDdXN0b21WYWxpZGl0eSgpIHRocmV3IGV4Y2VwdGlvbiBUeXBl RXJyb3I6IE5vdCBlbm91Z2ggYXJndW1lbnRzLgorUEFTUyBmcy5zZXRDdXN0b21WYWxpZGl0eSgp IHRocmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6IE5vdCBlbm91Z2ggYXJndW1lbnRzLgorUEFTUyBp LnNldEN1c3RvbVZhbGlkaXR5KCkgdGhyZXcgZXhjZXB0aW9uIFR5cGVFcnJvcjogTm90IGVub3Vn aCBhcmd1bWVudHMuCitQQVNTIGsuc2V0Q3VzdG9tVmFsaWRpdHkoKSB0aHJldyBleGNlcHRpb24g VHlwZUVycm9yOiBOb3QgZW5vdWdoIGFyZ3VtZW50cy4KK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2Vk IGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1z L3NldEN1c3RvbVZhbGlkaXR5LWFyZ3VtZW50cy5odG1sCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL2Zhc3QvZm9ybXMvc2V0Q3VzdG9tVmFsaWRpdHktYXJndW1lbnRzLmh0bWwJKHJldmlzaW9u IDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NldEN1c3RvbVZhbGlkaXR5LWFyZ3VtZW50 cy5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDI0IEBACis8IURPQ1RZUEUgSFRNTD4KKzxo dG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uL2pzL3Jlc291cmNl cy9qcy10ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRl c3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9u Ij48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQ+CitkZXNjcmlwdGlvbign VGVzdCBob3cgc2V0Q3VzdG9tVmFsaWRpdHkgcmVhY3RzIHRvIHRvbyBmZXcgYXJndW1lbnRzLicp OwordmFyIGIgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdidXR0b24nKTsKK3Nob3VsZFRocm93 KCJiLnNldEN1c3RvbVZhbGlkaXR5KCkiKTsKK3ZhciBmcyA9IGRvY3VtZW50LmNyZWF0ZUVsZW1l bnQoJ2ZpZWxkc2V0Jyk7CitzaG91bGRUaHJvdygiZnMuc2V0Q3VzdG9tVmFsaWRpdHkoKSIpOwor dmFyIGkgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdpbnB1dCcpOworc2hvdWxkVGhyb3coImku c2V0Q3VzdG9tVmFsaWRpdHkoKSIpOwordmFyIGsgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdr ZXlnZW4nKTsKK3Nob3VsZFRocm93KCJrLnNldEN1c3RvbVZhbGlkaXR5KCkiKTsKK3N1Y2Nlc3Nm dWxseVBhcnNlZCA9IHRydWU7Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJj ZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K