66522 2011-08-18 19:48:23 -0700 Test how HTMLAnchorElement.getParameter reacts to too few arguments 2011-09-08 19:56:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 66235 0 pilgrim webkit-unassigned abarth mjs sam webkit.review.bot oldest_to_newest 453559 0 pilgrim 2011-08-18 19:48:23 -0700 Test how HTMLAnchorElement.getParameter reacts to too few arguments 453562 1 104440 pilgrim 2011-08-18 19:52:31 -0700 Created attachment 104440 Patch 453615 2 104440 darin 2011-08-18 21:21:39 -0700 Comment on attachment 104440 Patch Looks fine. Two comments: 1) It's probably better to have each test cover more than one function. A separate test for each function will bulk up the test directory and has few benefits. 2) Using a separate script-tests source file is a bit of an anti-pattern. Alexey Proskuryakov has pointed out that you get almost all the same benefits if you put the script directly into the HTML file. You can still use the js-test files. 464366 3 106788 pilgrim 2011-09-08 14:22:33 -0700 Created attachment 106788 Patch 464367 4 pilgrim 2011-09-08 14:23:30 -0700 Merged separate script-tests file into HTML file 464371 5 abarth 2011-09-08 14:27:21 -0700 I agree that it makes sense to merge related tests. For example, I think the plan is to put all the validity-state tests together. We'll see how these shake out. 464604 6 106788 webkit.review.bot 2011-09-08 19:56:44 -0700 Comment on attachment 106788 Patch Clearing flags on attachment: 106788 Committed r94829: <http://trac.webkit.org/changeset/94829> 464605 7 webkit.review.bot 2011-09-08 19:56:49 -0700 All reviewed patches have been landed. Closing bug. 104440 2011-08-18 19:52:31 -0700 2011-09-08 14:22:26 -0700 Patch bug-66522-20110818225252.patch text/plain 2587 pilgrim SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDkzMzgzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDgtMTggIE1hcmsgUGlsZ3JpbSAgPHBp bGdyaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFRlc3QgaG93IEhUTUxBbmNob3JFbGVtZW50 LmdldFBhcmFtZXRlciByZWFjdHMgdG8gdG9vIGZldyBhcmd1bWVudHMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2NTIyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2RvbS9IVE1MQW5jaG9yRWxl bWVudC9nZXQtcGFyYW1ldGVyLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9k b20vSFRNTEFuY2hvckVsZW1lbnQvZ2V0LXBhcmFtZXRlci5odG1sOiBBZGRlZC4KKyAgICAgICAg KiBmYXN0L2RvbS9IVE1MQW5jaG9yRWxlbWVudC9zY3JpcHQtdGVzdHMvZ2V0LXBhcmFtZXRlci5q czogQWRkZWQuCisKIDIwMTEtMDgtMTggIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFJFR1JFU1NJT04ocjkwOTcxKTogTnVsbCBwb2ludGVyIGRlcmVmZXJlbmNl IHdpdGggcGxhY2Vob2xkZXIgYW5kIHdlYmtpdC1zY3JvbGxiYXItY29ybmVyCkluZGV4OiBMYXlv dXRUZXN0cy9mYXN0L2RvbS9IVE1MQW5jaG9yRWxlbWVudC9nZXQtcGFyYW1ldGVyLWV4cGVjdGVk LnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MQW5jaG9yRWxlbWVu dC9nZXQtcGFyYW1ldGVyLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3Rz L2Zhc3QvZG9tL0hUTUxBbmNob3JFbGVtZW50L2dldC1wYXJhbWV0ZXItZXhwZWN0ZWQudHh0CShy ZXZpc2lvbiAwKQpAQCAtMCwwICsxLDEwIEBACitUZXN0IGNhbGxpbmcgZ2V0UGFyYW1ldGVyIHdp dGhvdXQgcmVxdWlyZWQgYXJndW1lbnRzLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBz ZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisK KworUEFTUyBhLmdldFBhcmFtZXRlcigpIHRocmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6IE5vdCBl bm91Z2ggYXJndW1lbnRzLgorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNU IENPTVBMRVRFCisKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxBbmNob3JFbGVtZW50 L2dldC1wYXJhbWV0ZXIuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9I VE1MQW5jaG9yRWxlbWVudC9nZXQtcGFyYW1ldGVyLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlv dXRUZXN0cy9mYXN0L2RvbS9IVE1MQW5jaG9yRWxlbWVudC9nZXQtcGFyYW1ldGVyLmh0bWwJKHJl dmlzaW9uIDApCkBAIC0wLDAgKzEsMTMgQEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVU Ri8vRFREIEhUTUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQi IGhyZWY9Ii4uLy4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0IHNy Yz0iLi4vLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4K Kzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rp dj4KKzxzY3JpcHQgc3JjPSJzY3JpcHQtdGVzdHMvZ2V0LXBhcmFtZXRlci5qcyI+PC9zY3JpcHQ+ Cis8c2NyaXB0IHNyYz0iLi4vLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3Jp cHQ+Cis8L2JvZHk+Cis8L2h0bWw+CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MQW5j aG9yRWxlbWVudC9zY3JpcHQtdGVzdHMvZ2V0LXBhcmFtZXRlci5qcwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MQW5jaG9yRWxlbWVudC9zY3JpcHQtdGVzdHMvZ2V0LXBh cmFtZXRlci5qcwkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxBbmNo b3JFbGVtZW50L3NjcmlwdC10ZXN0cy9nZXQtcGFyYW1ldGVyLmpzCShyZXZpc2lvbiAwKQpAQCAt MCwwICsxLDcgQEAKK2Rlc2NyaXB0aW9uKCdUZXN0IGNhbGxpbmcgZ2V0UGFyYW1ldGVyIHdpdGhv dXQgcmVxdWlyZWQgYXJndW1lbnRzLicpOworCit2YXIgYSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1l bnQoJ2EnKTsKKworc2hvdWxkVGhyb3coImEuZ2V0UGFyYW1ldGVyKCkiKTsKKwordmFyIHN1Y2Nl c3NmdWxseVBhcnNlZCA9IHRydWU7Cg== 106788 2011-09-08 14:22:33 -0700 2011-09-08 19:56:44 -0700 Patch bug-66522-20110908172338.patch text/plain 2104 pilgrim SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDk0Nzk4 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDkt MDggIE1hcmsgUGlsZ3JpbSAgPHBpbGdyaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFRlc3Qg aG93IEhUTUxBbmNob3JFbGVtZW50LmdldFBhcmFtZXRlciByZWFjdHMgdG8gdG9vIGZldyBhcmd1 bWVudHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2 NTIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBM YXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MQW5jaG9yRWxlbWVudC9nZXQtcGFyYW1ldGVyLWV4cGVj dGVkLnR4dDogQWRkZWQuCisgICAgICAgICogTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTEFuY2hv ckVsZW1lbnQvZ2V0LXBhcmFtZXRlci5odG1sOiBBZGRlZC4KKwogMjAxMS0wOS0wOCAgVmFydW4g SmFpbiAgPHZhcnVuamFpbkBnb29nbGUuY29tPgogCiAgICAgICAgIEltcGxlbWVudCBkb3VibGUg dGFwIGRldGVjdGlvbiBpbiBHZXN0dXJlUmVjb2duaXplckNocm9taXVtCkluZGV4OiBMYXlvdXRU ZXN0cy9mYXN0L2RvbS9IVE1MQW5jaG9yRWxlbWVudC9nZXQtcGFyYW1ldGVyLWV4cGVjdGVkLnR4 dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MQW5jaG9yRWxlbWVudC9n ZXQtcGFyYW1ldGVyLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zh c3QvZG9tL0hUTUxBbmNob3JFbGVtZW50L2dldC1wYXJhbWV0ZXItZXhwZWN0ZWQudHh0CShyZXZp c2lvbiAwKQpAQCAtMCwwICsxLDEwIEBACitUZXN0IGNhbGxpbmcgZ2V0UGFyYW1ldGVyIHdpdGhv dXQgcmVxdWlyZWQgYXJndW1lbnRzLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJp ZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKwor UEFTUyBhLmdldFBhcmFtZXRlcigpIHRocmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6IE5vdCBlbm91 Z2ggYXJndW1lbnRzLgorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENP TVBMRVRFCisKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxBbmNob3JFbGVtZW50L2dl dC1wYXJhbWV0ZXIuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1M QW5jaG9yRWxlbWVudC9nZXQtcGFyYW1ldGVyLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRU ZXN0cy9mYXN0L2RvbS9IVE1MQW5jaG9yRWxlbWVudC9nZXQtcGFyYW1ldGVyLmh0bWwJKHJldmlz aW9uIDApCkBAIC0wLDAgKzEsMjEgQEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8v RFREIEhUTUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhy ZWY9Ii4uLy4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0IHNyYz0i Li4vLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxi b2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4K KzxzY3JpcHQ+CitkZXNjcmlwdGlvbignVGVzdCBjYWxsaW5nIGdldFBhcmFtZXRlciB3aXRob3V0 IHJlcXVpcmVkIGFyZ3VtZW50cy4nKTsKKwordmFyIGEgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50 KCdhJyk7CisKK3Nob3VsZFRocm93KCJhLmdldFBhcmFtZXRlcigpIik7CisKK3ZhciBzdWNjZXNz ZnVsbHlQYXJzZWQgPSB0cnVlOworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vanMvcmVz b3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==