66516 2011-08-18 17:53:44 -0700 Add shareResources flag to 3D graphics context attributes 2011-08-23 12:31:09 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apatrick apatrick jamesr webkit.review.bot oldest_to_newest 453520 0 apatrick 2011-08-18 17:53:44 -0700 This will allow 3D graphics context implementations to share resources like textures. Contexts with the shareResources flag set to true will be in the same resource namespace. For now, WebGL does not share resource, SharedGraphicsContext3D does and the context associated with the Chromium WebView does. There will be another patch downstream in Chromium to actually implement this. 453523 1 104430 apatrick 2011-08-18 18:01:06 -0700 Created attachment 104430 Patch 1 453586 2 104430 jamesr 2011-08-18 20:27:08 -0700 Comment on attachment 104430 Patch 1 LGTM 455605 3 104430 webkit.review.bot 2011-08-23 12:31:05 -0700 Comment on attachment 104430 Patch 1 Clearing flags on attachment: 104430 Committed r93625: <http://trac.webkit.org/changeset/93625> 455607 4 webkit.review.bot 2011-08-23 12:31:09 -0700 All reviewed patches have been landed. Closing bug. 104430 2011-08-18 18:01:06 -0700 2011-08-23 12:31:05 -0700 Patch 1 shared.patch text/plain 5464 apatrick SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA5MzM3NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTEtMDgtMTggIEFsIFBhdHJpY2sgIDxhcGF0cmlja0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgQWRkIHNoYXJlUmVzb3VyY2VzIGZsYWcgdG8gM0QgZ3JhcGhpY3Mg Y29udGV4dCBhdHRyaWJ1dGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD02NjUxNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OldlYkdMUmVuZGVyaW5nQ29udGV4dDo6Y3JlYXRlKToKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRC5oOgorICAgICAgICAoV2ViQ29yZTo6 R3JhcGhpY3NDb250ZXh0M0Q6OkF0dHJpYnV0ZXM6OkF0dHJpYnV0ZXMpOgorICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL2dwdS9TaGFyZWRHcmFwaGljc0NvbnRleHQzRC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpTaGFyZWRHcmFwaGljc0NvbnRleHQzRDo6Y3JlYXRlKToKKwogMjAxMS0wOC0x OCAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+CiAKICAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2NDk1CkluZGV4OiBXZWJDb3JlL2h0bWwvY2Fu dmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1s L2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCShyZXZpc2lvbiA5MzIzNCkKKysrIFdl YkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMzYzLDYgKzM2Myw4IEBAIFBhc3NPd25QdHI8V2ViR0xSZW5kZXJpbmdDb250ZXh0PiBX ZWJHTFIKICAgICB9CiAKICAgICBhdHRyaWJ1dGVzLm5vRXh0ZW5zaW9ucyA9IHRydWU7CisgICAg YXR0cmlidXRlcy5zaGFyZVJlc291cmNlcyA9IGZhbHNlOworCiAgICAgUmVmUHRyPEdyYXBoaWNz Q29udGV4dDNEPiBjb250ZXh0KEdyYXBoaWNzQ29udGV4dDNEOjpjcmVhdGUoYXR0cmlidXRlcywg aG9zdFdpbmRvdykpOwogCiAgICAgaWYgKCFjb250ZXh0KSB7CkluZGV4OiBXZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNELmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRC5oCShyZXZpc2lvbiA5MzIzNCkKKysr IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuaAkod29ya2luZyBj b3B5KQpAQCAtNDM2LDYgKzQzNiw3IEBAIHB1YmxpYzoKICAgICAgICAgICAgICwgY2FuUmVjb3Zl ckZyb21Db250ZXh0TG9zcyh0cnVlKQogICAgICAgICAgICAgLCBwcmVzZXJ2ZURyYXdpbmdCdWZm ZXIoZmFsc2UpCiAgICAgICAgICAgICAsIG5vRXh0ZW5zaW9ucyhmYWxzZSkKKyAgICAgICAgICAg ICwgc2hhcmVSZXNvdXJjZXModHJ1ZSkKICAgICAgICAgewogICAgICAgICB9CiAKQEAgLTQ0Nyw2 ICs0NDgsNyBAQCBwdWJsaWM6CiAgICAgICAgIGJvb2wgY2FuUmVjb3ZlckZyb21Db250ZXh0TG9z czsKICAgICAgICAgYm9vbCBwcmVzZXJ2ZURyYXdpbmdCdWZmZXI7CiAgICAgICAgIGJvb2wgbm9F eHRlbnNpb25zOworICAgICAgICBib29sIHNoYXJlUmVzb3VyY2VzOwogICAgIH07CiAKICAgICBl bnVtIFJlbmRlclN0eWxlIHsKSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L1No YXJlZEdyYXBoaWNzQ29udGV4dDNELmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2dwdS9TaGFyZWRHcmFwaGljc0NvbnRleHQzRC5jcHAJKHJldmlzaW9uIDkzMjM0 KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUvU2hhcmVkR3JhcGhpY3NDb250ZXh0 M0QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNyw2ICszNyw3IEBAIEdyYXBoaWNzQ29udGV4dDNE KiBTaGFyZWRHcmFwaGljc0NvbnRleHQKICAgICBhdHRyaWJ1dGVzLnN0ZW5jaWwgPSB0cnVlOwog ICAgIGF0dHJpYnV0ZXMuYW50aWFsaWFzID0gZmFsc2U7CiAgICAgYXR0cmlidXRlcy5jYW5SZWNv dmVyRnJvbUNvbnRleHRMb3NzID0gZmFsc2U7IC8vIENhbnZhcyBjb250ZXh0cyBjYW4gbm90IGhh bmRsZSBsb3N0IGNvbnRleHRzLgorICAgIGF0dHJpYnV0ZXMuc2hhcmVSZXNvdXJjZXMgPSB0cnVl OwogICAgIHN0YXRpYyBSZWZQdHI8R3JhcGhpY3NDb250ZXh0M0Q+IGNvbnRleHQgPSBHcmFwaGlj c0NvbnRleHQzRDo6Y3JlYXRlKGF0dHJpYnV0ZXMsIHdpbmRvdyk7CiAgICAgcmV0dXJuIGNvbnRl eHQuZ2V0KCk7CiB9CkluZGV4OiBXZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzMzc3KQorKysgV2ViS2l0 L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEx LTA4LTE4ICBBbCBQYXRyaWNrICA8YXBhdHJpY2tAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFk ZCBzaGFyZVJlc291cmNlcyBmbGFnIHRvIDNEIGdyYXBoaWNzIGNvbnRleHQgYXR0cmlidXRlcwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY1MTYKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHB1YmxpYy9X ZWJHcmFwaGljc0NvbnRleHQzRC5oOgorICAgICAgICAoV2ViS2l0OjpXZWJHcmFwaGljc0NvbnRl eHQzRDo6QXR0cmlidXRlczo6QXR0cmlidXRlcyk6CisgICAgICAgICogc3JjL0dyYXBoaWNzQ29u dGV4dDNEQ2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0M0RJ bnRlcm5hbDo6aW5pdGlhbGl6ZSk6CisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmNwcDoKKyAg ICAgICAgKHN0ZDo6Z2V0Q29tcG9zaXRvckNvbnRleHRBdHRyaWJ1dGVzKToKKwogMjAxMS0wOC0x OCAgQ2hyaXMgUm9nZXJzICA8Y3JvZ2Vyc0Bnb29nbGUuY29tPgogCiAgICAgICAgIEltcGxlbWVu dCBXZWJNZWRpYVBsYXllckNsaWVudEltcGw6OmF1ZGlvU291cmNlUHJvdmlkZXIoKSBhbmQgaW50 ZXJmYWNlIGludG8gY2hyb21pdW0KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViR3Jh cGhpY3NDb250ZXh0M0QuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dl YkdyYXBoaWNzQ29udGV4dDNELmgJKHJldmlzaW9uIDkzMjM0KQorKysgV2ViS2l0L2Nocm9taXVt L3B1YmxpYy9XZWJHcmFwaGljc0NvbnRleHQzRC5oCSh3b3JraW5nIGNvcHkpCkBAIC04Niw2ICs4 Niw3IEBAIHB1YmxpYzoKICAgICAgICAgICAgICwgcHJlbXVsdGlwbGllZEFscGhhKHRydWUpCiAg ICAgICAgICAgICAsIGNhblJlY292ZXJGcm9tQ29udGV4dExvc3ModHJ1ZSkKICAgICAgICAgICAg ICwgbm9FeHRlbnNpb25zKGZhbHNlKQorICAgICAgICAgICAgLCBzaGFyZVJlc291cmNlcyh0cnVl KQogICAgICAgICB7CiAgICAgICAgIH0KIApAQCAtOTYsNiArOTcsNyBAQCBwdWJsaWM6CiAgICAg ICAgIGJvb2wgcHJlbXVsdGlwbGllZEFscGhhOwogICAgICAgICBib29sIGNhblJlY292ZXJGcm9t Q29udGV4dExvc3M7CiAgICAgICAgIGJvb2wgbm9FeHRlbnNpb25zOworICAgICAgICBib29sIHNo YXJlUmVzb3VyY2VzOwogICAgIH07CiAKICAgICBjbGFzcyBXZWJHcmFwaGljc0NvbnRleHRMb3N0 Q2FsbGJhY2sgewpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9HcmFwaGljc0NvbnRleHQzRENo cm9taXVtLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL0dyYXBoaWNzQ29u dGV4dDNEQ2hyb21pdW0uY3BwCShyZXZpc2lvbiA5MzIzNCkKKysrIFdlYktpdC9jaHJvbWl1bS9z cmMvR3JhcGhpY3NDb250ZXh0M0RDaHJvbWl1bS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExNyw2 ICsxMTcsNyBAQCBib29sIEdyYXBoaWNzQ29udGV4dDNESW50ZXJuYWw6OmluaXRpYWxpCiAgICAg d2ViQXR0cmlidXRlcy5wcmVtdWx0aXBsaWVkQWxwaGEgPSBhdHRycy5wcmVtdWx0aXBsaWVkQWxw aGE7CiAgICAgd2ViQXR0cmlidXRlcy5jYW5SZWNvdmVyRnJvbUNvbnRleHRMb3NzID0gYXR0cnMu Y2FuUmVjb3ZlckZyb21Db250ZXh0TG9zczsKICAgICB3ZWJBdHRyaWJ1dGVzLm5vRXh0ZW5zaW9u cyA9IGF0dHJzLm5vRXh0ZW5zaW9uczsKKyAgICB3ZWJBdHRyaWJ1dGVzLnNoYXJlUmVzb3VyY2Vz ID0gYXR0cnMuc2hhcmVSZXNvdXJjZXM7CiAgICAgT3duUHRyPFdlYktpdDo6V2ViR3JhcGhpY3ND b250ZXh0M0Q+IHdlYkNvbnRleHQgPSBhZG9wdFB0cihXZWJLaXQ6OndlYktpdENsaWVudCgpLT5j cmVhdGVHcmFwaGljc0NvbnRleHQzRCgpKTsKICAgICBpZiAoIXdlYkNvbnRleHQpCiAgICAgICAg IHJldHVybiBmYWxzZTsKSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCShyZXZp c2lvbiA5MzIzNCkKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xNzYsNiArMTc2LDcgQEAgR3JhcGhpY3NDb250ZXh0M0Q6OkF0dHJpYnV0 ZXMgZ2V0Q29tcG9zaQogICAgIC8vIGRpc3Bhcml0aWVzIHdlIGV4cGxpY2l0bHkgZGlzYWJsZSBh bnRpYWxpYXNpbmcuCiAgICAgR3JhcGhpY3NDb250ZXh0M0Q6OkF0dHJpYnV0ZXMgYXR0cmlidXRl czsKICAgICBhdHRyaWJ1dGVzLmFudGlhbGlhcyA9IGZhbHNlOworICAgIGF0dHJpYnV0ZXMuc2hh cmVSZXNvdXJjZXMgPSB0cnVlOwogICAgIHJldHVybiBhdHRyaWJ1dGVzOwogfQogCg==