66498 2011-08-18 14:33:56 -0700 Typesetting features need not force complex for single-character runs 2011-09-01 11:52:37 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) All All RESOLVED FIXED P2 Enhancement --- 66733 0 ned webkit-unassigned jamesr mitz webkit.review.bot oldest_to_newest 453357 0 ned 2011-08-18 14:33:56 -0700 The only typesetting features are kerning and ligatures, neither of which applies for a single character. As such, there's no need to spool up the complex text machinery for a single-character run just because the font has typesetting features. This is particularly interesting when hyphenation is enabled. 453376 1 104401 ned 2011-08-18 14:55:34 -0700 Created attachment 104401 Proposed changes. In most cases this isn't much of a problem (a percent or less) but every little bit helps. 453510 2 ned 2011-08-18 17:19:51 -0700 Running the full set of tests shows that fast/writing-mode/text-orientation-basic.html is failing with this patch, I'm investigating now. 453517 3 104428 ned 2011-08-18 17:46:21 -0700 Created attachment 104428 Diffs from failing test. 455521 4 ned 2011-08-23 11:10:16 -0700 (In reply to comment #2) > Running the full set of tests shows that fast/writing-mode/text-orientation-basic.html is failing with this patch, I'm investigating now. This should be fixed by 66733. 459923 5 ned 2011-08-31 14:27:40 -0700 As of r94090, I see no fast or svg pixel test failures due to the proposed changes. I also ran the entire suite of tests without pixel tests and saw no failures. 460313 6 104401 mitz 2011-09-01 00:59:47 -0700 Comment on attachment 104401 Proposed changes. View in context: https://bugs.webkit.org/attachment.cgi?id=104401&action=review > Source/WebCore/ChangeLog:11 > + No new tests. (OOPS!) I think this line will stop the commit bot from landing this patch 460505 7 ned 2011-09-01 09:06:12 -0700 (In reply to comment #6) > I think this line will stop the commit bot from landing this patch Oops, indeed! I will change it to note that the changes are for performance and not expected to change layout. 460516 8 105977 ned 2011-09-01 09:28:12 -0700 Created attachment 105977 Updated ChangeLog. 460565 9 105977 webkit.review.bot 2011-09-01 10:19:34 -0700 Comment on attachment 105977 Updated ChangeLog. Clearing flags on attachment: 105977 Committed r94303: <http://trac.webkit.org/changeset/94303> 460566 10 webkit.review.bot 2011-09-01 10:19:38 -0700 All reviewed patches have been landed. Closing bug. 460655 11 jamesr 2011-09-01 11:50:10 -0700 On Chromium Mac on Snow Leopard this patch caused the text metrics on fast/text/international/vertical-text-glyph-test.html to change very, very slightly. Here's the text diff: --- /b/build/slave/Webkit_Mac10_6__CG__dbg_/build/layout-test-results/fast/text/international/vertical-text-glyph-test-expected.txt +++ /b/build/slave/Webkit_Mac10_6__CG__dbg_/build/layout-test-results/fast/text/international/vertical-text-glyph-test-actual.txt @@ -1,8 +1,8 @@ -layer at (0,0) size 785x634 +layer at (0,0) size 785x635 RenderView at (0,0) size 785x600 -layer at (0,0) size 785x634 - RenderBlock {HTML} at (0,0) size 785x634 - RenderBody {BODY} at (8,21) size 769x605 +layer at (0,0) size 785x635 + RenderBlock {HTML} at (0,0) size 785x635 + RenderBody {BODY} at (8,21) size 769x606 RenderBlock {P} at (0,0) size 769x32 RenderText {#text} at (0,5) size 161x21 text run at (0,5) width 161: "Simple text path" @@ -15,8 +15,8 @@ RenderBlock {P} at (0,320) size 769x32 RenderText {#text} at (0,5) size 181x21 text run at (0,5) width 181: "Complex text path" - RenderBlock (anonymous) at (0,373) size 769x232 - RenderBlock {SPAN} at (0,0) size 32x223 - RenderText {#text} at (5,0) size 21x223 - text run at (5,0) width 223: "string\x{300C}\x{3042}\x{3001}\x{5909}\x{3063}\x{FF01}\x{300D}\x{3002}" + RenderBlock (anonymous) at (0,373) size 769x233 + RenderBlock {SPAN} at (0,0) size 32x224 + RenderText {#text} at (5,0) size 21x224 + text run at (5,0) width 224: "string\x{300C}\x{3042}\x{3001}\x{5909}\x{3063}\x{FF01}\x{300D}\x{3002}" RenderText {#text} at (0,0) size 0x0 This also changes the pixel output slightly - the text all renders the same, but the scrollbar looks different because the scrollable area is 1px taller. I'm planning to rebaseline since this looks harmless, but since the comments indicate that this should not have changed any layout posting as an FYI. 460658 12 ned 2011-09-01 11:52:37 -0700 Interesting. I wonder if there aren't some minute differences in vertical metrics on SL. 104401 2011-08-18 14:55:34 -0700 2011-09-01 09:28:12 -0700 Proposed changes. 66498-changes.txt text/plain 1353 ned SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzMzUwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDgtMTggIE5lZCBIb2xi cm9vayAgPG5ob2xicm9va0BhcHBsZS5jb20+CisKKyAgICAgICAgVHlwZXNldHRpbmcgZmVhdHVy ZXMgbmVlZCBub3QgZm9yY2UgY29tcGxleCBmb3Igc2luZ2xlLWNoYXJhY3RlciBydW5zCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjQ5OAorICAgICAg ICAKKyAgICAgICAgVHlwZXNldHRpbmcgZmVhdHVyZXMgaGF2ZSBubyBlZmZlY3Qgb24gYSBzb2xp dGFyeSBjaGFyYWN0ZXIsIHNvIHRoZXkgc2hvdWxkbid0IGVuYWJsZSBjb21wbGV4IGxheW91dAor ICAgICAgICB1bmxlc3MgbXVsdGlwbGUgY2hhcmFjdGVycyBhcmUgcHJlc2VudC4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIChP T1BTISkKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ZvbnQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6Rm9udDo6Y29kZVBhdGgpOiB0eXBlc2V0dGluZ0ZlYXR1cmVzKCkgb25seSBmb3Jj ZXMgQ29tcGxleCBmb3IgbXVsdGlwbGUtY2hhcmFjdGVyIHJ1bnMuCisKIDIwMTEtMDgtMTggIFNo ZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2 aWV3ZWQsIHJvbGxpbmcgb3V0IHI5MzMyOS4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL0ZvbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL0ZvbnQuY3BwCShyZXZpc2lvbiA5MzMyMCkKKysrIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL0ZvbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MTYsNyArNDE2LDcg QEAgRm9udDo6Q29kZVBhdGggRm9udDo6Y29kZVBhdGgoY29uc3QgVGV4dAogICAgICAgICAgICAg cmV0dXJuIENvbXBsZXg7CiAgICAgfQogCi0gICAgaWYgKHR5cGVzZXR0aW5nRmVhdHVyZXMoKSkK KyAgICBpZiAocnVuLmxlbmd0aCgpID4gMSAmJiB0eXBlc2V0dGluZ0ZlYXR1cmVzKCkpCiAgICAg ICAgIHJldHVybiBDb21wbGV4OwogCiAgICAgcmV0dXJuIHJlc3VsdDsK 104428 2011-08-18 17:46:21 -0700 2011-08-18 17:46:21 -0700 Diffs from failing test. text-orientation-basic-diffs.txt text/plain 1313 ned LS0tIC90bXAvbGF5b3V0LXRlc3QtcmVzdWx0cy9mYXN0L3dyaXRpbmctbW9kZS90ZXh0LW9yaWVu dGF0aW9uLWJhc2ljLWV4cGVjdGVkLnR4dAkyMDExLTA4LTE4IDE3OjM3OjQ0LjAwMDAwMDAwMCAt MDcwMAorKysgL3RtcC9sYXlvdXQtdGVzdC1yZXN1bHRzL2Zhc3Qvd3JpdGluZy1tb2RlL3RleHQt b3JpZW50YXRpb24tYmFzaWMtYWN0dWFsLnR4dAkyMDExLTA4LTE4IDE3OjM3OjQ0LjAwMDAwMDAw MCAtMDcwMApAQCAtNDUsMTIgKzQ1LDEyIEBACiAgICAgICAgICAgICBSZW5kZXJUZXh0IHsjdGV4 dH0gYXQgKDQ0LDEpIHNpemUgNDB4MjU1CiAgICAgICAgICAgICAgIHRleHQgcnVuIGF0ICg0NCwx KSB3aWR0aCAyNTU6ICJIZWxsbyB3b3JsZCIKICAgICAgICAgICBSZW5kZXJCUiB7QlJ9IGF0ICg1 MiwyNTYpIHNpemUgMHgwCi0gICAgICAgICAgUmVuZGVySW5saW5lIHtTUEFOfSBhdCAoMCwwKSBz aXplIDM2eDE5OAotICAgICAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICg5NCwxKSBzaXpl IDM2eDE5OAotICAgICAgICAgICAgICB0ZXh0IHJ1biBhdCAoOTQsMSkgd2lkdGggMTk4OiAiSGVs bG8gd29ybGQiCi0gICAgICAgICAgUmVuZGVyQlIge0JSfSBhdCAoMTEyLDE5OSkgc2l6ZSAweDAK LSAgICAgICAgICBSZW5kZXJJbmxpbmUge1NQQU59IGF0ICgwLDApIHNpemUgMzZ4MjIyCi0gICAg ICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDE0OCwxKSBzaXplIDM2eDIyMgotICAgICAg ICAgICAgICB0ZXh0IHJ1biBhdCAoMTQ4LDEpIHdpZHRoIDIyMjogIkhlbGxvIHdvcmxkIgotICAg ICAgICAgIFJlbmRlckJSIHtCUn0gYXQgKDE2NiwyMjMpIHNpemUgMHgwCisgICAgICAgICAgUmVu ZGVySW5saW5lIHtTUEFOfSBhdCAoMCwwKSBzaXplIDM2eDE5OQorICAgICAgICAgICAgUmVuZGVy VGV4dCB7I3RleHR9IGF0ICg5NCwxKSBzaXplIDM2eDE5OQorICAgICAgICAgICAgICB0ZXh0IHJ1 biBhdCAoOTQsMSkgd2lkdGggMTk5OiAiSGVsbG8gd29ybGQiCisgICAgICAgICAgUmVuZGVyQlIg e0JSfSBhdCAoMTEyLDE5OSkgc2l6ZSAweDEKKyAgICAgICAgICBSZW5kZXJJbmxpbmUge1NQQU59 IGF0ICgwLDApIHNpemUgMzZ4MjIzCisgICAgICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQg KDE0OCwxKSBzaXplIDM2eDIyMworICAgICAgICAgICAgICB0ZXh0IHJ1biBhdCAoMTQ4LDEpIHdp ZHRoIDIyMzogIkhlbGxvIHdvcmxkIgorICAgICAgICAgIFJlbmRlckJSIHtCUn0gYXQgKDE2Niwy MjMpIHNpemUgMHgxCiAgICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMCwwKSBzaXplIDB4 MAo= 105977 2011-09-01 09:28:12 -0700 2011-09-01 10:19:34 -0700 Updated ChangeLog. 66498-comment.txt text/plain 1382 ned SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk0MzAxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDktMDEgIE5lZCBIb2xi cm9vayAgPG5ob2xicm9va0BhcHBsZS5jb20+CisKKyAgICAgICAgVHlwZXNldHRpbmcgZmVhdHVy ZXMgbmVlZCBub3QgZm9yY2UgY29tcGxleCBmb3Igc2luZ2xlLWNoYXJhY3RlciBydW5zCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjQ5OAorCisgICAg ICAgIFR5cGVzZXR0aW5nIGZlYXR1cmVzIGhhdmUgbm8gZWZmZWN0IG9uIGEgc29saXRhcnkgY2hh cmFjdGVyLCBzbyB0aGV5IHNob3VsZG4ndCBlbmFibGUgY29tcGxleCBsYXlvdXQKKyAgICAgICAg dW5sZXNzIG11bHRpcGxlIGNoYXJhY3RlcnMgYXJlIHByZXNlbnQuCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCB0aGlzIGlzIG1l cmVseSBhIHBlcmZvcm1hbmNlIG9wdGltaXphdGlvbi4KKworICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL0ZvbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Rm9udDo6Y29kZVBhdGgpOiB0eXBl c2V0dGluZ0ZlYXR1cmVzKCkgb25seSBmb3JjZXMgQ29tcGxleCBmb3IgbXVsdGlwbGUtY2hhcmFj dGVyIHJ1bnMuCisKIDIwMTEtMDgtMzEgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgog CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NzMyMQpJ bmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udC5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udC5jcHAJKHJldmlzaW9u IDk0MDkwKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTQxNiw3ICs0MTYsNyBAQCBGb250OjpDb2RlUGF0aCBGb250Ojpjb2Rl UGF0aChjb25zdCBUZXh0CiAgICAgICAgICAgICByZXR1cm4gQ29tcGxleDsKICAgICB9CiAKLSAg ICBpZiAodHlwZXNldHRpbmdGZWF0dXJlcygpKQorICAgIGlmIChydW4ubGVuZ3RoKCkgPiAxICYm IHR5cGVzZXR0aW5nRmVhdHVyZXMoKSkKICAgICAgICAgcmV0dXJuIENvbXBsZXg7CiAKICAgICBy ZXR1cm4gcmVzdWx0Owo=