66496 2011-08-18 13:48:19 -0700 [GTK] textInputController.doCommand is not implemented 2011-09-28 10:39:24 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa webkit-unassigned cshu kaustubh.ra mrobinson webkit.review.bot oldest_to_newest 453323 0 rniwa 2011-08-18 13:48:19 -0700 textInputController hasn't been implemented on GTK's DRT yet. 453324 1 rniwa 2011-08-18 13:50:10 -0700 Due to this bug, the tests added by http://trac.webkit.org/changeset/93291 are failing. I'll add them to the skipped list for now. 474670 2 109003 kaustubh.ra 2011-09-28 04:58:03 -0700 Created attachment 109003 Patch Implementation for textInputController.doCommand 474685 3 kaustubh.ra 2011-09-28 05:38:34 -0700 Currently all the command from WebCore/editing/EditorCommand.cpp -> CommandMap entries (http://www.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/editing/EditorCommand.cpp&type=cs&l=1407) are supported. 474707 4 109003 cshu 2011-09-28 06:23:50 -0700 Comment on attachment 109003 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109003&action=review Actually, I plan to modify the password echo tests to use eventSender, if possible, instead of textInputController.doCommand so they can be widely accepted. But it's nice to have this supported on GTK anyway. thanks. > Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:601 > + return; this return can be removed. > LayoutTests/ChangeLog:3 > + Removed skipped tests under textInputController.doCommand for Gtk Port. I usually still put the title here and some brief comments below. > LayoutTests/platform/gtk/Skipped:-1548 > - It's surprising but true that doCommand is used only in the above tests and some mac-specific tests. :) 474772 5 109029 kaustubh.ra 2011-09-28 09:33:46 -0700 Created attachment 109029 Updated Patch Updated patch with Chang Shu's comments. 474774 6 kaustubh.ra 2011-09-28 09:35:08 -0700 > Actually, I plan to modify the password echo tests to use eventSender, if possible, instead of textInputController.doCommand so they can be widely accepted. But it's nice to have this supported on GTK anyway. thanks. > Thanks for that comment :) Glad to implement it. > > Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:601 > > + return; > > this return can be removed. > Done. > > LayoutTests/ChangeLog:3 > > + Removed skipped tests under textInputController.doCommand for Gtk Port. > > I usually still put the title here and some brief comments below. > Updated the changeLog. 474783 7 kaustubh.ra 2011-09-28 09:47:45 -0700 Thanks for the review Martin :) 474823 8 109029 webkit.review.bot 2011-09-28 10:39:20 -0700 Comment on attachment 109029 Updated Patch Clearing flags on attachment: 109029 Committed r96234: <http://trac.webkit.org/changeset/96234> 474824 9 webkit.review.bot 2011-09-28 10:39:24 -0700 All reviewed patches have been landed. Closing bug. 109003 2011-09-28 04:58:03 -0700 2011-09-28 09:33:46 -0700 Patch patch.txt text/plain 7069 kaustubh.ra SW5kZXg6IFNvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L2d0ay9DaGFuZ2VMb2cJKHJldmlzaW9uIDk2MjE0KQorKysgU291cmNlL1dlYktpdC9n dGsvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDktMjgg IEthdXN0dWJoIEF0cmF3YWxrYXIgIDxrYXVzdHViaEBtb3Rvcm9sYS5jb20+CisKKyAgICAgICAg W0d0a10gSW1wbGVtZW50IHRleHRJbnB1dENvbnRyb2xsZXIuZG9Db21tYW5kCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjQ5NgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvRHVt cFJlbmRlclRyZWVTdXBwb3J0R3RrLmNwcDoKKyAgICAgICAgKER1bXBSZW5kZXJUcmVlU3VwcG9y dEd0azo6ZG9Db21tYW5kKTogRnVuY3Rpb24gZGVmaW5pdGlvbiBmb3IgZG9Db21tYW5kIAorICAg ICAgICBjYWxsYmFjay4gQ29udmVydGVkIEluY29taW5nIGNvbW1hbmQgdG8gbWF0Y2ggd2l0aCBX ZWJDb3JlOjpFZGl0b3IgQ29tbWFuZE1hcC4KKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9EdW1w UmVuZGVyVHJlZVN1cHBvcnRHdGsuaDoKKwogMjAxMS0wOS0yNyAgQ2FybG9zIEdhcmNpYSBDYW1w b3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gUmVvcmdhbml6ZSBoZWFk ZXIgZmlsZXMKSW5kZXg6IFNvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5k ZXJUcmVlU3VwcG9ydEd0ay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9ndGsvV2Vi Q29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrLmNwcAkocmV2aXNpb24gOTYyMTMp CisrKyBTb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBv cnRHdGsuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NzUsNiArNTc1LDMyIEBAIHZvaWQgRHVtcFJl bmRlclRyZWVTdXBwb3J0R3RrOjpjb25maXJtQ28KICAgICBlZGl0b3ItPmNvbmZpcm1Db21wb3Np dGlvbigpOwogfQogCit2b2lkIER1bXBSZW5kZXJUcmVlU3VwcG9ydEd0azo6ZG9Db21tYW5kKFdl YktpdFdlYlZpZXcqIHdlYlZpZXcsIGNvbnN0IGNoYXIqIGNvbW1hbmQpCit7CisgICAgZ19yZXR1 cm5faWZfZmFpbChXRUJLSVRfSVNfV0VCX1ZJRVcod2ViVmlldykpOworICAgIEZyYW1lKiBmcmFt ZSA9IGNvcmUod2ViVmlldyktPmZvY3VzQ29udHJvbGxlcigpLT5mb2N1c2VkT3JNYWluRnJhbWUo KTsKKyAgICBpZiAoIWZyYW1lKQorICAgICAgICByZXR1cm47CisKKyAgICBFZGl0b3IqIGVkaXRv ciA9IGZyYW1lLT5lZGl0b3IoKTsKKyAgICBpZiAoIWVkaXRvcikKKyAgICAgICAgcmV0dXJuOwor CisgICAgU3RyaW5nIGNvbW1hbmRTdHJpbmcoY29tbWFuZCk7CisgICAgLy8gUmVtb3ZlIGVuZGlu ZyA6IGhlcmUuCisgICAgaWYgKGNvbW1hbmRTdHJpbmcuZW5kc1dpdGgoIjoiLCB0cnVlKSkKKyAg ICAgICAgY29tbWFuZFN0cmluZyA9IGNvbW1hbmRTdHJpbmcubGVmdChjb21tYW5kU3RyaW5nLmxl bmd0aCgpIC0gMSk7CisKKyAgICAvLyBNYWtlIHRoZSBmaXJzdCBjaGFyIGluIHVwcGVyIGNhc2Uu CisgICAgU3RyaW5nIGZpcnN0Q2hhciA9IGNvbW1hbmRTdHJpbmcubGVmdCgxKTsKKyAgICBjb21t YW5kU3RyaW5nID0gY29tbWFuZFN0cmluZy5yaWdodChjb21tYW5kU3RyaW5nLmxlbmd0aCgpIC0g MSk7CisgICAgZmlyc3RDaGFyLm1ha2VVcHBlcigpOworICAgIGNvbW1hbmRTdHJpbmcuaW5zZXJ0 KGZpcnN0Q2hhciwgMCk7CisKKyAgICBlZGl0b3ItPmNvbW1hbmQoY29tbWFuZFN0cmluZykuZXhl Y3V0ZSgpOworICAgIHJldHVybjsKK30KKwogYm9vbCBEdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGs6 OmZpcnN0UmVjdEZvckNoYXJhY3RlclJhbmdlKFdlYktpdFdlYlZpZXcqIHdlYlZpZXcsIGludCBs b2NhdGlvbiwgaW50IGxlbmd0aCwgY2Fpcm9fcmVjdGFuZ2xlX2ludF90KiByZWN0KQogewogICAg IGdfcmV0dXJuX3ZhbF9pZl9mYWlsKFdFQktJVF9JU19XRUJfVklFVyh3ZWJWaWV3KSwgZmFsc2Up OwpJbmRleDogU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVT dXBwb3J0R3RrLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBv cnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrLmgJKHJldmlzaW9uIDk2MjEzKQorKysgU291cmNl L1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrLmgJKHdv cmtpbmcgY29weSkKQEAgLTEwOSw3ICsxMDksNyBAQCBwdWJsaWM6CiAgICAgc3RhdGljIHZvaWQg Y29uZmlybUNvbXBvc2l0aW9uKFdlYktpdFdlYlZpZXcqLCBjb25zdCBjaGFyKik7CiAgICAgc3Rh dGljIGJvb2wgZmlyc3RSZWN0Rm9yQ2hhcmFjdGVyUmFuZ2UoV2ViS2l0V2ViVmlldyosIGludCBs b2NhdGlvbiwgaW50IGxlbmd0aCwgY2Fpcm9fcmVjdGFuZ2xlX2ludF90Kik7CiAgICAgc3RhdGlj IGJvb2wgc2VsZWN0ZWRSYW5nZShXZWJLaXRXZWJWaWV3KiwgaW50KiBzdGFydCwgaW50KiBsZW5n dGgpOwotCisgICAgc3RhdGljIHZvaWQgZG9Db21tYW5kKFdlYktpdFdlYlZpZXcqLCBjb25zdCBj aGFyKik7CiAgICAgLy8gR0MKICAgICBzdGF0aWMgdm9pZCBnY0NvbGxlY3RKYXZhc2NyaXB0T2Jq ZWN0cygpOwogICAgIHN0YXRpYyB2b2lkIGdjQ29sbGVjdEphdmFzY3JpcHRPYmplY3RzT25BbHRl cm5hdGVUaHJlYWQoYm9vbCB3YWl0VW50aWxEb25lKTsKSW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJldmlzaW9uIDk2MjE0KQorKysgVG9vbHMv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDktMjggIEth dXN0dWJoIEF0cmF3YWxrYXIgIDxrYXVzdHViaEBtb3Rvcm9sYS5jb20+CisKKyAgICAgICAgW0d0 a10gSW1wbGVtZW50IHRleHRJbnB1dENvbnRyb2xsZXIuZG9Db21tYW5kCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjQ5NgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvZ3RrL1Rl eHRJbnB1dENvbnRyb2xsZXIuY3BwOgorICAgICAgICAoZG9Db21tYW5kQ2FsbGJhY2spOiBDYWxs YmFjayBmdW5jdGlvbiBmb3IgdGV4dElucHV0Q29udHJvbGxlci5kb0NvbW1hbmQKKwogMjAxMS0w OS0yOCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAgICAgICAg W0dUS10gbWlzc2luZyBXZWJLaXQyIHN1cHBvcnQgaW4gcnVuLWd0ay10ZXN0cwpJbmRleDogVG9v bHMvRHVtcFJlbmRlclRyZWUvZ3RrL1RleHRJbnB1dENvbnRyb2xsZXIuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9UZXh0SW5wdXRDb250cm9sbGVyLmNwcAkocmV2 aXNpb24gOTYyMTMpCisrKyBUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvVGV4dElucHV0Q29udHJv bGxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE2Miw2ICsxNjIsMjUgQEAgc3RhdGljIEpTVmFs dWVSZWYgc2VsZWN0ZWRSYW5nZUNhbGxiYWNrKAogICAgIHJldHVybiBhcnJheU9iamVjdDsKIH0K IAorc3RhdGljIEpTVmFsdWVSZWYgZG9Db21tYW5kQ2FsbGJhY2soSlNDb250ZXh0UmVmIGNvbnRl eHQsIEpTT2JqZWN0UmVmIGZ1bmN0aW9uLCBKU09iamVjdFJlZiB0aGlzT2JqZWN0LCBzaXplX3Qg YXJndW1lbnRDb3VudCwgY29uc3QgSlNWYWx1ZVJlZiBhcmd1bWVudHNbXSwgSlNWYWx1ZVJlZiog ZXhjZXB0aW9uKQoreworICAgIFdlYktpdFdlYlZpZXcqIHZpZXcgPSB3ZWJraXRfd2ViX2ZyYW1l X2dldF93ZWJfdmlldyhtYWluRnJhbWUpOworICAgIEFTU0VSVCh2aWV3KTsKKyAgICBpZiAoYXJn dW1lbnRDb3VudCA8IDEpCisgICAgICAgIHJldHVybiBKU1ZhbHVlTWFrZVVuZGVmaW5lZChjb250 ZXh0KTsKKworICAgIEpTU3RyaW5nUmVmIHN0cmluZyA9IEpTVmFsdWVUb1N0cmluZ0NvcHkoY29u dGV4dCwgYXJndW1lbnRzWzBdLCBleGNlcHRpb24pOworICAgIEFTU0VSVCghZXhjZXB0aW9uIHx8 ICEqZXhjZXB0aW9uKTsKKworICAgIHNpemVfdCBidWZmZXJTaXplID0gSlNTdHJpbmdHZXRNYXhp bXVtVVRGOENTdHJpbmdTaXplKHN0cmluZyk7CisgICAgR093blB0cjxnY2hhcj4gc3RyaW5nQnVm ZmVyKHN0YXRpY19jYXN0PGdjaGFyKj4oZ19tYWxsb2MoYnVmZmVyU2l6ZSkpKTsKKyAgICBKU1N0 cmluZ0dldFVURjhDU3RyaW5nKHN0cmluZywgc3RyaW5nQnVmZmVyLmdldCgpLCBidWZmZXJTaXpl KTsKKyAgICBKU1N0cmluZ1JlbGVhc2Uoc3RyaW5nKTsKKworICAgIER1bXBSZW5kZXJUcmVlU3Vw cG9ydEd0azo6ZG9Db21tYW5kKHZpZXcsIHN0cmluZ0J1ZmZlci5nZXQoKSk7CisgICAgcmV0dXJu IEpTVmFsdWVNYWtlVW5kZWZpbmVkKGNvbnRleHQpOworfQorCiBzdGF0aWMgSlNTdGF0aWNGdW5j dGlvbiBzdGF0aWNGdW5jdGlvbnNbXSA9IHsKICAgICB7ICJzZXRNYXJrZWRUZXh0Iiwgc2V0TWFy a2VkVGV4dENhbGxiYWNrLCBrSlNQcm9wZXJ0eUF0dHJpYnV0ZVJlYWRPbmx5IHwga0pTUHJvcGVy dHlBdHRyaWJ1dGVEb250RGVsZXRlIH0sCiAgICAgeyAiaGFzTWFya2VkVGV4dCIsIGhhc01hcmtl ZFRleHRDYWxsYmFjaywga0pTUHJvcGVydHlBdHRyaWJ1dGVSZWFkT25seSB8IGtKU1Byb3BlcnR5 QXR0cmlidXRlRG9udERlbGV0ZSB9LApAQCAtMTcwLDYgKzE4OSw3IEBAIHN0YXRpYyBKU1N0YXRp Y0Z1bmN0aW9uIHN0YXRpY0Z1bmN0aW9uc1sKICAgICB7ICJ1bm1hcmtUZXh0IiwgdW5tYXJrVGV4 dENhbGxiYWNrLCBrSlNQcm9wZXJ0eUF0dHJpYnV0ZVJlYWRPbmx5IHwga0pTUHJvcGVydHlBdHRy aWJ1dGVEb250RGVsZXRlIH0sCiAgICAgeyAiZmlyc3RSZWN0Rm9yQ2hhcmFjdGVyUmFuZ2UiLCBm aXJzdFJlY3RGb3JDaGFyYWN0ZXJSYW5nZUNhbGxiYWNrLCBrSlNQcm9wZXJ0eUF0dHJpYnV0ZVJl YWRPbmx5IHwga0pTUHJvcGVydHlBdHRyaWJ1dGVEb250RGVsZXRlIH0sCiAgICAgeyAic2VsZWN0 ZWRSYW5nZSIsIHNlbGVjdGVkUmFuZ2VDYWxsYmFjaywga0pTUHJvcGVydHlBdHRyaWJ1dGVSZWFk T25seSB8IGtKU1Byb3BlcnR5QXR0cmlidXRlRG9udERlbGV0ZSB9LAorICAgIHsgImRvQ29tbWFu ZCIsIGRvQ29tbWFuZENhbGxiYWNrLCBrSlNQcm9wZXJ0eUF0dHJpYnV0ZVJlYWRPbmx5IHwga0pT UHJvcGVydHlBdHRyaWJ1dGVEb250RGVsZXRlIH0sCiAgICAgeyAwLCAwLCAwIH0KIH07CiAKSW5k ZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cJKHJldmlzaW9uIDk2MjE0KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDktMjggIEthdXN0dWJoIEF0cmF3YWxrYXIg IDxrYXVzdHViaEBtb3Rvcm9sYS5jb20+CisKKyAgICAgICAgUmVtb3ZlZCBza2lwcGVkIHRlc3Rz IHVuZGVyIHRleHRJbnB1dENvbnRyb2xsZXIuZG9Db21tYW5kIGZvciBHdGsgUG9ydC4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2NDk2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsv U2tpcHBlZDoKKwogMjAxMS0wOS0yOCAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgSW1wbGVtZW50IGEgUG9wU3RhdGVFdmVudCBjb25zdHJ1Y3RvciBmb3Ig VjgKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCShyZXZpc2lvbiA5NjIxMykKKysrIExh eW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCSh3b3JraW5nIGNvcHkpCkBAIC0xNTM5LDEz ICsxNTM5LDYgQEAgZWRpdGluZy9zcGVsbGluZy9ncmFtbWFyLmh0bWwKICMgbGF5b3V0VGVzdENv bnRyb2xsZXI6OnNldFRleHREaXJlY3Rpb24oKSBpcyBub3QgaW1wbGVtZW50ZWQuCiBmYXN0L2h0 bWwvc2V0LXRleHQtZGlyZWN0aW9uLmh0bWwKIAotIyB0ZXh0SW5wdXRDb250cm9sbGVyLmRvQ29t bWFuZCBpcyBub3QgaW1wbGVtZW50ZWQuCi0jIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD02NjQ5NgotZWRpdGluZy9pbnB1dC9wYXNzd29yZC1lY2hvLXBhc3Nub2RlLmh0 bWwKLWVkaXRpbmcvaW5wdXQvcGFzc3dvcmQtZWNoby1wYXNzbm9kZTIuaHRtbAotZWRpdGluZy9p bnB1dC9wYXNzd29yZC1lY2hvLXBhc3Nub2RlMy5odG1sCi1lZGl0aW5nL2lucHV0L3Bhc3N3b3Jk LWVjaG8tdGV4dG5vZGUuaHRtbAotCiAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD01NzE2MCAKICMgW0dUS10gbGF5b3V0VGVzdENvbnRyb2xsZXIub3ZlcnJpZGVQcmVm ZXJlbmNlKCJXZWJLaXREZWZhdWx0Rm9udFNpemUiLi4uKSBkb2VzIG5vdCB0YWtlIGludG8gYWNj b3VudCBzY3JlZW4gRFBJCiBmYXN0L2hhcm5lc3Mvb3ZlcnJpZGUtcHJlZmVyZW5jZXMtMi5odG1s Cg== 109029 2011-09-28 09:33:46 -0700 2011-09-28 10:39:20 -0700 Updated Patch patch.txt text/plain 6987 kaustubh.ra SW5kZXg6IFNvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L2d0ay9DaGFuZ2VMb2cJKHJldmlzaW9uIDk2MjI2KQorKysgU291cmNlL1dlYktpdC9n dGsvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDktMjgg IEthdXN0dWJoIEF0cmF3YWxrYXIgIDxrYXVzdHViaEBtb3Rvcm9sYS5jb20+CisKKyAgICAgICAg W0d0a10gSW1wbGVtZW50IHRleHRJbnB1dENvbnRyb2xsZXIuZG9Db21tYW5kCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjQ5NgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvRHVt cFJlbmRlclRyZWVTdXBwb3J0R3RrLmNwcDoKKyAgICAgICAgKER1bXBSZW5kZXJUcmVlU3VwcG9y dEd0azo6ZG9Db21tYW5kKTogRnVuY3Rpb24gZGVmaW5pdGlvbiBmb3IgZG9Db21tYW5kIAorICAg ICAgICBjYWxsYmFjay4gQ29udmVydGVkIEluY29taW5nIGNvbW1hbmQgdG8gbWF0Y2ggd2l0aCBX ZWJDb3JlOjpFZGl0b3IgQ29tbWFuZE1hcC4KKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9EdW1w UmVuZGVyVHJlZVN1cHBvcnRHdGsuaDoKKwogMjAxMS0wOS0yNyAgQ2FybG9zIEdhcmNpYSBDYW1w b3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gUmVvcmdhbml6ZSBoZWFk ZXIgZmlsZXMKSW5kZXg6IFNvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5k ZXJUcmVlU3VwcG9ydEd0ay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9ndGsvV2Vi Q29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrLmNwcAkocmV2aXNpb24gOTYyMjYp CisrKyBTb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBv cnRHdGsuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NzUsNiArNTc1LDMxIEBACiAgICAgZWRpdG9y LT5jb25maXJtQ29tcG9zaXRpb24oKTsKIH0KIAordm9pZCBEdW1wUmVuZGVyVHJlZVN1cHBvcnRH dGs6OmRvQ29tbWFuZChXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3LCBjb25zdCBjaGFyKiBjb21tYW5k KQoreworICAgIGdfcmV0dXJuX2lmX2ZhaWwoV0VCS0lUX0lTX1dFQl9WSUVXKHdlYlZpZXcpKTsK KyAgICBGcmFtZSogZnJhbWUgPSBjb3JlKHdlYlZpZXcpLT5mb2N1c0NvbnRyb2xsZXIoKS0+Zm9j dXNlZE9yTWFpbkZyYW1lKCk7CisgICAgaWYgKCFmcmFtZSkKKyAgICAgICAgcmV0dXJuOworCisg ICAgRWRpdG9yKiBlZGl0b3IgPSBmcmFtZS0+ZWRpdG9yKCk7CisgICAgaWYgKCFlZGl0b3IpCisg ICAgICAgIHJldHVybjsKKworICAgIFN0cmluZyBjb21tYW5kU3RyaW5nKGNvbW1hbmQpOworICAg IC8vIFJlbW92ZSBlbmRpbmcgOiBoZXJlLgorICAgIGlmIChjb21tYW5kU3RyaW5nLmVuZHNXaXRo KCI6IiwgdHJ1ZSkpCisgICAgICAgIGNvbW1hbmRTdHJpbmcgPSBjb21tYW5kU3RyaW5nLmxlZnQo Y29tbWFuZFN0cmluZy5sZW5ndGgoKSAtIDEpOworCisgICAgLy8gTWFrZSB0aGUgZmlyc3QgY2hh ciBpbiB1cHBlciBjYXNlLgorICAgIFN0cmluZyBmaXJzdENoYXIgPSBjb21tYW5kU3RyaW5nLmxl ZnQoMSk7CisgICAgY29tbWFuZFN0cmluZyA9IGNvbW1hbmRTdHJpbmcucmlnaHQoY29tbWFuZFN0 cmluZy5sZW5ndGgoKSAtIDEpOworICAgIGZpcnN0Q2hhci5tYWtlVXBwZXIoKTsKKyAgICBjb21t YW5kU3RyaW5nLmluc2VydChmaXJzdENoYXIsIDApOworCisgICAgZWRpdG9yLT5jb21tYW5kKGNv bW1hbmRTdHJpbmcpLmV4ZWN1dGUoKTsKK30KKwogYm9vbCBEdW1wUmVuZGVyVHJlZVN1cHBvcnRH dGs6OmZpcnN0UmVjdEZvckNoYXJhY3RlclJhbmdlKFdlYktpdFdlYlZpZXcqIHdlYlZpZXcsIGlu dCBsb2NhdGlvbiwgaW50IGxlbmd0aCwgY2Fpcm9fcmVjdGFuZ2xlX2ludF90KiByZWN0KQogewog ICAgIGdfcmV0dXJuX3ZhbF9pZl9mYWlsKFdFQktJVF9JU19XRUJfVklFVyh3ZWJWaWV3KSwgZmFs c2UpOwpJbmRleDogU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRy ZWVTdXBwb3J0R3RrLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1 cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrLmgJKHJldmlzaW9uIDk2MjI2KQorKysgU291 cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrLmgJ KHdvcmtpbmcgY29weSkKQEAgLTEwOSw3ICsxMDksNyBAQAogICAgIHN0YXRpYyB2b2lkIGNvbmZp cm1Db21wb3NpdGlvbihXZWJLaXRXZWJWaWV3KiwgY29uc3QgY2hhciopOwogICAgIHN0YXRpYyBi b29sIGZpcnN0UmVjdEZvckNoYXJhY3RlclJhbmdlKFdlYktpdFdlYlZpZXcqLCBpbnQgbG9jYXRp b24sIGludCBsZW5ndGgsIGNhaXJvX3JlY3RhbmdsZV9pbnRfdCopOwogICAgIHN0YXRpYyBib29s IHNlbGVjdGVkUmFuZ2UoV2ViS2l0V2ViVmlldyosIGludCogc3RhcnQsIGludCogbGVuZ3RoKTsK LQorICAgIHN0YXRpYyB2b2lkIGRvQ29tbWFuZChXZWJLaXRXZWJWaWV3KiwgY29uc3QgY2hhciop OwogICAgIC8vIEdDCiAgICAgc3RhdGljIHZvaWQgZ2NDb2xsZWN0SmF2YXNjcmlwdE9iamVjdHMo KTsKICAgICBzdGF0aWMgdm9pZCBnY0NvbGxlY3RKYXZhc2NyaXB0T2JqZWN0c09uQWx0ZXJuYXRl VGhyZWFkKGJvb2wgd2FpdFVudGlsRG9uZSk7CkluZGV4OiBUb29scy9DaGFuZ2VMb2cKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA5NjIyNikKKysrIFRvb2xzL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDExLTA5LTI4ICBLYXVzdHVi aCBBdHJhd2Fsa2FyICA8a2F1c3R1YmhAbW90b3JvbGEuY29tPgorCisgICAgICAgIFtHdGtdIElt cGxlbWVudCB0ZXh0SW5wdXRDb250cm9sbGVyLmRvQ29tbWFuZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY0OTYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2d0ay9UZXh0SW5w dXRDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKGRvQ29tbWFuZENhbGxiYWNrKTogQ2FsbGJhY2sg ZnVuY3Rpb24gZm9yIHRleHRJbnB1dENvbnRyb2xsZXIuZG9Db21tYW5kCisKIDIwMTEtMDktMjgg IENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtH VEtdIEFkZCBXZWJLaXRFcnJvciB0byBHVEsrIFdlYktpdDIgQVBJCkluZGV4OiBUb29scy9EdW1w UmVuZGVyVHJlZS9ndGsvVGV4dElucHV0Q29udHJvbGxlci5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvRHVtcFJlbmRlclRyZWUvZ3RrL1RleHRJbnB1dENvbnRyb2xsZXIuY3BwCShyZXZpc2lvbiA5 NjIyNikKKysrIFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9UZXh0SW5wdXRDb250cm9sbGVyLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTYyLDYgKzE2MiwyNSBAQAogICAgIHJldHVybiBhcnJheU9i amVjdDsKIH0KIAorc3RhdGljIEpTVmFsdWVSZWYgZG9Db21tYW5kQ2FsbGJhY2soSlNDb250ZXh0 UmVmIGNvbnRleHQsIEpTT2JqZWN0UmVmIGZ1bmN0aW9uLCBKU09iamVjdFJlZiB0aGlzT2JqZWN0 LCBzaXplX3QgYXJndW1lbnRDb3VudCwgY29uc3QgSlNWYWx1ZVJlZiBhcmd1bWVudHNbXSwgSlNW YWx1ZVJlZiogZXhjZXB0aW9uKQoreworICAgIFdlYktpdFdlYlZpZXcqIHZpZXcgPSB3ZWJraXRf d2ViX2ZyYW1lX2dldF93ZWJfdmlldyhtYWluRnJhbWUpOworICAgIEFTU0VSVCh2aWV3KTsKKyAg ICBpZiAoYXJndW1lbnRDb3VudCA8IDEpCisgICAgICAgIHJldHVybiBKU1ZhbHVlTWFrZVVuZGVm aW5lZChjb250ZXh0KTsKKworICAgIEpTU3RyaW5nUmVmIHN0cmluZyA9IEpTVmFsdWVUb1N0cmlu Z0NvcHkoY29udGV4dCwgYXJndW1lbnRzWzBdLCBleGNlcHRpb24pOworICAgIEFTU0VSVCghZXhj ZXB0aW9uIHx8ICEqZXhjZXB0aW9uKTsKKworICAgIHNpemVfdCBidWZmZXJTaXplID0gSlNTdHJp bmdHZXRNYXhpbXVtVVRGOENTdHJpbmdTaXplKHN0cmluZyk7CisgICAgR093blB0cjxnY2hhcj4g c3RyaW5nQnVmZmVyKHN0YXRpY19jYXN0PGdjaGFyKj4oZ19tYWxsb2MoYnVmZmVyU2l6ZSkpKTsK KyAgICBKU1N0cmluZ0dldFVURjhDU3RyaW5nKHN0cmluZywgc3RyaW5nQnVmZmVyLmdldCgpLCBi dWZmZXJTaXplKTsKKyAgICBKU1N0cmluZ1JlbGVhc2Uoc3RyaW5nKTsKKworICAgIER1bXBSZW5k ZXJUcmVlU3VwcG9ydEd0azo6ZG9Db21tYW5kKHZpZXcsIHN0cmluZ0J1ZmZlci5nZXQoKSk7Cisg ICAgcmV0dXJuIEpTVmFsdWVNYWtlVW5kZWZpbmVkKGNvbnRleHQpOworfQorCiBzdGF0aWMgSlNT dGF0aWNGdW5jdGlvbiBzdGF0aWNGdW5jdGlvbnNbXSA9IHsKICAgICB7ICJzZXRNYXJrZWRUZXh0 Iiwgc2V0TWFya2VkVGV4dENhbGxiYWNrLCBrSlNQcm9wZXJ0eUF0dHJpYnV0ZVJlYWRPbmx5IHwg a0pTUHJvcGVydHlBdHRyaWJ1dGVEb250RGVsZXRlIH0sCiAgICAgeyAiaGFzTWFya2VkVGV4dCIs IGhhc01hcmtlZFRleHRDYWxsYmFjaywga0pTUHJvcGVydHlBdHRyaWJ1dGVSZWFkT25seSB8IGtK U1Byb3BlcnR5QXR0cmlidXRlRG9udERlbGV0ZSB9LApAQCAtMTcwLDYgKzE4OSw3IEBACiAgICAg eyAidW5tYXJrVGV4dCIsIHVubWFya1RleHRDYWxsYmFjaywga0pTUHJvcGVydHlBdHRyaWJ1dGVS ZWFkT25seSB8IGtKU1Byb3BlcnR5QXR0cmlidXRlRG9udERlbGV0ZSB9LAogICAgIHsgImZpcnN0 UmVjdEZvckNoYXJhY3RlclJhbmdlIiwgZmlyc3RSZWN0Rm9yQ2hhcmFjdGVyUmFuZ2VDYWxsYmFj aywga0pTUHJvcGVydHlBdHRyaWJ1dGVSZWFkT25seSB8IGtKU1Byb3BlcnR5QXR0cmlidXRlRG9u dERlbGV0ZSB9LAogICAgIHsgInNlbGVjdGVkUmFuZ2UiLCBzZWxlY3RlZFJhbmdlQ2FsbGJhY2ss IGtKU1Byb3BlcnR5QXR0cmlidXRlUmVhZE9ubHkgfCBrSlNQcm9wZXJ0eUF0dHJpYnV0ZURvbnRE ZWxldGUgfSwKKyAgICB7ICJkb0NvbW1hbmQiLCBkb0NvbW1hbmRDYWxsYmFjaywga0pTUHJvcGVy dHlBdHRyaWJ1dGVSZWFkT25seSB8IGtKU1Byb3BlcnR5QXR0cmlidXRlRG9udERlbGV0ZSB9LAog ICAgIHsgMCwgMCwgMCB9CiB9OwogCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA5NjIyNikKKysrIExheW91 dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDExLTA5 LTI4ICBLYXVzdHViaCBBdHJhd2Fsa2FyICA8a2F1c3R1YmhAbW90b3JvbGEuY29tPgorCisgICAg ICAgIFtHdGtdIEltcGxlbWVudCB0ZXh0SW5wdXRDb250cm9sbGVyLmRvQ29tbWFuZAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY0OTYKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmVkIHNraXBwZWQg dGVzdHMgdW5kZXIgdGV4dElucHV0Q29udHJvbGxlci5kb0NvbW1hbmQgZm9yIEd0ayBQb3J0Lgor CisgICAgICAgICogcGxhdGZvcm0vZ3RrL1NraXBwZWQ6CisKIDIwMTEtMDktMjggIEFudGFyeWFt aSBQYW5kaWEgIDxhbnRhcnlhbWkucGFuZGlhQG1vdG9yb2xhLmNvbT4KIAogICAgICAgICBSZWZs ZWN0ZWQgYXR0cmlidXRlIGlucHV0LnNpemUgd3JhcHMgb24gbmVnYXRpdmUgdmFsdWVzIChDaHJv bWUpLCBvcgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQJKHJldmlzaW9uIDk2MjI2KQor KysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQJKHdvcmtpbmcgY29weSkKQEAgLTE1 NDUsMTMgKzE1NDUsNiBAQAogIyBsYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0VGV4dERpcmVjdGlv bigpIGlzIG5vdCBpbXBsZW1lbnRlZC4KIGZhc3QvaHRtbC9zZXQtdGV4dC1kaXJlY3Rpb24uaHRt bAogCi0jIHRleHRJbnB1dENvbnRyb2xsZXIuZG9Db21tYW5kIGlzIG5vdCBpbXBsZW1lbnRlZC4K LSMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY2NDk2Ci1lZGl0aW5n L2lucHV0L3Bhc3N3b3JkLWVjaG8tcGFzc25vZGUuaHRtbAotZWRpdGluZy9pbnB1dC9wYXNzd29y ZC1lY2hvLXBhc3Nub2RlMi5odG1sCi1lZGl0aW5nL2lucHV0L3Bhc3N3b3JkLWVjaG8tcGFzc25v ZGUzLmh0bWwKLWVkaXRpbmcvaW5wdXQvcGFzc3dvcmQtZWNoby10ZXh0bm9kZS5odG1sCi0KICMg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU3MTYwIAogIyBbR1RLXSBs YXlvdXRUZXN0Q29udHJvbGxlci5vdmVycmlkZVByZWZlcmVuY2UoIldlYktpdERlZmF1bHRGb250 U2l6ZSIuLi4pIGRvZXMgbm90IHRha2UgaW50byBhY2NvdW50IHNjcmVlbiBEUEkKIGZhc3QvaGFy bmVzcy9vdmVycmlkZS1wcmVmZXJlbmNlcy0yLmh0bWwK