66486 2011-08-18 11:09:25 -0700 "Could not find apache" reported even though apache is found 2011-08-19 09:07:06 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tomz tomz jchaffraix webkit.review.bot oldest_to_newest 453157 0 tomz 2011-08-18 11:09:25 -0700 In Tools/Scripts/webkitpy/layout_tests/port/webkit.py, there is a problem in _path_to_apache. The error message is inside the loop so it prints unless the first path is the right one. Fix is simple. Outdent _log.error one level. 453170 1 104369 tomz 2011-08-18 11:21:35 -0700 Created attachment 104369 Patch 453179 2 104369 rniwa 2011-08-18 11:26:30 -0700 Comment on attachment 104369 Patch this looks like a no-brainer so r=me. 453864 3 104369 webkit.review.bot 2011-08-19 09:07:02 -0700 Comment on attachment 104369 Patch Clearing flags on attachment: 104369 Committed r93416: <http://trac.webkit.org/changeset/93416> 453865 4 webkit.review.bot 2011-08-19 09:07:06 -0700 All reviewed patches have been landed. Closing bug. 104369 2011-08-18 11:21:35 -0700 2011-08-19 09:07:02 -0700 Patch webkit-66486-p1.patch text/plain 1202 tomz ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5NTRm NTkzLi43MTY5NWNlIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDgtMTggIFRvbSBaYWtyYWpzZWsgIDx0b216 QGNvZGVhdXJvcmEub3JnPgorCisgICAgICAgIEZpeCBfcGF0aF90b19hcGFjaGUoKSBlcnJvciBy ZXBvcnRpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTY2NDg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weToKKwogMjAxMS0w OC0xNiAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgVGVhY2ggVGVz dEZhaWx1cmVzIGhvdyB0byBpbnRlcnByZXQgdW5maW5pc2hlZCB0ZXN0IHJ1bnMKZGlmZiAtLWdp dCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5IGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXQucHkKaW5kZXgg ZjE4OGRkOC4uYTg0YzY5OCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcG9ydC93ZWJraXQucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcG9ydC93ZWJraXQucHkKQEAgLTM4NCw3ICszODQsNyBAQCBjbGFzcyBXZWJLaXRQ b3J0KFBvcnQpOgogICAgICAgICBmb3IgcGF0aCBpbiBbIi91c3Ivc2Jpbi9odHRwZCIsICIvdXNy L3NiaW4vYXBhY2hlMiJdOgogICAgICAgICAgICAgaWYgc2VsZi5fZmlsZXN5c3RlbS5leGlzdHMo cGF0aCk6CiAgICAgICAgICAgICAgICAgcmV0dXJuIHBhdGgKLSAgICAgICAgICAgIF9sb2cuZXJy b3IoIkNvdWxkIG5vdCBmaW5kIGFwYWNoZS4gTm90IGluc3RhbGxlZCBvciB1bmtub3duIHBhdGgu IikKKyAgICAgICAgX2xvZy5lcnJvcigiQ291bGQgbm90IGZpbmQgYXBhY2hlLiBOb3QgaW5zdGFs bGVkIG9yIHVua25vd24gcGF0aC4iKQogICAgICAgICByZXR1cm4gTm9uZQogCiAgICAgIyBGSVhN RTogVGhpcyBiZWxvbmdzIG9uIHNvbWUgcGxhdGZvcm0gYWJzdHJhY3Rpb24gaW5zdGVhZCBvZiBQ b3J0Lgo=