66478 2011-08-18 10:19:29 -0700 Fix rubber band gutter drawing for Skia on Chromium Mac 2011-08-18 13:23:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 caryclark caryclark asvitkine dglazkov jamesr webkit.review.bot oldest_to_newest 453107 0 caryclark 2011-08-18 10:19:29 -0700 Fix Rubber band gutter drawing for Skia on Chromium Mac 453113 1 104359 caryclark 2011-08-18 10:21:51 -0700 Created attachment 104359 Patch 453115 2 104360 caryclark 2011-08-18 10:24:31 -0700 Created attachment 104360 Patch 453116 3 webkit.review.bot 2011-08-18 10:24:44 -0700 Attachment 104359 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:13: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 453131 4 104360 jamesr 2011-08-18 10:44:30 -0700 Comment on attachment 104360 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104360&action=review > Source/WebCore/ChangeLog:9 > + No new tests. The Skia on Chromium Mac platform has > + not been enabled. We have bots for this config now, don't we? If we had bots, would they catch this issue? Is this a compile-time issue or something that shows up at runtime? 453147 5 104365 caryclark 2011-08-18 11:00:35 -0700 Created attachment 104365 Patch 453148 6 104365 jamesr 2011-08-18 11:01:22 -0700 Comment on attachment 104365 Patch R=me 453303 7 104365 webkit.review.bot 2011-08-18 13:23:09 -0700 Comment on attachment 104365 Patch Clearing flags on attachment: 104365 Committed r93343: <http://trac.webkit.org/changeset/93343> 453304 8 webkit.review.bot 2011-08-18 13:23:13 -0700 All reviewed patches have been landed. Closing bug. 104359 2011-08-18 10:21:51 -0700 2011-08-18 10:24:27 -0700 Patch bug-66478-20110818132150.patch text/plain 2001 caryclark SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzMzE3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDgtMTggIENhcnkgQ2xh cmsgIDxjYXJ5Y2xhcmtAZ29vZ2xlLmNvbT4KKworICAgICAgICBGaXggcnViYmVyIGJhbmQgZ3V0 dGVyIGRyYXdpbmcgZm9yIFNraWEgb24gQ2hyb21pdW0gTWFjCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjQ3OAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gVGhlIFNraWEgb24gQ2hy b21pdW0gTWFjIHBsYXRmb3JtIGhhcworICAgICAgICBub3QgYmVlbiBlbmFibGVkLgorCisgICAg ICAgICogcGxhdGZvcm0vY2hyb21pdW0vU2Nyb2xsYmFyVGhlbWVDaHJvbWl1bU1hYy5tbToKKyAg ICAgICAgKFdlYkNvcmU6OlNjcm9sbGJhclRoZW1lQ2hyb21pdW1NYWM6OlNjcm9sbGJhclRoZW1l Q2hyb21pdW1NYWMpOgorCUNvbnZlcnQgdGhlIENHSW1hZ2UgaW50byBhbiBTa0JpdG1hcCBpZiBT a2lhIGlzIHByZXNlbnQuCisKIDIwMTEtMDgtMTggIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2Nh QGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggY2xhbmcgbGliYysrIEMrKzB4IGJ1aWxkCkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9TY3JvbGxiYXJUaGVtZUNocm9taXVt TWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1Nj cm9sbGJhclRoZW1lQ2hyb21pdW1NYWMubW0JKHJldmlzaW9uIDkzMjAyKQorKysgU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vU2Nyb2xsYmFyVGhlbWVDaHJvbWl1bU1hYy5tbQkod29y a2luZyBjb3B5KQpAQCAtNDIsNiArNDIsNyBAQAogI2luY2x1ZGUgPHd0Zi9VbnVzZWRQYXJhbS5o PgogCiAjaWYgVVNFKFNLSUEpCisjaW5jbHVkZSAiQml0bWFwSW1hZ2VTaW5nbGVGcmFtZVNraWEu aCIKICNpbmNsdWRlICJQbGF0Zm9ybUNvbnRleHRTa2lhLmgiCiAjaW5jbHVkZSAic2tpYS9leHQv c2tpYV91dGlsc19tYWMuaCIKICNlbmRpZgpAQCAtMjAzLDcgKzIwNCwxMiBAQCBTY3JvbGxiYXJU aGVtZUNocm9taXVtTWFjOjpTY3JvbGxiYXJUaGVtCiAgICAgICAgICAgICAgICAgaWYgKHRpZmZE YXRhKSB7CiAgICAgICAgICAgICAgICAgICAgIENHSW1hZ2VTb3VyY2VSZWYgaW1hZ2VTb3VyY2Ug PSBDR0ltYWdlU291cmNlQ3JlYXRlV2l0aERhdGEoKENGRGF0YVJlZil0aWZmRGF0YSwgTlVMTCk7 CiAgICAgICAgICAgICAgICAgICAgIENHSW1hZ2VSZWYgY2dJbWFnZSA9IENHSW1hZ2VTb3VyY2VD cmVhdGVJbWFnZUF0SW5kZXgoaW1hZ2VTb3VyY2UsIDAsIE5VTEwpOworI2lmIFVTRShTS0lBKQor ICAgICAgICAgICAgICAgICAgICBTa0JpdG1hcCBiaXRtYXAgPSBnZng6OkNHSW1hZ2VUb1NrQml0 bWFwKGNnSW1hZ2UpOworICAgICAgICAgICAgICAgICAgICBSZWZQdHI8SW1hZ2U+IHBhdHRlcm5J bWFnZSA9IEJpdG1hcEltYWdlU2luZ2xlRnJhbWVTa2lhOjpjcmVhdGUoYml0bWFwLCBmYWxzZSk7 CisjZWxzZQogICAgICAgICAgICAgICAgICAgICBSZWZQdHI8SW1hZ2U+IHBhdHRlcm5JbWFnZSA9 IEJpdG1hcEltYWdlOjpjcmVhdGUoY2dJbWFnZSk7CisjZW5kaWYgICAgICAgICAgICAgICAgICAg IAogICAgICAgICAgICAgICAgICAgICBtX292ZXJoYW5nUGF0dGVybiA9IFBhdHRlcm46OmNyZWF0 ZShwYXR0ZXJuSW1hZ2UsIHRydWUsIHRydWUpOwogICAgICAgICAgICAgICAgIH0KICAgICAgICAg ICAgIH0K 104360 2011-08-18 10:24:31 -0700 2011-08-18 11:00:30 -0700 Patch bug-66478-20110818132430.patch text/plain 2008 caryclark SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzMzE3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDgtMTggIENhcnkgQ2xh cmsgIDxjYXJ5Y2xhcmtAZ29vZ2xlLmNvbT4KKworICAgICAgICBGaXggcnViYmVyIGJhbmQgZ3V0 dGVyIGRyYXdpbmcgZm9yIFNraWEgb24gQ2hyb21pdW0gTWFjCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjQ3OAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gVGhlIFNraWEgb24gQ2hy b21pdW0gTWFjIHBsYXRmb3JtIGhhcworICAgICAgICBub3QgYmVlbiBlbmFibGVkLgorCisgICAg ICAgICogcGxhdGZvcm0vY2hyb21pdW0vU2Nyb2xsYmFyVGhlbWVDaHJvbWl1bU1hYy5tbToKKyAg ICAgICAgKFdlYkNvcmU6OlNjcm9sbGJhclRoZW1lQ2hyb21pdW1NYWM6OlNjcm9sbGJhclRoZW1l Q2hyb21pdW1NYWMpOgorICAgICAgICBDb252ZXJ0IHRoZSBDR0ltYWdlIGludG8gYW4gU2tCaXRt YXAgaWYgU2tpYSBpcyBwcmVzZW50LgorCiAyMDExLTA4LTE4ICBBbmRlcnMgQ2FybHNzb24gIDxh bmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IGNsYW5nIGxpYmMrKyBDKysweCBidWls ZApJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vU2Nyb2xsYmFyVGhlbWVD aHJvbWl1bU1hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJv bWl1bS9TY3JvbGxiYXJUaGVtZUNocm9taXVtTWFjLm1tCShyZXZpc2lvbiA5MzIwMikKKysrIFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJhclRoZW1lQ2hyb21pdW1NYWMu bW0JKHdvcmtpbmcgY29weSkKQEAgLTQyLDYgKzQyLDcgQEAKICNpbmNsdWRlIDx3dGYvVW51c2Vk UGFyYW0uaD4KIAogI2lmIFVTRShTS0lBKQorI2luY2x1ZGUgIkJpdG1hcEltYWdlU2luZ2xlRnJh bWVTa2lhLmgiCiAjaW5jbHVkZSAiUGxhdGZvcm1Db250ZXh0U2tpYS5oIgogI2luY2x1ZGUgInNr aWEvZXh0L3NraWFfdXRpbHNfbWFjLmgiCiAjZW5kaWYKQEAgLTIwMyw3ICsyMDQsMTIgQEAgU2Ny b2xsYmFyVGhlbWVDaHJvbWl1bU1hYzo6U2Nyb2xsYmFyVGhlbQogICAgICAgICAgICAgICAgIGlm ICh0aWZmRGF0YSkgewogICAgICAgICAgICAgICAgICAgICBDR0ltYWdlU291cmNlUmVmIGltYWdl U291cmNlID0gQ0dJbWFnZVNvdXJjZUNyZWF0ZVdpdGhEYXRhKChDRkRhdGFSZWYpdGlmZkRhdGEs IE5VTEwpOwogICAgICAgICAgICAgICAgICAgICBDR0ltYWdlUmVmIGNnSW1hZ2UgPSBDR0ltYWdl U291cmNlQ3JlYXRlSW1hZ2VBdEluZGV4KGltYWdlU291cmNlLCAwLCBOVUxMKTsKKyNpZiBVU0Uo U0tJQSkKKyAgICAgICAgICAgICAgICAgICAgU2tCaXRtYXAgYml0bWFwID0gZ2Z4OjpDR0ltYWdl VG9Ta0JpdG1hcChjZ0ltYWdlKTsKKyAgICAgICAgICAgICAgICAgICAgUmVmUHRyPEltYWdlPiBw YXR0ZXJuSW1hZ2UgPSBCaXRtYXBJbWFnZVNpbmdsZUZyYW1lU2tpYTo6Y3JlYXRlKGJpdG1hcCwg ZmFsc2UpOworI2Vsc2UKICAgICAgICAgICAgICAgICAgICAgUmVmUHRyPEltYWdlPiBwYXR0ZXJu SW1hZ2UgPSBCaXRtYXBJbWFnZTo6Y3JlYXRlKGNnSW1hZ2UpOworI2VuZGlmICAgICAgICAgICAg ICAgICAgICAKICAgICAgICAgICAgICAgICAgICAgbV9vdmVyaGFuZ1BhdHRlcm4gPSBQYXR0ZXJu OjpjcmVhdGUocGF0dGVybkltYWdlLCB0cnVlLCB0cnVlKTsKICAgICAgICAgICAgICAgICB9CiAg ICAgICAgICAgICB9Cg== 104365 2011-08-18 11:00:35 -0700 2011-08-18 13:23:09 -0700 Patch bug-66478-20110818140034.patch text/plain 2098 caryclark SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzMzE3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDgtMTggIENhcnkgQ2xh cmsgIDxjYXJ5Y2xhcmtAZ29vZ2xlLmNvbT4KKworICAgICAgICBGaXggcnViYmVyIGJhbmQgZ3V0 dGVyIGRyYXdpbmcgZm9yIFNraWEgb24gQ2hyb21pdW0gTWFjCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjQ3OAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gVGhlIFNraWEgb24gQ2hy b21pdW0gTWFjIHBsYXRmb3JtIGhhcworICAgICAgICBub3QgYmVlbiBlbmFibGVkLgorCisgICAg ICAgIFRoaXMgYnJlYWsgd2FzIGRldGVjdGVkIGF0IGNvbXBpbGUgdGltZTsgdGhlcmUgaXMgbm8K KyAgICAgICAgYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0v U2Nyb2xsYmFyVGhlbWVDaHJvbWl1bU1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGJh clRoZW1lQ2hyb21pdW1NYWM6OlNjcm9sbGJhclRoZW1lQ2hyb21pdW1NYWMpOgorICAgICAgICBD b252ZXJ0IHRoZSBDR0ltYWdlIGludG8gYW4gU2tCaXRtYXAgaWYgU2tpYSBpcyBwcmVzZW50Lgor CiAyMDExLTA4LTE4ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAg ICAgICAgRml4IGNsYW5nIGxpYmMrKyBDKysweCBidWlsZApJbmRleDogU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vY2hyb21pdW0vU2Nyb2xsYmFyVGhlbWVDaHJvbWl1bU1hYy5tbQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9TY3JvbGxiYXJUaGVtZUNocm9t aXVtTWFjLm1tCShyZXZpc2lvbiA5MzIwMikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2No cm9taXVtL1Njcm9sbGJhclRoZW1lQ2hyb21pdW1NYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTQy LDYgKzQyLDcgQEAKICNpbmNsdWRlIDx3dGYvVW51c2VkUGFyYW0uaD4KIAogI2lmIFVTRShTS0lB KQorI2luY2x1ZGUgIkJpdG1hcEltYWdlU2luZ2xlRnJhbWVTa2lhLmgiCiAjaW5jbHVkZSAiUGxh dGZvcm1Db250ZXh0U2tpYS5oIgogI2luY2x1ZGUgInNraWEvZXh0L3NraWFfdXRpbHNfbWFjLmgi CiAjZW5kaWYKQEAgLTIwMyw3ICsyMDQsMTIgQEAgU2Nyb2xsYmFyVGhlbWVDaHJvbWl1bU1hYzo6 U2Nyb2xsYmFyVGhlbQogICAgICAgICAgICAgICAgIGlmICh0aWZmRGF0YSkgewogICAgICAgICAg ICAgICAgICAgICBDR0ltYWdlU291cmNlUmVmIGltYWdlU291cmNlID0gQ0dJbWFnZVNvdXJjZUNy ZWF0ZVdpdGhEYXRhKChDRkRhdGFSZWYpdGlmZkRhdGEsIE5VTEwpOwogICAgICAgICAgICAgICAg ICAgICBDR0ltYWdlUmVmIGNnSW1hZ2UgPSBDR0ltYWdlU291cmNlQ3JlYXRlSW1hZ2VBdEluZGV4 KGltYWdlU291cmNlLCAwLCBOVUxMKTsKKyNpZiBVU0UoU0tJQSkKKyAgICAgICAgICAgICAgICAg ICAgU2tCaXRtYXAgYml0bWFwID0gZ2Z4OjpDR0ltYWdlVG9Ta0JpdG1hcChjZ0ltYWdlKTsKKyAg ICAgICAgICAgICAgICAgICAgUmVmUHRyPEltYWdlPiBwYXR0ZXJuSW1hZ2UgPSBCaXRtYXBJbWFn ZVNpbmdsZUZyYW1lU2tpYTo6Y3JlYXRlKGJpdG1hcCwgZmFsc2UpOworI2Vsc2UKICAgICAgICAg ICAgICAgICAgICAgUmVmUHRyPEltYWdlPiBwYXR0ZXJuSW1hZ2UgPSBCaXRtYXBJbWFnZTo6Y3Jl YXRlKGNnSW1hZ2UpOworI2VuZGlmICAgICAgICAgICAgICAgICAgICAKICAgICAgICAgICAgICAg ICAgICAgbV9vdmVyaGFuZ1BhdHRlcm4gPSBQYXR0ZXJuOjpjcmVhdGUocGF0dGVybkltYWdlLCB0 cnVlLCB0cnVlKTsKICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9Cg==