66475 2011-08-18 09:54:32 -0700 Fix clang libc++ C++0x build 2011-08-18 10:47:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 453094 0 andersca 2011-08-18 09:54:32 -0700 Fix clang libc++ C++0x build 453095 1 104353 andersca 2011-08-18 09:55:33 -0700 Created attachment 104353 Patch 453096 2 andersca 2011-08-18 09:56:24 -0700 Committed r93316: <http://trac.webkit.org/changeset/93316> 453136 3 104353 darin 2011-08-18 10:47:29 -0700 Comment on attachment 104353 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104353&action=review > Source/WebCore/html/canvas/WebGLRenderingContext.cpp:-3907 > - if (isnan(width)) > - width = 100; > - if (isnan(height)) > - height = 100; I think this indicates a bug. We are probably making width and height be 0 if you pass undefined from JavaScript rather than 100. Someone working on WebGL should probably look into this and make a test case. 104353 2011-08-18 09:55:33 -0700 2011-08-18 10:47:29 -0700 Patch bug-66475-20110818095531.patch text/plain 1976 andersca SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzMzE1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDgtMTggIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggY2xhbmcgbGliYysr IEMrKzB4IGJ1aWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02NjQ3NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFJlbW92ZSBjYWxscyB0byBpc25hbiBhbmQgaXNmaW5pdGUgd2l0aCBpbnRlZ2VyIGFyZ3Vt ZW50cy4KKworICAgICAgICAqIGNzcy9DU1NQcmltaXRpdmVWYWx1ZS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTUHJpbWl0aXZlVmFsdWUpOgorICAgICAgICAq IGh0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OnZpZXdwb3J0KToKKwogMjAxMS0wOC0xOCAgQW5kcmV5 IEtvc3lha292ICA8Y2FzZXFAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6 IFtFeHRlbnNpb25zIEFQSV0gcmVuYW1lIHdlYkluc3BlY3Rvci5yZXNvdXJjZXMgdG8gd2ViSW5z cGVjdG9yLm5ldHdvcmsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1 ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVl LmNwcAkocmV2aXNpb24gOTMzMTEpCisrKyBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJpbWl0aXZl VmFsdWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNTksNyArMTU5LDYgQEAgQ1NTUHJpbWl0aXZl VmFsdWU6OkNTU1ByaW1pdGl2ZVZhbHVlKGNvbgogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAg IGNhc2UgV2ViQ29yZTo6Rml4ZWQ6CiAgICAgICAgICAgICBtX3R5cGUgPSBDU1NfUFg7Ci0gICAg ICAgICAgICBBU1NFUlQoaXNmaW5pdGUobGVuZ3RoLnZhbHVlKCkpKTsKICAgICAgICAgICAgIG1f dmFsdWUubnVtID0gbGVuZ3RoLnZhbHVlKCk7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAg Y2FzZSBJbnRyaW5zaWM6CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJl bmRlcmluZ0NvbnRleHQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvY2Fu dmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAJKHJldmlzaW9uIDkzMzExKQorKysgU291cmNl L1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcAkod29ya2luZyBj b3B5KQpAQCAtMzg5NywxNCArMzg5Nyw2IEBAIHZvaWQgV2ViR0xSZW5kZXJpbmdDb250ZXh0Ojp2 aWV3cG9ydChHQzMKIHsKICAgICBpZiAoaXNDb250ZXh0TG9zdCgpKQogICAgICAgICByZXR1cm47 Ci0gICAgaWYgKGlzbmFuKHgpKQotICAgICAgICB4ID0gMDsKLSAgICBpZiAoaXNuYW4oeSkpCi0g ICAgICAgIHkgPSAwOwotICAgIGlmIChpc25hbih3aWR0aCkpCi0gICAgICAgIHdpZHRoID0gMTAw OwotICAgIGlmIChpc25hbihoZWlnaHQpKQotICAgICAgICBoZWlnaHQgPSAxMDA7CiAgICAgaWYg KCF2YWxpZGF0ZVNpemUod2lkdGgsIGhlaWdodCkpCiAgICAgICAgIHJldHVybjsKICAgICBtX2Nv bnRleHQtPnZpZXdwb3J0KHgsIHksIHdpZHRoLCBoZWlnaHQpOwo=