66471 2011-08-18 08:45:20 -0700 [GTK] [WK2] Activating sub menus cause the WebProcess to crash 2011-08-18 11:49:38 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 amruthraj webkit-unassigned andersca mrobinson ravi.kasibhatla sam webkit.review.bot xan.lopez oldest_to_newest 453068 0 amruthraj 2011-08-18 08:45:20 -0700 Context menu items which are actionable should only connect to activate signal. Connecting sub-menu item to "activate" signal would trigger sending of DidSelectItemFromActiveContextMenu to WebProcess. WebProcess then assumes that a click has happened and destroys the context menu, further leading to a crash. 453071 1 104348 amruthraj 2011-08-18 08:48:26 -0700 Created attachment 104348 Fix submenu activation crash in WebKit2 GTK 453202 2 104348 webkit.review.bot 2011-08-18 11:49:34 -0700 Comment on attachment 104348 Fix submenu activation crash in WebKit2 GTK Clearing flags on attachment: 104348 Committed r93327: <http://trac.webkit.org/changeset/93327> 453203 3 webkit.review.bot 2011-08-18 11:49:38 -0700 All reviewed patches have been landed. Closing bug. 104348 2011-08-18 08:48:26 -0700 2011-08-18 11:49:33 -0700 Fix submenu activation crash in WebKit2 GTK fix-66471.patch text/plain 1511 amruthraj SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzMzEwKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDgtMTggIEFtcnV0aCBS YWogIDxhbXJ1dGhyYWpAbW90b3JvbGEuY29tPgorCisgICAgICAgIFtHVEtdIFtXSzJdIEFjdGl2 YXRpbmcgc3ViIG1lbnVzIGNhdXNlIHRoZSBXZWJQcm9jZXNzIHRvIGNyYXNoCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NjQ3MQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL2d0ay9XZWJD b250ZXh0TWVudVByb3h5R3RrLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViQ29udGV4dE1lbnVQ cm94eUd0azo6Y3JlYXRlR3RrTWVudSk6CisKIDIwMTEtMDgtMTcgIEFkYW0gUm9iZW4gIDxhcm9i ZW5AYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgV2ViQ29yZSBrZWVwIHRyYWNrIG9mIHRoZSBj dXJyZW50IGRldmljZSBzY2FsZSBmYWN0b3IKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9ndGsvV2ViQ29udGV4dE1lbnVQcm94eUd0ay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL2d0ay9XZWJDb250ZXh0TWVudVByb3h5R3RrLmNwcAkocmV2aXNpb24g OTMyMDMpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYkNvbnRleHRNZW51UHJv eHlHdGsuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01OCw3ICs1OCw3IEBAIEd0a01lbnUqIFdlYkNv bnRleHRNZW51UHJveHlHdGs6OmNyZWF0ZUcKICAgICAgICAgQ29udGV4dE1lbnVJdGVtIG1lbnVJ dGVtKGl0ZW0udHlwZSgpLCBpdGVtLmFjdGlvbigpLCBpdGVtLnRpdGxlKCksIGl0ZW0uZW5hYmxl ZCgpLCBpdGVtLmNoZWNrZWQoKSk7CiAgICAgICAgIEd0a0FjdGlvbiogYWN0aW9uID0gbWVudUl0 ZW0uZ3RrQWN0aW9uKCk7CiAKLSAgICAgICAgaWYgKGFjdGlvbikgeworICAgICAgICBpZiAoYWN0 aW9uICYmIChpdGVtLnR5cGUoKSA9PSBXZWJDb3JlOjpBY3Rpb25UeXBlIHx8IGl0ZW0udHlwZSgp ID09IFdlYkNvcmU6OkNoZWNrYWJsZUFjdGlvblR5cGUpKSB7CiAgICAgICAgICAgICBnX29iamVj dF9zZXRfZGF0YShHX09CSkVDVChhY3Rpb24pLCBnQ29udGV4dE1lbnVBY3Rpb25JZCwgR0lOVF9U T19QT0lOVEVSKGl0ZW0uYWN0aW9uKCkpKTsKICAgICAgICAgICAgIGdfc2lnbmFsX2Nvbm5lY3Qo YWN0aW9uLCAiYWN0aXZhdGUiLCBHX0NBTExCQUNLKGNvbnRleHRNZW51SXRlbUFjdGl2YXRlZENh bGxiYWNrKSwgbV9wYWdlKTsKICAgICAgICAgfQo=