66470 2011-08-18 08:20:06 -0700 IDBSQLiteBackingStore::deleteObjectStore should maintain referential integrity 2011-08-19 05:13:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jochen jochen dgrogan hans tonyg webkit.review.bot oldest_to_newest 453052 0 jochen 2011-08-18 08:20:06 -0700 Delete object store data while maintaining referential integrity 453053 1 104345 jochen 2011-08-18 08:20:26 -0700 Created attachment 104345 Patch 453124 2 ap 2011-08-18 10:37:57 -0700 I had difficulty parsing the bug title, so re-titling for others' benefit. Please correct it if I misunderstood something. 453138 3 jochen 2011-08-18 10:51:59 -0700 no, you're right. thanks for updating the title 453141 4 104364 jochen 2011-08-18 10:53:47 -0700 Created attachment 104364 Patch 453188 5 dgrogan 2011-08-18 11:34:03 -0700 LGTM Was sqlite returning an error because the references would be broken? 453192 6 jochen 2011-08-18 11:37:01 -0700 (In reply to comment #5) > LGTM > > Was sqlite returning an error because the references would be broken? I don't know, it just occurred to me while working on that file that this is broken. doDelete doesn't do error checking :( and I think we don't check that code at all, as the layoutTests are executed with the leveldb backend afaik double-:( 453751 7 104364 webkit.review.bot 2011-08-19 05:13:34 -0700 Comment on attachment 104364 Patch Clearing flags on attachment: 104364 Committed r93395: <http://trac.webkit.org/changeset/93395> 453752 8 webkit.review.bot 2011-08-19 05:13:38 -0700 All reviewed patches have been landed. Closing bug. 104345 2011-08-18 08:20:26 -0700 2011-08-18 10:53:42 -0700 Patch bug-66470-20110818172024.patch text/plain 1806 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogOTMxOTUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiNTM4Y2VjOWM2ZDEyNzM4 YWZjYzdmOTRlM2JhY2E5NDlkZDcwYjRiLi43NjkwZGY1MDc0MTUwZDNjMzFkMDBkYzg2YTc0NjFj OWRlZWM4NjJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDgtMTggIEpvY2hl biBFaXNpbmdlciAgPGpvY2hlbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRGVsZXRlIG9iamVj dCBzdG9yZSBkYXRhIHdoaWxlIG1haW50YWluaW5nIHJlZmVyZW50aWFsIGludGVncml0eQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY0NzAKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0b3JhZ2UvSURC U1FMaXRlQmFja2luZ1N0b3JlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OklEQlNRTGl0ZUJhY2tp bmdTdG9yZTo6ZGVsZXRlT2JqZWN0U3RvcmUpOgorCiAyMDExLTA4LTE2ICBMdWtlIE1hY3BoZXJz b24gICA8bWFjcGhlcnNvbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmVwcmVzZW50IFJlbmRl clN0eWxlOjp0ZXh0T3ZlcmZsb3cgcHJvcGVydHkgdXNpbmcgYW4gZW51bSBpbnN0ZWFkIG9mIGEg Ym9vbC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvSURCU1FMaXRlQmFja2lu Z1N0b3JlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvSURCU1FMaXRlQmFja2luZ1N0b3Jl LmNwcAppbmRleCBkZDA2NWQ0YjMyMWQ1OTA0ZmU4YTdkYmE2ZTdkNDRkNTI0MmU1N2NiLi4zNDYx NzYwYmQwOGM4YmU4ZmExYmNhOGY4M2IzNzA2ZmI3ZGQ5NTFmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9zdG9yYWdlL0lEQlNRTGl0ZUJhY2tpbmdTdG9yZS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvc3RvcmFnZS9JREJTUUxpdGVCYWNraW5nU3RvcmUuY3BwCkBAIC0yOTMsMTAgKzI5Mywx MCBAQCBzdGF0aWMgdm9pZCBkb0RlbGV0ZShTUUxpdGVEYXRhYmFzZSYgZGIsIGNvbnN0IGNoYXIq IHNxbCwgaW50NjRfdCBpZCkKIAogdm9pZCBJREJTUUxpdGVCYWNraW5nU3RvcmU6OmRlbGV0ZU9i amVjdFN0b3JlKGludDY0X3QsIGludDY0X3Qgb2JqZWN0U3RvcmVJZCkKIHsKLSAgICBkb0RlbGV0 ZShtX2RiLCAiREVMRVRFIEZST00gT2JqZWN0U3RvcmVzIFdIRVJFIGlkID0gPyIsIG9iamVjdFN0 b3JlSWQpOwotICAgIGRvRGVsZXRlKG1fZGIsICJERUxFVEUgRlJPTSBPYmplY3RTdG9yZURhdGEg V0hFUkUgb2JqZWN0U3RvcmVJZCA9ID8iLCBvYmplY3RTdG9yZUlkKTsKICAgICBkb0RlbGV0ZSht X2RiLCAiREVMRVRFIEZST00gSW5kZXhEYXRhIFdIRVJFIGluZGV4SWQgSU4gKFNFTEVDVCBpZCBG Uk9NIEluZGV4ZXMgV0hFUkUgb2JqZWN0U3RvcmVJZCA9ID8pIiwgb2JqZWN0U3RvcmVJZCk7CiAg ICAgZG9EZWxldGUobV9kYiwgIkRFTEVURSBGUk9NIEluZGV4ZXMgV0hFUkUgb2JqZWN0U3RvcmVJ ZCA9ID8iLCBvYmplY3RTdG9yZUlkKTsKKyAgICBkb0RlbGV0ZShtX2RiLCAiREVMRVRFIEZST00g T2JqZWN0U3RvcmVEYXRhIFdIRVJFIG9iamVjdFN0b3JlSWQgPSA/Iiwgb2JqZWN0U3RvcmVJZCk7 CisgICAgZG9EZWxldGUobV9kYiwgIkRFTEVURSBGUk9NIE9iamVjdFN0b3JlcyBXSEVSRSBpZCA9 ID8iLCBvYmplY3RTdG9yZUlkKTsKIH0KIAogbmFtZXNwYWNlIHsK 104364 2011-08-18 10:53:47 -0700 2011-08-19 05:13:34 -0700 Patch bug-66470-20110818195345.patch text/plain 1821 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogOTMxOTUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiNTM4Y2VjOWM2ZDEyNzM4 YWZjYzdmOTRlM2JhY2E5NDlkZDcwYjRiLi44YWEwZjIwM2I5ODJkYjFlYTQ3ZTQzODRmNmY3Mzcz ODZkZjI1ZDRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDgtMTggIEpvY2hl biBFaXNpbmdlciAgPGpvY2hlbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgSURCU1FMaXRlQmFj a2luZ1N0b3JlOjpkZWxldGVPYmplY3RTdG9yZSBzaG91bGQgbWFpbnRhaW4gcmVmZXJlbnRpYWwg aW50ZWdyaXR5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NjY0NzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHN0b3JhZ2UvSURCU1FMaXRlQmFja2luZ1N0b3JlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OklEQlNRTGl0ZUJhY2tpbmdTdG9yZTo6ZGVsZXRlT2JqZWN0U3RvcmUpOgorCiAyMDExLTA4LTE2 ICBMdWtlIE1hY3BoZXJzb24gICA8bWFjcGhlcnNvbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg UmVwcmVzZW50IFJlbmRlclN0eWxlOjp0ZXh0T3ZlcmZsb3cgcHJvcGVydHkgdXNpbmcgYW4gZW51 bSBpbnN0ZWFkIG9mIGEgYm9vbC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2Uv SURCU1FMaXRlQmFja2luZ1N0b3JlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvSURCU1FM aXRlQmFja2luZ1N0b3JlLmNwcAppbmRleCBkZDA2NWQ0YjMyMWQ1OTA0ZmU4YTdkYmE2ZTdkNDRk NTI0MmU1N2NiLi4zNDYxNzYwYmQwOGM4YmU4ZmExYmNhOGY4M2IzNzA2ZmI3ZGQ5NTFmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdlL0lEQlNRTGl0ZUJhY2tpbmdTdG9yZS5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvc3RvcmFnZS9JREJTUUxpdGVCYWNraW5nU3RvcmUuY3BwCkBA IC0yOTMsMTAgKzI5MywxMCBAQCBzdGF0aWMgdm9pZCBkb0RlbGV0ZShTUUxpdGVEYXRhYmFzZSYg ZGIsIGNvbnN0IGNoYXIqIHNxbCwgaW50NjRfdCBpZCkKIAogdm9pZCBJREJTUUxpdGVCYWNraW5n U3RvcmU6OmRlbGV0ZU9iamVjdFN0b3JlKGludDY0X3QsIGludDY0X3Qgb2JqZWN0U3RvcmVJZCkK IHsKLSAgICBkb0RlbGV0ZShtX2RiLCAiREVMRVRFIEZST00gT2JqZWN0U3RvcmVzIFdIRVJFIGlk ID0gPyIsIG9iamVjdFN0b3JlSWQpOwotICAgIGRvRGVsZXRlKG1fZGIsICJERUxFVEUgRlJPTSBP YmplY3RTdG9yZURhdGEgV0hFUkUgb2JqZWN0U3RvcmVJZCA9ID8iLCBvYmplY3RTdG9yZUlkKTsK ICAgICBkb0RlbGV0ZShtX2RiLCAiREVMRVRFIEZST00gSW5kZXhEYXRhIFdIRVJFIGluZGV4SWQg SU4gKFNFTEVDVCBpZCBGUk9NIEluZGV4ZXMgV0hFUkUgb2JqZWN0U3RvcmVJZCA9ID8pIiwgb2Jq ZWN0U3RvcmVJZCk7CiAgICAgZG9EZWxldGUobV9kYiwgIkRFTEVURSBGUk9NIEluZGV4ZXMgV0hF UkUgb2JqZWN0U3RvcmVJZCA9ID8iLCBvYmplY3RTdG9yZUlkKTsKKyAgICBkb0RlbGV0ZShtX2Ri LCAiREVMRVRFIEZST00gT2JqZWN0U3RvcmVEYXRhIFdIRVJFIG9iamVjdFN0b3JlSWQgPSA/Iiwg b2JqZWN0U3RvcmVJZCk7CisgICAgZG9EZWxldGUobV9kYiwgIkRFTEVURSBGUk9NIE9iamVjdFN0 b3JlcyBXSEVSRSBpZCA9ID8iLCBvYmplY3RTdG9yZUlkKTsKIH0KIAogbmFtZXNwYWNlIHsK