66468 2011-08-18 07:54:01 -0700 REGRESSION(r93294): Mac 10.6 test failures (Requested by vitalyr on #webkit). 2011-08-30 16:40:10 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66418 1 webkit.review.bot webkit.review.bot dglazkov thakis tony oldest_to_newest 453039 0 webkit.review.bot 2011-08-18 07:54:01 -0700 http://trac.webkit.org/changeset/93294 broke the build: Mac 10.6 test failures (Requested by vitalyr on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 453040 1 104342 webkit.review.bot 2011-08-18 07:54:34 -0700 Created attachment 104342 ROLLOUT of r93294 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID --ignore-builders where ATTACHMENT_ID is the ID of this attachment. 453044 2 thakis 2011-08-18 08:02:42 -0700 Log: http://build.chromium.org/p/chromium.webkit/builders/Mac10.6%20Tests/builds/6319 Failing tests: BrowserWindowFullScreenControllerTest.TestActivate: /b/build/slave/Mac10_6_Tests/build/src/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm:703: Failure Value of: IsFrontWindow([controller_ createFullscreenWindow]) Actual: false Expected: true GrabWindowSnapshotTest.TestGrabWindowSnapshot: /b/build/slave/Mac10_6_Tests/build/src/chrome/browser/ui/window_snapshot/window_snapshot_mac_unittest.mm:41: Failure Value of: CGImageGetWidth([rep CGImage]) == 400 Actual: false Expected: true /b/build/slave/Mac10_6_Tests/build/src/chrome/browser/ui/window_snapshot/window_snapshot_mac_unittest.mm:45: Failure Expected: (red + green + blue) >= (3.0), actual: 0 vs 3 BrowserCrApplicationAppleScriptTest.InsertWindow: /b/build/slave/Mac10_6_Tests/build/src/chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript_test.mm:57: Failure Value of: [window uniqueID] Actual: 1 Expected: var Which is: 4 RenderViewTest.MacTestCmdUp: /b/build/slave/Mac10_6_Tests/build/src/chrome/../content/renderer/render_view_browsertest_mac.mm:103: Failure Value of: UTF16ToASCII(output) Actual: "40,false,false,true,false\np1\n\np2" Expected: kArrowDownScrollDown Which is: "40,false,false,true,false 1936 p1 p2" /b/build/slave/Mac10_6_Tests/build/src/chrome/../content/renderer/render_view_browsertest_mac.mm:112: Failure Value of: UTF16ToASCII(output) Actual: "38,false,false,true,false\np1\n\np2" Expected: kArrowUpScrollUp Which is: "38,false,false,true,false 0 p1 p2" WindowAppleScriptTest.WindowOrder: /b/build/slave/Mac10_6_Tests/build/src/chrome/browser/ui/cocoa/applescript/window_applescript_test.mm:175: Failure Value of: NSOrderedAscending Actual: -1 Expected: [window1.get() windowComparator:window2.get()] Which is: 1 /b/build/slave/Mac10_6_Tests/build/src/chrome/browser/ui/cocoa/applescript/window_applescript_test.mm:177: Failure Value of: NSOrderedDescending Actual: 1 Expected: [window2.get() windowComparator:window1.get()] Which is: -1 PPAPITest.Scrollbar: Thu Aug 18 06:15:12 mini9-m1.golo.chromium.org Chromium[14210] <Error>: kCGErrorIllegalArgument: CGSOrderWindowList Thu Aug 18 06:15:12 mini9-m1.golo.chromium.org Chromium[14210] <Error>: kCGErrorFailure: Set a breakpoint @ CGErrorBreakpoint() to catch errors as they are logged. /b/build/slave/Mac10_6_Tests/build/src/chrome/test/ui/ppapi_uitest.cc:112: Failure Value of: escaped_value.c_str() Actual: "HandleEvent FAIL: Didn't get callback for scrollbar value change" Expected: "PASS" AccessibilityMacUITest.TestInitialPageNotifications: Thu Aug 18 06:20:07 mini9-m1.golo.chromium.org Chromium[14821] <Error>: kCGErrorIllegalArgument: CGSOrderWindowList Thu Aug 18 06:20:07 mini9-m1.golo.chromium.org Chromium[14821] <Error>: kCGErrorFailure: Set a breakpoint @ CGErrorBreakpoint() to catch errors as they are logged. Killed (timed out). BrowserFocusTest.ClickingMovesFocus: /b/build/slave/Mac10_6_Tests/build/src/chrome/browser/browser_focus_uitest.cc:209: Failure Value of: IsViewFocused(VIEW_ID_TAB_CONTAINER_FOCUS_VIEW) Actual: false Expected: true BrowserFocusTest.FindFocusTest: /b/build/third_party/zope/__init__.py:19: UserWarning: Module twisted was already imported from /b/build/third_party/twisted_8_1/twisted/__init__.pyc, but /System/Library/Frameworks/Python.framework/Versions/2.6/Extras/lib/python is being added to sys.path import pkg_resources /b/build/third_party/zope/__init__.py:19: UserWarning: Module zope was already imported from /b/build/third_party/zope/__init__.pyc, but /System/Library/Frameworks/Python.framework/Versions/2.6/Extras/lib/python is being added to sys.path import pkg_resources /b/build/slave/Mac10_6_Tests/build/src/chrome/browser/browser_focus_uitest.cc:778: Failure Value of: IsViewFocused(VIEW_ID_FIND_IN_PAGE_TEXT_FIELD) Actual: false Expected: true RenderViewTest.MacTestCmdUp just needs to be rebased. PPAPITest.Scrollbar and AccessibilityMacUITest.TestInitialPageNotifications might also be caused by my change. I'm surprised by the other failures. 453059 3 104342 webkit.review.bot 2011-08-18 08:30:54 -0700 Comment on attachment 104342 ROLLOUT of r93294 Rejecting attachment 104342 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2 Last 500 characters of output: WebKit/chromium/features.gypi Hunk #1 FAILED at 154. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/chromium/features.gypi.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 Updating OpenSource Current branch master is up to date. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9424638 453085 4 tony 2011-08-18 09:40:10 -0700 Rolled out in http://trac.webkit.org/changeset/93313 454367 5 thakis 2011-08-20 19:37:00 -0700 I tried reproducing the failures locally and got: unit_tests: [ OK ] BrowserWindowFullScreenControllerTest.TestActivate (697 ms) [ OK ] GrabWindowSnapshotTest.TestGrabWindowSnapshot (44 ms) browser_tests: [ OK ] BrowserCrApplicationAppleScriptTest.InsertWindow (1495 ms) [ FAILED ] RenderViewTest.MacTestCmdUp (1574 ms) [ OK ] WindowAppleScriptTest.WindowOrder (1440 ms) ui_tests: [ FAILED ] PPAPITest.Scrollbar (3870 ms) interactive_ui_tests: [ RUN ] AccessibilityMacUITest.TestInitialPageNotifications [0820/193458:ERROR:out_of_proc_test_runner.cc(388)] Test timeout (45000 ms) exceeded for AccessibilityMacUITest.TestInitialPageNotifications [ OK ] BrowserFocusTest.ClickingMovesFocus (1938 ms) [ OK ] BrowserFocusTest.FindFocusTest (5886 ms) Only RenderViewTest.MacTestCmdUp, PPAPITest.Scrollbar, and AccessibilityMacUITest.TestInitialPageNotifications seem to be caused by my patch, the rest was some form of flakiness. 454387 6 thakis 2011-08-20 23:15:36 -0700 AccessibilityMacUITest.TestInitialPageNotifications fails without this change for me locally as well. http://codereview.chromium.org/7694021/ Fixes that both with and without the smooth scrolling change. 459325 7 thakis 2011-08-30 16:40:10 -0700 http://codereview.chromium.org/7693019/ fixes the problems with the two remaining bugs 104342 2011-08-18 07:54:34 -0700 2011-08-18 08:30:54 -0700 ROLLOUT of r93294 bug-66468-20110818145425.patch text/plain 1275 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogOTMzMDcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg YTQ0M2UxMzBkZGMyYjA5ODFlZWYyM2NkZTc0NjlhMTZhMjBkMDllZS4uZThjZGU3ODcyNjE2M2M1 ZmQ4YWJjYzA2YTBkMTFhOTVjYjQ2NjI3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxMyBAQAorMjAxMS0wOC0xOCAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJv dEBnbWFpbC5jb20+CisKKyAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjkzMjk0Lgor ICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC85MzI5NAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY0NjgKKworICAgICAgICBN YWMgMTAuNiB0ZXN0IGZhaWx1cmVzIChSZXF1ZXN0ZWQgYnkgdml0YWx5ciBvbiAjd2Via2l0KS4K KworICAgICAgICAqIGZlYXR1cmVzLmd5cGk6CisKIDIwMTEtMDgtMTcgIEFkYW0gUm9iZW4gIDxh cm9iZW5AYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgV2ViQ29yZSBrZWVwIHRyYWNrIG9mIHRo ZSBjdXJyZW50IGRldmljZSBzY2FsZSBmYWN0b3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vZmVhdHVyZXMuZ3lwaSBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMu Z3lwaQppbmRleCBlMGRjOTcwNGYxNDg0OWNhYTRmNjY4NzkxNTJjNTllNDZkNmY0NTc2Li4xN2I4 ZWNmNWJkYTk5YTcyYjc4NzNhZTQyMjkxNmZmMzZjMjhlZTgwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5cGkKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9mZWF0dXJlcy5neXBpCkBAIC0xNTQsOCArMTU0LDYgQEAKICAgICAgIFsnT1M9PSJtYWMiJywg ewogICAgICAgICAnZmVhdHVyZV9kZWZpbmVzJzogWwogICAgICAgICAgICdFTkFCTEVfUlVCQkVS X0JBTkRJTkc9MScsCi0gICAgICAgICAgIyBVbmNvbmRpdGlvbmFsbHkgZW5hYmxlIHNtb290aCBz Y3JvbGxpbmcgb24gbWFjLgotICAgICAgICAgICdFTkFCTEVfU01PT1RIX1NDUk9MTElORz0xJywK ICAgICAgICAgICAnV1RGX1VTRV9TS0lBX09OX01BQ19DSFJPTUlVTT08KHVzZV9za2lhKScsCiAg ICAgICAgIF0sCiAgICAgICB9XSwK