66445 2011-08-17 18:56:12 -0700 Fix logic error causing reverse of desired WebGL rate limiting behavior 2011-08-22 18:09:34 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbates jbates cmarrin darin kbr webkit.review.bot oldest_to_newest 452802 0 jbates 2011-08-17 18:56:12 -0700 Fix logic error causing reverse of desired WebGL rate limiting behavior 452803 1 104294 jbates 2011-08-17 18:56:49 -0700 Created attachment 104294 Patch 452805 2 jbates 2011-08-17 18:58:08 -0700 Quick fix... 453186 3 104294 kbr 2011-08-18 11:32:54 -0700 Comment on attachment 104294 Patch Looks good. 453251 4 104294 webkit.review.bot 2011-08-18 12:32:26 -0700 Comment on attachment 104294 Patch Clearing flags on attachment: 104294 Committed r93335: <http://trac.webkit.org/changeset/93335> 453252 5 webkit.review.bot 2011-08-18 12:32:30 -0700 All reviewed patches have been landed. Closing bug. 453253 6 darin 2011-08-18 12:33:00 -0700 Is there a way to make a regression test for this? 453359 7 kbr 2011-08-18 14:35:33 -0700 (In reply to comment #6) > Is there a way to make a regression test for this? We gave this some thought; this fix would probably be testable with more hooks in the LayoutTestController. (Run an animation, do some WebGL work, and ensure that it isn't being rate-limited.) John, would you consider filing another bug to add a regression test in this area? 455130 8 jbates 2011-08-22 18:09:34 -0700 Filed: https://bugs.webkit.org/show_bug.cgi?id=66742 104294 2011-08-17 18:56:49 -0700 2011-08-18 12:32:26 -0700 Patch bug-66445-20110817185648.patch text/plain 1735 jbates U3VidmVyc2lvbiBSZXZpc2lvbjogOTMxNjUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhODI4Y2VjMDAzMjMxNzQ3 MWE3YThiMTg3MWU1M2JlMWM1ZmIxNjNmLi45YmY4YjZiY2ZiMmE2OTJiNmZhM2NlMDU2ZTQ4ODMx MzdkZmYyZmI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDgtMTcgIEpvaG4g QmF0ZXMgIDxqYmF0ZXNAZ29vZ2xlLmNvbT4KKworICAgICAgICBGaXggbG9naWMgZXJyb3IgY2F1 c2luZyByZXZlcnNlIG9mIGRlc2lyZWQgV2ViR0wgcmF0ZSBsaW1pdGluZyBiZWhhdmlvcgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY0NDUKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL2Nocm9taXVtL1dlYkdMTGF5ZXJDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpXZWJHTExheWVyQ2hyb21pdW06OnNldFRleHR1cmVVcGRhdGVkKToKKwogMjAxMS0wOC0xNiAg Sm9zZXBoIFBlY29yYXJvICA8am9lcGVja0B3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3 ZWQgQ2hyb21pdW0gV2luZG93cyBidWlsZCBmaXggYWZ0ZXIgcjkzMTQwLiBUYWtlIDQuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9XZWJHTExh eWVyQ2hyb21pdW0uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21p dW0vV2ViR0xMYXllckNocm9taXVtLmNwcAppbmRleCBkOGEzZTQwOWM0ZGQxNTY1NWYyNzEzNDFh Nzk2NjIzYWY3NDRmMzEyLi5hYjZlM2Y2ZTkyOThkY2E1OGJjYmIzMWY2OGIyYWIyOWNjYjgyOTQy IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9X ZWJHTExheWVyQ2hyb21pdW0uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2Nocm9taXVtL1dlYkdMTGF5ZXJDaHJvbWl1bS5jcHAKQEAgLTEyMyw3ICsxMjMsNyBAQCB2 b2lkIFdlYkdMTGF5ZXJDaHJvbWl1bTo6c2V0VGV4dHVyZVVwZGF0ZWQoKQogICAgIG1fdGV4dHVy ZVVwZGF0ZWQgPSB0cnVlOwogICAgIC8vIElmIFdlYkdMIGNvbW1hbmRzIGFyZSBpc3N1ZWQgb3V0 c2lkZSBvZiBhIHRoZSBhbmltYXRpb24gY2FsbGJhY2tzLCB0aGVuIHVzZQogICAgIC8vIGNhbGwg cmF0ZUxpbWl0T2Zmc2NyZWVuQ29udGV4dENIUk9NSVVNKCkgdG8ga2VlcCB0aGUgY29udGV4dCBm cm9tIGdldHRpbmcgdG9vIGZhciBhaGVhZC4KLSAgICBpZiAobGF5ZXJSZW5kZXJlcigpICYmIGxh eWVyUmVuZGVyZXIoKS0+b3duZXIoKS0+YW5pbWF0aW5nKCkgJiYgbV9jb250ZXh0U3VwcG9ydHNS YXRlTGltaXRpbmdFeHRlbnNpb24gJiYgIW1fcmF0ZUxpbWl0aW5nVGltZXIuaXNBY3RpdmUoKSkK KyAgICBpZiAobGF5ZXJSZW5kZXJlcigpICYmICFsYXllclJlbmRlcmVyKCktPm93bmVyKCktPmFu aW1hdGluZygpICYmIG1fY29udGV4dFN1cHBvcnRzUmF0ZUxpbWl0aW5nRXh0ZW5zaW9uICYmICFt X3JhdGVMaW1pdGluZ1RpbWVyLmlzQWN0aXZlKCkpCiAgICAgICAgIG1fcmF0ZUxpbWl0aW5nVGlt ZXIuc3RhcnRPbmVTaG90KDApOwogfQogCg==