66436 2011-08-17 17:29:12 -0700 --webkit-visual-word renaming right/leftWordPositionAcrossBoundary 2011-08-18 16:06:02 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 25298 1 xji webkit-unassigned ap rniwa vanlam oldest_to_newest 452758 0 xji 2011-08-17 17:29:12 -0700 Those 2 function names are confusing. They are actually returning right/left word position ignore editable boundary. Rename them to right/leftWordPositionIgnoreEditableBoundary. 452778 1 104289 xji 2011-08-17 18:09:21 -0700 Created attachment 104289 patch 452828 2 104289 rniwa 2011-08-17 20:23:31 -0700 Comment on attachment 104289 patch View in context: https://bugs.webkit.org/attachment.cgi?id=104289&action=review > Source/WebCore/editing/visible_units.cpp:1598 > +static VisiblePosition leftWordPositionIgnoreEditableBoundary(const VisiblePosition& visiblePosition) We normally use AcrossEditingBoundary instead of IgnoringEditingBoundary. 453082 3 xji 2011-08-18 09:26:33 -0700 (In reply to comment #2) > (From update of attachment 104289 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=104289&action=review > > > Source/WebCore/editing/visible_units.cpp:1598 > > +static VisiblePosition leftWordPositionIgnoreEditableBoundary(const VisiblePosition& visiblePosition) > > We normally use AcrossEditingBoundary instead of IgnoringEditingBoundary. ap commented in issue 65277 (https://bugs.webkit.org/show_bug.cgi?id=65277#c32) that "Both names mean that the result will always be across boundary, which is apparently untrue.". So, I am changing "Across" to "Ignoring" which means it ignores editing boundary, could return a position inside editing boundary or across editing boundary. 453345 4 rniwa 2011-08-18 14:16:07 -0700 (In reply to comment #3) > ap commented in issue 65277 (https://bugs.webkit.org/show_bug.cgi?id=65277#c32) that > "Both names mean that the result will always be across boundary, which is apparently untrue.". > > So, I am changing "Across" to "Ignoring" which means it ignores editing boundary, could return a position inside editing boundary or across editing boundary. Okay. I agree with ap on second thought so let's rename these to IgnoringEditingBoundary (NOT IgnoreEditingBoundary). 453374 5 104400 xji 2011-08-18 14:55:30 -0700 Created attachment 104400 patch 453465 6 xji 2011-08-18 16:06:02 -0700 Committed r93368: <http://trac.webkit.org/changeset/93368> 104289 2011-08-17 18:09:21 -0700 2011-08-18 14:55:30 -0700 patch 66436.v1 text/plain 2688 xji SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzMjcxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDgtMTcgIFhpYW9tZWkg SmkgIDx4amlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIC0td2Via2l0LXZpc3VhbC13b3JkIHJl bmFtaW5nIHJpZ2h0L2xlZnRXb3JkUG9zaXRpb25BY3Jvc3NCb3VuZGFyeQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY0MzYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW5hbWUgdGhlbSB0byByaWdodC9s ZWZ0V29yZFBvc2l0aW9uSWdub3JlRWRpdGFibGVCb3VuZGFyeS4KKworICAgICAgICAqIGVkaXRp bmcvdmlzaWJsZV91bml0cy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpsZWZ0V29yZFBvc2l0aW9u SWdub3JlRWRpdGFibGVCb3VuZGFyeSk6CisgICAgICAgIChXZWJDb3JlOjpyaWdodFdvcmRQb3Np dGlvbklnbm9yZUVkaXRhYmxlQm91bmRhcnkpOgorICAgICAgICAoV2ViQ29yZTo6bGVmdFdvcmRQ b3NpdGlvbik6CisgICAgICAgIChXZWJDb3JlOjpyaWdodFdvcmRQb3NpdGlvbik6CisKIDIwMTEt MDgtMTcgIEVtaWwgQSBFa2x1bmQgIDxlYWVAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFN3aXRj aCBmb2N1cyBoYW5kbGluZyB0byB0byBuZXcgbGF5b3V0IHR5cGVzCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9lZGl0aW5nL3Zpc2libGVfdW5pdHMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2VkaXRpbmcvdmlzaWJsZV91bml0cy5jcHAJKHJldmlzaW9uIDkzMTc3KQorKysgU291cmNl L1dlYkNvcmUvZWRpdGluZy92aXNpYmxlX3VuaXRzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTU5 NSw3ICsxNTk1LDcgQEAgc3RhdGljIGJvb2wgcG9zaXRpb25Jc0luQm94QnV0Tm90T25Cb3VuZAog ICAgICAgICAmJiBvZmZzZXRPZldvcmRCcmVhayAhPSBib3gtPmNhcmV0TWF4T2Zmc2V0KCkgJiYg b2Zmc2V0T2ZXb3JkQnJlYWsgIT0gYm94LT5jYXJldE1pbk9mZnNldCgpOwogfQogCi1zdGF0aWMg VmlzaWJsZVBvc2l0aW9uIGxlZnRXb3JkUG9zaXRpb25BY3Jvc3NCb3VuZGFyeShjb25zdCBWaXNp YmxlUG9zaXRpb24mIHZpc2libGVQb3NpdGlvbikKK3N0YXRpYyBWaXNpYmxlUG9zaXRpb24gbGVm dFdvcmRQb3NpdGlvbklnbm9yZUVkaXRhYmxlQm91bmRhcnkoY29uc3QgVmlzaWJsZVBvc2l0aW9u JiB2aXNpYmxlUG9zaXRpb24pCiB7CiAgICAgSW5saW5lQm94KiBib3g7CiAgICAgaW50IG9mZnNl dDsKQEAgLTE2MzYsNyArMTYzNiw3IEBAIHN0YXRpYyBWaXNpYmxlUG9zaXRpb24gbGVmdFdvcmRQ b3NpdGlvbkEKICAgICByZXR1cm4gbGVmdFdvcmRCb3VuZGFyeShsZWZ0SW5saW5lQm94KGJveCwg YmxvY2tEaXJlY3Rpb24pLCBpbnZhbGlkT2Zmc2V0LCBibG9ja0RpcmVjdGlvbik7CiB9CiAKLXN0 YXRpYyBWaXNpYmxlUG9zaXRpb24gcmlnaHRXb3JkUG9zaXRpb25BY3Jvc3NCb3VuZGFyeShjb25z dCBWaXNpYmxlUG9zaXRpb24mIHZpc2libGVQb3NpdGlvbikKK3N0YXRpYyBWaXNpYmxlUG9zaXRp b24gcmlnaHRXb3JkUG9zaXRpb25JZ25vcmVFZGl0YWJsZUJvdW5kYXJ5KGNvbnN0IFZpc2libGVQ b3NpdGlvbiYgdmlzaWJsZVBvc2l0aW9uKQogewogICAgIElubGluZUJveCogYm94OwogICAgIGlu dCBvZmZzZXQ7CkBAIC0xNjc4LDcgKzE2NzgsNyBAQCBWaXNpYmxlUG9zaXRpb24gbGVmdFdvcmRQ b3NpdGlvbihjb25zdCBWCiAgICAgaWYgKHZpc2libGVQb3NpdGlvbi5pc051bGwoKSkKICAgICAg ICAgcmV0dXJuIFZpc2libGVQb3NpdGlvbigpOwogCi0gICAgVmlzaWJsZVBvc2l0aW9uIGxlZnRX b3JkQnJlYWsgPSBsZWZ0V29yZFBvc2l0aW9uQWNyb3NzQm91bmRhcnkodmlzaWJsZVBvc2l0aW9u KTsKKyAgICBWaXNpYmxlUG9zaXRpb24gbGVmdFdvcmRCcmVhayA9IGxlZnRXb3JkUG9zaXRpb25J Z25vcmVFZGl0YWJsZUJvdW5kYXJ5KHZpc2libGVQb3NpdGlvbik7CiAgICAgcmV0dXJuIHZpc2li bGVQb3NpdGlvbi5ob25vckVkaXRhYmxlQm91bmRhcnlBdE9yQmVmb3JlKGxlZnRXb3JkQnJlYWsp OwogfQogCkBAIC0xNjg3LDcgKzE2ODcsNyBAQCBWaXNpYmxlUG9zaXRpb24gcmlnaHRXb3JkUG9z aXRpb24oY29uc3QgCiAgICAgaWYgKHZpc2libGVQb3NpdGlvbi5pc051bGwoKSkKICAgICAgICAg cmV0dXJuIFZpc2libGVQb3NpdGlvbigpOwogCi0gICAgVmlzaWJsZVBvc2l0aW9uIHJpZ2h0V29y ZEJyZWFrID0gcmlnaHRXb3JkUG9zaXRpb25BY3Jvc3NCb3VuZGFyeSh2aXNpYmxlUG9zaXRpb24p OworICAgIFZpc2libGVQb3NpdGlvbiByaWdodFdvcmRCcmVhayA9IHJpZ2h0V29yZFBvc2l0aW9u SWdub3JlRWRpdGFibGVCb3VuZGFyeSh2aXNpYmxlUG9zaXRpb24pOwogICAgIHJldHVybiB2aXNp YmxlUG9zaXRpb24uaG9ub3JFZGl0YWJsZUJvdW5kYXJ5QXRPckJlZm9yZShyaWdodFdvcmRCcmVh ayk7CiB9CiAK 104400 2011-08-18 14:55:30 -0700 2011-08-18 15:10:58 -0700 patch 66436.v2 text/plain 2691 xji SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzMzUxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDgtMTggIFhpYW9tZWkg SmkgIDx4amlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIC0td2Via2l0LXZpc3VhbC13b3JkIHJl bmFtaW5nIHJpZ2h0L2xlZnRXb3JkUG9zaXRpb25BY3Jvc3NCb3VuZGFyeQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY0MzYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW5hbWUgdGhlbSB0byByaWdodC9s ZWZ0V29yZFBvc2l0aW9uSWdub3JpbmdFZGl0aW5nQm91bmRhcnkuCisKKyAgICAgICAgKiBlZGl0 aW5nL3Zpc2libGVfdW5pdHMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6bGVmdFdvcmRQb3NpdGlv bklnbm9yaW5nRWRpdGluZ0JvdW5kYXJ5KToKKyAgICAgICAgKFdlYkNvcmU6OnJpZ2h0V29yZFBv c2l0aW9uSWdub3JpbmdFZGl0aW5nQm91bmRhcnkpOgorICAgICAgICAoV2ViQ29yZTo6bGVmdFdv cmRQb3NpdGlvbik6CisgICAgICAgIChXZWJDb3JlOjpyaWdodFdvcmRQb3NpdGlvbik6CisKIDIw MTEtMDgtMTggIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAg ICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI5MzMyOS4KSW5kZXg6IFNvdXJjZS9XZWJD b3JlL2VkaXRpbmcvdmlzaWJsZV91bml0cy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvZWRpdGluZy92aXNpYmxlX3VuaXRzLmNwcAkocmV2aXNpb24gOTMxNzcpCisrKyBTb3VyY2Uv V2ViQ29yZS9lZGl0aW5nL3Zpc2libGVfdW5pdHMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNTk1 LDcgKzE1OTUsNyBAQCBzdGF0aWMgYm9vbCBwb3NpdGlvbklzSW5Cb3hCdXROb3RPbkJvdW5kCiAg ICAgICAgICYmIG9mZnNldE9mV29yZEJyZWFrICE9IGJveC0+Y2FyZXRNYXhPZmZzZXQoKSAmJiBv ZmZzZXRPZldvcmRCcmVhayAhPSBib3gtPmNhcmV0TWluT2Zmc2V0KCk7CiB9CiAKLXN0YXRpYyBW aXNpYmxlUG9zaXRpb24gbGVmdFdvcmRQb3NpdGlvbkFjcm9zc0JvdW5kYXJ5KGNvbnN0IFZpc2li bGVQb3NpdGlvbiYgdmlzaWJsZVBvc2l0aW9uKQorc3RhdGljIFZpc2libGVQb3NpdGlvbiBsZWZ0 V29yZFBvc2l0aW9uSWdub3JpbmdFZGl0aW5nQm91bmRhcnkoY29uc3QgVmlzaWJsZVBvc2l0aW9u JiB2aXNpYmxlUG9zaXRpb24pCiB7CiAgICAgSW5saW5lQm94KiBib3g7CiAgICAgaW50IG9mZnNl dDsKQEAgLTE2MzYsNyArMTYzNiw3IEBAIHN0YXRpYyBWaXNpYmxlUG9zaXRpb24gbGVmdFdvcmRQ b3NpdGlvbkEKICAgICByZXR1cm4gbGVmdFdvcmRCb3VuZGFyeShsZWZ0SW5saW5lQm94KGJveCwg YmxvY2tEaXJlY3Rpb24pLCBpbnZhbGlkT2Zmc2V0LCBibG9ja0RpcmVjdGlvbik7CiB9CiAKLXN0 YXRpYyBWaXNpYmxlUG9zaXRpb24gcmlnaHRXb3JkUG9zaXRpb25BY3Jvc3NCb3VuZGFyeShjb25z dCBWaXNpYmxlUG9zaXRpb24mIHZpc2libGVQb3NpdGlvbikKK3N0YXRpYyBWaXNpYmxlUG9zaXRp b24gcmlnaHRXb3JkUG9zaXRpb25JZ25vcmluZ0VkaXRpbmdCb3VuZGFyeShjb25zdCBWaXNpYmxl UG9zaXRpb24mIHZpc2libGVQb3NpdGlvbikKIHsKICAgICBJbmxpbmVCb3gqIGJveDsKICAgICBp bnQgb2Zmc2V0OwpAQCAtMTY3OCw3ICsxNjc4LDcgQEAgVmlzaWJsZVBvc2l0aW9uIGxlZnRXb3Jk UG9zaXRpb24oY29uc3QgVgogICAgIGlmICh2aXNpYmxlUG9zaXRpb24uaXNOdWxsKCkpCiAgICAg ICAgIHJldHVybiBWaXNpYmxlUG9zaXRpb24oKTsKIAotICAgIFZpc2libGVQb3NpdGlvbiBsZWZ0 V29yZEJyZWFrID0gbGVmdFdvcmRQb3NpdGlvbkFjcm9zc0JvdW5kYXJ5KHZpc2libGVQb3NpdGlv bik7CisgICAgVmlzaWJsZVBvc2l0aW9uIGxlZnRXb3JkQnJlYWsgPSBsZWZ0V29yZFBvc2l0aW9u SWdub3JpbmdFZGl0aW5nQm91bmRhcnkodmlzaWJsZVBvc2l0aW9uKTsKICAgICByZXR1cm4gdmlz aWJsZVBvc2l0aW9uLmhvbm9yRWRpdGFibGVCb3VuZGFyeUF0T3JCZWZvcmUobGVmdFdvcmRCcmVh ayk7CiB9CiAKQEAgLTE2ODcsNyArMTY4Nyw3IEBAIFZpc2libGVQb3NpdGlvbiByaWdodFdvcmRQ b3NpdGlvbihjb25zdCAKICAgICBpZiAodmlzaWJsZVBvc2l0aW9uLmlzTnVsbCgpKQogICAgICAg ICByZXR1cm4gVmlzaWJsZVBvc2l0aW9uKCk7CiAKLSAgICBWaXNpYmxlUG9zaXRpb24gcmlnaHRX b3JkQnJlYWsgPSByaWdodFdvcmRQb3NpdGlvbkFjcm9zc0JvdW5kYXJ5KHZpc2libGVQb3NpdGlv bik7CisgICAgVmlzaWJsZVBvc2l0aW9uIHJpZ2h0V29yZEJyZWFrID0gcmlnaHRXb3JkUG9zaXRp b25JZ25vcmluZ0VkaXRpbmdCb3VuZGFyeSh2aXNpYmxlUG9zaXRpb24pOwogICAgIHJldHVybiB2 aXNpYmxlUG9zaXRpb24uaG9ub3JFZGl0YWJsZUJvdW5kYXJ5QXRPckJlZm9yZShyaWdodFdvcmRC cmVhayk7CiB9CiAK