66428 2011-08-17 16:26:49 -0700 Made some code even more private to a particular file and class 2011-08-18 13:01:13 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 darin darin andersca aroben oldest_to_newest 452705 0 darin 2011-08-17 16:26:49 -0700 Made some code even more private to a particular file and class 452720 1 104279 darin 2011-08-17 16:37:56 -0700 Created attachment 104279 Patch 453128 2 darin 2011-08-18 10:41:44 -0700 Looks like Adam did part of this already, independently! 453254 3 104279 aroben 2011-08-18 12:33:03 -0700 Comment on attachment 104279 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104279&action=review > Source/WebKit2/UIProcess/API/mac/WKView.mm:2528 > +@implementation WKView (WKFileInternal) I added a WKView (FileInternal) category in an earlier revision today. We should unify the two! 453255 4 darin 2011-08-18 12:33:30 -0700 (In reply to comment #3) > I added a WKView (FileInternal) category in an earlier revision today. We should unify the two! I did already, will land shortly. 453285 5 darin 2011-08-18 13:01:13 -0700 Committed r93337: <http://trac.webkit.org/changeset/93337> 104279 2011-08-17 16:37:56 -0700 2011-08-18 12:33:03 -0700 Patch bug-66428-20110817163755.patch text/plain 3573 darin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzMjU4KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDgtMTcgIERhcmluIEFk bGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIE1hZGUgc29tZSBjb2RlIGV2ZW4gbW9y ZSBwcml2YXRlIHRvIGEgcGFydGljdWxhciBmaWxlIGFuZCBjbGFzcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjY0MjgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvbWFjL1dLVmll dy5tbToKKyAgICAgICAgKC1bV0tWaWV3IF9zZXREcmF3aW5nQXJlYVNpemU6XSk6IE1hZGUgdGhp cyBmaWxlIGludGVybmFsLgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvbWFjL1dLVmlld0ludGVy bmFsLmg6IFJlbW92ZWQgX3NldERyYXdpbmdBcmVhU2l6ZS4KKyAgICAgICAgKiBVSVByb2Nlc3Mv RHJhd2luZ0FyZWFQcm94eS5oOiBNYWRlIHNpemVEaWRDaGFuZ2UgcHJpdmF0ZS4KKwogMjAxMS0w OC0xNyAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJl bW92ZSB1bnVzZWQgQ29yZSBBbmltYXRpb24gcmVsYXRlZCBjbGFzc2VzCkluZGV4OiBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvRHJhd2luZ0FyZWFQcm94eS5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9EcmF3aW5nQXJlYVByb3h5LmgJKHJldmlzaW9uIDkzMTYxKQor KysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0RyYXdpbmdBcmVhUHJveHkuaAkod29ya2luZyBj b3B5KQpAQCAtNzcsNyArNzcsNiBAQCBwdWJsaWM6CiAgICAgLy8gUmV0dXJucyB0cnVlIGlmIHBh aW50aW5nIHdhcyBzdWNjZXNzZnVsLCBmYWxzZSBvdGhlcndpc2UuCiAgICAgdmlydHVhbCBib29s IHBhaW50KGNvbnN0IFdlYkNvcmU6OkludFJlY3QmLCBQbGF0Zm9ybURyYXdpbmdDb250ZXh0KSA9 IDA7CiAKLSAgICB2aXJ0dWFsIHZvaWQgc2l6ZURpZENoYW5nZSgpID0gMDsKICAgICB2aXJ0dWFs IHZvaWQgZGV2aWNlU2NhbGVGYWN0b3JEaWRDaGFuZ2UoKSA9IDA7CiAKICAgICAvLyBGSVhNRTog VGhlc2Ugc2hvdWxkIGJlIHB1cmUgdmlydHVhbC4KQEAgLTEwMSw2ICsxMDAsOCBAQCBwcm90ZWN0 ZWQ6CiAgICAgV2ViQ29yZTo6SW50U2l6ZSBtX3Njcm9sbE9mZnNldDsKIAogcHJpdmF0ZToKKyAg ICB2aXJ0dWFsIHZvaWQgc2l6ZURpZENoYW5nZSgpID0gMDsKKwogICAgIC8vIENvcmVJUEMgbWVz c2FnZSBoYW5kbGVycy4KICAgICAvLyBGSVhNRTogVGhlc2Ugc2hvdWxkIGJlIHB1cmUgdmlydHVh bC4KICAgICB2aXJ0dWFsIHZvaWQgdXBkYXRlKHVpbnQ2NF90IGJhY2tpbmdTdG9yZVN0YXRlSUQs IGNvbnN0IFVwZGF0ZUluZm8mKSB7IH0KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvbWFjL1dLVmlldy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL21hYy9XS1ZpZXcubW0JKHJldmlzaW9uIDkzMTYxKQorKysgU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC05NCw2ICs5NCwxMCBA QCAtICh2b2lkKV9tYXNrUm91bmRlZEJvdHRvbUNvcm5lcnM6KE5TUmVjCiB1c2luZyBuYW1lc3Bh Y2UgV2ViS2l0OwogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKK0BpbnRlcmZhY2UgV0tWaWV3 IChXS0ZpbGVJbnRlcm5hbCkKKy0gKHZvaWQpX3NldERyYXdpbmdBcmVhU2l6ZTooTlNTaXplKXNp emU7CitAZW5kCisKIG5hbWVzcGFjZSBXZWJLaXQgewogCiB0eXBlZGVmIGlkIDxOU1ZhbGlkYXRl ZFVzZXJJbnRlcmZhY2VJdGVtPiBWYWxpZGF0aW9uSXRlbTsKQEAgLTI0MjUsMTUgKzI0MjksNiBA QCAtICh2b2lkKV9yZXNldFRleHRJbnB1dFN0YXRlCiAgICAgfQogfQogCi0tICh2b2lkKV9zZXRE cmF3aW5nQXJlYVNpemU6KE5TU2l6ZSlzaXplCi17Ci0gICAgaWYgKCFfZGF0YS0+X3BhZ2UtPmRy YXdpbmdBcmVhKCkpCi0gICAgICAgIHJldHVybjsKLSAgICAKLSAgICBfZGF0YS0+X3BhZ2UtPmRy YXdpbmdBcmVhKCktPnNldFNpemUoSW50U2l6ZShzaXplKSwgSW50U2l6ZShfZGF0YS0+X3Jlc2l6 ZVNjcm9sbE9mZnNldCkpOwotICAgIF9kYXRhLT5fcmVzaXplU2Nyb2xsT2Zmc2V0ID0gTlNaZXJv U2l6ZTsKLX0KLQogLSAodm9pZClfZGlkQ2hhbmdlU2Nyb2xsYmFyc0Zvck1haW5GcmFtZQogewog ICAgIFtzZWxmIF91cGRhdGVHcm93Qm94Rm9yV2luZG93RnJhbWVDaGFuZ2VdOwpAQCAtMjUzMCw2 ICsyNTI1LDE5IEBAIC0gKHZvaWQpaGFuZGxlQ29ycmVjdGlvblBhbmVsUmVzdWx0OihOU1MKIAog QGVuZAogCitAaW1wbGVtZW50YXRpb24gV0tWaWV3IChXS0ZpbGVJbnRlcm5hbCkKKworLSAodm9p ZClfc2V0RHJhd2luZ0FyZWFTaXplOihOU1NpemUpc2l6ZQoreworICAgIGlmICghX2RhdGEtPl9w YWdlLT5kcmF3aW5nQXJlYSgpKQorICAgICAgICByZXR1cm47CisgICAgCisgICAgX2RhdGEtPl9w YWdlLT5kcmF3aW5nQXJlYSgpLT5zZXRTaXplKEludFNpemUoc2l6ZSksIEludFNpemUoX2RhdGEt Pl9yZXNpemVTY3JvbGxPZmZzZXQpKTsKKyAgICBfZGF0YS0+X3Jlc2l6ZVNjcm9sbE9mZnNldCA9 IE5TWmVyb1NpemU7Cit9CisKK0BlbmQKKwogQGltcGxlbWVudGF0aW9uIFdLUmVzcG9uZGVyQ2hh aW5TaW5rCiAKIC0gKGlkKWluaXRXaXRoUmVzcG9uZGVyQ2hhaW46KE5TUmVzcG9uZGVyICopY2hh aW4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlld0ludGVybmFs LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3 SW50ZXJuYWwuaAkocmV2aXNpb24gOTMxNjEpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL21hYy9XS1ZpZXdJbnRlcm5hbC5oCSh3b3JraW5nIGNvcHkpCkBAIC03OCw4ICs3OCw2IEBA IEBpbnRlcmZhY2UgV0tWaWV3IChJbnRlcm5hbCkKIC0gKHZvaWQpX3VwZGF0ZVRleHRJbnB1dFN0 YXRlSW5jbHVkaW5nU2VjdXJlSW5wdXRTdGF0ZTooQk9PTCl1cGRhdGVTZWN1cmVJbnB1dFN0YXRl OwogLSAodm9pZClfcmVzZXRUZXh0SW5wdXRTdGF0ZTsKIAotLSAodm9pZClfc2V0RHJhd2luZ0Fy ZWFTaXplOihOU1NpemUpc2l6ZTsKLQogLSAodm9pZClfZGlkQ2hhbmdlU2Nyb2xsYmFyc0Zvck1h aW5GcmFtZTsKIAogI2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkK