66425 2011-08-17 16:15:15 -0700 check-webkit-style should detect incorrectly formatted file change descriptions 2011-08-18 04:44:09 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dslomov dslomov levin webkit.review.bot oldest_to_newest 452683 0 dslomov 2011-08-17 16:15:15 -0700 Description, if present, should be separated from colon with a space 452690 1 104269 dslomov 2011-08-17 16:20:27 -0700 Created attachment 104269 The fix + unittests 452954 2 104269 webkit.review.bot 2011-08-18 04:44:05 -0700 Comment on attachment 104269 The fix + unittests Clearing flags on attachment: 104269 Committed r93297: <http://trac.webkit.org/changeset/93297> 452955 3 webkit.review.bot 2011-08-18 04:44:09 -0700 All reviewed patches have been landed. Closing bug. 104269 2011-08-17 16:20:27 -0700 2011-08-18 04:44:05 -0700 The fix + unittests 66425.patch text/plain 4317 dslomov ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3ZjIw YTEwLi4xNTUxNjkxIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDgtMTcgIERtaXRyeSBMb21vdiAgPGRzbG9t b3ZAZ29vZ2xlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjY0MjUKKyAgICAgICAgY2hlY2std2Via2l0LXN0eWxlIHNob3VsZCBkZXRlY3Qg aW5jb3JyZWN0bHkgZm9ybWF0dGVkIGZpbGUgY2hhbmdlIGRlc2NyaXB0aW9ucy4KKyAgICAgICAg RGVzY3JpcHRpb24sIGlmIHByZXNlbnQsIHNob3VsZCBiZSBzZXBhcmF0ZWQgZnJvbSBjb2xvbiB3 aXRoIGEgc3BhY2UuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NoYW5nZWxvZy5weTogRml4 LgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY2hhbmdlbG9nX3Vu aXR0ZXN0LnB5OiBVbml0IHRlc3RzLgorCiAyMDExLTA4LTE3ICBKb2NoZW4gRWlzaW5nZXIgIDxq b2NoZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIE1ha2UgU1ZOVGVzdC50ZXN0X3N2bl9hcHBs eSB1c2UgdGhlIHNhbWUgdGltZXpvbmUgbG9naWMgYXMgVkNTVXRpbHMucG0KZGlmZiAtLWdpdCBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY2hhbmdlbG9nLnB5IGIvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jaGFuZ2Vsb2cucHkKaW5kZXggYmI4 NTdkYy4uYWNiNDA3MyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9j aGVja2Vycy9jaGFuZ2Vsb2cucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9j aGVja2Vycy9jaGFuZ2Vsb2cucHkKQEAgLTU0LDYgKzU0LDE5IEBAIGNsYXNzIENoYW5nZUxvZ0No ZWNrZXIob2JqZWN0KToKICAgICAgICAgICAgIHNlbGYuaGFuZGxlX3N0eWxlX2Vycm9yKGZpcnN0 X2xpbmVfY2hlY2tlZCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJjaGFu Z2Vsb2cvYnVnbnVtYmVyIiwgNSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICJDaGFuZ2VMb2cgZW50cnkgaGFzIG5vIGJ1ZyBudW1iZXIiKQorICAgICAgICAjIGNoZWNrIGZp bGUgY2hhbmdlIGRlc2NyaXB0aW9ucyBmb3Igc3R5bGUgdmlvbGF0aW9ucworICAgICAgICBsaW5l X25vID0gZmlyc3RfbGluZV9jaGVja2VkIC0gMQorICAgICAgICBmb3IgbGluZSBpbiBlbnRyeV9s aW5lczoKKyAgICAgICAgICAgIGxpbmVfbm8gPSBsaW5lX25vICsgMQorICAgICAgICAgICAgIyBm aWx0ZXIgZmlsZSBjaGFuZ2UgZGVzY3JpcHRpb25zCisgICAgICAgICAgICBpZiBub3QgcmUubWF0 Y2goJ1xzKlwqXHMnLCBsaW5lKToKKyAgICAgICAgICAgICAgICBjb250aW51ZQorICAgICAgICAg ICAgaWYgcmUuc2VhcmNoKCc6XHMqJCcsIGxpbmUpIG9yIHJlLnNlYXJjaCgnOlxzJywgbGluZSk6 CisgICAgICAgICAgICAgICAgY29udGludWUKKyAgICAgICAgICAgIHNlbGYuaGFuZGxlX3N0eWxl X2Vycm9yKGxpbmVfbm8sCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiY2hh bmdlbG9nL2ZpbGVjaGFuZ2VkZXNjcmlwdGlvbndoaXRlc3BhY2UiLCA1LAorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIk5lZWQgd2hpdGVzcGFjZSBiZXR3ZWVuIGNvbG9uIGFu ZCBkZXNjcmlwdGlvbiIpCisKIAogICAgIGRlZiBjaGVjayhzZWxmLCBsaW5lcyk6CiAgICAgICAg IHNlbGYuX3RhYl9jaGVja2VyLmNoZWNrKGxpbmVzKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jaGFuZ2Vsb2dfdW5pdHRlc3QucHkgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NoYW5nZWxvZ191bml0dGVzdC5weQppbmRl eCAwMjI5NmQzLi44NDJlYWExIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NoZWNrZXJzL2NoYW5nZWxvZ191bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NoYW5nZWxvZ191bml0dGVzdC5weQpAQCAtMTA1LDYgKzEw NSwyMyBAQCBjbGFzcyBDaGFuZ2VMb2dDaGVja2VyVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAg ICAgICAgICAgICAgICAgICAgICAgICAgICdcbicKICAgICAgICAgICAgICAgICAgICAgICAgICAg JyAgICAgICAgTm8gYnVnIGluIHRoaXMgY2hhbmdlLlxuJykKIAorICAgIGRlZiB0ZXN0X2ZpbGVf ZGVzY3JpcHRpb25zKHNlbGYpOgorICAgICAgICBzZWxmLmFzc2VydF9lcnJvcig1LCByYW5nZSgx LCAyMCksICdjaGFuZ2Vsb2cvZmlsZWNoYW5nZWRlc2NyaXB0aW9ud2hpdGVzcGFjZScsCisgICAg ICAgICAgICAgICAgICAgICAgICAgICcyMDExLTAxLTAxIERtaXRyeSBMb21vdiAgPGRzbG9tb3ZA Z29vZ2xlLmNvbT5cbicKKyAgICAgICAgICAgICAgICAgICAgICAgICAgJyAgICAgICAgRXhhbXBs ZUJ1Z1xuJworICAgICAgICAgICAgICAgICAgICAgICAgICAnICAgICAgICBodHRwOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjM0NVxuJworICAgICAgICAgICAgICAgICAgICAg ICAgICAnXG4nCisgICAgICAgICAgICAgICAgICAgICAgICAgICcgICAgICAgICogIFNvdXJjZS9U b29scy9yYW5kb20tc2NyaXB0LnB5OkZpeGVkJykKKyAgICAgICAgc2VsZi5hc3NlcnRfZXJyb3Io NiwgcmFuZ2UoMSwgMjApLCAnY2hhbmdlbG9nL2ZpbGVjaGFuZ2VkZXNjcmlwdGlvbndoaXRlc3Bh Y2UnLAorICAgICAgICAgICAgICAgICAgICAgICAgICAnMjAxMS0wMS0wMSBEbWl0cnkgTG9tb3Yg IDxkc2xvbW92QGdvb2dsZS5jb20+XG4nCisgICAgICAgICAgICAgICAgICAgICAgICAgICcgICAg ICAgIEV4YW1wbGVCdWdcbicKKyAgICAgICAgICAgICAgICAgICAgICAgICAgJyAgICAgICAgaHR0 cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzNDVcbicKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgJ1xuJworICAgICAgICAgICAgICAgICAgICAgICAgICAnICAgICAgICAq ICBTb3VyY2UvVG9vbHMvYW5vdGhlci1maWxlOiBEb25lXG4nCisgICAgICAgICAgICAgICAgICAg ICAgICAgICcgICAgICAgICogIFNvdXJjZS9Ub29scy9yYW5kb20tc2NyaXB0LnB5OkZpeGVkXG4n CisgICAgICAgICAgICAgICAgICAgICAgICAgICcgICAgICAgICogIFNvdXJjZS9Ub29scy9vbmUt bW9yZWZpbGU6XG4nKQorCisKICAgICBkZWYgdGVzdF9ub19lcnJvcihzZWxmKToKICAgICAgICAg c2VsZi5hc3NlcnRfbm9fZXJyb3IoW10sCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICcy MDExLTAxLTAxICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUBwYXJvZ2EuY29tPlxuJwpAQCAt MTUwLDYgKzE2NywxMyBAQCBjbGFzcyBDaGFuZ2VMb2dDaGVja2VyVGVzdCh1bml0dGVzdC5UZXN0 Q2FzZSk6CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdcbicKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgJzIwMTEtMDEtMDEgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHBh cm9nYS5jb20+XG4nCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICcgICAgICAgIE5vIGJ1 ZyBoZXJlIVxuJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbm9fZXJyb3IocmFuZ2UoMSwgMjApLAor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnMjAxMS0wMS0wMSAgUGF0cmljayBHYW5zdGVy ZXIgIDxwYXJvZ2FAcGFyb2dhLmNvbT5cbicKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg JyAgICAgICAgRXhhbXBsZSBidWdcbicKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMzQ1XG4nCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICcgICAgICAgICogU291cmNlL1dlYktpdC9mb28u Y3BwOiAgICBcbicKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJyAgICAgICAgKiBTb3Vy Y2UvV2ViS2l0L2Jhci5jcHA6XG4nCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICcgICAg ICAgICogU291cmNlL1dlYktpdC9mb29iYXIuY3BwOiBEZXNjcmlwdGlvblxuJykKIAogaWYgX19u YW1lX18gPT0gJ19fbWFpbl9fJzoKICAgICB1bml0dGVzdC5tYWluKCkK