66400 2011-08-17 13:05:45 -0700 Fix TestWebKitAPI build on Mac OS 2011-08-17 21:47:36 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dslomov dslomov aroben levin webkit.review.bot oldest_to_newest 452487 0 dslomov 2011-08-17 13:05:45 -0700 StringOperations.cpp fail to build due to ICU headers missing 452491 1 104218 dslomov 2011-08-17 13:08:41 -0700 Created attachment 104218 Added ICU headers to HEADER_SEARCH_PATH. 452495 2 104218 mrowe 2011-08-17 13:11:28 -0700 Comment on attachment 104218 Added ICU headers to HEADER_SEARCH_PATH. View in context: https://bugs.webkit.org/attachment.cgi?id=104218&action=review > Tools/ChangeLog:4 > + Fix TestWebKitAPI build on MacOS. Mac OS. > Tools/ChangeLog:8 > + * TestWebKitAPI/Configurations/Base.xcconfig:Added ICU headers to the HEADER_SEARCH_PATH. We typically leave some space after the colon rather than jamming the message right up against it. 452501 3 dslomov 2011-08-17 13:17:10 -0700 (In reply to comment #2) > We typically leave some space after the colon rather than jamming the message right up against it. check-webkit-style should report this. 452506 4 104221 dslomov 2011-08-17 13:20:25 -0700 Created attachment 104221 Fix style nits. 452695 5 dslomov 2011-08-17 16:22:25 -0700 (In reply to comment #3) > (In reply to comment #2) > > > We typically leave some space after the colon rather than jamming the message right up against it. > > check-webkit-style should report this. https://bugs.webkit.org/show_bug.cgi?id=66425 452849 6 104221 webkit.review.bot 2011-08-17 21:47:31 -0700 Comment on attachment 104221 Fix style nits. Clearing flags on attachment: 104221 Committed r93282: <http://trac.webkit.org/changeset/93282> 452850 7 webkit.review.bot 2011-08-17 21:47:36 -0700 All reviewed patches have been landed. Closing bug. 104218 2011-08-17 13:08:41 -0700 2011-08-17 13:20:25 -0700 Added ICU headers to HEADER_SEARCH_PATH. 66400.patch text/plain 1776 dslomov ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3Mzc5 ZmY0Li41ZWQ3ZmU5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDgtMTcgIERtaXRyeSBMb21vdiAgPGRzbG9t b3ZAZ29vZ2xlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjY0MDAKKyAgICAgICAgRml4IFRlc3RXZWJLaXRBUEkgYnVpbGQgb24gTWFjT1Mu CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0 V2ViS2l0QVBJL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWc6QWRkZWQgSUNVIGhlYWRlcnMg dG8gdGhlIEhFQURFUl9TRUFSQ0hfUEFUSC4KKwogMjAxMS0wOC0xNiAgQWRhbSBCYXJ0aCAgPGFi YXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIE1vdmUgY2hyb21pdW0tbWFjIHRvIGNocm9taXVt LWNnLW1hYyB0byBwcmVwYXJlIGZvciBTa2lhIHN3aXRjaG92ZXIKZGlmZiAtLWdpdCBhL1Rvb2xz L1Rlc3RXZWJLaXRBUEkvQ29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZpZyBiL1Rvb2xzL1Rlc3RX ZWJLaXRBUEkvQ29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZpZwppbmRleCBjZmNmY2E2Li43M2U5 MmRlIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL0NvbmZpZ3VyYXRpb25zL0Jhc2Uu eGNjb25maWcKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9Db25maWd1cmF0aW9ucy9CYXNlLnhj Y29uZmlnCkBAIC0xOSwxMSArMTksMTEgQEAKIC8vIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVS UlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWSBUSEVPUlkKIC8vIE9GIExJQUJJTElU WSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAogLy8gKElO Q0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBP RiBUSEUgVVNFCi0vLyBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBP U1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLiAKKy8vIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYg QURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAKICNpbmNsdWRlICJD b21waWxlclZlcnNpb24ueGNjb25maWciCiAKLUhFQURFUl9TRUFSQ0hfUEFUSFMgPSAkKFdFQkNP UkVfUFJJVkFURV9IRUFERVJTX0RJUikvRm9yd2FyZGluZ0hlYWRlcnM7CitIRUFERVJfU0VBUkNI X1BBVEhTID0gJChXRUJDT1JFX1BSSVZBVEVfSEVBREVSU19ESVIpL0ZvcndhcmRpbmdIZWFkZXJz ICQoV0VCQ09SRV9QUklWQVRFX0hFQURFUlNfRElSKS9pY3U7CiBGUkFNRVdPUktfU0VBUkNIX1BB VEhTID0gJChTWVNURU1fTElCUkFSWV9ESVIpL0ZyYW1ld29ya3MvUXVhcnR6LmZyYW1ld29yay9G cmFtZXdvcmtzICQoU1lTVEVNX0xJQlJBUllfRElSKS9GcmFtZXdvcmtzL0FwcGxpY2F0aW9uU2Vy dmljZXMuZnJhbWV3b3JrL0ZyYW1ld29ya3MgJChTWVNURU1fTElCUkFSWV9ESVIpL0ZyYW1ld29y a3MvQ29yZVNlcnZpY2VzLmZyYW1ld29yay9GcmFtZXdvcmtzOwogR0NDX1BSRVBST0NFU1NPUl9E RUZJTklUSU9OUyA9IEVOQUJMRV9EQVNIQk9BUkRfU1VQUE9SVCBXRUJLSVRfVkVSU0lPTl9NSU5f UkVRVUlSRUQ9V0VCS0lUX1ZFUlNJT05fTEFURVNUOwogREVCVUdfSU5GT1JNQVRJT05fRk9STUFU ID0gZHdhcmYK 104221 2011-08-17 13:20:25 -0700 2011-08-17 21:47:31 -0700 Fix style nits. 66400.patch text/plain 1775 dslomov ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3Mzc5 ZmY0Li5lMzc1OWIwIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDgtMTcgIERtaXRyeSBMb21vdiAgPGRzbG9t b3ZAZ29vZ2xlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjY0MDAKKyAgICAgICAgRml4IFRlc3RXZWJLaXRBUEkgYnVpbGQgb24gTWFjIE9T LgorCisgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmluLgorCisgICAgICAgICogVGVzdFdl YktpdEFQSS9Db25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnOiBBZGRlZCBJQ1UgaGVhZGVycyB0 byB0aGUgSEVBREVSX1NFQVJDSF9QQVRILgorCiAyMDExLTA4LTE2ICBBZGFtIEJhcnRoICA8YWJh cnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTW92ZSBjaHJvbWl1bS1tYWMgdG8gY2hyb21pdW0t Y2ctbWFjIHRvIHByZXBhcmUgZm9yIFNraWEgc3dpdGNob3ZlcgpkaWZmIC0tZ2l0IGEvVG9vbHMv VGVzdFdlYktpdEFQSS9Db25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnIGIvVG9vbHMvVGVzdFdl YktpdEFQSS9Db25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnCmluZGV4IGNmY2ZjYTYuLjczZTky ZGUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvQ29uZmlndXJhdGlvbnMvQmFzZS54 Y2NvbmZpZworKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNj b25maWcKQEAgLTE5LDExICsxOSwxMSBAQAogLy8gUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJS VVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZIFRIRU9SWQogLy8gT0YgTElBQklMSVRZ LCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCiAvLyAoSU5D TFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9G IFRIRSBVU0UKLS8vIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9T U0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuIAorLy8gT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBB RFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KIAogI2luY2x1ZGUgIkNv bXBpbGVyVmVyc2lvbi54Y2NvbmZpZyIKIAotSEVBREVSX1NFQVJDSF9QQVRIUyA9ICQoV0VCQ09S RV9QUklWQVRFX0hFQURFUlNfRElSKS9Gb3J3YXJkaW5nSGVhZGVyczsKK0hFQURFUl9TRUFSQ0hf UEFUSFMgPSAkKFdFQkNPUkVfUFJJVkFURV9IRUFERVJTX0RJUikvRm9yd2FyZGluZ0hlYWRlcnMg JChXRUJDT1JFX1BSSVZBVEVfSEVBREVSU19ESVIpL2ljdTsKIEZSQU1FV09SS19TRUFSQ0hfUEFU SFMgPSAkKFNZU1RFTV9MSUJSQVJZX0RJUikvRnJhbWV3b3Jrcy9RdWFydHouZnJhbWV3b3JrL0Zy YW1ld29ya3MgJChTWVNURU1fTElCUkFSWV9ESVIpL0ZyYW1ld29ya3MvQXBwbGljYXRpb25TZXJ2 aWNlcy5mcmFtZXdvcmsvRnJhbWV3b3JrcyAkKFNZU1RFTV9MSUJSQVJZX0RJUikvRnJhbWV3b3Jr cy9Db3JlU2VydmljZXMuZnJhbWV3b3JrL0ZyYW1ld29ya3M7CiBHQ0NfUFJFUFJPQ0VTU09SX0RF RklOSVRJT05TID0gRU5BQkxFX0RBU0hCT0FSRF9TVVBQT1JUIFdFQktJVF9WRVJTSU9OX01JTl9S RVFVSVJFRD1XRUJLSVRfVkVSU0lPTl9MQVRFU1Q7CiBERUJVR19JTkZPUk1BVElPTl9GT1JNQVQg PSBkd2FyZgo=