66366 2011-08-17 02:31:48 -0700 [EFL] Private function _ewk_view_viewport_attributes_compute takes an internal data of ewk_view. 2011-10-26 01:26:57 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 0 g.czajkowski webkit-unassigned gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 452179 0 g.czajkowski 2011-08-17 02:31:48 -0700 Passes to _ewk_view_viewport_attributes_compute an internal data of ewk_view instead of the view object. Adds to ewk_view_viewport_attributes_get NULL checking to avoid unexpected results since this is API. 452180 1 104160 g.czajkowski 2011-08-17 02:32:31 -0700 Created attachment 104160 proposed patch 452187 2 104160 gyuyoung.kim 2011-08-17 03:06:36 -0700 Comment on attachment 104160 proposed patch LGTM 452232 3 104160 leandro 2011-08-17 07:10:59 -0700 Comment on attachment 104160 proposed patch Informal r+. 488355 4 111960 g.czajkowski 2011-10-21 06:53:10 -0700 Created attachment 111960 updated patch to a new coding style of WebKit-EFL 490620 5 111960 rniwa 2011-10-26 00:33:03 -0700 Comment on attachment 111960 updated patch to a new coding style of WebKit-EFL View in context: https://bugs.webkit.org/attachment.cgi?id=111960&action=review > Source/WebKit/efl/ChangeLog:9 > + Passes to _ewk_view_viewport_attributes_compute an internal > + data of ewk_view instead of the view object. This can fit in one line. > Source/WebKit/efl/ChangeLog:11 > + Adds to ewk_view_viewport_attributes_get NULL checks to > + avoid unexpected results since this is API. Ditto. 490645 6 112466 g.czajkowski 2011-10-26 01:13:38 -0700 Created attachment 112466 followed Ryosuke's suggestions 490658 7 112466 webkit.review.bot 2011-10-26 01:26:52 -0700 Comment on attachment 112466 followed Ryosuke's suggestions Clearing flags on attachment: 112466 Committed r98446: <http://trac.webkit.org/changeset/98446> 490659 8 webkit.review.bot 2011-10-26 01:26:57 -0700 All reviewed patches have been landed. Closing bug. 104160 2011-08-17 02:32:31 -0700 2011-10-21 06:53:10 -0700 proposed patch view_port_methods_refactoring.patch text/plain 2279 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBjZmFjYzczLi4yNGI3MDdjIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDUgKzEsMjAgQEAKIDIwMTEtMDgtMTIgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWpr b3dza2lAc2Ftc3VuZy5jb20+CiAKKyAgICAgICAgW0VGTF0gUHJpdmF0ZSBmdW5jdGlvbiBfZXdr X3ZpZXdfdmlld3BvcnRfYXR0cmlidXRlc19jb21wdXRlIHRha2VzIGFuIGludGVybmFsIGRhdGEg b2YgZXdrX3ZpZXcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02NjM2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFBhc3NlcyB0byBfZXdrX3ZpZXdfdmlld3BvcnRfYXR0cmlidXRlc19jb21wdXRlIGFuIGlu dGVybmFsIGRhdGEgb2YgZXdrX3ZpZXcKKyAgICAgICAgaW5zdGVhZCBvZiB0aGUgdmlldyBvYmpl Y3QuCisgICAgICAgIEFkZHMgdG8gZXdrX3ZpZXdfdmlld3BvcnRfYXR0cmlidXRlc19nZXQgTlVM TCBjaGVja2luZyB0byBhdm9pZCB1bmV4cGVjdGVkIHJlc3VsdHMgc2luY2UgdGhpcyBpcyBBUEku CisKKyAgICAgICAgKiBld2svZXdrX3ZpZXcuY3BwOgorICAgICAgICAoX2V3a192aWV3X3ZpZXdw b3J0X2F0dHJpYnV0ZXNfY29tcHV0ZSk6CisgICAgICAgIChld2tfdmlld192aWV3cG9ydF9hdHRy aWJ1dGVzX2dldCk6CisKKzIwMTEtMDgtMTIgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWpr b3dza2lAc2Ftc3VuZy5jb20+CisKICAgICAgICAgW0VGTF0gRml4IGFmdGVyIHI5MTgxNSAtIHJl c3RvcmUgY2hhbmdlcyBmcm9tIHI5MTY1OS4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTY0NjgyCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L2V3ay9ld2tfdmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCmlu ZGV4IDkyYjUxMmEuLjQwMjBhYjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9l d2tfdmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcApAQCAt MTAxNSwxMSArMTAxNSw4IEBAIHN0YXRpYyB2b2lkIF9ld2tfdmlld196b29tX2FuaW1hdGlvbl9z dGFydChFd2tfVmlld19TbWFydF9EYXRhICpzZCkKICAgICAgICAgKF9ld2tfdmlld196b29tX2Fu aW1hdG9yX2NiLCBzZCk7CiB9CiAKLXN0YXRpYyBXZWJDb3JlOjpWaWV3cG9ydEF0dHJpYnV0ZXMg X2V3a192aWV3X3ZpZXdwb3J0X2F0dHJpYnV0ZXNfY29tcHV0ZShFdmFzX09iamVjdCAqbykKK3N0 YXRpYyBXZWJDb3JlOjpWaWV3cG9ydEF0dHJpYnV0ZXMgX2V3a192aWV3X3ZpZXdwb3J0X2F0dHJp YnV0ZXNfY29tcHV0ZShFd2tfVmlld19Qcml2YXRlX0RhdGEgKnByaXYpCiB7Ci0gICAgRVdLX1ZJ RVdfU0RfR0VUKG8sIHNkKTsKLSAgICBFV0tfVklFV19QUklWX0dFVChzZCwgcHJpdik7Ci0KICAg ICBpbnQgZGVza3RvcF93aWR0aCA9IDk4MDsKICAgICBpbnQgZGV2aWNlX2RwaSA9IGV3a191dGls X2RwaV9nZXQoKTsKIApAQCAtMzM5MSw3ICszMzg4LDkgQEAgdm9pZCBld2tfdmlld192aWV3cG9y dF9hdHRyaWJ1dGVzX3NldChFdmFzX09iamVjdCAqbywgY29uc3QgV2ViQ29yZTo6Vmlld3BvcnRB cmcKIAogdm9pZCBld2tfdmlld192aWV3cG9ydF9hdHRyaWJ1dGVzX2dldChFdmFzX09iamVjdCAq bywgZmxvYXQgKncsIGZsb2F0ICpoLCBmbG9hdCAqaW5pdF9zY2FsZSwgZmxvYXQgKm1heF9zY2Fs ZSwgZmxvYXQgKm1pbl9zY2FsZSwgZmxvYXQgKmRldmljZV9waXhlbF9yYXRpbywgRWluYV9Cb29s ICp1c2VyX3NjYWxhYmxlKQogewotICAgIFdlYkNvcmU6OlZpZXdwb3J0QXR0cmlidXRlcyBhdHRy aWJ1dGVzID0gX2V3a192aWV3X3ZpZXdwb3J0X2F0dHJpYnV0ZXNfY29tcHV0ZShvKTsKKyAgICBF V0tfVklFV19TRF9HRVRfT1JfUkVUVVJOKG8sIHNkKTsKKyAgICBFV0tfVklFV19QUklWX0dFVF9P Ul9SRVRVUk4oc2QsIHByaXYpOworICAgIFdlYkNvcmU6OlZpZXdwb3J0QXR0cmlidXRlcyBhdHRy aWJ1dGVzID0gX2V3a192aWV3X3ZpZXdwb3J0X2F0dHJpYnV0ZXNfY29tcHV0ZShwcml2KTsKIAog ICAgIGlmICh3KQogICAgICAgICAqdyA9IGF0dHJpYnV0ZXMubGF5b3V0U2l6ZS53aWR0aCgpOwo= 111960 2011-10-21 06:53:10 -0700 2011-10-26 01:13:38 -0700 updated patch to a new coding style of WebKit-EFL view_port_methods_refactoring.patch text/plain 2427 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA4NTM2ZTM3Li4xYmNkZGE0IDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDUgKzEsMjEgQEAKIDIwMTEtMTAtMjEgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWpr b3dza2lAc2Ftc3VuZy5jb20+CiAKKyAgICAgICAgW0VGTF0gUHJpdmF0ZSBmdW5jdGlvbiBfZXdr X3ZpZXdfdmlld3BvcnRfYXR0cmlidXRlc19jb21wdXRlIHRha2VzIGFuIGludGVybmFsIGRhdGEg b2YgZXdrX3ZpZXcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02NjM2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFBhc3NlcyB0byBfZXdrX3ZpZXdfdmlld3BvcnRfYXR0cmlidXRlc19jb21wdXRlIGFuIGlu dGVybmFsCisgICAgICAgIGRhdGEgb2YgZXdrX3ZpZXcgaW5zdGVhZCBvZiB0aGUgdmlldyBvYmpl Y3QuCisgICAgICAgIEFkZHMgdG8gZXdrX3ZpZXdfdmlld3BvcnRfYXR0cmlidXRlc19nZXQgTlVM TCBjaGVja3MgdG8KKyAgICAgICAgYXZvaWQgdW5leHBlY3RlZCByZXN1bHRzIHNpbmNlIHRoaXMg aXMgQVBJLgorCisgICAgICAgICogZXdrL2V3a192aWV3LmNwcDoKKyAgICAgICAgKF9ld2tfdmll d192aWV3cG9ydF9hdHRyaWJ1dGVzX2NvbXB1dGUpOgorICAgICAgICAoZXdrX3ZpZXdfdmlld3Bv cnRfYXR0cmlidXRlc19nZXQpOgorCisyMDExLTEwLTIxICBHcnplZ29yeiBDemFqa293c2tpICA8 Zy5jemFqa293c2tpQHNhbXN1bmcuY29tPgorCiAgICAgICAgIFtFRkxdIGV3a192aWV3X21vZGVf Z2V0IHVzZXMgZGVkaWNhdGVkIG1hY3JvcyBpbnN0ZWFkIG9mIHN0YW5kYXJkIE5VTEwgY2hlY2tp bmcuCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTY4 MAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwIGIvU291 cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAppbmRleCA2NDM2Y2RiLi43ZTViMTExIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKQEAgLTEwNDIsMTEgKzEwNDIsOCBAQCBzdGF0 aWMgdm9pZCBfZXdrX3ZpZXdfem9vbV9hbmltYXRpb25fc3RhcnQoRXdrX1ZpZXdfU21hcnRfRGF0 YSogc21hcnREYXRhKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKF9l d2tfdmlld196b29tX2FuaW1hdG9yX2NiLCBzbWFydERhdGEpOwogfQogCi1zdGF0aWMgV2ViQ29y ZTo6Vmlld3BvcnRBdHRyaWJ1dGVzIF9ld2tfdmlld192aWV3cG9ydF9hdHRyaWJ1dGVzX2NvbXB1 dGUoY29uc3QgRXZhc19PYmplY3QqIGV3a1ZpZXcpCitzdGF0aWMgV2ViQ29yZTo6Vmlld3BvcnRB dHRyaWJ1dGVzIF9ld2tfdmlld192aWV3cG9ydF9hdHRyaWJ1dGVzX2NvbXB1dGUoY29uc3QgRXdr X1ZpZXdfUHJpdmF0ZV9EYXRhKiBwcml2KQogewotICAgIEVXS19WSUVXX1NEX0dFVChld2tWaWV3 LCBzZCk7Ci0gICAgRVdLX1ZJRVdfUFJJVl9HRVQoc2QsIHByaXYpOwotCiAgICAgaW50IGRlc2t0 b3Bfd2lkdGggPSA5ODA7CiAgICAgaW50IGRldmljZV9kcGkgPSBld2tfdXRpbF9kcGlfZ2V0KCk7 CiAKQEAgLTM0OTksNyArMzQ5Niw5IEBAIHZvaWQgZXdrX3ZpZXdfdmlld3BvcnRfYXR0cmlidXRl c19zZXQoRXZhc19PYmplY3QqIGV3a1ZpZXcsIGNvbnN0IFdlYkNvcmU6OlZpZXdwCiAKIHZvaWQg ZXdrX3ZpZXdfdmlld3BvcnRfYXR0cmlidXRlc19nZXQoY29uc3QgRXZhc19PYmplY3QqIGV3a1Zp ZXcsIGludCogd2lkdGgsIGludCogaGVpZ2h0LCBmbG9hdCogaW5pdFNjYWxlLCBmbG9hdCogbWF4 U2NhbGUsIGZsb2F0KiBtaW5TY2FsZSwgZmxvYXQqIGRldmljZVBpeGVsUmF0aW8sIEVpbmFfQm9v bCogdXNlclNjYWxhYmxlKQogewotICAgIFdlYkNvcmU6OlZpZXdwb3J0QXR0cmlidXRlcyBhdHRy aWJ1dGVzID0gX2V3a192aWV3X3ZpZXdwb3J0X2F0dHJpYnV0ZXNfY29tcHV0ZShld2tWaWV3KTsK KyAgICBFV0tfVklFV19TRF9HRVRfT1JfUkVUVVJOKGV3a1ZpZXcsIHNtYXJ0RGF0YSk7CisgICAg RVdLX1ZJRVdfUFJJVl9HRVRfT1JfUkVUVVJOKHNtYXJ0RGF0YSwgcHJpdik7CisgICAgV2ViQ29y ZTo6Vmlld3BvcnRBdHRyaWJ1dGVzIGF0dHJpYnV0ZXMgPSBfZXdrX3ZpZXdfdmlld3BvcnRfYXR0 cmlidXRlc19jb21wdXRlKHByaXYpOwogCiAgICAgaWYgKHdpZHRoKQogICAgICAgICAqd2lkdGgg PSBhdHRyaWJ1dGVzLmxheW91dFNpemUud2lkdGgoKTsK 112466 2011-10-26 01:13:38 -0700 2011-10-26 01:26:52 -0700 followed Ryosuke's suggestions view_port_methods_refactoring.patch text/plain 2335 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAzNDdmODJjLi45YmQ5NzI5IDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTEtMTAtMjYgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWpr b3dza2lAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gUHJpdmF0ZSBmdW5jdGlvbiBfZXdr X3ZpZXdfdmlld3BvcnRfYXR0cmlidXRlc19jb21wdXRlIHRha2VzIGFuIGludGVybmFsIGRhdGEg b2YgZXdrX3ZpZXcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02NjM2NgorCisgICAgICAgIFJldmlld2VkIGJ5IFJ5b3N1a2UgTml3YS4KKworICAgICAg ICBQYXNzZXMgdG8gX2V3a192aWV3X3ZpZXdwb3J0X2F0dHJpYnV0ZXNfY29tcHV0ZSBhbiBpbnRl cm5hbCBkYXRhIG9mIGV3a192aWV3IGluc3RlYWQgb2YgdGhlIHZpZXcgb2JqZWN0LgorICAgICAg ICBBZGRzIHRvIGV3a192aWV3X3ZpZXdwb3J0X2F0dHJpYnV0ZXNfZ2V0IE5VTEwgY2hlY2tzIHRv IGF2b2lkIHVuZXhwZWN0ZWQgcmVzdWx0cyBzaW5jZSB0aGlzIGlzIEFQSS4KKworICAgICAgICAq IGV3ay9ld2tfdmlldy5jcHA6CisgICAgICAgIChfZXdrX3ZpZXdfdmlld3BvcnRfYXR0cmlidXRl c19jb21wdXRlKToKKyAgICAgICAgKGV3a192aWV3X3ZpZXdwb3J0X2F0dHJpYnV0ZXNfZ2V0KToK KwogMjAxMS0xMC0yNSAgS3dhbmdIeXVrIEtpbSAgPGh5dWtpLmtpbUBzYW1zdW5nLmNvbT4KIAog ICAgICAgICBGaXggb2NjdXJyZW5jZSBvZiB1bnBhaW50ZWQgdGlsZXMgd2hpbGUgc2Nyb2xsaW5n IGFuZCB6b29taW5nLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3 LmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKaW5kZXggYjM5YmQ0MC4u OTllZTI5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCkBAIC0xMDc5LDExICsxMDc5 LDggQEAgc3RhdGljIHZvaWQgX2V3a192aWV3X3pvb21fYW5pbWF0aW9uX3N0YXJ0KEV3a19WaWV3 X1NtYXJ0X0RhdGEqIHNtYXJ0RGF0YSkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIChfZXdrX3ZpZXdfem9vbV9hbmltYXRvcl9jYiwgc21hcnREYXRhKTsKIH0KIAotc3Rh dGljIFdlYkNvcmU6OlZpZXdwb3J0QXR0cmlidXRlcyBfZXdrX3ZpZXdfdmlld3BvcnRfYXR0cmli dXRlc19jb21wdXRlKGNvbnN0IEV2YXNfT2JqZWN0KiBld2tWaWV3KQorc3RhdGljIFdlYkNvcmU6 OlZpZXdwb3J0QXR0cmlidXRlcyBfZXdrX3ZpZXdfdmlld3BvcnRfYXR0cmlidXRlc19jb21wdXRl KGNvbnN0IEV3a19WaWV3X1ByaXZhdGVfRGF0YSogcHJpdikKIHsKLSAgICBFV0tfVklFV19TRF9H RVQoZXdrVmlldywgc21hcnREYXRhKTsKLSAgICBFV0tfVklFV19QUklWX0dFVChzbWFydERhdGEs IHByaXYpOwotCiAgICAgaW50IGRlc2t0b3BXaWR0aCA9IDk4MDsKICAgICBpbnQgZGV2aWNlRFBJ ID0gZXdrX3V0aWxfZHBpX2dldCgpOwogCkBAIC0zNTM3LDcgKzM1MzQsOSBAQCB2b2lkIGV3a192 aWV3X3ZpZXdwb3J0X2F0dHJpYnV0ZXNfc2V0KEV2YXNfT2JqZWN0KiBld2tWaWV3LCBjb25zdCBX ZWJDb3JlOjpWaWV3cAogCiB2b2lkIGV3a192aWV3X3ZpZXdwb3J0X2F0dHJpYnV0ZXNfZ2V0KGNv bnN0IEV2YXNfT2JqZWN0KiBld2tWaWV3LCBpbnQqIHdpZHRoLCBpbnQqIGhlaWdodCwgZmxvYXQq IGluaXRTY2FsZSwgZmxvYXQqIG1heFNjYWxlLCBmbG9hdCogbWluU2NhbGUsIGZsb2F0KiBkZXZp Y2VQaXhlbFJhdGlvLCBFaW5hX0Jvb2wqIHVzZXJTY2FsYWJsZSkKIHsKLSAgICBXZWJDb3JlOjpW aWV3cG9ydEF0dHJpYnV0ZXMgYXR0cmlidXRlcyA9IF9ld2tfdmlld192aWV3cG9ydF9hdHRyaWJ1 dGVzX2NvbXB1dGUoZXdrVmlldyk7CisgICAgRVdLX1ZJRVdfU0RfR0VUX09SX1JFVFVSTihld2tW aWV3LCBzbWFydERhdGEpOworICAgIEVXS19WSUVXX1BSSVZfR0VUX09SX1JFVFVSTihzbWFydERh dGEsIHByaXYpOworICAgIFdlYkNvcmU6OlZpZXdwb3J0QXR0cmlidXRlcyBhdHRyaWJ1dGVzID0g X2V3a192aWV3X3ZpZXdwb3J0X2F0dHJpYnV0ZXNfY29tcHV0ZShwcml2KTsKIAogICAgIGlmICh3 aWR0aCkKICAgICAgICAgKndpZHRoID0gYXR0cmlidXRlcy5sYXlvdXRTaXplLndpZHRoKCk7Cg==