66357 2011-08-16 17:36:28 -0700 make-script-test-wrappers should not look outside fast/js 2011-10-25 14:15:52 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 67747 1 ap ap webkit.review.bot oldest_to_newest 452024 0 ap 2011-08-16 17:36:28 -0700 Splitting tests into HTML and JS parts is harmful: - it's more difficult to navigate to test source from results page to see what it's actually doing; - it's more difficult to navigate to it in Finder; - an extra file per test makes version control slower; - some people are led to believe that they should dynamically create a DOM from within JavaScript code, making tests even more difficult to follow; - other people manually modify wrappers, making it a pain to run the script for others. For fast/js, splitting the tests is likely worth it, as we want to eventually run them from within a pure JS interpreter without WebCore. 452025 1 104131 ap 2011-08-16 17:38:15 -0700 Created attachment 104131 proposed patch 452027 2 104131 ap 2011-08-16 17:41:01 -0700 Comment on attachment 104131 proposed patch That's too much, should also look in fast/js subdirectories. 452028 3 104132 ap 2011-08-16 17:43:43 -0700 Created attachment 104132 proposed patch 490266 4 104132 mjs 2011-10-25 12:59:49 -0700 Comment on attachment 104132 proposed patch r=me 490353 5 104132 webkit.review.bot 2011-10-25 14:15:47 -0700 Comment on attachment 104132 proposed patch Clearing flags on attachment: 104132 Committed r98395: <http://trac.webkit.org/changeset/98395> 490354 6 webkit.review.bot 2011-10-25 14:15:52 -0700 All reviewed patches have been landed. Closing bug. 104131 2011-08-16 17:38:15 -0700 2011-08-16 17:43:43 -0700 proposed patch FastJS.txt text/plain 4095 ap SW5kZXg6IFRvb2xzL1NjcmlwdHMvbWFrZS1zY3JpcHQtdGVzdC13cmFwcGVycwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9TY3JpcHRzL21ha2Utc2NyaXB0LXRlc3Qtd3JhcHBlcnMJKHJldmlzaW9uIDkz MDcxKQorKysgVG9vbHMvU2NyaXB0cy9tYWtlLXNjcmlwdC10ZXN0LXdyYXBwZXJzCSh3b3JraW5n IGNvcHkpCkBAIC0zOSw3ICszOSw2IEBAIHVzZSBHZXRvcHQ6Okxvbmc7CiB1c2Ugd2Via2l0ZGly czsKIAogc3ViIGRpcmVjdG9yeUZpbHRlcjsKLXN1YiBmaW5kVGVtcGxhdGVGaWxlcyhAKTsKIAog bXkgJHNob3dIZWxwOwogCkBAIC00OCw3MSArNDcsNTQgQEAgbXkgJHJlc3VsdCA9IEdldE9wdGlv bnMoCiApOwogCiBpZiAoISRyZXN1bHQgfHwgJHNob3dIZWxwKSB7Ci0gICAgcHJpbnQgU1RERVJS IGJhc2VuYW1lKCQwKSAuICIgWy1ofC0taGVscF0gW3BhdGggLi4uXVxuIjsKKyAgICBwcmludCBT VERFUlIgYmFzZW5hbWUoJDApIC4gIiBbLWh8LS1oZWxwXVxuIjsKICAgICBleGl0IDE7CiB9CiAK IHNldENvbmZpZ3VyYXRpb24oKTsKIG15ICRwcm9kdWN0RGlyID0gcHJvZHVjdERpcigpOwogCi1j aGRpcldlYktpdCgpOwotCi1teSBAdGVtcGxhdGVzID0gZmluZFRlbXBsYXRlRmlsZXMoQEFSR1Yp OwotCi1mb3IgbXkgJHRmaWxlIChAdGVtcGxhdGVzKSB7Ci0KLSAgICBteSAkdHBhdGggPSAkdGZp bGU7Ci0gICAgbXkgJHRlbXBsYXRlRGlyZWN0b3J5OwotICAgIG15ICR0ZW1wbGF0ZVJlbGF0aXZl UGF0aDsKLSAgICBpZiAoJHRwYXRoID1+IHM6LyhzY3JpcHQtdGVzdHMpL1RFTVBMQVRFLmh0bWwk OjopIHsKLSAgICAgICAgJHRlbXBsYXRlRGlyZWN0b3J5ID0gJDE7Ci0gICAgICAgICR0ZW1wbGF0 ZVJlbGF0aXZlUGF0aCA9ICQxIC4gIi9URU1QTEFURS5odG1sIjsKLSAgICB9IGVsc2UgewotICAg ICAgICBwcmludCAiSW5hcHByb3ByaWF0ZSBwb3NpdGlvbiBvZiBhIHRlbXBsYXRlOiAke3RwYXRo fVxuIjsKLSAgICAgICAgbmV4dDsKLSAgICB9CitteSAkdGVtcGxhdGVEaXJlY3RvcnkgPSAic2Ny aXB0LXRlc3RzIjsKK215ICR0ZW1wbGF0ZVJlbGF0aXZlUGF0aCA9ICJzY3JpcHQtdGVzdHMvVEVN UExBVEUuaHRtbCI7CiAKLSAgICBwcmludCAiJHt0cGF0aH1cbiI7Ci0KLSAgICBjaGRpcldlYktp dCgpOwotICAgIGNoZGlyKCR0cGF0aCk7Ci0KLSAgICBteSBAZmlsZXM7Ci0gICAgbXkgJGZpbGVG aWx0ZXIgPSBzdWIgewotICAgICAgICBwdXNoIEBmaWxlcywgJEZpbGU6OkZpbmQ6Om5hbWUgaWYg c3Vic3RyKCRfLCAtMykgZXEgIi5qcyI7Ci0gICAgfTsKLSAgICBmaW5kKHsgcHJlcHJvY2VzcyA9 PiBcJmRpcmVjdG9yeUZpbHRlciwgd2FudGVkID0+ICRmaWxlRmlsdGVyIH0sICR0ZW1wbGF0ZURp cmVjdG9yeSk7CitjaGRpcldlYktpdCgpOworY2hkaXIoIkxheW91dFRlc3RzL2Zhc3QvanMiKTsK IAotICAgIG9wZW4gVEVNUExBVEUsICI8JHt0ZW1wbGF0ZVJlbGF0aXZlUGF0aH0iOwotICAgIG15 ICR0ZW1wbGF0ZSA9IGRvIHsgbG9jYWwgJC87IDxURU1QTEFURT4gfTsKK215IEBmaWxlczsKK215 ICRmaWxlRmlsdGVyID0gc3ViIHsKKyAgICBwdXNoIEBmaWxlcywgJEZpbGU6OkZpbmQ6Om5hbWUg aWYgc3Vic3RyKCRfLCAtMykgZXEgIi5qcyI7Cit9OworZmluZCh7IHByZXByb2Nlc3MgPT4gXCZk aXJlY3RvcnlGaWx0ZXIsIHdhbnRlZCA9PiAkZmlsZUZpbHRlciB9LCAkdGVtcGxhdGVEaXJlY3Rv cnkpOworCitvcGVuIFRFTVBMQVRFLCAiPCR7dGVtcGxhdGVSZWxhdGl2ZVBhdGh9IjsKK215ICR0 ZW1wbGF0ZSA9IGRvIHsgbG9jYWwgJC87IDxURU1QTEFURT4gfTsKK2Nsb3NlIFRFTVBMQVRFOwor CitteSAkdGVtcGxhdGVOZWdhdGl2ZSA9ICR0ZW1wbGF0ZTsKK2lmICgtZSAiJHt0ZW1wbGF0ZURp cmVjdG9yeX0vVEVNUExBVEUtbi5odG1sIikgeworICAgIG9wZW4gVEVNUExBVEUsICI8JHt0ZW1w bGF0ZURpcmVjdG9yeX0vVEVNUExBVEUtbi5odG1sIjsKKyAgICAkdGVtcGxhdGVOZWdhdGl2ZSA9 IGRvIHsgbG9jYWwgJC87IDxURU1QTEFURT4gfTsKICAgICBjbG9zZSBURU1QTEFURTsKK30KIAot ICAgIG15ICR0ZW1wbGF0ZU5lZ2F0aXZlID0gJHRlbXBsYXRlOwotICAgIGlmICgtZSAiJHt0ZW1w bGF0ZURpcmVjdG9yeX0vVEVNUExBVEUtbi5odG1sIikgewotICAgICAgICBvcGVuIFRFTVBMQVRF LCAiPCR7dGVtcGxhdGVEaXJlY3Rvcnl9L1RFTVBMQVRFLW4uaHRtbCI7Ci0gICAgICAgICR0ZW1w bGF0ZU5lZ2F0aXZlID0gZG8geyBsb2NhbCAkLzsgPFRFTVBMQVRFPiB9OwotICAgICAgICBjbG9z ZSBURU1QTEFURTsKLSAgICB9Ci0KLSAgICBmb3IgbXkgJGZpbGUgKEBmaWxlcykgewotICAgICAg ICBteSAkaHRtbCA9ICRmaWxlOwotICAgICAgICAkaHRtbCA9fiBzOiR7dGVtcGxhdGVEaXJlY3Rv cnl9LyguKilcLmpzOiQxLmh0bWw6OwotICAgICAgICBuZXh0IGlmIC1mICIkaHRtbC1kaXNhYmxl ZCI7Ci0KLSAgICAgICAgc3lzdGVtKCJjYXQgJHtmaWxlfSB8IHRyICdcXDAnICcgJyB8IGdyZXAg LXEgJ3N1Y2Nlc3NmdWxseVBhcnNlZCA9JyIpOwotICAgICAgICBpZiAoJD8gIT0gMCkgewotICAg ICAgICAgICAgYGVjaG8gIiIgPj4gIiR7ZmlsZX0iYDsKLSAgICAgICAgICAgIGBlY2hvICJ2YXIg c3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsiID4+ICIke2ZpbGV9ImA7Ci0gICAgICAgIH0KLSAg ICAgICAgCi0gICAgICAgIHByaW50ICIgICAgJHtodG1sfVxuIjsKLSAgICAgICAgb3BlbiBIVE1M LCAiPiRodG1sIjsKLSAgICAgICAgbXkgJG91dHB1dCA9ICgkZmlsZSA9fiAvLW5cLmpzLykgPyAk dGVtcGxhdGVOZWdhdGl2ZSA6ICR0ZW1wbGF0ZTsKLSAgICAgICAgJG91dHB1dCA9fiBzOllPVVJf SlNfRklMRV9IRVJFOiRmaWxlOjsKLSAgICAgICAgcHJpbnQgSFRNTCAkb3V0cHV0OwotICAgICAg ICAKLSAgICAgICAgY2xvc2UgSFRNTDsKK2ZvciBteSAkZmlsZSAoQGZpbGVzKSB7CisgICAgbXkg JGh0bWwgPSAkZmlsZTsKKyAgICAkaHRtbCA9fiBzOiR7dGVtcGxhdGVEaXJlY3Rvcnl9LyguKilc LmpzOiQxLmh0bWw6OworICAgIG5leHQgaWYgLWYgIiRodG1sLWRpc2FibGVkIjsKKworICAgIHN5 c3RlbSgiY2F0ICR7ZmlsZX0gfCB0ciAnXFwwJyAnICcgfCBncmVwIC1xICdzdWNjZXNzZnVsbHlQ YXJzZWQgPSciKTsKKyAgICBpZiAoJD8gIT0gMCkgeworICAgICAgICBgZWNobyAiIiA+PiAiJHtm aWxlfSJgOworICAgICAgICBgZWNobyAidmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7IiA+ PiAiJHtmaWxlfSJgOwogICAgIH0KKyAgICAKKyAgICBwcmludCAiICAgICR7aHRtbH1cbiI7Cisg ICAgb3BlbiBIVE1MLCAiPiRodG1sIjsKKyAgICBteSAkb3V0cHV0ID0gKCRmaWxlID1+IC8tblwu anMvKSA/ICR0ZW1wbGF0ZU5lZ2F0aXZlIDogJHRlbXBsYXRlOworICAgICRvdXRwdXQgPX4gczpZ T1VSX0pTX0ZJTEVfSEVSRTokZmlsZTo7CisgICAgcHJpbnQgSFRNTCAkb3V0cHV0OworICAgIAor ICAgIGNsb3NlIEhUTUw7CiB9CiAKIGV4aXQgMDsKQEAgLTEyMiwyMCArMTA0LDMgQEAgc3ViIGRp cmVjdG9yeUZpbHRlcgogICAgIHJldHVybiAoKSBpZiBiYXNlbmFtZSgkRmlsZTo6RmluZDo6ZGly KSBlcSAiLnN2biI7CiAgICAgcmV0dXJuIEBfOwogfQotCi1zdWIgZmluZFRlbXBsYXRlRmlsZXMo QCkgewotICAgIG15IEBhcmdzID0gQF87Ci0gICAgbXkgQHRlbXBsYXRlRmlsZXM7Ci0KLSAgICBw dXNoIEBhcmdzLCAiTGF5b3V0VGVzdHMiIGlmIHNjYWxhcihAYXJncykgPT0gMDsKLQotICAgIG15 IEBwYXRocyA9IG1hcCB7IC1mICRfID8gZGlybmFtZSgkXykgOiAkXyB9IEBhcmdzOwotCi0gICAg bXkgJGZpbGVGaWx0ZXIgPSBzdWIgewotICAgICAgICBwdXNoIEB0ZW1wbGF0ZUZpbGVzLCAkRmls ZTo6RmluZDo6bmFtZSBpZiAkXyBlcSAiVEVNUExBVEUuaHRtbCI7Ci0gICAgfTsKLQotICAgIGZp bmQoeyBwcmVwcm9jZXNzID0+IFwmZGlyZWN0b3J5RmlsdGVyLCB3YW50ZWQgPT4gJGZpbGVGaWx0 ZXIgfSwgQHBhdGhzKTsKLQotICAgIHJldHVybiBAdGVtcGxhdGVGaWxlczsKLX0K 104132 2011-08-16 17:43:43 -0700 2011-10-25 14:15:47 -0700 proposed patch FastJS.txt text/plain 1645 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDkzMTgyKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTMgQEAKKzIwMTEtMDgtMTYgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+ CisKKyAgICAgICAgbWFrZS1zY3JpcHQtdGVzdC13cmFwcGVycyBzaG91bGQgbm90IGxvb2sgb3V0 c2lkZSBmYXN0L2pzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02NjM1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogU2NyaXB0cy9tYWtlLXNjcmlwdC10ZXN0LXdyYXBwZXJzOiBEb24ndCBsb29rIGZvciB0 ZW1wbGF0ZSBmaWxlcyBldmVyeXdoZXJlLCBvbmx5IHN1cHBvcnQKKyAgICAgICAgZmFzdC9qcy4K KwogMjAxMS0wOC0xNiAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAg IENoYW5nZSB3ZWJraXQtcGF0Y2ggYW5hbHl6ZS1iYXNlbGluZXMgdG8gcHJpbnQgaW4gYSBtb3Jl IHVuaXgtZnJpZW5kbHkgd2F5CkluZGV4OiBUb29scy9TY3JpcHRzL21ha2Utc2NyaXB0LXRlc3Qt d3JhcHBlcnMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9tYWtlLXNjcmlwdC10ZXN0LXdy YXBwZXJzCShyZXZpc2lvbiA5MzA3MSkKKysrIFRvb2xzL1NjcmlwdHMvbWFrZS1zY3JpcHQtdGVz dC13cmFwcGVycwkod29ya2luZyBjb3B5KQpAQCAtNDgsNyArNDgsNyBAQCBteSAkcmVzdWx0ID0g R2V0T3B0aW9ucygKICk7CiAKIGlmICghJHJlc3VsdCB8fCAkc2hvd0hlbHApIHsKLSAgICBwcmlu dCBTVERFUlIgYmFzZW5hbWUoJDApIC4gIiBbLWh8LS1oZWxwXSBbcGF0aCAuLi5dXG4iOworICAg IHByaW50IFNUREVSUiBiYXNlbmFtZSgkMCkgLiAiIFstaHwtLWhlbHBdXG4iOwogICAgIGV4aXQg MTsKIH0KIApAQCAtMTI0LDE4ICsxMjQsMTMgQEAgc3ViIGRpcmVjdG9yeUZpbHRlcgogfQogCiBz dWIgZmluZFRlbXBsYXRlRmlsZXMoQCkgewotICAgIG15IEBhcmdzID0gQF87CiAgICAgbXkgQHRl bXBsYXRlRmlsZXM7CiAKLSAgICBwdXNoIEBhcmdzLCAiTGF5b3V0VGVzdHMiIGlmIHNjYWxhcihA YXJncykgPT0gMDsKLQotICAgIG15IEBwYXRocyA9IG1hcCB7IC1mICRfID8gZGlybmFtZSgkXykg OiAkXyB9IEBhcmdzOwotCiAgICAgbXkgJGZpbGVGaWx0ZXIgPSBzdWIgewogICAgICAgICBwdXNo IEB0ZW1wbGF0ZUZpbGVzLCAkRmlsZTo6RmluZDo6bmFtZSBpZiAkXyBlcSAiVEVNUExBVEUuaHRt bCI7CiAgICAgfTsKIAotICAgIGZpbmQoeyBwcmVwcm9jZXNzID0+IFwmZGlyZWN0b3J5RmlsdGVy LCB3YW50ZWQgPT4gJGZpbGVGaWx0ZXIgfSwgQHBhdGhzKTsKKyAgICBmaW5kKHsgcHJlcHJvY2Vz cyA9PiBcJmRpcmVjdG9yeUZpbHRlciwgd2FudGVkID0+ICRmaWxlRmlsdGVyIH0sICJMYXlvdXRU ZXN0cy9mYXN0L2pzIik7CiAKICAgICByZXR1cm4gQHRlbXBsYXRlRmlsZXM7CiB9Cg==