66355 2011-08-16 17:13:36 -0700 Switch Editing code to new layout types 2011-08-17 18:31:50 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 63567 1 leviw leviw eae eric webkit.review.bot oldest_to_newest 452003 0 leviw 2011-08-16 17:13:36 -0700 Ongoing conversion 452014 1 104126 leviw 2011-08-16 17:18:51 -0700 Created attachment 104126 Patch 452790 2 104126 webkit.review.bot 2011-08-17 18:31:46 -0700 Comment on attachment 104126 Patch Clearing flags on attachment: 104126 Committed r93273: <http://trac.webkit.org/changeset/93273> 452791 3 webkit.review.bot 2011-08-17 18:31:50 -0700 All reviewed patches have been landed. Closing bug. 104126 2011-08-16 17:18:51 -0700 2011-08-17 18:31:45 -0700 Patch bug-66355-20110816171850.patch text/plain 6025 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkzMTgxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDgtMTYgIExldmkgV2Vp bnRyYXViICA8bGV2aXdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFN3aXRjaCBFZGl0aW5nIGNv ZGUgdG8gbmV3IGxheW91dCB0eXBlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NjYzNTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBDb252ZXJ0aW5nIHJlbWFpbmluZyBlZGl0aW5nIGNvZGUgdG8gdGhlIExh eW91dFVuaXQgYWJzdHJhY3Rpb24uCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBjaGFuZ2Ug aW4gZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIGVkaXRpbmcvRWRpdG9yLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkVkaXRvcjo6cmFuZ2VGb3JQb2ludCk6CisgICAgICAgIChXZWJDb3JlOjpF ZGl0b3I6Omluc2lkZVZpc2libGVBcmVhKToKKyAgICAgICAgKFdlYkNvcmU6OkVkaXRvcjo6Y291 bnRNYXRjaGVzRm9yVGV4dCk6CisgICAgICAgICogZWRpdGluZy9FZGl0b3IuaDoKKyAgICAgICAg KiBlZGl0aW5nL21hYy9GcmFtZVNlbGVjdGlvbk1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OkZy YW1lU2VsZWN0aW9uOjpub3RpZnlBY2Nlc3NpYmlsaXR5Rm9yU2VsZWN0aW9uQ2hhbmdlKToKKwog MjAxMS0wOC0xNiAgU2NvdHQgQnllciAgPHNjb3R0YnllckBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgRml4IHNwZWxsaW5nIGVycm9yLgpJbmRleDogU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0 b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNwcAko cmV2aXNpb24gOTMxNzApCisrKyBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTI0MTUsNyArMjQxNSw3IEBAIHZvaWQgRWRpdG9yOjpkZWxldGVkQXV0 b2NvcnJlY3Rpb25BdFBvc2kKICAgICBtX3NwZWxsaW5nQ29ycmVjdG9yLT5kZWxldGVkQXV0b2Nv cnJlY3Rpb25BdFBvc2l0aW9uKHBvc2l0aW9uLCBvcmlnaW5hbFN0cmluZyk7CiB9CiAKLVBhc3NS ZWZQdHI8UmFuZ2U+IEVkaXRvcjo6cmFuZ2VGb3JQb2ludChjb25zdCBJbnRQb2ludCYgd2luZG93 UG9pbnQpCitQYXNzUmVmUHRyPFJhbmdlPiBFZGl0b3I6OnJhbmdlRm9yUG9pbnQoY29uc3QgTGF5 b3V0UG9pbnQmIHdpbmRvd1BvaW50KQogewogICAgIERvY3VtZW50KiBkb2N1bWVudCA9IG1fZnJh bWUtPmRvY3VtZW50QXRQb2ludCh3aW5kb3dQb2ludCk7CiAgICAgaWYgKCFkb2N1bWVudCkKQEAg LTI0MjYsNyArMjQyNiw3IEBAIFBhc3NSZWZQdHI8UmFuZ2U+IEVkaXRvcjo6cmFuZ2VGb3JQb2lu dCgKICAgICBGcmFtZVZpZXcqIGZyYW1lVmlldyA9IGZyYW1lLT52aWV3KCk7CiAgICAgaWYgKCFm cmFtZVZpZXcpCiAgICAgICAgIHJldHVybiAwOwotICAgIEludFBvaW50IGZyYW1lUG9pbnQgPSBm cmFtZVZpZXctPndpbmRvd1RvQ29udGVudHMod2luZG93UG9pbnQpOworICAgIExheW91dFBvaW50 IGZyYW1lUG9pbnQgPSBmcmFtZVZpZXctPndpbmRvd1RvQ29udGVudHMod2luZG93UG9pbnQpOwog ICAgIFZpc2libGVTZWxlY3Rpb24gc2VsZWN0aW9uKGZyYW1lLT52aXNpYmxlUG9zaXRpb25Gb3JQ b2ludChmcmFtZVBvaW50KSk7CiAgICAgcmV0dXJuIGF2b2lkSW50ZXJzZWN0aW9uV2l0aE5vZGUo c2VsZWN0aW9uLnRvTm9ybWFsaXplZFJhbmdlKCkuZ2V0KCksIG1fZGVsZXRlQnV0dG9uQ29udHJv bGxlci0+Y29udGFpbmVyRWxlbWVudCgpKTsKIH0KQEAgLTI1NTMsNyArMjU1Myw3IEBAIHZvaWQg RWRpdG9yOjpkaXNtaXNzQ29ycmVjdGlvblBhbmVsQXNJZ24KICAgICBtX3NwZWxsaW5nQ29ycmVj dG9yLT5kaXNtaXNzKFJlYXNvbkZvckRpc21pc3NpbmdDb3JyZWN0aW9uUGFuZWxJZ25vcmVkKTsK IH0KIAotYm9vbCBFZGl0b3I6Omluc2lkZVZpc2libGVBcmVhKGNvbnN0IEludFBvaW50JiBwb2lu dCkgY29uc3QKK2Jvb2wgRWRpdG9yOjppbnNpZGVWaXNpYmxlQXJlYShjb25zdCBMYXlvdXRQb2lu dCYgcG9pbnQpIGNvbnN0CiB7CiAgICAgaWYgKG1fZnJhbWUtPmV4Y2x1ZGVGcm9tVGV4dFNlYXJj aCgpKQogICAgICAgICByZXR1cm4gZmFsc2U7CkBAIC0yNTcyLDkgKzI1NzIsOSBAQCBib29sIEVk aXRvcjo6aW5zaWRlVmlzaWJsZUFyZWEoY29uc3QgSW50CiAgICAgaWYgKCEoY29udGFpbmVyLT5z dHlsZSgpLT5vdmVyZmxvd1goKSA9PSBPSElEREVOIHx8IGNvbnRhaW5lci0+c3R5bGUoKS0+b3Zl cmZsb3dZKCkgPT0gT0hJRERFTikpCiAgICAgICAgIHJldHVybiB0cnVlOwogCi0gICAgSW50UmVj dCByZWN0SW5QYWdlQ29vcmRzID0gY29udGFpbmVyLT5vdmVyZmxvd0NsaXBSZWN0KEludFBvaW50 KCkpOwotICAgIEludFJlY3QgcmVjdEluRnJhbWVDb29yZHMgPSBJbnRSZWN0KHJlbmRlcmVyLT54 KCkgKiAtMSwgcmVuZGVyZXItPnkoKSAqIC0xLAotICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgcmVjdEluUGFnZUNvb3Jkcy53aWR0aCgpLCByZWN0SW5QYWdlQ29vcmRzLmhlaWdo dCgpKTsKKyAgICBMYXlvdXRSZWN0IHJlY3RJblBhZ2VDb29yZHMgPSBjb250YWluZXItPm92ZXJm bG93Q2xpcFJlY3QoSW50UG9pbnQoKSk7CisgICAgTGF5b3V0UmVjdCByZWN0SW5GcmFtZUNvb3Jk cyA9IExheW91dFJlY3QocmVuZGVyZXItPngoKSAqIC0xLCByZW5kZXJlci0+eSgpICogLTEsCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVjdEluUGFnZUNv b3Jkcy53aWR0aCgpLCByZWN0SW5QYWdlQ29vcmRzLmhlaWdodCgpKTsKIAogICAgIHJldHVybiBy ZWN0SW5GcmFtZUNvb3Jkcy5jb250YWlucyhwb2ludCk7CiB9CkBAIC0yNjAxLDEwICsyNjAxLDEw IEBAIGJvb2wgRWRpdG9yOjppbnNpZGVWaXNpYmxlQXJlYShSYW5nZSogcmEKICAgICBpZiAoIShj b250YWluZXItPnN0eWxlKCktPm92ZXJmbG93WCgpID09IE9ISURERU4gfHwgY29udGFpbmVyLT5z dHlsZSgpLT5vdmVyZmxvd1koKSA9PSBPSElEREVOKSkKICAgICAgICAgcmV0dXJuIHRydWU7CiAK LSAgICBJbnRSZWN0IHJlY3RJblBhZ2VDb29yZHMgPSBjb250YWluZXItPm92ZXJmbG93Q2xpcFJl Y3QoSW50UG9pbnQoKSk7Ci0gICAgSW50UmVjdCByZWN0SW5GcmFtZUNvb3JkcyA9IEludFJlY3Qo cmVuZGVyZXItPngoKSAqIC0xLCByZW5kZXJlci0+eSgpICogLTEsCisgICAgTGF5b3V0UmVjdCBy ZWN0SW5QYWdlQ29vcmRzID0gY29udGFpbmVyLT5vdmVyZmxvd0NsaXBSZWN0KExheW91dFBvaW50 KCkpOworICAgIExheW91dFJlY3QgcmVjdEluRnJhbWVDb29yZHMgPSBMYXlvdXRSZWN0KHJlbmRl cmVyLT54KCkgKiAtMSwgcmVuZGVyZXItPnkoKSAqIC0xLAogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgcmVjdEluUGFnZUNvb3Jkcy53aWR0aCgpLCByZWN0SW5QYWdlQ29vcmRz LmhlaWdodCgpKTsKLSAgICBJbnRSZWN0IHJlc3VsdFJlY3QgPSByYW5nZS0+Ym91bmRpbmdCb3go KTsKKyAgICBMYXlvdXRSZWN0IHJlc3VsdFJlY3QgPSByYW5nZS0+Ym91bmRpbmdCb3goKTsKICAg ICAKICAgICByZXR1cm4gcmVjdEluRnJhbWVDb29yZHMuY29udGFpbnMocmVzdWx0UmVjdCk7CiB9 CkBAIC0zMDgzLDcgKzMwODMsNyBAQCB1bnNpZ25lZCBFZGl0b3I6OmNvdW50TWF0Y2hlc0ZvclRl eHQoY29uCiAgICAgICAgIC8vIERvIGEgImZha2UiIHBhaW50IGluIG9yZGVyIHRvIGV4ZWN1dGUg dGhlIGNvZGUgdGhhdCBjb21wdXRlcyB0aGUgcmVuZGVyZWQgcmVjdCBmb3IgZWFjaCB0ZXh0IG1h dGNoLgogICAgICAgICBpZiAobV9mcmFtZS0+dmlldygpICYmIG1fZnJhbWUtPmNvbnRlbnRSZW5k ZXJlcigpKSB7CiAgICAgICAgICAgICBtX2ZyYW1lLT5kb2N1bWVudCgpLT51cGRhdGVMYXlvdXQo KTsgLy8gRW5zdXJlIGxheW91dCBpcyB1cCB0byBkYXRlLgotICAgICAgICAgICAgSW50UmVjdCB2 aXNpYmxlUmVjdCA9IG1fZnJhbWUtPnZpZXcoKS0+dmlzaWJsZUNvbnRlbnRSZWN0KCk7CisgICAg ICAgICAgICBMYXlvdXRSZWN0IHZpc2libGVSZWN0ID0gbV9mcmFtZS0+dmlldygpLT52aXNpYmxl Q29udGVudFJlY3QoKTsKICAgICAgICAgICAgIGlmICghdmlzaWJsZVJlY3QuaXNFbXB0eSgpKSB7 CiAgICAgICAgICAgICAgICAgR3JhcGhpY3NDb250ZXh0IGNvbnRleHQoKFBsYXRmb3JtR3JhcGhp Y3NDb250ZXh0KikwKTsKICAgICAgICAgICAgICAgICBjb250ZXh0LnNldFBhaW50aW5nRGlzYWJs ZWQodHJ1ZSk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmgJKHJldmlzaW9uIDkzMTcwKQor KysgU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuaAkod29ya2luZyBjb3B5KQpAQCAtMjk1 LDcgKzI5NSw3IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgc2V0U3RhcnROZXdLaWxsUmluZ1NlcXVl bmNlKGJvb2wpOwogCi0gICAgUGFzc1JlZlB0cjxSYW5nZT4gcmFuZ2VGb3JQb2ludChjb25zdCBJ bnRQb2ludCYgd2luZG93UG9pbnQpOworICAgIFBhc3NSZWZQdHI8UmFuZ2U+IHJhbmdlRm9yUG9p bnQoY29uc3QgTGF5b3V0UG9pbnQmIHdpbmRvd1BvaW50KTsKIAogICAgIHZvaWQgY2xlYXIoKTsK IApAQCAtMzA5LDcgKzMwOSw3IEBAIHB1YmxpYzoKICAgICBQYXNzUmVmUHRyPFJhbmdlPiBzZWxl Y3RlZFJhbmdlKCk7CiAgICAgCiAgICAgLy8gV2Ugc2hvdWxkIG1ha2UgdGhlc2UgZnVuY3Rpb25z IHByaXZhdGUgd2hlbiB0aGVpciBjYWxsZXJzIGluIEZyYW1lIGFyZSBtb3ZlZCBvdmVyIGhlcmUg dG8gRWRpdG9yCi0gICAgYm9vbCBpbnNpZGVWaXNpYmxlQXJlYShjb25zdCBJbnRQb2ludCYpIGNv bnN0OworICAgIGJvb2wgaW5zaWRlVmlzaWJsZUFyZWEoY29uc3QgTGF5b3V0UG9pbnQmKSBjb25z dDsKICAgICBib29sIGluc2lkZVZpc2libGVBcmVhKFJhbmdlKikgY29uc3Q7CiAKICAgICB2b2lk IGFkZFRvS2lsbFJpbmcoUmFuZ2UqLCBib29sIHByZXBlbmQpOwpJbmRleDogU291cmNlL1dlYkNv cmUvZWRpdGluZy9tYWMvRnJhbWVTZWxlY3Rpb25NYWMubW0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvZWRpdGluZy9tYWMvRnJhbWVTZWxlY3Rpb25NYWMubW0JKHJldmlzaW9uIDkzMTcw KQorKysgU291cmNlL1dlYkNvcmUvZWRpdGluZy9tYWMvRnJhbWVTZWxlY3Rpb25NYWMubW0JKHdv cmtpbmcgY29weSkKQEAgLTY0LDggKzY0LDggQEAgdm9pZCBGcmFtZVNlbGVjdGlvbjo6bm90aWZ5 QWNjZXNzaWJpbGl0eQogICAgIGlmICghZnJhbWVWaWV3KQogICAgICAgICByZXR1cm47CiAKLSAg ICBJbnRSZWN0IHNlbGVjdGlvblJlY3QgPSBhYnNvbHV0ZUNhcmV0Qm91bmRzKCk7Ci0gICAgSW50 UmVjdCB2aWV3UmVjdCA9IHJlbmRlclZpZXctPnZpZXdSZWN0KCk7CisgICAgTGF5b3V0UmVjdCBz ZWxlY3Rpb25SZWN0ID0gYWJzb2x1dGVDYXJldEJvdW5kcygpOworICAgIExheW91dFJlY3Qgdmll d1JlY3QgPSByZW5kZXJWaWV3LT52aWV3UmVjdCgpOwogCiAgICAgc2VsZWN0aW9uUmVjdCA9IGZy YW1lVmlldy0+Y29udGVudHNUb1NjcmVlbihzZWxlY3Rpb25SZWN0KTsKICAgICB2aWV3UmVjdCA9 IGZyYW1lVmlldy0+Y29udGVudHNUb1NjcmVlbih2aWV3UmVjdCk7Cg==