<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>66350</bug_id>
          
          <creation_ts>2011-08-16 16:48:06 -0700</creation_ts>
          <short_desc>Should call didFail for nil requests</short_desc>
          <delta_ts>2011-08-17 12:08:05 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>66336</dependson>
          <blocked>51836</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Pratik Solanki">psolanki</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ap</cc>
    
    <cc>aroben</cc>
    
    <cc>beidson</cc>
    
    <cc>ddkilzer</cc>
    
    <cc>psolanki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>451986</commentid>
    <comment_count>0</comment_count>
    <who name="Pratik Solanki">psolanki</who>
    <bug_when>2011-08-16 16:48:06 -0700</bug_when>
    <thetext>PolicyChecker::checkNavigationPolicy() tries to avoid making a delegate callback if the request is null. It does

    if (equalIgnoringHeaderFields(request, loader-&gt;lastCheckedRequest()) || (!request.isNull() &amp;&amp; request.url().isEmpty())) {
        function(argument, request, 0, true);
        loader-&gt;setLastCheckedRequest(request);
        return;
    }

However, if the request is null i.e. a caller called [WebFrame loadRequest:nil], we should at least make a did fail notification to inform the caller. This can be done by just calling PolicyChecker::continueAfterNavigationPolicy(PolicyUse). The checks in that code will trigger the didFail notification.

We do get a didFail notification on mac right now. But that&apos;s because of bug 66336. If we fix that, we won&apos;t get the failure notification. This bug occurs when we use the CFNetwork based loader.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>