<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>66336</bug_id>
          
          <creation_ts>2011-08-16 15:04:56 -0700</creation_ts>
          <short_desc>ResourceRequest::doUpdatePlatformRequest() should clear http method</short_desc>
          <delta_ts>2011-08-17 09:43:09 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>66350</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Pratik Solanki">psolanki</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ap</cc>
    
    <cc>ddkilzer</cc>
    
    <cc>psolanki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>451899</commentid>
    <comment_count>0</comment_count>
    <who name="Pratik Solanki">psolanki</who>
    <bug_when>2011-08-16 15:04:56 -0700</bug_when>
    <thetext>In ResourceRequestMac.mm, ResourceRequest::doUpdateResourceRequest() does

    if (NSString* method = [m_nsRequest.get() HTTPMethod])
        m_httpMethod = method;

This means that we don&apos;t clear out the m_httpMethod field if (e.g.) the NSURLRequest was nil. This can cause 2 ResourceRequests to be treated as different when they should be equal e.g. if the 2 ResourceRequests were created with different ctors. We have 2 different ResourceRequestBase actor - one sets the httpMethod to &quot;GET&quot; by default, the other doesn&apos;t do anything.

By contrast on the CFNetwork side, we always clear out all the fields.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>